Maddy
5be2e01632
Notebook Telemetry initial changes ( #13929 )
...
* initial changes
* add ads-telemetry to nb extension
* add aiKey to notebook extension
* add run cell telemetry in cellmodel
* add NbTelemetryAction
* remove source
* remove telemtery for run notebook for now
* fix optional variable call
* addr comments
* changing the dependency package
* revert
* removed webpack config for telemetry compat
* add opentelemetry to externals
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com >
2021-01-25 09:42:37 -08:00
Sai Avishkar Sreerama
0316d9ac57
Adding Dacpac extension telemetry and core wizard/page telemetry updates( #13859 )
...
* Dacpac telmetry code changes
* Removed added spaces
* Generate deployScript accessibility changed back to public
* code review suggessions updates
* dacpac extension tests fixes
* Updated time and filesize methods allowing general return values
* Telemetry code updates
* Dacpac Telemetry potential data loss capture and PII error excluded
* Dacpac telemetry code updates for comments
* Wizard pages navigation telemetry event capture moved to the core
* DacpacTelemetry code updates
* Extension wizard cancel telemetry for data loss
* Dacpac telemetry pagename and small code updates
* final Dacpac telemetry code updates...
2021-01-21 17:00:37 -06:00
Charles Gagnon
5810623e55
Don't capture query history events until service is started ( #13983 )
2021-01-15 12:54:29 -08:00
Vasu Bhog
df51f35be0
Enable Parameterization via Notebook URI ( #13869 )
...
* Enable Parameterization via Notebook URI
* Add Parameterization and Move notebookModel tests
* minor typos
* parameter typo
* Multiple parameters through uri fix
* Address PR comments and tests fix
* add new injected parameters after original injected parameters
* Add new test to verify notebookURi parameter is injected after both parameter and injected cell
* fix tests
2021-01-08 00:38:33 -08:00
Daniel Grajeda
16943c68c6
Notebook Views Models ( #13884 )
...
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
* Add metadata capabilities
* Notebook views definitions
* Add notebook views models
* Views test
* Rename type arguments
* Additional tests
* Fix unused import
* Update resize cell test
2021-01-05 15:28:30 -08:00
Christopher Suh
bc9719d5a8
Fix parentheses for firewall ip address ( #13903 )
...
* fix parentheses for firewall ip address
* use template string
2021-01-04 17:02:06 -05:00
Daniel Grajeda
11f236ade1
Notebook Views ( #13465 )
...
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
2020-12-27 13:08:27 -08:00
Aditya Bist
91522caa67
Change server group look ( #13608 )
...
* change server group look
* remove dead code
* add top padding
* add bot padding as well
* fix heights to account for padding
* fix arrow alignment
* fix ellipses and node length parity
* fix alignment
2020-12-09 10:54:47 -08:00
Lucy Zhang
f96fd911c1
Notebooks: Remove result set summary from saved metadata ( #13616 )
...
* remove result set summary from metadata
* remove batchId and id from celloutputmetadata
* remove extra line
2020-12-07 12:28:07 -08:00
Alan Ren
0b1239b755
accessibility support for filtering ( #13581 )
2020-12-01 10:13:39 -08:00
Lucy Zhang
aa30b52d03
Notebooks: Fix query results not displaying table rows ( #13488 )
...
* fix PQSQL queries not displaying rows
* comment
* change comment and fix unit test
2020-11-20 15:31:01 -08:00
Chris LaFreniere
8d42182db8
Attempt to Colorize Code Cells from Notebook Contents ( #13473 )
...
* Attempt to colorize from saved language info
* Simplify colorization change
* Fixup
2020-11-19 19:54:09 -08:00
Justin M
271fe62344
12567 Fixed Notebooks not adding to recent connections ( #13113 )
...
* 12567 Changed tryAddActiveConnection to always add recent connection
* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel
* 12567 Simplified conditional in connectionDialogService
2020-11-16 11:27:09 -08:00
Justin M
c18a54bc1d
12666 Passed azureAccount into onFetchDatabases and set on tempProfile. ( #13239 )
2020-11-16 11:24:22 -08:00
Alan Ren
99e3da5b48
Editable dropdown component improvement ( #13389 )
...
* replace Tree with List
* comments
2020-11-13 13:36:54 -08:00
Aasim Khan
bd4676ac8c
removing separate heading for page number and clubbing it with wizard title ( #13380 )
2020-11-13 00:38:04 -08:00
Lucy Zhang
32a6385fef
Notebooks: Save cell connection name in cell metadata ( #13208 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* save/read cell connection name to/from metadata
* get started on toggling multi connection mode
* add activeConnection property to cell model
* add changeContext method for cell
* add comments
* add unit test for reading connection name
* save connection mode in metadata
* clean up code
* address PR comments
2020-11-12 10:44:34 -08:00
Kim Santiago
abdf575885
fix wizard page name and step getting announced when pages are added and removed ( #13362 )
2020-11-12 09:44:33 -08:00
Alan Ren
3be00b1635
add tabindex and handle keyboard selection ( #13348 )
2020-11-10 23:00:03 -08:00
Aditya Bist
8bbcfff119
fix agent types ( #13340 )
2020-11-10 13:38:57 -08:00
Aditya Bist
fa9a38d74a
Update/agent ( #13298 )
...
* Revert "Fix Agent not working (#13126 )"
This reverts commit a0ee8b00fb .
* agent fix and bump
2020-11-09 09:00:03 -08:00
Charles Gagnon
a0ee8b00fb
Fix Agent not working ( #13126 )
...
* Fix Agent display
* more fixes
* cleanup
2020-11-04 09:23:16 -08:00
Vasu Bhog
351516f08d
Change the way we insert Injected Parameter ( #13171 )
2020-11-02 09:14:37 -08:00
Alan Ren
cb1c8503b0
handle keyboard selection ( #13175 )
2020-10-30 21:17:49 -07:00
Charles Gagnon
d7767c7d91
Resource viewer cleanup ( #13168 )
...
* Resource viewer cleanup
* uneeded
* Only show in insiders
2020-10-30 16:48:50 -07:00
Alan Ren
2f571d868b
show folder icon for some tree nodes ( #13161 )
2020-10-30 15:38:23 -07:00
Charles Gagnon
3015845093
Add title property for data grid providers ( #13155 )
2020-10-30 15:37:11 -07:00
Lucy Zhang
69527f91b0
Notebooks: Save connection information in metadata ( #13060 )
...
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
2020-10-30 13:56:33 -07:00
Alan Ren
82d5fe3821
put feature behind preview flag ( #13147 )
...
* put feature behind preview flag
* remove unused import
2020-10-30 10:17:54 -07:00
Alan Ren
ac476ba973
make the tree theme aware and remove group color ( #13143 )
...
* make the tree theme aware and remove group color
* fix eslint error
2020-10-29 22:46:11 -07:00
Alan Ren
7819d25c95
resource label update ( #13129 )
...
* resource label update
* preserve existing behavior
* fix connection group color
* comments
2020-10-29 14:42:01 -07:00
Alan Ren
1d4398388c
bring Azure context menu to the new tree and enhance start cloud shell command ( #13101 )
...
* bring context menu to the new tree
* enhance start cloud shell command
* text
2020-10-28 13:48:28 -07:00
Lucy Zhang
86357b45b0
Notebooks: re-factor grid streaming ( #12937 )
...
* refactor grid streaming (convert to data first)
* change convertRowsToHtml method to return value
* remove griddataconversioncomplete checks
* send row data from STS to gridoutput component
* clean up code
* send data updates to cell model
* serialize cell output at the end of cell execution
* remove unused parameters
* update output contents instead of output reference
* remove unnecessary promise
* move azdata changes to proposed
* update comment
2020-10-28 09:08:15 -07:00
Alan Ren
e2c9d3899b
make sure saved connections are up to date ( #13098 )
2020-10-27 19:41:44 -07:00
Alan Ren
79800902db
enable filtering, account node context menu and introduce flat account tree node ( #13066 )
...
* add search box
* switch back to the traditional azure tree
* Revert "switch back to the traditional azure tree"
This reverts commit 7904b9cd599591e94412ec79da23590068de46b6.
* flat account tree node and filtering
* add comment
* context menu
* fix test
* handle disposable
* add logging
2020-10-26 17:00:44 -07:00
Vasu Bhog
cb30dd1893
Notebook Parameterization - Papermill Compatibility ( #13034 )
...
* Parameterization papermill fix
* Utilize isParameter instead
* Address PR comments, and fix tests
* Address comment
2020-10-23 20:32:55 -05:00
Charles Gagnon
2d182fcd03
Remove calls to DOM.addClass and DOM.removeClass ( #13063 )
2020-10-23 14:42:22 -07:00
Charles Gagnon
656d727854
Skip getting icon if we don't have a server info ( #13017 )
2020-10-21 15:56:22 -07:00
Vasu Bhog
fcec690546
Backend work for Notebook Parameterization and Tests ( #12914 )
...
* Backend work for Parameterization + Tests
* minor comments
* fix test
* address comments
2020-10-20 13:26:59 -05:00
Alan Ren
49983a6f05
fix connection dialog scroll issue ( #12956 )
2020-10-16 11:09:30 -07:00
Alan Ren
545a5504e0
fix missing icon issue ( #12928 )
...
* fix missing icon issue
* move the logic to renderServerIcon
2020-10-15 12:01:35 -07:00
Tony Xia
607447365d
Fixed minor typos ( #12936 )
2020-10-15 09:55:00 -07:00
Anthony Dresser
9fdb5037bc
Connection Browse Tab ( #12222 )
...
* add browse tab and flat tree provider for azure
* fix tests
* add comment
* fix build errors
* fix test cases
Co-authored-by: Alan Ren <alanren@microsoft.com >
2020-10-13 14:58:09 -07:00
Vasu Bhog
53f00bee12
Fix connection when changing kernel from Kusto to SQL ( #12881 )
...
* Fix Kusto to SQL kernel connection change
* Updated Fix - removes kernel alias mapping while ensuring multi kusto notebooks work properly
* Fix tests
2020-10-10 00:10:33 -05:00
Lucy Zhang
b910bf2f33
Notebooks: Fix strict compile errors ( #12591 )
...
* strict compile for sqlSessionManager.ts
* start clientSession.ts fixes
* strict compile for clientSession.ts
* strict compile for notebookModel.ts
* add display name
* clean up code
* clean up code
* initialize string to empty string
* address PR comments
* address PR comments
* address PR comments
* remove errorMessage check
2020-10-08 15:39:57 -07:00
Vasu Bhog
726f0cef0e
Add Notebook tests for Kernel Alias connections ( #12722 )
...
* More Generic tests for kernel alias connections
* Kernel Alias tests for the Notebook Model
* Updated titles of tests
2020-10-05 23:17:41 -05:00
Christopher Suh
6ff1e3866b
Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 ( #12295 )
...
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3
* Fix test build break
* Update distro
* Fix build errors
* Update distro
* Update REH build file
* Update build task names for REL
* Fix product build yaml
* Fix product REH task name
* Fix type in task name
* Update linux build step
* Update windows build tasks
* Turn off server publish
* Disable REH
* Fix typo
* Bump distro
* Update vscode tests
* Bump distro
* Fix type in disto
* Bump distro
* Turn off docker build
* Remove docker step from release
Co-authored-by: ADS Merger <andresse@microsoft.com >
Co-authored-by: Karl Burtram <karlb@microsoft.com >
2020-10-03 11:42:05 -07:00
Monica Gupta
b574f2aa32
Fix notebook issue when creating Kusto notebooks 2nd time after launching ADS ( #12700 )
...
* Fix notebook issue
* Removed not required code
Co-authored-by: Monica Gupta <mogupt@microsoft.com >
2020-10-01 16:27:41 -07:00
Alex Ma
82648fab3e
connection tests for connectionDialogWidget ( #11160 )
...
* Added providerRegistered test
* test for EditConnectionDialog
* changed wording
* added test for connectionInfo
* utils.ts tests added
* hasRegisteredServers test
* commented out editconnection tests, addl. tests
* added onConnectionChangedNotification test
* added changeGroupId tests
* Added connection profile changes
* added connectIfNotConnected test
* added delete connection test
* isRecent and disconnect editor tests
* Add CodeQL Analysis workflow (#10195 )
* Add CodeQL Analysis workflow
* Fix path
* added registerIconProvider test
* Fix for ensureDefaultLanguageFlavor test
* added a few tests
* utils prefix test updated
* added utils tests
* disconnect tests added
* Added additional get connection info tests
* added some more tests
* minor additions to tests
* again another commit
* another change
* connectionManagementService finalized
* connectionDialogWidget test WIP
* wip connectiondialogwidget test
* added working connectionDialogWidget test
* added more tests
* current connectionDialogWidget tests
* undid space
* hanging promise addressed
* added open test
* finished connectionDialogWidget tests
* Added showDialog test
* mockConnectionDialogService added
* added accessorConnectionDialogService
* removed accessor service
* added openDialogAndWait test
* added fake error to test
* added error tests
* Added comments to test
* more coverage
* async to await change
* registerCapabilities test added
* connectionDialogService tests finished
* undefined added
* Added views for tests
* tslint disable added
* error catchers added
* added empty connectioninfo
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com >
2020-09-30 08:39:54 -07:00
Lucy Zhang
cf9754f627
revert grid streaming changes ( #12650 )
2020-09-28 18:34:58 -07:00