Commit Graph

260 Commits

Author SHA1 Message Date
Karl Burtram
434d017a6b Update various branch references to main branch (#10913) 2020-06-13 14:26:18 -07:00
Maddy
26a00696d4 Fix/prev next links issue (#10523)
* intital test code

* added tests

* remove commented code

* fix for failing tests

* reuse exported enum

* changes to address comments

* add back onVisibility highlight

* port highlight fix from Chris

* fix tests
2020-06-12 18:42:17 -07:00
Chris LaFreniere
960aa14027 stop running magics that dont exist (#10894) 2020-06-12 14:25:01 -07:00
Chris LaFreniere
168ef80d8f Fix Notebook Viewlet Highlighting (#10868)
* Stop double tree data provider registrations

* revert book finding logic, leverage currentBook
2020-06-10 22:27:16 -07:00
Charles Gagnon
dff43687e2 Clean up coverage and fix issue with notebook names (#10826)
* Clean up coverage and fix issue with notebook names

* update name
2020-06-10 13:44:38 -07:00
Maddy
22d7c9083e highlight correct notebook on navigation. (#10807)
* highlight correct notebook on navigation.

* add back behavior of highight on viewlet visible

* optimize bookViewer create

* createTreeView for every book
2020-06-08 19:09:43 -07:00
Cory Rivera
5d60254bb9 Add custom width to Python wizard to reduce wasted space. (#10705)
* Also use double quotes for localize calls in the wizard.
2020-06-03 14:41:39 -07:00
Charles Gagnon
da41fda4bb Update to latest vscodetestcover (#10680)
* Update to latest vscodetestcover

* Remove unused config
2020-06-02 13:33:30 -07:00
Charles Gagnon
4d6ec69eba Fetch password from credential store before connecting to knox endpoint (#10666)
* Fetch password from credential store before connecting to knox endpoint

* Add combined code coverage script

* Revert "Add combined code coverage script"

This reverts commit e538f2fb2a79993a77f749f384fbc306b18b9f64.
2020-06-02 13:27:37 -07:00
Charles Gagnon
2879da5ca5 Add script to combine coverage files (#10674)
* Add script to combine coverage files

* add script

* Add core coverage file as well

* Add json reporting

* Update README

* more
2020-06-02 12:53:58 -07:00
Maddy
3088c73e2b Feat/notebooks viewlet (#10170)
* clean up unsavedBooks to providedBooks

* added notebooks viewley contribution

* added notebookExporerAction context

* temp shortcut key B

* remove commenred code

* changes with master merge

* fix comments

* initial tests

* fix casing and description

* merged master and resolved errors

* remove extension point & add custom view container

* merge latest from master

* remove unused files

* move book images to common

* remove notebookExplorer contrib & move to notebook

* build fix

* remove explorer specific sryles from common

* vscode convention to define container actions

* rename notebooks/title
2020-06-01 15:47:56 -07:00
Charles Gagnon
7305bdaec4 Add integration-test code coverage (#10632)
* wip

* Update to latest vscodetestcover and add tests back in

* Update to latest version of vscodetestcover

* updates

* another yarn.lock

* update version

* Revert import path change
2020-06-01 14:54:07 -07:00
Cory Rivera
98ce3c74e6 Hide installation options in Configure Python wizard if python is already setup. (#10635) 2020-05-29 17:28:02 -07:00
Leila Lali
5955953b4a ML - displaying all Python and R packages (including system ones) (#10603)
* displaying all packages including readonly
2020-05-29 13:52:37 -07:00
Charles Gagnon
f568ff82d8 Fix HDFS support for CU5+ BDC instances (#10577)
* Fix HDFS node auth for non-root username

* more changes
2020-05-27 10:17:28 -07:00
Charles Gagnon
7496d09eb9 Add and fix Notebook tests (#10488)
* Add and fix Notebook tests

* Fix name

* Fix compile

* Acutally fix error

* Add Notebook title test and fix command

* Add extra check and add comments

* Remove extra show error message
2020-05-26 17:27:43 -07:00
Charles Gagnon
14554f0d11 Fix some issues with book tree view (#10521) 2020-05-20 11:54:25 -07:00
Maddy
e46521cafc open viewlet on showPreview (#10474)
* open viewlet on shoePreview

* on showPreview reveal explorer
2020-05-18 13:46:55 -07:00
Hale Rankin
47687ff6b2 Notebook main toolbar additions (#10271)
* Reworking notebook action bar functionality and appearance.

* added separator

* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.

* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.

* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.

* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.

* Adjusted styles for the cell and run all icons in notebook toolbar.

* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.

* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.

* Added new icon for Underline action.

* Removed comment from needed markup.

* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.

* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.

* Removed unnecessary !important from style override.

* Removed reference to unused color entry.

* Syntax cleanup.

* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.

* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.

* Replaced SVG code for not-trusted icon.

* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
2020-05-15 19:13:31 -07:00
Cory Rivera
d3e1675fc5 Only check if python is running before trying to overwrite an existing installation. (#10383) 2020-05-14 11:37:06 -07:00
Cory Rivera
fc548be2c1 Uncheck unselected radio buttons in Configure Python wizard. (#10344) 2020-05-12 13:02:35 -07:00
Maddy
f6e7b56946 opening as text document launches json (#10323) 2020-05-08 23:28:28 -07:00
Cory Rivera
f94a9d0d58 Update Configure Python dialog to allow packages to be installed for specific kernels. (#10286) 2020-05-08 16:02:59 -07:00
Chris LaFreniere
0fbc3d1cb6 Get rid of red herrings (#10309) 2020-05-08 14:49:49 -07:00
Charles Gagnon
6e5fc9c495 Add ModelView method SetItemLayout (#10306)
* Add ModelView method SetItemLayout

* Remove extra line break
2020-05-08 08:38:36 -07:00
ADS Merger
fa62ec1f34 Merge from vscode 7653d836944892f83ce9e1f95c1204bafa1aec31 2020-05-08 03:58:34 +00:00
Leila Lali
a7c4a259ad Fixed an issue with setting the default location in package management (#10263) 2020-05-04 17:00:51 -07:00
Cory Rivera
d7a425239b Only reveal items in the books viewlet if the viewlet is visible. (#10234) 2020-04-30 20:10:27 -07:00
Chris LaFreniere
0a3a0ec80f Notebooks: Support User-Installed Kernels (#10194)
* Fixes for attach to. Still need to update cache

* Don't have jupyter hardcoded

* Handle DOTNET_ROOT env var

* Fix on load

* Put behind feature flag

* Cleanup

* Error check

* PR feedback
2020-04-29 10:34:27 -07:00
Chris LaFreniere
5b57b13005 Update python Mac install url (#10200) 2020-04-29 10:29:52 -07:00
Charles Gagnon
586c28bf79 Add and fix notebook extension unit tests (#10156) 2020-04-24 22:05:36 -07:00
ADS Merger
7f1d8fc32f Merge from vscode 2e5312cd61ff99c570299ecc122c52584265eda2 2020-04-24 14:03:37 -07:00
Charles Gagnon
8311c3985d Add PropertiesContainer ModelView component (#10115)
* Add PropertiesContainer ModelView component

* Switch to component

* Remove unneeded interface

* Update names

* Fix names
2020-04-22 16:29:46 -07:00
Cory Rivera
097289d94c Check treeItem first when building search path in searchJupyterBooks. (#10083) 2020-04-20 15:30:52 -07:00
Cory Rivera
67b6f6ffcd Add tests for Open Notebook Folder functionality. (#10056) 2020-04-17 16:27:00 -07:00
Maddy
02ae1ecff8 Rename/books viewlet sections (#10044)
* renamed viewlet sections

* template to provided
2020-04-16 17:23:54 -07:00
Cory Rivera
2817316cf4 Check conda-forge channel first when installing conda packages. (#10035) 2020-04-16 16:58:32 -07:00
Maddy
a58d4d7d05 replaced watch with watchFile (#9873)
* replaced watch with watchFile

* testing debounce

* changed the beounce delay to 1500
2020-04-15 10:03:48 -07:00
Maddy
c728f23893 some more tests (#9933)
* some more tests

* changes to address comments
2020-04-14 22:33:23 -07:00
Charles Gagnon
30607ec61b Update to latest vscodetestcover (#9909)
* Update to latest vscodetestcover

* Undo ci disable

* Add mssql to coverage upload

* Also update sh script

* Add mocha reporters

* Update yarn.lock

* Fix merge conflict

* Update

* Update yarn.lock again

* Fix compile errors

* Try disabling test

* Disable another test

* Try disabling all tests

* Leave one test...

* Skip msssql tests again

* Remove mssql coverage merge

* re-disable CI
2020-04-14 21:32:17 -07:00
Cory Rivera
2b2a275fb0 Add Open Notebook Folder functionality to Books viewlet. (#9939) 2020-04-13 23:42:02 -07:00
Maddy
6bc123d76b Fix/open book spcl characters (#9888)
* upgrade fast-glob that escapes them.

* added tests

* added test with brackets in bookPath
2020-04-07 15:55:53 -07:00
Monica Gupta
63006e6e63 Undo default kqlmagic install (#9871)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-04-07 10:20:37 -07:00
Maddy
4c01482a8f fixes to the toc formatting (#9825)
* fixes to the toc formatting

* addressed comments
2020-04-06 15:30:08 -07:00
Monica Gupta
11c34f36d7 set ads context for kqlmagic (#9849)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-04-06 09:48:16 -07:00
Leila Lali
dd56908a06 Added multiple location option to package management dialog (#9790)
* Added multiple location option to package management dialog
2020-04-01 13:33:45 -07:00
Chris LaFreniere
bb135d6c67 Ensure kqlmagic is only offered for pip (#9776) 2020-03-30 16:33:49 -07:00
Monica Gupta
9c842e7548 Kql magic updates (#9753)
* Inludes package upgrade and silent env

* Make user param changes

* Address comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-03-30 10:43:26 -07:00
Charles Gagnon
fd950391e4 Fix notebook command palette clauses (#9752) 2020-03-26 14:43:03 -07:00
Monica Gupta
fa6898ded7 Pre-installs and registers kqlmagic (#9558)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-03-17 09:02:58 -07:00