Commit Graph

857 Commits

Author SHA1 Message Date
Barbara Valdez
362290f8ec Add security tab for server properties (#24209)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-29 13:28:17 -07:00
Sai Avishkar Sreerama
c4b1765745 Enabling Files tab to the database properties (#24138)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* initial commit - fullText and owner need revision

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* loading data, need stylings-increase col length, etc

* using the existed setTableData method

* Adding new file dialog

* creating addFile, but not displaying in table, issue with appendData

* Adding row to the table, options are getting from STS

* all working except InPercent value

* code review comment updates

* Input type checkbox update table additional validation

* all except path

* fixing the input type focus and reverting the enterKeyPress logic

* browse path is created, need stylings,refactor,filestream selection and add

* fixing the flickering issue with data refresh

* new file options toggle and grid display string updates

* moving code inline and using actual component

* cleanup

* Add file saving is done, except one styling issue with autogrowth section

* add,remove working, need to edit file

* add, edit, remove - all working, need css fixes and -1 fix

* addressing code review comments

* adding local changes adn fixing for edit file

* adjusting css

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* all fixed, need testing and refactor

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch

* fixing autogrowth radio buttons change updates

* all working except some css

* disabled size for filestream

* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file

* added max and min values to the inputs

* editing filename validation completed, all done exccept CSS

* all fixed except scroll bar

* edit db file header, filename enable issue fix

* PR comment supporting updates for STS

* min updates

* modfying addButtonsForTable method and reusing it for edit button

* code review comment updates

* Dialogbase addbuttons to table refactored

* more typo fixes

* removing fulltext index prop

* service fix

* using path.join instead of hardcoded separators

* final commit changes
2023-08-29 14:42:09 -05:00
Sai Avishkar Sreerama
9557e77982 STS version bump to 4.9.0.25 (#24245) 2023-08-29 14:15:42 -05:00
Cheena Malhotra
8c98862343 Bump STS to v4.9.0.22 (#24212) 2023-08-24 09:47:07 -07:00
Cheena Malhotra
6c6464e772 Part 2 - Make Model view components disposable + dispose all emitters (#24097) 2023-08-23 12:46:09 -07:00
Barbara Valdez
41ad39f665 Enable script button for Server properties (#24201)
* enable script button

* remove override method
2023-08-22 15:42:11 -07:00
Lewis Sanchez
d5a9c172d1 Integrate Contextualization API into Azure Data Studio to get better query recommendations from Copilot (#24044)
* Boilerplate for new metadata API endpoint

* Register all server metadata provider

* Fully registers data provider

* Registers metadata provider

* Instantiate metadata service

* Generates server metadata when connection is established

* Allow queryEditorInput to get server metadata

* Minor clean up

* Renames metadata provider and request endpoint

* Corrects documentation block

* Integrates get server metadata request endpoint

* Adjusts GetServerMetadataResult scripts type

* Add back Cargo.toml file

* Fix SQL hygiene error

* reflect changes made in in STS for table metadata

* Adds feature toggle to serverMetadataService

* Places toggle before request to get create scripts

* Fix build check issues

* Minor review changes

* Improves contextualization setting label

* Generalize contextualization service names

* Additional code review changes

* Update extensions/mssql/src/contracts.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Code reivew changes

* Capitalize c in contextualization

* Additional review changes

* Update provider type

* Simplify type and method names

* Unregister MSSQL ServerContextualization provider

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-21 19:54:44 -07:00
Barbara Valdez
df5693ffd3 update sts (#24178) 2023-08-21 16:26:45 -07:00
Barbara Valdez
60bff01240 Add processors tab (#23634)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-21 10:52:55 -07:00
Cory Rivera
0e7942913b Replace usage of Delete with Drop in object management code (#24159)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-17 14:26:03 -07:00
Aasim Khan
2fce9c5b38 Adding sql core dll to esrp code signing and updating sts (#24157) 2023-08-17 21:25:22 +00:00
Sai Avishkar Sreerama
e5b7bff7b4 Enabling Database scoped configurations tab to DB Properties (#23890)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* using the existed setTableData method

* code review comment updates

* Input type checkbox update table additional validation

* fixing the input type focus and reverting the enterKeyPress logic

* fixing the flickering issue with data refresh

* moving code inline and using actual component

* cleanup

* addressing code review comments

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch
2023-08-16 12:00:18 -05:00
Barbara Valdez
3fbca593be Refactor create inputbox method (#24113)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-15 13:36:02 -07:00
Aasim Khan
752c33c960 Vbumping vscodetestcover (#24133) 2023-08-15 17:22:30 +00:00
Cory Rivera
04301629c1 Rename internal references to Delete Database to Drop Database (#24132) 2023-08-14 14:23:53 -07:00
Cory Rivera
22e2b0df9f Add Delete Database dialog to enable additional deletion options (#24109) 2023-08-14 11:20:08 -07:00
Cheena Malhotra
0328450f6a Bump STS to v4.9.0.10 (#24064) 2023-08-02 17:07:26 -07:00
Cory Rivera
9727a761c9 Select default database dropdown values based on a default index value (#24013) 2023-07-28 14:37:37 -07:00
Cory Rivera
5c5b73525d Connect query editor when producing script from object management dialogs. (#24015) 2023-07-28 14:26:33 -07:00
Cory Rivera
cc778ad69f Use faster, editable dropdown for Collations in database dialogs (#23974)
* Also fixed an issue where a manually edited text field doesn't get updated when selecting the same dropdown value from before the manual edit.
---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-26 10:04:29 -07:00
Christopher Suh
91359a32c9 Remove ADAL Code (#23360)
* initial commit, removed all adal code

* remove all authLibrary references in extension/azurecore

* removed authLibrary references from src/sql

* remove MSAL/ADAL setting option

* wip fixing tests and removing Msal from method names

* fixed tests

* create accountInfo mock

* fix tests

* fix clientApplication mock

* remove clientapplication

* fix compile

* add typing

* wip

* wip

* wip

* fix tree provider

* remove SimpleTokenCache, FileDatabase & tests

* remove remaining adal / authentication library references:

* remove comma from package.nls.json

* fix error fetching subscriptions

* fix tests

* remove getAzureAuthenticationLibraryConfig

* remove adal check

* fix build

* remove test

* undo remove customProviderSettings

* fix bracket
2023-07-20 10:37:38 -07:00
Cheena Malhotra
a833ae7b79 Allow empty username + fix profiles on read (#23924) 2023-07-18 16:03:10 -07:00
Alex Ma
a0a685bbcf Remove/comment out connection title generation from all areas. (#23873) 2023-07-18 10:47:50 -07:00
Cory Rivera
fed4f2a18e Change OK button label based on whether the dialog is creating a new object or updating an existing one. (#23908) 2023-07-17 15:54:30 -07:00
Barbara Valdez
6e84766cec Add basic validation to database names (#23842)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-14 10:11:52 -07:00
Sai Avishkar Sreerama
207b1daf9f Making IsLedger Property to Read-only (#23804)
* Making IsLedger Property to Read-only

* refactor

* Update extensions/mssql/src/objectManagement/ui/databaseDialog.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-12 16:13:38 -05:00
Cory Rivera
d23cb8e90f Bump SQL Tools version to 4.9.0.3 (#23813) 2023-07-12 13:08:23 -07:00
Sai Avishkar Sreerama
9884bb44c0 Recovery time validation (#23789) 2023-07-12 10:47:10 -05:00
dependabot[bot]
7103aaae09 Bump semver from 5.7.1 to 5.7.2 in /extensions/mssql (#23756)
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v5.7.1...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-11 17:25:02 -07:00
Cheena Malhotra
ddb5a13b45 Enable connection pooling by default (targeting Sept release) (#23777) 2023-07-11 15:25:23 -07:00
Barbara Valdez
03acee1d12 Create new context menu item for Database (#23771) 2023-07-11 11:28:04 -07:00
Barbara Valdez
bfb8536aa6 Fix error when trying to update server or database properties (#23695) 2023-07-11 11:07:09 -07:00
Cheena Malhotra
ba483815b2 Fix connection URI default value comparisons (#23705) 2023-07-11 10:44:59 -07:00
Barbara Valdez
017fcf14b0 Fix issues found in the bug bash (#23741)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 10:15:41 -07:00
Cory Rivera
af0e2baa7e Limit Detach Database and Database/Server Properties to insiders and dev builds. (#23750) 2023-07-11 09:48:36 -07:00
Sakshi Sharma
2fd2b79611 ADS changes for opening XEL files (#23666)
* Initial set of changes for opening XEL files in ADS

* Code cleanup and update STS version

* Fix runtime errors

* Address comments

* Address comments and update Start button to be disabled for file session

* Code cleanup
2023-07-09 10:22:12 -07:00
Cory Rivera
92249aedda Exclude system databases for Delete, Detach, and New object management commands (#23696) 2023-07-07 18:12:12 -07:00
Barbara Valdez
9e3f117c4a include latest changes in sts (#23699) 2023-07-07 15:54:58 -07:00
Barbara Valdez
a52f86bc48 Add memory inputs validation (#23685)
* memory validation

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* rename property to match sts

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-07 12:36:55 -07:00
Barbara Valdez
8048cab162 enable properties dialog (#23691) 2023-07-07 11:41:28 -07:00
Cheena Malhotra
3a7ce6ac24 Support enabling connection pooling (on demand) + additional telemetry (#23664) 2023-07-07 11:31:10 -07:00
Charles Gagnon
cb32513f9e Update dataprotocolclient to 1.3.6 (#23690) 2023-07-07 11:08:11 -07:00
Cory Rivera
f4688f447c Add New Object context menu entries on the objects themselves in OE (#23676) 2023-07-07 10:45:39 -07:00
Barbara Valdez
a6cba3b318 Update STS (#23682)
* vbump sts

* update version to latest build
2023-07-07 09:57:51 -07:00
Sai Avishkar Sreerama
acfa93fbb8 Enabling options tab for database properties (#23448)
* Initial commit for adding a basic general tab for the database properties

* Refactoring for dialog inputs

* removed properties nodeType and using database node and additional cleanup, diabling the functionality.

* Changes according to STS data fetch

* Reuse database Dialog

* Undo contract file change

* more refactoring

* fetched scrollbar fix into this PR

* Tabbed panel is being used for horizontal tabs

* stying fix for general tab button

* final commit for today :)

* Updates according to STS changes

* missed updates

* Refactored updates

* moved options as discussed and added collapsible sections... need to fix scroll bar

* Fixing the horizontal scroll bar of tabbedpanel

* initial updates

* need to fix the error!

* rror fixed and options are loading with sample values

* need to load real values for all felds and map values to dropdown options

* Dd loading correctly, need to add validation to recovery field and save options back

* refactor

* removing nullable property

* All changes done except recoveryTime validation

* Refactoring

* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests

* added general section for the options tab

* modifying pageVerify and userAccess to string array

* updates to general section of options tb

* disabling couple of general properties for MI

* Adding server edition conditions and toggling the UI options

* adding numeric validation to the recovey time

* Removing serveInfo logic and using the unsupported options approach from STS

* addressing comments and little code refactor

* changes with nullOrUndefined helper method

* replacing dropdowns with checkboxes

* adding unit test for helper method

* removed commented sample code and added comments
2023-07-06 18:22:20 -05:00
Barbara Valdez
32356cabc5 Server properties fixes (#23667)
* server properties fixes
2023-07-06 12:58:01 -07:00
Charles Gagnon
85beb65ad0 Add missing CREATE DATABASE keywords for syntax colorization (#23662)
* Add missing CREATE DATABASE keywords for syntax colorization

* remove script
2023-07-05 17:15:59 -07:00
Charles Gagnon
4a160b331f Cleanup OE context menu order (#23592) 2023-06-30 11:33:05 -07:00
Aasim Khan
78ccf9fe0d Replacing contains filter from like filter in OE (#23422) 2023-06-28 22:51:14 -07:00
Hai Cao
4869ebab51 Add a config for copying with trailing line break (#23481) 2023-06-28 14:34:52 -07:00