Commit Graph

14 Commits

Author SHA1 Message Date
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837)
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
2019-10-21 12:02:30 -07:00
Cory Rivera
888327f5bc Hide collapse cell button if cell only has one line. (#7701) 2019-10-11 15:12:42 -07:00
Cory Rivera
d37105ada2 Don't expand notebook cells after being run, and don't hide outputs when cell is collapsed. (#7585) 2019-10-08 17:39:21 -07:00
Cory Rivera
6b29fd05bd Add collapse/expand functionality to notebook code cells. (#7481) 2019-10-03 16:50:47 -07:00
Chris LaFreniere
b8976785fd Stop grabbing focus when nb editor isn't in view (#7466)
* Stop grabbing focus when nb editor isn't in view

* Add comments
2019-10-02 11:56:57 -07:00
Maddy
2ec4a0c8a8 renamed .icon to .codicon as per vscode updates that are merged. (#7331) 2019-09-23 17:17:24 -07:00
Anthony Dresser
5e3ec6ea39 moves notebooks code to browser (#7313) 2019-09-23 13:32:29 -07:00
Chris LaFreniere
6125e68c1f Ensure we call layout() as few times as possible for notebook cells (#7253)
* Call layout fewer times from queryTextEditor

* remove unused method
2019-09-20 12:06:37 -07:00
Chris LaFreniere
141226332c Add notebook grid actions (#7181)
* Add notebook grid actions

* pr comments
2019-09-17 14:16:35 -07:00
Anthony Dresser
823d136a00 No browser from common (#7178)
* no browser from common

* clean up some imports
2019-09-12 14:52:42 -07:00
Chris LaFreniere
84b3e876d7 Notebook Performance Improvements to Cell Editing/Output Changes/Execution Count Changes (#6867)
* edit perf

* Save multiline source in notebooks

* More merges

* Single, multi line works needs work

* Works with single + multi and recomputes active

* Actual perf improvements this time

* code cleanup

* Calculating output position on the fly

* Hmm can we use brackets to make this simpler?

* monday progress

* output working. lots of improvements.

* First tests working

* 10 tests now, fixed bugs

* Cleanup, add output test

* More fixes

* Need to still fix execution count bug

* Tests pass, added comments

* Cleanup

* PR comments round 1

* Deal with merge issues from master, layering

* Deleting duplicate file

* More PR Comments

* PR Comments
2019-08-26 10:17:58 -07:00
Anthony Dresser
8e070454c3 Global object linting (#6857)
* add more linting

* fix linting issues
2019-08-22 10:51:59 -07:00
Anthony Dresser
c1acf6ae93 More work around isolating node imports (#6512)
* more work around isolating node imports

* rewrite query plan input

* fix hygiene errors

* fix tests

* address feedback

* remove welcome page changes
2019-07-30 14:01:37 -07:00
Anthony Dresser
371504358d refactor notebook to be fileservice based (#6459) 2019-07-26 22:19:13 -07:00