Commit Graph

196 Commits

Author SHA1 Message Date
Karl Burtram
8a3d08f0de Merge vscode 1.67 (#20883)
* Fix initial build breaks from 1.67 merge (#2514)

* Update yarn lock files

* Update build scripts

* Fix tsconfig

* Build breaks

* WIP

* Update yarn lock files

* Misc breaks

* Updates to package.json

* Breaks

* Update yarn

* Fix breaks

* Breaks

* Build breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Missing file

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Fix several runtime breaks (#2515)

* Missing files

* Runtime breaks

* Fix proxy ordering issue

* Remove commented code

* Fix breaks with opening query editor

* Fix post merge break

* Updates related to setup build and other breaks (#2516)

* Fix bundle build issues

* Update distro

* Fix distro merge and update build JS files

* Disable pipeline steps

* Remove stats call

* Update license name

* Make new RPM dependencies a warning

* Fix extension manager version checks

* Update JS file

* Fix a few runtime breaks

* Fixes

* Fix runtime issues

* Fix build breaks

* Update notebook tests (part 1)

* Fix broken tests

* Linting errors

* Fix hygiene

* Disable lint rules

* Bump distro

* Turn off smoke tests

* Disable integration tests

* Remove failing "activate" test

* Remove failed test assertion

* Disable other broken test

* Disable query history tests

* Disable extension unit tests

* Disable failing tasks
2022-10-19 19:13:18 -07:00
Alan Ren
5d731fe0ad table cell selection improvement (#20854)
* Support SHIFT key for table cell selection

* fix for mac

* PR comment
2022-10-14 19:44:14 -07:00
Lewis Sanchez
f51e5c370b Registers all disposable items for query execution plans (#20851) 2022-10-14 14:50:25 -07:00
Benjamin Russell
38eb0c8429 Export to Markdown (#20661)
* Give saveAsExcel its own config options

* Wired up correctly

* Merge conflicts

* PR comments 1

Co-authored-by: Ben Russell <russellben@microsoft.com>
2022-10-13 16:08:21 -07:00
Alan Ren
d4552cf176 make the json regex better (#20826)
* make the json regex better

* comment
2022-10-12 16:26:32 -07:00
Charles Gagnon
3005d5435f Add preview features enabled flag to issue reporter info (#20808)
* Add preview features enabled flag to issue reporter info

* fix tests

* fix key
2022-10-11 15:46:32 -07:00
Benjamin Russell
29daa72ef1 Give saveAsExcel its own config options (#20647)
Co-authored-by: Ben Russell <russellben@microsoft.com>
2022-10-05 09:40:00 -07:00
Lewis Sanchez
7de5ee0427 Adds functionality to open execution plans from DB tables and DMVs. (#20377)
* Adds functionality to open execution plans from DB tables and DMVs.

* Code review changes

* Renames method to getProviderFromUri
2022-08-17 19:24:23 -07:00
Alan Ren
c663493690 properly handle copy request (#20320) 2022-08-11 21:22:19 -07:00
Alan Ren
9ec68087ac allow database name to be empty (#20221)
* allow database to be empty

* test changes

* fix import

* fix test cases

* comment
2022-08-11 10:26:55 -07:00
Alan Ren
2d14665208 announce query execution events (#20285) 2022-08-09 20:23:17 -07:00
Alan Ren
4096037167 fix query results view issue (#20234) 2022-08-03 10:45:33 -07:00
Alan Ren
f72dbccc52 no-op is the object is disposed (#20236) 2022-08-03 10:45:11 -07:00
Alan Ren
6be1420220 do not run query in multi-selection mode (#20213)
* do not run query in multi-selection mode

* fix test

* fix more tests
2022-07-30 14:29:32 -07:00
Alan Ren
67ecd6d3d9 fix the grid goes blank issue (#20209) 2022-07-29 18:12:02 -07:00
Alan Ren
bb4b00a25a fix recent closed (#20188) 2022-07-27 18:44:08 -07:00
Aasim Khan
518bb33a2f Adding plan tree to execution plan (#20158)
* Adding plan tree

* Fixing localization keys

* Removed whitespace
2022-07-26 14:30:46 -07:00
Charles Gagnon
ba1f4db745 Make createEditorInput async (#20038) 2022-07-14 19:39:52 -07:00
Lewis Sanchez
8f93fd9d09 Updates Actual Execution Plan button icon (#20018) 2022-07-12 17:14:49 -07:00
Karl Burtram
26455e9113 Merge vscode source through 1.62 release (#19981)
* Build breaks 1

* Build breaks

* Build breaks

* Build breaks

* More build breaks

* Build breaks (#2512)

* Runtime breaks

* Build breaks

* Fix dialog location break

* Update typescript

* Fix ASAR break issue

* Unit test breaks

* Update distro

* Fix breaks in ADO builds (#2513)

* Bump to node 16

* Fix hygiene errors

* Bump distro

* Remove reference to node type

* Delete vscode specific extension

* Bump to node 16 in CI yaml

* Skip integration tests in CI builds (while fixing)

* yarn.lock update

* Bump moment dependency in remote yarn

* Fix drop-down chevron style

* Bump to node 16

* Remove playwrite from ci.yaml

* Skip building build scripts in hygine check
2022-07-11 14:09:32 -07:00
Aasim Khan
9cfa1436d9 Adding top operations to execution plans (#19902)
* Adding top operations to execution plans

* Adding title to links

* Fixing pr comments

* Hiding top operations icon in execution plan editor

* Reducing outline width, adding separator and removing placeholder text

* Registering TopOperationsTabView
2022-07-07 12:50:52 -07:00
Lewis Sanchez
96d29bcbc1 Actual Execution Plan No Longer Executes Queries (#19840)
* Ctrl/Cmd + m, no longer executes queries.

* Adjusts command label

* Code review changes

* Uses category parameter to categorize actual plan command

* Actual execution plan command label matches estimated plan command label

* Revert "Actual execution plan command label matches estimated plan command label"

This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.

* Centralizes localized category string (#19857)

* Actual Plan action uses centralized category
2022-06-28 18:31:41 -07:00
Lewis Sanchez
811aa18862 Centralizes localized category string (#19857) 2022-06-28 16:58:09 -07:00
Lewis Sanchez
b01642aec1 Adds "Execution Plan" prefix to Execution Plan commands (#19842)
* Prefixes execution plan commands, so they are easier to find

* Provides category argument to categorize commands.
2022-06-28 11:42:25 -07:00
Lewis Sanchez
800f2cebb5 Updates actual plan text to enable/disable instead of include/exclude (#19796)
* Updates actual plan text to enable/disable instead of include/exclude

* Makes actual plan button text static and readonly
2022-06-22 14:59:13 -07:00
Lewis Sanchez
20d2256709 Adds toggle button to switch between estimated and actual execution plans (#19629)
* Creates toggle button to switch between estimate and actual query plans

* Renames ID for the toggleActualExecutionPlanModeAction class

* Renames button back to explain

* Creating actual execution plans resembles SSMS

* Adds CTRL/CMD + L shortcut to display estimated execution plans

* Alphabetically organizes telemetry actions

* Adds telemetry when the setting for actual execution plan toggle is used

* Resolves build errors

* Fixes broken unit tests.

* Code review changes

* Removes unnecessary null-coalescing operator.

* Creates placeholder icons for actual execution plans enabled

* Code review changes

* Shortens label names

* Telemetry moved to toggle button

* Telemetry review changes

* Clarifies misleading label
2022-06-09 16:07:12 -07:00
Alan Ren
75ab9b6812 fix json cell handling issue (#19310)
* fix json cell handling issue

* pr comment
2022-05-09 16:54:06 -07:00
Alan Ren
402604ba34 remove the preview feature flag check (#19194) 2022-04-23 20:07:43 -07:00
Aasim Khan
387f4cd116 Adding caching to execution plan and refactoring code and some other fixes (#18913)
* Making ep code modular for easy swithcing in and out

* Changing to innerText

* Fixing renames

* Fixing var name in one file
2022-04-12 12:52:24 -07:00
Alan Ren
c04f78981c retrieve the data from display data source (#18973) 2022-04-08 11:13:29 -07:00
Alan Ren
b6083b6447 handle special values in the table filter (#18872)
* handle special values in the table filter

* pr comments
2022-03-31 11:17:55 -07:00
Aditya Bist
a2c39369c9 Add and move editable dropdown (#18589)
* add and move editable dropdown

* merge dropdowns

* merge dropdown cell factories

* add new column and hide in properties

* remove editable property
2022-03-03 20:23:20 -08:00
Aasim Khan
02341088eb Renaming query plan to execution plan (#18551) 2022-02-25 00:49:34 -08:00
Alan Ren
28ab7372d2 table designer validation support (#18438)
* table designer validation

* vbump sts
2022-02-17 13:07:19 -08:00
Aasim Khan
424c6e34a4 Removing older show plan from results pane (#18294) 2022-02-10 08:31:22 -08:00
Charles Gagnon
36b1a5a209 Fix query editor diff compare (#18222) 2022-02-04 12:26:29 -08:00
Aasim Khan
e40c31559a Adding properties view and action bar to graph and fixing styling. (#18185)
* Adding properties view and action bar to graph.

* Open Graph File

* replacing innerhtml with  innertext

* Fixing floating promises

* Fixed typo

* renaming

* Fixing hardcoded colors and comments

* Removing todo and hardcoded colors

* renaming method

* removed unused contract

* Fixed path in comment

* converting div to button

* adding checks to table width and height setter

* Make method name more meaningful

* adding method return types

* concising repeated logic

* removing unused styling

* better sorting logic

* Fixing graph parsing
Renaming some stuff
Implementing IDisposable

* Fixing bad props logic

* Fixed image loading issue

* Removing hardcoded colors

* Adding comments to localize and handling undefined cases in sort

* Changed ch to px

* moving util function to strings
2022-02-02 14:17:01 -08:00
Charles Gagnon
1c9ba64ee0 check-param-names (#18189) 2022-01-31 12:39:22 -08:00
Aasim Khan
ea2860eb33 Pushing initial work for done in Query plan feature to main (#17986)
* Adding initial boilerplate for qp2

* Adding feature flag in query plan 2

* Clearing show plan 2 after every run

* Adding sub tree cost

* removing unused method.

* WIP 2

* Adding properties view and relative cost to query plan

* WIP

* Add icons to ads

* Assing relative costs and prop windows

* Enabling older query plan again

* Making some PR fixes

* Some more PR related fixes

* Use MS org azdataGraph module

* Moving new properties to azdata proposed.

* Moving new class properties to proposed

* added missing doc component.

* Changing how azdatagraph package is referenced

* Removing empty lines, fixing localization keys

* Removing empty line, localizing some string

* making css classes more specific

* making some logic concise

* localizing some more strings

* Making more css classes specific

* Removing important tag from css props

* Checking if sum is greater than 0 to prevent divide by zero exceptions

* Fixed loader error in bootstrap

* Fixing query index

* -fixing image paths
-making css class more class specific by using nested selectors

Co-authored-by: kburtram <karlb@microsoft.com>
2022-01-13 09:32:13 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Alan Ren
4ea6805d55 fix grid actionbar (#17837) 2021-12-07 11:56:11 -08:00
Alan Ren
ba3e6343e8 dot not crash query editor (#17787) 2021-12-02 09:38:08 -08:00
Alan Ren
1006652a31 fix sorting bug (#17769)
* fix sorting bug

* comments
2021-11-30 17:11:57 -08:00
Charles Gagnon
615df975ec Fix query editors restoring as plain text (#17643) 2021-11-10 12:31:43 -08:00
Charles Gagnon
25711acde0 Add a few missed instantiation service usages (#17554)
* Add a few missed instantiation service usages

* remove unused
2021-11-01 14:32:37 -07:00
Aditya Bist
6dda9392e0 respect include header option (#17134)
* respect include header option

* use correct option for copying

* check for setting when copying

* add dependency injection

* use instantiation service

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-11-01 12:36:19 -07:00
Alan Ren
b48f392ab2 optional database name option (#17538)
* optional database name option

* object explorer connection title

* revert unexpected change

* bug fixes
2021-10-29 16:37:35 -07:00
Alan Ren
156f8f1d5f only show new query when query is supported (#17346)
* only show new query when query is supported

* test case fix and pr comments

* rename context key
2021-10-13 13:01:31 -07:00
Lewis Sanchez
8b1fa3ea52 Don't prompt for save when JSON column untitled file is closed (version 2) (#17327)
* Stops flagging untitled editors with pre-loaded content as dirty

* Code changes address broken unit tests.

* Completes original comment

* Defines new non dirty text editor model

* Revert "Completes original comment"

This reverts commit 6d0e90bb9f0650eead5a0ec1ca8524dfe96c56cd.

* Revert "Code changes address broken unit tests."

This reverts commit 5b8cdd9f0bb43638bdd427a454ea177f6fbc024d.

* Revert "Stops flagging untitled editors with pre-loaded content as dirty"

This reverts commit 7a39226b7961af3aba8dc2f08113ed09eb2a1d61.

* Stops marking untitled editors with JSON as dirty

* Code clean up.
2021-10-08 17:37:08 -07:00
Alan Ren
458c4cff39 improvement for the editor crash issue (#17278)
* handle the query editor crash issue

* update message
2021-10-06 09:45:53 -07:00