Commit Graph

2161 Commits

Author SHA1 Message Date
v-bbrady
9f0584f88f removes more link from list element into div (#11218) 2020-07-07 11:06:44 -07:00
Alan Ren
3cf48fb207 SQL Edge deployment using Azure IoT hub (#11202)
* Azure IoT deployment type

* more updates

* organize fields

* a few more improvements

* resolve merge issues

* new rg improvement

* fix tests

* comments 1

* comments 2
2020-07-07 10:36:26 -07:00
Kim Santiago
3084867d7e pass connection profile to extension contributed commands in dashboard toolbar (#11217) 2020-07-07 10:34:04 -07:00
Maddy
ac78822d90 set currentMatch on find changes only (#11215) 2020-07-06 17:33:22 -07:00
Christopher Suh
aa4045c8a9 ServerTreeView unit tests (#11207)
* added unit tests

* removed newlines
2020-07-06 20:25:07 -04:00
Barbara Valdez
2a6fcee913 Add more tests to local content manager (#10350)
* Add more tests

* Add descriptive messages to asserts and remove formats check

* Address comments
2020-07-06 16:58:19 -07:00
v-bbrady
eabacae0c0 fixes show all extensions button #10445 #10625 (#11104)
* fixes button alignment and missing icons issues with ads welcome page

* removes dead code, registers new Button

* creates one button component and adds proper attributes depending on platform

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* adds return types to functions

* fixes show all extensions command

* formats css

* fixes layering issue

* updates querySelectors to be more specific

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-07-06 14:01:08 -07:00
Amir Omidi
84a7d1916a Fixes the azure account pane location (#11211) 2020-07-06 13:32:23 -07:00
Hale Rankin
ecfac10949 Notebook UI - Markdown toolbar - Headings dropdown (#11049)
* Adds heading dropdown to markdown toolbar.

* Added a method specific to headings that places markdown at beginning of line selected.

* Rewrote comment for my new method.

* Revised code to support multi select for headers, similar to how unordered list is applied. Multi-line headings can be undone if the multi lines are selected.

* Modified transformText to make single-line undo operation possible with just the cursor position.

* Added utility methods to help determine if the selection is a line-only or multi-line.

* Building isReplaceOperation to determine when preceeding characters need to be replaced with a new MarkdownButtonType.

* Updated comments.

* Applied changes written by Chris.

* Reverted changes to earlier stage where heading addition works just like list item additions.

* getExtendedSelectedText now returns an actual value in range for MarkdownLineType.EVERY_LINE.

* Added conditional so that Preview element is updated only when Preview is enabled.

* Updated tests for heading toolbar: heading 1, 2 and 3.

* Removed code that could not be reached.

* Corrected tests for headings.

* wip

(cherry picked from commit 43deb9635cc0eeebaffef22d4373f1f6ad713ace)

* cleanup

* fix error

* Fix tests

* Add more testing

* delete

* re-add

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-07-02 17:30:29 -07:00
Jorge Berumen
a06a06bb58 Add Azure DevOps as a resource for authentication (#11146)
* Adding ado as auth resource
* Removing Gov ADO resource
* Correctly handling azureDevOpsResource not being present for usgov
2020-07-02 17:22:31 -07:00
Karl Burtram
a4539daa62 Move account management icon to action bar (#11173) 2020-07-01 15:55:12 -07:00
Charles Gagnon
bd801ad8da Fix errors throw when doing validity checks (#11171) 2020-07-01 14:37:28 -07:00
Vladimir Chernov
b875d919d2 spell error in Severity column name (#11156) 2020-06-30 23:33:52 +03:00
ADS Merger
1388493cc1 Merge from vscode 2cd495805cf99b31b6926f08ff4348124b2cf73d 2020-06-30 11:31:11 -07:00
Anthony Dresser
ef8205f918 Remove deleting the old config (unsupported) and add notification (#11142)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* remove deleting the old config (unsupported) and add notification

* fix tests

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 21:40:03 -07:00
Anthony Dresser
93a88e38fe Messages panel wordwrap (#10970)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* fix word wrap support in the message panel

* fix width on message treee

* fix import

* fix settings editor to reflect the changes in the settings ids

* fix tests

* add configuration upgrader

* make sure to maintian execution order

* make the compiler happy

* add tests for upgrader

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 16:25:11 -07:00
v-bbrady
e540096e07 Bbrady/fixes tour start button (#11092)
* builds getting started tour

* reorganizes ts according to amirs comments

* Fix hygiene issues

* updates class names

* adds description to new configuration value

* uses core components

* PR fixes based on Charles comments

* formats css

* updates guided tour based on charles comments

* updates css formatting

* fixes read more link

* formats gettingStartedTour.ts

* updates copy

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* updates pr based on pr comments

* removes unused decleration

* formatting

* reformats css document

* updates file path

* updates images

* fixes start button issue

* merges master

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-29 09:55:19 -07:00
Chris LaFreniere
061d3510b9 Run ADS Commands from Notebooks (#11069)
* Run commands

* cleanup

* Plumbed through error and message output

* undo unnecessary changes

* Remove change to fix tests

* pr feedback
2020-06-28 21:17:50 -07:00
Aasim Khan
a9848a7a96 Added check all nulls to modify column Page (#10683) (#10751)
* -Added check all null checkbox

* Modified declarative table to add check all columns  in the column header

* -changed to using existing methods for firing events.

* -changed table height to auto
-center aligned data in table cell
-Check all generates event for only changed values

* -changes column header from text to column header (#10787)

* This fixes the weird angular stuff - we need to do this in every other component

* -added changes made by amir for dom object tracking
-added automatic checkall detection.
-made text-align center in table cells

* -fixed styling issues and issue with checkboxes

* -Removed unsued function

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-06-26 19:02:59 -07:00
Chris LaFreniere
9dc7ca056f Change nb before/after strings (#11121) 2020-06-26 17:36:28 -07:00
Maddy
6870bdaf72 revert back to original code (#11116)
* revert back to original code

* skip failing tests
2020-06-26 14:17:42 -07:00
Hale Rankin
7ef8acf04e Markdown toolbar > Preview toggle feature (#10963)
* Added toggle preview button to Markdown toolbar. Revised components, theme and styles to present the preview as a second column beside the markdown.

* Added showPreview to model and began working on togglePreview.

* Uncommented use of cellModel.showPreview

* add cell model event for onPreviewChange

* Renamed my showPreview boolean to prevent confusion with local boolean used in toogglePreview.

* Added CSS class when preview is enabled. Adjusted styles accordingly.

* Swapped icon show/hide references for correct sequence. Modified updatePreview to include state of doShowPreview.

* Added check for isEditMode so we can run togglePreview and show it once editor closes.

* Added listener to code.component that triggers layoutEmitter on changes to peview.

* Renamed local boolean doShowPreview. Removed unneeded code. Fixed ambiguity in my use of booleans, adding a getter and setter to textCell.

* Cleaned up implementation of new get/set for toggling preview.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-06-26 13:47:17 -07:00
Hale Rankin
00fe535add 10887 - Fixes icon position beside Cell and Run all in notebook toolbar. (#10897) 2020-06-26 13:46:52 -07:00
Hale Rankin
8f6c5af94f Cleaned up code for Add cell button in both main toolbar and cell toolbar. Corrected toolip to read: Add cell. (#10829) 2020-06-26 13:46:31 -07:00
Hale Rankin
8d7b3ef6ec Cell toolbar More Actions menu -- remove duplicate separators (#10827)
* Added code to remove multiple separators from more actions menu.

* Moved check for separators after list is deduped.

* Logic cleanup

* Added unit test for cell toolbar ellipses menu.

* Fix tests

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-26 13:45:53 -07:00
Arvind Ranasaria
c2ef27cd68 Second batch of tests for notebookEditor class (#10999)
* first few notebookEditor tests

* formating fixes

* unstash previous unfinished work

* saving

* PR feedback

* PR feedback

* copyright fixes

* improve test names and assertion messages

* saving

* PR feedback

* improve test names.

* test name change

* test name change

* remove unneeded cast

* remove spurious comment

* fix misplaced paranthesis - thanks hygiene checker!

* remove unused code

* remove deferredPromise

* createEditor test and dispose fixes

* remove unneeded import

* rempve unnecessary mock usage in dispose test

* use getContainer() for ['parent']

* use getContainer for ['parent']

* remove launch.json edits

* notebookService needs 9th constructor argument

* Add uploading debugging step

* minor changes

* remove changes to ci.yml

* working version

* formatting fixes

* pr fixes

* hygiene and exception path fixes

* remove minor debug changes

* pr feedback

* pr feedback

Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-24 13:19:12 -07:00
v-bbrady
17621e4df3 builds getting started tour (#10546)
* builds getting started tour

* reorganizes ts according to amirs comments

* Fix hygiene issues

* updates class names

* adds description to new configuration value

* uses core components

* PR fixes based on Charles comments

* formats css

* updates guided tour based on charles comments

* updates css formatting

* fixes read more link

* formats gettingStartedTour.ts

* updates copy

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* updates pr based on pr comments

* removes unused decleration

* formatting

* reformats css document

* updates file path

* updates images

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-06-23 18:59:02 -07:00
Charles Gagnon
a303144226 getCredentials returns credentials for any saved connection (#11029)
* getCredentials returns credentials for any saved connection

* Update doc comment

* Add tests

* cleanup

* cleanup
2020-06-23 11:04:13 -07:00
Chris LaFreniere
98ff618efd Add deprecated tag for standardKernels property (#11038)
* Remove unnecessary prop from NotebookProvider API

* Add deprecated tag

* make standardKernels required again

* tweak comment
2020-06-22 21:15:39 -07:00
Alex Ma
e01723f195 Additional tests for connection (#10944)
* Added providerRegistered test

* test for EditConnectionDialog

* changed wording

* added test for connectionInfo

* utils.ts tests added

* hasRegisteredServers test

* commented out editconnection tests, addl. tests

* added onConnectionChangedNotification test

* added changeGroupId tests

* Added connection  profile changes

* added connectIfNotConnected test

* added delete connection test

* isRecent and disconnect editor tests

* added registerIconProvider test

* Fix for ensureDefaultLanguageFlavor test

* added a few tests

* utils prefix test updated

* added utils tests
2020-06-22 13:51:39 -07:00
Laura Jiang
47f91b8efb fix typo (#11021) 2020-06-19 17:04:44 -07:00
AzureDataStudio
c4c23aa40d remove unused workflows
fix tests

disable vscode integration tests

distro

bump smoke test extension

ensure we register language register

fix compile
2020-06-19 10:59:24 -07:00
ADS Merger
5e7071e466 Merge from vscode 4d91d96e5e121b38d33508cdef17868bab255eae 2020-06-19 10:59:23 -07:00
Alex Ma
95107f1f61 Fix for auto resize column headers, (#10909)
* Fixed scroll to top

* removed brackets

* Don't trigger the cellSelectionModel when className is the resizable handler

* Added message for header listener

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-06-17 15:22:05 -07:00
Charles Gagnon
487bd2693e MIAA Dashboard Updates (#10960)
* Add database info to MIAA dashboard

* hook up open in azure button

* Only use plural text
2020-06-17 12:35:14 -07:00
Amir Omidi
21fd8b22e7 Fix a memory leak on listener (#10294)
* Fix leak

* We don't need the full connection profiles for drag drop control

* Remove unused code

* Change test definition

* Change test definition

* Change equality check
2020-06-16 19:36:10 -07:00
Charles Gagnon
fb4e400919 Make property container values selectable (#10946) 2020-06-16 15:08:16 -07:00
Anthony Dresser
381a747b62 fix export for remote (#10934) 2020-06-16 12:10:05 -07:00
Alex Ma
f13a5954a9 Port of Maddy's Edit Data Line Fix (#10676) 2020-06-16 10:13:17 -07:00
Christopher Suh
0c56e4a603 Column/Table Drag & Drop (#10702)
* able to drag objects from left pane

* changed scheme from file

* base functionality working

* extended functionality to tables

* added string literals and formatting

* cleanup

* cleanup

* added table/column parsing

* removed bad logic

* updated to use metadata

* cleanup and added sql carbon edit tags

* moved changes from vs into sql code base

* refactoring drag and drop

* cleanup

* cleanup

* cleanup

* added unit tests

* pr changes

* moved treeMock file

* fixed small bug
2020-06-15 23:52:46 -04:00
Arvind Ranasaria
f02e2a4b72 Initial unit tests for class NotebookEditor (#10926)
* first few notebookEditor tests

* formating fixes

* PR feedback

* PR feedback

* copyright fixes

* improve test names and assertion messages

* PR feedback

* improve test names.

* test name change

* test name change

* remove unneeded cast

* remove spurious comment

* fix misplaced paranthesis - thanks hygiene checker!

* remove unused code

* remove deferredPromise

* rempve unnecessary mock usage in dispose test

* use getContainer for ['parent']

* notebookService needs 9th constructor argument

* Add uploading debugging step

* remove changes to ci.yml

Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-06-15 15:27:42 -07:00
Anthony Dresser
16c27baf10 maintain scheme in insights (#10904)
* maintain scheme in insights

* fix compiles

* fix tests

* handle undefined

* fix windows tests

* fix imports

* handle remote resources
2020-06-15 14:23:31 -07:00
Brian Bergeron
a5cd755e41 support table with for DeclarativeTableComponent (#10881) 2020-06-15 10:12:49 -07:00
Maddy
26a00696d4 Fix/prev next links issue (#10523)
* intital test code

* added tests

* remove commented code

* fix for failing tests

* reuse exported enum

* changes to address comments

* add back onVisibility highlight

* port highlight fix from Chris

* fix tests
2020-06-12 18:42:17 -07:00
Amir Omidi
3608e132cb Add close button (#10898)
* Add close button

* Change the localize key
2020-06-12 13:03:18 -07:00
Amir Omidi
83a8b13750 If the connectionProfile was undefined, then return undefined (#10899) 2020-06-12 12:46:34 -07:00
Anthony Dresser
535e9d012a add getting started to contribution (#10892) 2020-06-12 12:21:04 -07:00
Anthony Dresser
46f72fef6a change icon locations (#10884)
* change icon locations

* fix icon location
2020-06-11 17:10:29 -07:00
Charles Gagnon
8db272cea4 Fix deployment warnings to only show if no resources found (#10878) 2020-06-11 17:07:19 -07:00
Alan Ren
4322234d0b use default row height and update button column (#10885) 2020-06-11 16:09:25 -07:00