ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-08 01:28:26 -05:00
Code Issues Packages Projects Releases Wiki Activity
9,073 Commits 1 Branch 152 Tags
5fc69a04454364d3057d21ff7fa34ae5d301a1e4
Commit Graph

593 Commits

Author SHA1 Message Date
Charles Gagnon
d647dbde09 Make dropdown update width immediately upon opening (#8716) 
* Make dropdown update width immediately upon opening

* remove type

* min size of the input container width

* use clamp
 2020-01-03 11:07:24 -08:00
Anthony Dresser
30d9e9c141 Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 (#8722) 
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1

* remove tests that aren't working
 2019-12-18 00:14:28 -08:00
Anthony Dresser
ea5f9be441 Properly expose errors in ads and tests (#8692) 
* add code to expose errors outside zone

* remove unexpect error hiding

* remove uncessary code

* fix tests

* trying to catch more errros

* revert for testing

* wip

* wip

* figured out what was going on

* wip

* fix tests

* fix tests
 2019-12-17 12:06:36 -08:00
Aditya Bist
a0c3f8f614 fix modelview tables failing for number columns (#8681) 2019-12-13 16:46:57 -08:00
Chris LaFreniere
698b4fce41 Add generic select box padding (#8635) 2019-12-10 22:14:01 -08:00
Anthony Dresser
f5ce7fb2a5 Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c (#8525) 
* Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c

* remove files we don't want

* fix hygiene

* update distro

* update distro

* fix hygiene

* fix strict nulls

* distro

* distro

* fix tests

* fix tests

* add another edit

* fix viewlet icon

* fix azure dialog

* fix some padding

* fix more padding issues
 2019-12-04 19:28:22 -08:00
Alan Ren
c03cce7f60 set aria label for table (#8443) 2019-11-22 16:05:57 -08:00
Alan Ren
8cd9097526 remove active css class on mouse leave (#8410) 2019-11-20 13:28:06 -08:00
Charles Gagnon
55059907a3 Fix a couple a11y issues with manage access (#8386) 
* Fix a couple a11y issues with manage access

* Fix strict null check

* Fix another strict null check
 2019-11-19 13:42:53 -08:00
Charles Gagnon
66048f1d63 Default checkbox aria label to label (#8367) 2019-11-18 10:24:27 -08:00
Amir Omidi
d6ef42c8b0 Change how dropdowns get their lengths - take 2 (#8356) 
* Add an element for width control

* Change the method that retrieves length

* Change to a readonly element
 2019-11-15 15:17:46 -08:00
Charles Gagnon
82185f75d7 Fix tab focus for select box (#8349) 2019-11-15 14:31:40 -08:00
Charles Gagnon
7563416754 Fix a couple a11y issues (#8334) 
* Fix a couple a11y issues

* Add other dialog
 2019-11-15 07:41:09 -08:00
Charles Gagnon
4f69ed5745 Fix missing icon and add test (#8307) 
* Fix missing icon and add test

* Remove debug statement
 2019-11-12 16:31:39 -08:00
Charles Gagnon
0ae525cbd5 Fix a few more floating promises (#8290) 
* Fix a few more floating promises

* More explicit calls
 2019-11-11 13:42:03 -08:00
Anthony Dresser
df0c505452 No unused locals (#8231) 
* add no unused local

* fix strict null

* fix compile errors

* update vscode comments
 2019-11-06 17:22:05 -08:00
Anthony Dresser
564f78b6f6 Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)"" (#8242) 
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240)"

This reverts commit e801a04bcf.

* fix runtime error

* add tests for chartview
 2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240) 
This reverts commit 22a427f934.
 2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934 Remove typings and replace missing methods with vscodes (#8217) 
* remove typings and replace missing methods with vscodes

* fix strict-null-checks

* fix tests
 2019-11-05 13:03:20 -08:00
Amir Omidi
1b88c10197 Some promise fixes (#8216) 
* Some promise fixes

* changes to how we're logging errors

* Fix the tests

* Fix a few other issues
 2019-11-05 11:50:39 -08:00
Anthony Dresser
ade68b184d Move code around for more linting (#8190) 
* testing

* moving around all the code

* fix strict nulls
 2019-11-04 10:41:28 -08:00
Charles Gagnon
82e5221024 Fix modal event propagation (#8050) 
* Fix event propagation

* Remove unneeded onkeyup method

* Move event handling code into SQL classes
 2019-10-30 11:29:01 -07:00
Kim Santiago
ce5eb00177 Fix schema compare include/exclude behavior (#8042) 
* don't uncheck difference if unsuccessful

* changes after rebasing to get schema compare fix

* First cut of column checkbox checking reactive to include opteration

* handle blocking dependencies and affected dependencies

* Changing the checked property of table to be list

* Addressing comments

* add map to keep row number of diff entries

* remove findDifferenceRow() since it isn't needed anymore

* fix scrolling to the top when checking/unchecking and add info message

* change checked to updateCells

* improve warning cannot include/exclude message
 2019-10-29 11:55:31 -07:00
Anthony Dresser
1e22f47304 Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998 (#7880) 
* Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998

* fix pipelines

* fix strict-null-checks

* add missing files
 2019-10-21 22:12:22 -07:00
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837) 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
 2019-10-21 12:02:30 -07:00
Amir Omidi
5da0e16e44 Check for error (#7711) 
* Custom error
 2019-10-14 16:26:51 -07:00
Alex Ma
12d824d791 Fix for chart names in dropdown select box. (#7642) 
* isolated problem involving user friendly names

* Fix to handle horizontalBar

* Working rough version, need to implement data structure to store alternative names later

* consolidated checks into its own static method, data structure still highly recommended to implement

* Version with hashMap implemented

* Moved check for alternative names into chartView

* removed parseOption

* removed space in selectbox

* removed unused import

* removed unused import and spaces

* Fixed formatting

* Added new comment and modified changeToAltNames

* Localization has been added to the Hash

* flxed small formatting issue

* fixed double quotes for nls.localize
 2019-10-11 09:50:23 -07:00
Amir Omidi
b58927fea1 Fix the CI (#7633) 2019-10-10 11:52:02 -07:00
Alex Ma
4d618c5ef1 Improved chart names for chart type dropdown. (#7631) 
* isolated problem involving user friendly names

* Fix to handle horizontalBar

* Working rough version, need to implement data structure to store alternative names later

* consolidated checks into its own static method, data structure still highly recommended to implement

* Version with hashMap implemented
 2019-10-10 11:08:33 -07:00
Amir Omidi
16fbd4abfd Return values (#7521) 2019-10-07 15:29:51 -07:00
Amir Omidi
cacbcb5415 Add more functionality to the grid (#7516) 2019-10-05 12:08:18 -07:00
Charles Gagnon
08b78c3ca5 Add width and height properties to checkbox component (#7482) 2019-10-02 16:21:08 -07:00
Udeesha Gautam
7489a65bbe Changing Sql cmd icons to more clear ones (#7451) 
Changing Sql cmd icons to more clear ones
 2019-10-02 11:04:22 -07:00
Anthony Dresser
2a15768a25 Remove diff (#7368) 
* remove diff

* gulpfile changes (#7370)

* gulpfile changes

* Remove examples

* move require statements to the top of the file

* add await
 2019-09-26 11:55:42 -07:00
Anthony Dresser
db498db0a8 Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f (#7282) 
* Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f

* fix various icon issues

* fix preview features
 2019-09-19 21:50:52 -07:00
Amir Omidi
86a9a2c069 NaN checks aren't possible with an equality check (#7268) 2019-09-18 10:59:58 -07:00
Aditya Bist
c6c863cd84 commiter work (#7244) 
* fix incorrect css and removed redundant css warnings

* add gulp step to check all files

* added files file

* revert build to hygiene job

* keep css changes only
 2019-09-17 14:10:38 -07:00
Anthony Dresser
ea0f9e6ce9 Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 (#7206) 
* Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463

* fix config changes

* fix strictnull checks
 2019-09-15 22:38:26 -07:00
Amir Omidi
abe917f3c1 Better cell selection (#6914) 
* Better cell selection

* Explicit return type and undefined assignment

* More complex copy/paste

* Get TS to be less mad at me

* Remove EoL

* Fail safe if statement

* strict null check
 2019-09-11 18:23:49 -07:00
Udeesha Gautam
5ae8017233 Bug/accessibility 5 (#7008) 
* fixing 6946 and 6796(second part)

* fix for https://github.com/microsoft/azuredatastudio/issues/6726

* comments cleanup

* taking PR comments

* adding strong border for HC focus

* convert to string template
 2019-09-09 15:37:12 -07:00
Anthony Dresser
02f497712d clean up some promise use in cms (#7004) 2019-09-06 15:58:47 -07:00
Anthony Dresser
1d6f48806e fix index for panel push (#7035) 2019-09-03 17:17:23 -07:00
Benjin Dubishar
faf6eae535 Inform screen-readers of Dacpac Deploy loading and loading complete for summary (#7000) 
* Loading components now announce themselves.  Likely need way to disable.

* Adding focus elements to table for screen-reading after component is loaded in

* Adding piping for aria roles on tables

* Alerting on completion of deploy plan summary

* Removing extra ariaLive property
 2019-08-28 14:42:40 -07:00
Anthony Dresser
658cf51887 Merge from vscode 0f73473c08055054f317c1c94502f7f39fdbb164 (#6892) 
* Merge from vscode 0f73473c08055054f317c1c94502f7f39fdbb164

* fix tslinting
 2019-08-22 22:07:01 -07:00
Udeesha Gautam
1372cbaee1 Bug/Accessibility fix for 6796 (partial), 6800 and 6745 (#6882) 
* fix for https://github.com/microsoft/azuredatastudio/issues/6796 (partial) and https://github.com/microsoft/azuredatastudio/issues/6800 and checkbox regression

* fix for https://github.com/microsoft/azuredatastudio/issues/6745
 2019-08-22 17:31:06 -07:00
Benjin Dubishar
887b2bfd2b Adding aria-live label support for input boxes (#6862) 
* Adding aria-live support for InputBoxes

* Adding aria-live setting for DacFx wizard InputBox control

* Dud commit to unstick Github CI
 2019-08-22 14:01:19 -07:00
Udeesha Gautam
854508e940 Bug/accessibility - Focus related issues (#6859) 
* fix for https://github.com/microsoft/azuredatastudio/issues/6798

* fix for https://github.com/microsoft/azuredatastudio/issues/6851
 2019-08-22 10:29:27 -07:00
Kim Santiago
8e668b657c add names for schema compare dialog (#6856) 2019-08-21 15:20:07 -07:00
Kim Santiago
f64c2775b0 set aria-label for radio buttons (#6835) 2019-08-20 15:17:37 -07:00
Anthony Dresser
c540e81108 clean up some disposable use (#6832) 2019-08-20 14:34:13 -07:00