ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 01:25:36 -05:00
Code Issues Packages Projects Releases Wiki Activity
8,967 Commits 1 Branch 152 Tags
656a86a103607c8b004ebd082b982df72353a561
Commit Graph

820 Commits

Author SHA1 Message Date
Lewis Sanchez
656a86a103 Fix empty connection name in delete connection prompt (#22001) 
* Fix empty name in delete connection prompt

* Update src/sql/workbench/services/objectExplorer/browser/connectionTreeAction.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-02-21 17:43:29 -08:00
Christopher Suh
6231df85e0 Handle undefined error when opening connection dialog (#21980) 
* handle undefined error when opening connection dialog

* combine into else if

* change log

* update log message
 2023-02-17 15:22:51 -08:00
Lewis Sanchez
7c47aea06e Fix set authenticationType of undefined error (#21982) 2023-02-17 15:04:59 -08:00
Cheena Malhotra
66053f5152 Fix missing null ref check causing extension issues (#21974) 2023-02-17 09:45:23 -08:00
Alan Ren
8690c350d2 fix server group color a11y issue (#21958) 2023-02-15 21:21:35 -08:00
Aasim Khan
d6c35836cc Adding group by schema to OE (#21941) 
* Adding group by schema and updating schema icon

* Adding item context menu

* Fixing command logic

* Adding telemetry for group by and changing default config

* reverting no child nodes error message

* Code cleanup

* Cleaning up constants

* Removing unused imports

* Update extensions/mssql/src/main.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* converting to sendActionEvent

* sendActionEvent

* Adding telemetryViews and telemetry actions

* Fixing localized string

* registering context

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-02-15 15:18:10 -08:00
Cory Rivera
f7fa9bece3 Add a check for an undefined model when creating the connection dialog model. (#21953) 2023-02-15 14:23:15 -08:00
Lewis Sanchez
d9b24522e5 Fix missing password in Connection pane for Server connections with remembered passwords (#21813) 
* Fix missing password in Connection pane

* Get saved password for SQL login default auth type

* Clean up

* Fix build hygiene errors

* Captures input

* Add timeout waiting for all promises to resolve

* Add missing semicolon

* Code review feedback

* Minor clean up

* Code review feedback

* Improved error messaging

* Update src/sql/workbench/services/connection/browser/connectionDialogService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Improves UX around loading passwords

* Remove unused import

* Uses await instead of promise chaining.

* Removes async

* Revert back to resolving password promise.

* Asserts controller map and model have values.

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-02-14 20:49:55 -08:00
Alan Ren
a683b1b777 profiler a11y bug fixes (#21940) 2023-02-14 18:48:17 -08:00
Alan Ren
385e4a2245 move the focus to newly added filter field. (#21930) 2023-02-13 19:43:16 -08:00
Alan Ren
93f5581bc7 add aria-label for step link in wizard (#21925) 
* add aria label to wizard step link

* update aria label
 2023-02-13 13:41:01 -08:00
Cheena Malhotra
3fb8d57d25 Add support for Encrypt=Strict for TDS 8.0 connections with SQL Server 2022 (#21256) 2023-02-10 10:34:36 -08:00
Alan Ren
514d599e62 remove client side sorting for db list (#21899) 
* remove client side sorting for db list

* update sts
 2023-02-10 09:15:41 -08:00
Christopher Suh
7150257218 Fix Account Dialog with Multiple Providers (#21836) 
* fix uncaught error in showSplitView

* fixed bugs around account dialog with multiple providers

* cleanup

* fix index out of bounds error

* Fire account list update after removing provider, other pr fixes
 2023-02-07 15:00:47 -08:00
Cheena Malhotra
66410edf02 Migrate cert validation error handling to mssql extension (#21829) 2023-02-07 09:21:35 -08:00
Lucy Zhang
b3048213e8 Minor improvements in notebook edit mode handling (#21839) 
* rename + remove duplicate calls

* only fire onCellEditModeChanged when changed
 2023-02-06 10:42:19 -08:00
Aasim Khan
95d4f130c6 Replacing select with focus to prevent second create session (#21811) 2023-02-02 15:07:05 -08:00
Alex Ma
298402647d Added error handling service for providers (#21627) 
* added prototype errorHandlerService

* added initial contracts

* Added WIP client sent request function

* added WIP signature for handleOtherError to resourceProviderService

* made some small fixes

* removed unnecessary resourceProviderId

* added updates to contracts and resourceProvider

* moved error codes to azdata proposed

* added connection type instead of profile

* added WIP handleOtherError code

* added fix for send

* added WIP change password function in resource provider

* added work in progress error handling thread

* added errorHandler interface

* added result error check

* renamed errorHandling namespace to diagnostics

* WIP rename of errorhandler

* light cleanup

* Bump json5 from 2.1.3 to 2.2.3 in /extensions/machine-learning (#21514)

Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437)

* Debounces second invocation while expanding OE tree items

* Minor clean up

* Adjusts debounce time

* Adding temp trace comments

* Adds missing semicolon

* Removes debouncer to stop 2nd newSession calls

* Removes temp trace comments

* Updates comment

Co-authored-by: Alan Ren <alanren@microsoft.com>

* Bump json5 from 2.1.3 to 2.2.3 in /extensions/admin-tool-ext-win (#21546)

Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix resource endpoints to end with slash (#21540)

* Bump json5 from 2.1.3 to 2.2.3 in /extensions/azcli (#21543)

Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump json5 from 2.1.3 to 2.2.3 in /extensions/arc (#21544)

Bumps [json5](https://github.com/json5/json5) from 2.1.3 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v2.1.3...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* renamed diagnostics service slightly

* registered service

* added work in progress diagnostics implementation

* small changes

* added new diagnostics exe

* Changes for Diagnostics Service (#21583)

Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>

* WIP provider changes

* added changes for errorDiagnosticsService

* removed stuff from mssql.

* made fix to connectionManagementService

* added error catch

* added small changes

* more small changes made

* added small changes to handleOtherError

* moved changePassword to CMS

* added testErrorDiagnosticsService

* Added provider-based handling for change password/generic error handling. (#21662)

* WIP rework for error connection change

* added connectionProfileDuringError

* added working password reset

* added comments

* consolidated connection profile conversion

* added additionalObjects parameter.

* removed unnecessary error profile grab

* added comments

* added changes to parameters and comments

* added changes and params

* added handleConnectionErrorParam

* added more changes

* added async

* added params and more

* added many fixes

* added updated documentation

* added WIP password change dialog with await

* added error handling

* added comment

* added options as parameters

* cleaned up parameters

* added async

* added check fixes

* Added username to title

* added server name to dialog

* Added dialog changes

* Revert "Added dialog changes"

This reverts commit c2bdcd16f4a0dffdc643ef9cae1c1a20642ac512.

* Revert "added server name to dialog"

This reverts commit dbd22e80461b5a068643f0c2d6728adce4010978.

* Revert "Added username to title"

This reverts commit 6d936b4d5f97f9345f8ec2fdbbcf6b52df18820a.

* Revert "added check fixes"

This reverts commit f58081a5af3276766e2042b4d671455b18add9a7.

* Revert "added async"

This reverts commit dd1198e26ec7542ec51add0628f588361d674299.

* Revert "cleaned up parameters"

This reverts commit 51135c9f9db452104697483779d8df15b6430717.

* Revert "added options as parameters"

This reverts commit b167804a2410558bbe60042e017ae2c77af7697f.

* Revert "added comment"

This reverts commit 0ad37326a3e025e88f715e3f2547be6825597a8d.

* Revert "added error handling"

This reverts commit 69340980d2c84056a2bcf126ea77f4b5ed4cddf3.

* Revert "added WIP password change dialog with await"

This reverts commit 9e43113e07b10421b39575f6c7dd14287662b90d.

* added a fix to check

* added fixes

* added back in change password changes

* added in comment

* added suggested changes

* removed param colons

* Update extensions/mssql/src/errorDiagnostics/errorDiagnosticsProvider.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* fixed conversion and provider dialog

* altered comments

* Update src/sql/platform/connection/common/utils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* renamed Id

* Update src/sql/platform/connection/common/utils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Improvements for Change password dialog + logs added (#21794)

* Improvements for Change password dialog + logs added

* Include server

* fixed tab space

* added comment

---------

Co-authored-by: Alex Ma <alma1@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* added fix to id to extHostErrorDiagnostics

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
Co-authored-by: Cheena Malhotra <cmalhotra@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-01-31 14:31:12 -08:00
Cheena Malhotra
f43afff8d1 Show tenant dropdown when selecting 'AzureMFA' for first time (#21763) 2023-01-27 16:08:11 -08:00
Cheena Malhotra
895b43f36a Fix account and tenant selection behavior (#21749) 2023-01-27 11:47:24 -08:00
Aasim Khan
ccc8df31c7 Adding prompt for delete connection (#21624) 
* Adding prompt for disconnect

* changing to Idialog service

* Code cleanup and fixing comments

* Adding comments and making a test async

* removing then and awaiting for function
 2023-01-23 22:56:09 -08:00
Cheena Malhotra
b3acef3124 Add Azure Resource 'Sql' to MSSQL extension. (#21600) 2023-01-20 13:08:38 -08:00
Lewis Sanchez
f74d6f6d9b Copy Headers for Selected Columns (#21622) 
* Adds copy header delimiter setting

* Copies all table headers or selected headers only

* Adds missing comments

* Update src/sql/workbench/contrib/query/browser/query.contribution.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/contrib/query/browser/query.contribution.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Creates sort map entries function

* Removes CSV formatting and setting.

* Add colons before error message

* Renames table column sorting method

* Removes extra unnecessary function call

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
 2023-01-18 13:20:27 -08:00
Charles Gagnon
85eb7b8824 Add trace debug logging to OE service (#21617) 
* Add trace debug logging to OE service

* cleanup
 2023-01-17 17:00:21 -08:00
Cheena Malhotra
3239bb429f Null Check for errorNumber (#21586) 2023-01-12 18:27:10 -08:00
Christopher Suh
90ef8e4907 Remove duplicate account entries (#21575) 2023-01-12 12:35:16 -08:00
Cheena Malhotra
9708b470c7 Azure core | Include alternate library accounts if found (#21565) 2023-01-11 16:05:20 -08:00
Cheena Malhotra
fd2ced449b Skip fetching access token when opening context menu in OE (#21557) 2023-01-09 21:22:02 -08:00
Lewis Sanchez
8c8a7859a0 Stops second invocation of createNewSession while expanding OE tree items on disconnected servers (#21437) 
* Debounces second invocation while expanding OE tree items

* Minor clean up

* Adjusts debounce time

* Adding temp trace comments

* Adds missing semicolon

* Removes debouncer to stop 2nd newSession calls

* Removes temp trace comments

* Updates comment

Co-authored-by: Alan Ren <alanren@microsoft.com>
 2023-01-06 16:10:19 -08:00
Alan Ren
88ab7947a4 fix issue caused by execution plan provider (#21533) 2023-01-05 21:12:49 -08:00
Cheena Malhotra
ec7e754009 Handle default tenant to be set when only 1 tenant exists (#21532) 2023-01-05 16:40:16 -08:00
Cheena Malhotra
e7fcda7351 Filter accounts based on Auth library in accounts management service (#21501) 2023-01-03 20:16:08 -08:00
Charles Gagnon
29c88923f5 Fix Firewall Rule dialog dropdowns (#21499) 
* Fix Firewall Rule dialog dropdowns

* Fix tenant dropdown
 2023-01-03 16:24:59 -08:00
Cheena Malhotra
87f1d14357 Reset expiresOn property for non-Azure connections (#21452) 2022-12-19 13:04:39 -08:00
Cheena Malhotra
ca22686061 Add support for firewall rule name (#21430) 2022-12-16 18:29:44 -08:00
Cheena Malhotra
112de46723 Fix ADAL to MSAL transition of connections and account list (#21425) 2022-12-15 16:38:45 -08:00
Cheena Malhotra
234c3debaa Fix issues when setting azureTenantId (#21412) 2022-12-14 12:03:11 -08:00
Cory Rivera
272e748424 Show a message if kernel is not supported when first opening a notebook. (#21376) 2022-12-08 10:27:57 -08:00
Alex Ma
fb6e221fff [Loc] added small change to password change dialog localization (#21377) 2022-12-07 15:03:45 -08:00
Alex Ma
cffba368a9 Added reset password dialog upon SQL Server expired password error (#21295) 
* Added initial password connection dialog box

* made small changes

* more preliminary work

* more WIP changes

* more cleanup done

* added dialog instantiation

* added placeholder dialog window

* added changePasswordController

* made some changes to changePasswordController

* some changes made

* added more changes

* more changes made to dialogue

* added password confirm box

* added WIP change password function

* small changes made to API

* small changes for test

* added  uri

* added valid password

* added TODO comments

* added small change to connectionManagementService

* added connectionManagementService password change

* added comment on what to do next

* made some simplification of change password

* added response callback

* added fixes to protocol

* added throw error for passwordChangeResult

* WIP added call to self after password change

* WIP changes to implementing new password change dialog

* added changes to passwordChangeDialog

* added launchChangePasswordDialog

* remove erroneous css

* added working dialog

* removed old password change dialog

* fixed space

* added checkbox option to passwordChangeDialog

* added test signatures

* added error handling

* added some changes

* added changes to HTML for passwordChangeDialog

* added CSS to passwordChangeDialog

* added display none for matching passwords

* added documentation changes

* small cleanup

* added working error catch and retry

* added await

* added recovery instructions

* Added ok button hide for button click.

* added loading spinner

* fixed for semicolon

* added updated message

* Added message change

* added minor fixes

* added small fixes

* made more changes

* renamed messages to errorDetails

* added styling to passwordChangeDialog

* simplified error message

* changed comment

* modified azdata to be consistent

* small changes

* change to azdata for consistency

* added clarification for provider

* removed additional instructions

* Added new dialog title

* addressed feedback

* added comments

* added changes
 2022-12-07 14:27:01 -08:00
Cory Rivera
e2327c393a Remove all Big Data Cluster features (#21369) 2022-12-07 12:28:17 -08:00
Karl Burtram
05eb8dd448 Add PowerBI PPE URI to domain list (#21357) 2022-12-05 15:03:01 -08:00
Cheena Malhotra
e89341f6bd Set both label and values to custom options select Boxes (#21354) 2022-12-02 13:48:23 -08:00
Cheena Malhotra
02e9f8d3ef Rename to security token to match STS (#21338) 2022-11-30 15:02:08 -08:00
Aasim Khan
c0a194df4a Adding wizard and dialog footer loading spinner (#21230) 
* Adding wizard and dialog loading

* Moving apis to proposed

* fixing namespace

* Only firing event when the value changes

* Only firing when value is changed

* Adding loading complete message to dialog and wizard

* Registering listeners and making a new base interface for loading components

* Fixing api comment

* Renaming prop to loadingCompleted

* old loading icon
 2022-11-30 12:18:34 -08:00
Cheena Malhotra
23dfd690a6 Refresh token with SqlToolService session update (#21308) 2022-11-29 15:26:15 -08:00
Cheena Malhotra
405b3bbfdb Fix default auth and 'AzureTenantId' to persist and not reset on selection event (#21289) 2022-11-23 17:39:03 -08:00
Christopher Suh
86c3f315f2 Add MSAL Authentication Library support (#21024) 2022-11-23 14:06:44 -08:00
Cheena Malhotra
62b123624d Fix icon foreground (#21287) 2022-11-22 18:03:51 -08:00
Cheena Malhotra
3b6ce47acc Fix access token refresh design (ADS only) (#21206) 2022-11-21 19:35:00 -08:00