mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-24 17:23:05 -05:00
65ef41d53d635c50faadf9b04386df694a8db01c
25 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Nemanja Milovančević
|
65ef41d53d |
UI for the Backup/Restore Managed Instance Feature (#19244)
* Rebase from main branch * Made mssql a module * remove rpc specific stuff * Added create sas RPC call * Backup to url works now * Moved createSas RPC to the BlobService * Relocated createSas RPC from sql-dataprotocolclient to the mssql * After rebase * Removed duplicate symbol * Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension * Removed AzureBlobProvider, removed AzureBlobService feature * renamed blob to azureblob, converted thenable to promise * Simplify API * fixes * docs update, blob to azureblob update * UI design first commit * Detected Managed Instance, trying to script backup to url * azure subscription api added, but ADS crashes * Created url dialog component and added link account * Changed backup component UI logic * Changed b/r UI, added restore from URL, detected MI from restore component * Removed mocked and added real Azure API, changed RestoreDialog UI * Added file fetching API * added create sas RPC call * Backup to url works now * Fixed some bugs * Moved createSas RPC to the BlobService * Relocated createSas RPC from sql-dataprotocolclient to the mssql * Rebase createSas changed to the backupRestoreManagedInstance * PR comments fix * Enabled backup to url for gov clouds * Replaced anchor element with Link class * Fixed pick azure account logic * Removed duplicates from eslintrc * Fixed url browser dialog * Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button * bumped sts version * bumped sts version * Fix config * Fixed URL browser dialog UX * Backup and restore dialog fix * Referencing azure resource types directly * Scoped url browser dialog css classes * Made the url browser dialog field a local variable * moved url browser files from fileBrowser to the urlBrowser folder * Changed deviceType from number to enum * Added all device type options * Moved mssql * Added MI backup button comment * Removed unhelpful comment * Revert differential copy only backup mistake * Renamed azurebrowser to urlBrowserDialog * Localize create sas button label * Removed unnecessary spinner * Use UTC date instead of locale date * Removed * and added required flag * Use async instead of nested thens * Added target database tooltip * Using deferred promise instead of event emitter * Added error handling to the url browser dialog * Registered backup component elements * Register backup component listeners * Removed redundant setDefaultBackupPaths call * Added setBackupPathList docs * Add return types * Remove code from comment * Register restore dialog elements * Register restore dialog listeners * Pass engine edition enum instead of boolean * Capitalize enum values * DatabaseEngineEdition fix * Use DeviceType instead of number * Use deferred pointer * Add new ModalDialogName * Use constructor fields * Register URL browser dialog components * Remove unnecessary helper function * nextYear function doc and move * split registerListeners method * showDialog returns promise * Backup device type comment * Pass aria label through constructor * Fix backup button * Remove comment * Comment unsupported MI backup options * Remove one liner helper function * Restore dialog methods return types * Remove comment * JS doc format * Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog * Moved MediaDeviceType, added PhisicalDeviceType * Reorder and rename physical device type * remove extra spaces Co-authored-by: chgagnon <chgagnon@microsoft.com> |
||
|
Charles Gagnon
|
8d45e40901 | Add event to track node expansion errors (#19248) | ||
|
Lewis Sanchez
|
010107aea8 |
Telemetry for Query Execution Plans (#19039)
* Adds telemetry around how the properties window is opened * Adds telemetry around accessing execution plan top operations * Adds key for viewing top operations * Adds telemetry around using the open query button and context menu item * Adds telemetry around execution plan zoom in, out, to fit, and custom * Adds telemetry around searching for nodes in execution plans * Reduces telemetry additional properties to 1. * Code review changes * Removes unnecessary export |
||
|
Aditya Bist
|
e7773425ee |
added graph node types from edit and publish results (#18891)
* added graph node types from edit and publish results * make generic property bag * review comments * add comment for function * edit comment * change name to telemetry info |
||
|
Chris LaFreniere
|
230c0f317f |
Notebooks: Add telemetry event for mime type renderer not found (#18200)
* Add event for mime type renderer not found * Add back missing return statement |
||
|
Aditya Bist
|
de5090e47a |
Added data points for Table Designer (#18182)
* added server infor and metrics for table designer * update generate script * pr comments * format more files * pr comments * make changes to core * remove unused imports * add server info * revert enum change and add publish event * format doc * nitpicks * remove os version * remove modifier from telemetry info * remove error message |
||
|
Alan Ren
|
ff84cc17c4 |
save/generate script for table designer (#17972)
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit
|
||
|
Barbara Valdez
|
8a205965d2 |
add telemetry to undo/redo at cell level (#17804)
* add telemetry to undo/redo at cell level *add sendTelemetryActionEvent that sends telemetry from notebook model |
||
|
Alan Ren
|
f07427f2c1 |
add open table designer event telemetry (#17595)
* add open table designer telemetry event * rename variables to reflect the text change * format code |
||
|
Charles Gagnon
|
ebe24046de |
Log extension host commands (#15721)
* Log extension host commands * Add more comments |
||
|
Alan Ren
|
e42da81005 |
connect dialog telemetry (#15267)
* add connection dialog telemetry * reset source * add to correct place |
||
|
Maddy
|
43db30d1da |
Add more Notebook telemetry events (#14755)
* initial checkin * telemetry for search in notebooks * telemetry for move notebook * address comments * feedback changes * fix tests paasing NullAdsTelemetryService * move changeKernel telemetry higher up * remove telemetry service * Fix new Notebook events (#14982) * Notebook telemetry fixes * update2 * Move event location * remove service * remove unused Co-authored-by: chgagnon <chgagnon@microsoft.com> |
||
|
Alan Ren
|
c2d2cf5a82 |
limit the data size for chart rendering (#14949)
* limit the rows feed to charts * add telemetry and option to hide * fix typo * updates * comments * notebook fix |
||
|
Charles Gagnon
|
31ce58a8fc |
Cleanup telemetry keys (#14795)
* Add event for connection error * Cleanup telemetry keys * Fix missed keys |
||
|
Charles Gagnon
|
f6f45bc3f9 | Add event for connection error (#14564) | ||
|
Hale Rankin
|
05f97411fa |
New feature for Notebooks - Callout (#13078)
* New feature for Notebooks - callout. This utilizes a modifed modal.ts that renders a small modal set to appear at the trigger event and disappear when user clicks off of it. This is intended only for micro-interactions such as inserting links, tables and images into Notebooks. Error dialogs dependent on modal have been updated to implement the modified width property correctlty. * Modified dialogStyle names in interface. Applied updates to files dependent on this. Wired up disposable listener for browsing local files in image select callout. Renamed callout to calloutDialog. * Converted double quotes in CSS to single quotes. Revised run method, removing the promise wrapping from the conditional. * Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag. * Revised structure and styles. * Updated component for use with ML extension. Updated ML extension code with changes for custom dialog creation. * Fixed async context for handleBrowse. Passing the new modal properties into Dialog implementation for ML. * Added option to suppress callout dialog header and footer from the machine learning view file. Added a compact variant of callout. Corrected Dialog tab initialization. * Maddy/callout modifications (#13586) * initial changes * canSelectFolders false * change label, placeholder text on radiobtn click * Added support for custom XY offset to account for modal size and to provide for fine-tuning of unique modal instances. * Updated Image icon with latest from Design. * Replaced node process with IPathService for retreiving image file. * Added theme color lookups to provide default colors when none are provided. * Added async/await to tests calling transformText. * textCell, modal - swapped out HostListener for a member method which listens for the Esc keyup. Updated templates with method call on keyup. This cleaned up the double event call whenever the Esc key was pressed. Added property to modal Cancel button call to make it a secondary button. * Cleaned up callout styles. * Removed color use for input fields because component code delivers theme-specific values. * Added check for CSS class `mac` on the body tag. Added conditionals to supply alternate dialogXYOffset in the case of non-Mac environment. * Cleanup: Simplified DialogPosition. Renamed telemtry references and dialog related methods. Corrected spelling. Added missing signatures and types. Updated warning callout link URLs. * Removed async and await as there are no promise dependencies. Added a signature. * Revert "Fix windows insiders icons (#13579)" (#13630) This reverts commit |
||
|
Charles Gagnon
|
c3a00c2cc6 | Clean up telemetry keys (#14093) | ||
|
Maddy
|
5be2e01632 |
Notebook Telemetry initial changes (#13929)
* initial changes * add ads-telemetry to nb extension * add aiKey to notebook extension * add run cell telemetry in cellmodel * add NbTelemetryAction * remove source * remove telemtery for run notebook for now * fix optional variable call * addr comments * changing the dependency package * revert * removed webpack config for telemetry compat * add opentelemetry to externals Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> |
||
|
Sai Avishkar Sreerama
|
0316d9ac57 |
Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859)
* Dacpac telmetry code changes * Removed added spaces * Generate deployScript accessibility changed back to public * code review suggessions updates * dacpac extension tests fixes * Updated time and filesize methods allowing general return values * Telemetry code updates * Dacpac Telemetry potential data loss capture and PII error excluded * Dacpac telemetry code updates for comments * Wizard pages navigation telemetry event capture moved to the core * DacpacTelemetry code updates * Extension wizard cancel telemetry for data loss * Dacpac telemetry pagename and small code updates * final Dacpac telemetry code updates... |
||
|
Charles Gagnon
|
bf9646ba98 |
Add ModelViewEditorOpened event (#12597)
* Add ModelViewEditorOpened event * fix * Fix compile |
||
|
Charles Gagnon
|
1b4f6f8934 |
Add Data Grid Provider API (#12097)
* Add RegisterResourceDataProvider API * Change to data grid provider * fixes * updates |
||
|
Vladimir Chernov
|
8288360cc4 | Assessment core extension (#10154) | ||
|
rajeshka
|
b9b3c1071e |
Added Notebook telemetry for livesite notebooks (#9948)
* Added Notebook telemetry for livesite * added back the metadata retension code * Unified Telemetry services * fixed names * Fixed texts to use new NullAdsTelemetryService * Validate GUID before sending it * made GUID check a bit more robust Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com> |
||
|
Candice Ye
|
161c182a56 |
Fixed telemetry events for visualizer recommendation prompts (#6547)
* Fixed telemetry events for visualizer recommendation prompts * Added telemetry event for when Visualizer button in action bar is clicked and added respective telemetry keys * Created TelemetryView and TelemetryAction and relocated new constants |
||
|
Anthony Dresser
|
c23738f935 |
Inital platform relayering (#6385)
* moving test files and inital refactoring * relayer extension host code * fix imports * make insights work * relayer dashboard * relayer notebooks * moveing more code around * formatting * accept angular as browser * fix serializer * add missing files * remove declarations from extensions * fix build errors * more relayering * change urls to relative to help code relayering * remove layering to prep for merge * fix hygiene errors * fix hygiene errors * fix tests |