ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 01:25:39 -05:00
Code Issues Packages Projects Releases Wiki Activity
6,790 Commits 1 Branch 152 Tags
671c062e59dc65f2024f36ef9eae7ad649b4eef7
Commit Graph

171 Commits

Author SHA1 Message Date
rajeshka
671c062e59 Split notebookcell (#17185) 
* Initial Split code

* minor change

* minor changes

* Added split cell button to initActionBar, created split cell class to pss cell context.

* added changes

* fixed index

* Split Cell Working in markdown mode

* Fixed highlighting

* Preserve the edit state

* Added new icon and updated styles and cellToolbar component with new icon name.

* Addressed PR

* Addressed PR

* Added back isEditMode flag

* Moved split action to after edit toggle.

* Fixed typo

* Addressed PR

* Addressed PR

* Removed deletion of the cell

* fixed the comments

Co-authored-by: Hale Rankin <harankin@microsoft.com>
 2021-10-06 18:18:22 -07:00
Cory Rivera
14904bb671 Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) 2021-09-29 16:15:28 -07:00
Daniel Grajeda
4a715e473a Add guids to RunAll and RunCell events (#17123) 
Add guids to RunAll and RunCell events
 2021-09-21 20:56:46 -07:00
Chris LaFreniere
d32f25425b Use updated markdown renderer from vscode (#16988) 2021-09-03 10:43:25 -07:00
Chris LaFreniere
502feba76d Hide suggest widget on cell execution (#16895) 
* Hide suggest widget on cell execution

* Also hide for query editor

* Fix compile issue with tests
 2021-09-01 16:27:08 -07:00
Charles Gagnon
45e251c0d6 Add test (#16953) 2021-08-31 15:58:19 -07:00
Daniel Grajeda
e02ae0865a Notebook Views Insert Cells Modal (#16836) 
* Add html-to-image package

* Add image card type
 2021-08-31 13:11:21 -07:00
Cory Rivera
0082031f97 Replace deprecated assert functions in test files. (#16945) 2021-08-31 09:04:17 -07:00
Cory Rivera
cb7b7da0a4 Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) 2021-08-25 16:28:29 -07:00
Charles Gagnon
fe1f8fb2f3 Add setting for enabling using new markdown renderer (#16864) 
* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false
 2021-08-25 12:43:32 -07:00
Daniel Grajeda
ed280cb003 Add html-to-image library (#16845) 
For use by the Notebook Views insert cells modal
 2021-08-20 17:18:23 -07:00
Daniel Grajeda
640c6f30f4 Notebook views UI 2 (#15865) 
Provide access to the Notebook Views UI. Feature is hidden behind a feature flag.

Co-authored-by: rkselfhost <rkselfhost@outlook.com>
 2021-08-17 14:15:28 -07:00
Charles Gagnon
82576e54a4 Add more marked.js tests (#16800) 2021-08-17 14:02:18 -07:00
Daniel Grajeda
10ee4f2d7c Notebook Views Actions fix for ADS Web (#16707) 2021-08-11 13:19:02 -07:00
Charles Gagnon
d189805bcc Add marked.js parse differences tests (#16554) 
* Add marked.js parse differences tests

* cleanup
 2021-08-04 09:07:24 -07:00
Daniel Grajeda
0567141bc4 Notebook Views Actions (#16207) 
This adds the actions currently needed by the views
 2021-08-03 22:52:27 -07:00
Daniel Grajeda
e2dd257fa9 Add Notebook Views dropdown (#16228) 
This adds the entry point to NVs. It is currently hidden behind a feature flag, which can be enabled in the settings.
 2021-08-03 21:15:11 -07:00
Vasu Bhog
179678b495 Refactor Notebook Link Handling (#16473) 
* add keep absolute paths instead convert setting

* update tests/config

* refactor links in NotebookLinkHandler
 2021-07-30 19:20:38 -07:00
Cory Rivera
63a65f5821 Remove quotes from inserted markdown links (#16457) 2021-07-27 16:40:20 -07:00
Vasu Bhog
151522013f Notebook Markdown email rendering fix (#16417) 
* fix email WYSIWYG rendering
 2021-07-23 15:24:34 -07:00
Vasu Bhog
63e97caa94 Fix Windows WYSIWYG linking issue (switching to splitview and resolving links in WYSIWYG) (#16133) 
* fix relative links not correctly formatted due to marked js

* logic in one place
 2021-07-16 13:27:45 -07:00
Cory Rivera
d92c1d5ca8 Add max size setting for Rich Text undo history in notebooks. (#15793) 2021-06-18 16:04:45 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681) 
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
 2021-06-17 08:17:11 -07:00
Cory Rivera
a61462a2c0 Improve Undo and Redo functionality for notebook Rich Text editors (#15627) 2021-06-08 13:24:58 -07:00
Maddy
d04451985c Highlight all matches in Notebook on Find (#15562) 
* iterate over every cell and highlight ranges.

* fix yellow for all matches and orange for current

* fix

* avoid duplicate deltaDecorations call

* initialize on declare
 2021-06-04 15:45:51 -07:00
Maddy
b490d53284 Add image as attachment on copy/paste into cell (#15602) 
* add pasted image as attachment

* handle duplicate image logic

* replace with regex

* address PR comments
 2021-06-04 15:20:18 -07:00
Vasu Bhog
1de05a2339 Fix WYWIWYG Table cell adding new line in table cell (#15594) 
* fixes new line in table cell

* add test and fix for table head
 2021-05-28 13:47:50 -07:00
Vasu Bhog
730367494b Run with Parameters learn more link to use correct format and kernels (#15547) 
* indicate to users correct format and kernels

* add test for unsupported kernel

* replace with enum
 2021-05-25 17:39:19 -07:00
Charles Gagnon
399406b732 Update action run return type (#15568) 
* Update action run return type

* fix tests

* Update rest

* Add back null checks
 2021-05-25 14:52:39 -07:00
Chris LaFreniere
624c07947c Notebooks: Fix Table Generation into Pure Markdown When No thead Exists (#15423) 
* works without alignment

* Alignment working

* Add comment

* Remove outdated comment
 2021-05-12 16:28:23 -07:00
Vasu Bhog
cb06ca07c0 Fixes the empty parameter cell and multi parameters on one line (#15234) 
* fix two bugs

* work on empty parameter cell and format properly

* add empty cell tests
 2021-05-06 14:48:38 -07:00
Maddy
bd5b9b36c6 add tests for cell attachment changes (#15325) 2021-05-04 14:53:04 -07:00
Maddy
ef8b26b7ae Insert local/online images using image call out (#15238) 
* changes from Chris's branch and cell model updates

* get base64 value

* handle spaces in image names

* add comments

* add tests for imageCallOut dialog

* format document for hygiene errors

* address comments

* check base64 validity using regex

* replace space with regex

* add parameter and return type

* split into two functions

* move functions to fileUtilities

* correct import

* fix for layering issue

* revert file function changes
 2021-04-30 19:43:55 -07:00
Karl Burtram
867a963882 Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8 (#14883) 
* Merge from vscode bead496a613e475819f89f08e9e882b841bc1fe8

* Bump distro

* Upgrade GCC to 4.9 due to yarn install errors

* Update build image

* Fix bootstrap base url

* Bump distro

* Fix build errors

* Update source map file

* Disable checkbox for blocking migration issues (#15131)

* disable checkbox for blocking issues

* wip

* disable checkbox fixes

* fix strings

* Remove duplicate tsec command

* Default to off for tab color if settings not present

* re-skip failing tests

* Fix mocha error

* Bump sqlite version & fix notebooks search view

* Turn off esbuild warnings

* Update esbuild log level

* Fix overflowactionbar tests

* Fix ts-ignore in dropdown tests

* cleanup/fixes

* Fix hygiene

* Bundle in entire zone.js module

* Remove extra constructor param

* bump distro for web compile break

* bump distro for web compile break v2

* Undo log level change

* New distro

* Fix integration test scripts

* remove the "no yarn.lock changes" workflow

* fix scripts v2

* Update unit test scripts

* Ensure ads-kerberos2 updates in .vscodeignore

* Try fix unit tests

* Upload crash reports

* remove nogpu

* always upload crashes

* Use bash script

* Consolidate data/ext dir names

* Create in tmp directory

Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-04-27 14:01:59 -07:00
Maddy
fcaaf1cb29 fix the find highlight issues (#15149) 
* register mode changes, remove cleanMarkdownLinks

* fixes

* test fixes and scroll to center change
 2021-04-22 10:13:30 -07:00
Maddy
bec1916c62 show notebook as trusted when it belongs to a trusted book (#15093) 
* check for trusted books

* don't add to trustedNotebooksMomento

* update comment

* added comments

* remove empty line
 2021-04-15 10:30:51 -07:00
Vasu Bhog
3a1885491f Update run w/parameters icon and increment parameterized notebook (#15127) 
* update icon and increment parameterized notebook
 2021-04-14 15:28:27 -07:00
Vasu Bhog
d76a6698a9 [Notebook] Run Parameters Action openNotebook Functionality in Core (#14978) 
* NotebookService update

* openNotebook functionality in NbService

* Add tests for RunParametersAction
 2021-04-08 14:48:37 -07:00
Barbara Valdez
4f67f32262 fix anchor links in wysiwyg (#14950) 
* fix anchor links in wysiwyg
 2021-04-08 10:56:11 -07:00
Vasu Bhog
04af3e161a See and Edit Selected Links in Callout Dialog (#14987) 
* Add URL label to linkCallout

* add test for file link
 2021-04-06 11:51:53 -07:00
Maddy
43db30d1da Add more Notebook telemetry events (#14755) 
* initial checkin

* telemetry for search in notebooks

* telemetry for move notebook

* address comments

* feedback changes

* fix tests paasing NullAdsTelemetryService

* move changeKernel telemetry higher up

* remove telemetry service

* Fix new Notebook events (#14982)

* Notebook telemetry fixes

* update2

* Move event location

* remove service

* remove unused

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2021-04-05 16:08:39 -07:00
Vasu Bhog
0a7719b475 [Notebook] Run Parameters Action UI Component (#14889) 
* Run Parameters Action UI Component

* Update UX discussion - accept empty string
 2021-04-05 13:59:27 -07:00
Lucy Zhang
f59e9b5695 Notebooks: Use new Python installation after configuration change (#14765) 
* start new jupyter server

* restart session working (removed extra code)

* only restart server once

* shutdown session first then stop server

* add comments remove extra lines

* add comment

* fix test

* only restart jupyter sessions

* Dispose jupytersessionmanager and create new one

* move restart server logic out of notebookmodel

* move methods to azdata proposed

* pr comment
 2021-03-24 15:31:20 -07:00
Lucy Zhang
780ca84f9a Enable status bar for notebooks (#14817) 
* enable status bar for notebooks

* add onCellExecutionStart event to notebook service

* fix test, change var name
 2021-03-22 14:54:13 -07:00
Hale Rankin
972b649beb Connection error box style fix (#14469) 
* Modified modal styles, limiting height of basic modal to 480px.

* wip - added new attachCalloutDialogStyler. Moved callout-specific styler code out of modal.ts

* Moved attach styler code to workbench/common. Added custom styles to imageCalloutDialog

* Moved styler code into calloutDialog. Added callout-specific theme colors to colorRegistry. Removed color styles from modal and callout stylesheets.

* Added CalloutDialogModal that extends CalloutDialog so that the callout can be instantiated from core. Revised calloutDialog so the position cn be passed in from where it is instantiated.

* Revised refactor of modal and image/link callouts so that callout dialog invoked by core can also use the styler. Removed unused properties from dialog code.

* Added conditional to dialogModal to use correct styler for callouts.

* Cleaned up styles. Modified custom colors.

* Wrapped call to positionCalloutDialog in conditional.

* Style, colors, styler and modal updates to align callout with latest OPAC toolkit styles.

* Moved calloutDialog stylesheet

* Consolidated styler code and added a flexible custom styler to provide values for dialogModal

* Added image callout code.

* Remove image callout dialog until wired fully

* Test fixes

Co-authored-by: chlafreniere <hichise@gmail.com>
 2021-03-05 17:34:02 -08:00
Lucy Zhang
f125b9b2c7 Notebooks: Fix callout dialog being cut off at the bottom of the document (#14579) 
* add above position for callout dialog

* use if else
 2021-03-05 15:23:44 -08:00
Chris LaFreniere
69a35b38b2 Callout Dialog Fixes + WYSIWYG Improvements for Insert Link (#14494) 
* wip

* Works in all edit modes

* Default value set

* wip

* preventdefault

* cleanup, add tests

* markup -> markdown

* Ensure selection is persisted for WYSIWYG

* Add simple dialog tests and some PR feedback

* floating promise

* PR comments, formatted markdown refactor

* Change escaping logic + PR comments

* PR feedback
 2021-03-04 12:51:13 -08:00
Vasu Bhog
0141db80bc [Notebook] Open Kernel Alias (Kusto) notebook with Kernel Alias (Kusto) as selected kernel (#14504) 
* Open kernel alias notebook with kernel alias as selected kernel

* Add language info test

* fix test

Co-authored-by: Vasu Bhog <bhogvu@mail.uc.edu>
 2021-03-04 12:36:25 -08:00
Chris LaFreniere
8c04266ff4 Notebooks: Persist Chart Data when Re-Executing Cell (#14512) 
* empty chart

* Update chart data appropriately

* Adding tests

* wip, cleanup

* PR feedback
 2021-03-03 22:40:11 -08:00
Chris LaFreniere
56dcd4ba50 Only serialize attachments in JSON if exists (#14516) 2021-03-03 09:06:16 -08:00