Commit Graph

55 Commits

Author SHA1 Message Date
Alan Ren
54c2fe6899 remove duplicate code (#20664)
* remove dupe code

* fix step name

* fix errors

* comment out arc

* fix timeout issue

* fix typo

* update name
2022-09-26 17:48:59 -07:00
Candice Ye
83698a14b0 Fixed color contrast for error message in connect a dc window. (#18411)
* Fixed color contrast for error message in connect a dc window.

* Remove color check for error message

* Remove more unneeded checks

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-02-16 21:06:51 -08:00
Charles Gagnon
8e1e9a95c3 Move to MS vscodetestcover and update lodash (#18192) 2022-02-01 14:09:10 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Candice Ye
0ec2974aa4 Enabled SQL MIAA deployment in direct mode (#17874)
* Added customlocation, location, resource group, and connection mode to controllerinfo. Updated SQL MIAA create notebook with direct mode params.

* Removed annotations from metadata in postgres test file.

* Only parse the customlocation if the connection mode is direct.

Co-authored-by: Candice Ye <canye@microsoft.com>
2021-12-09 12:14:31 -08:00
Candice Ye
914fe8fc29 Replacing all azdata with az (#16502)
* Changed azdata to az in azcli extension and resource-deployment, and some arc. Removed user, pass, url from controller connect blade. Commented out tests. Ported over work from old branch.

* Changed unit tests, all unit tests passing. Changed parameters to new ones, fixed some Controller Connect issues.

* Connect data controller and create dc working.

* Changed az back to azdata in necessary places in resource-deployment.

* Changed notebook values and added namespace to some params.

* Added some changes from PR to this branch

* Changed azdata.ts to az.ts and changed subscription parameter

* Brought over changes from azcli PR into this branch.

* added endpoint, username, password to getIsPassword

* Changed notebooks to use proper az params, hard coded in some values to verify it is working, removed some variableNames from package.json.

* Changed -sc to --storage-class in notebook

* Added namespace to SQL deploy, deleted dc create in api

* Deleted more dc create code and uncommented findAz() with unfinished work on Do Not Ask Again.

* Removed (preview) from extensions/arc and extensions/azcli excluding preview:true in package.json

* Commented out install/update prompts until DoNotAskAgain is implemented

* Fixed bugs: JSON Output errors are now being caught, --infrastructure now has a required UI component with dropdown options, config page loads properly, SQL create flags use full names instead of shortnames.

* Adds validation to pg extensions and bug fixes (#16486)

* Extensions

* Server parameters

* Change locaiton of postgres extensions, pr fixes

* Change location of list

* List spacing

* Commented out Don't Ask Again prompt implementation.

* Uncommented header of a test file.

* Added Azure CLI arcdata extension to Prerequisites

* Reverted package.json and yarn.lock

* Took away casting of stderr and stdout in executeCommand.

* Deleted override function for initializeFields in connectControllerDialog.ts

* Removed fakeAzApi for testing and added back in (Preview)

* Removed en-us from python notebook links.

* Deleted azdata tool from tool tests in resource-deployment

* Deleted another instance of azdata in tool test

* Add back in azdata tooltype

* Remove en-us

* Replaced AzdataTool in typings

* Reverting adding azdata tool back in

* Changed Azdata to AzdataToolOld

* Added back azdata tool type

* Added AzdataToolOld to tool types

* fix test

Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-08-01 15:12:24 -07:00
Charles Gagnon
35832e83da Add required field to kube config picker (#15795) 2021-06-17 19:38:38 -07:00
Charles Gagnon
cae598d36c Correctly announce loading state for arc cluster context loading (#15747)
* Correctly announce loading state for arc cluster context loading

* localize

* Fix compile

* Fix test
2021-06-17 10:28:12 -07:00
Charles Gagnon
1231be124a Add aria-label to kube config input box (#15743) 2021-06-16 12:22:00 -07:00
nasc17
02770e21ee Edit Postgres Engine Settings Per Role (#15481)
* Enables being able to view and edit Coordinator node scheduling params (#15114)

* Trying to save per role settings

* Updated spec

* Cleaning up

* Removed unneccessary code and comments

* Added separate type for { w?: string, c?: string}, PR fixes

* Added methods to refresh mr,ml,cr,cl versus per role

* Fixed spec

* Put back optional properties, removed passing empty string to reset scheduling params

* Spacing

* vBump arc

* Included roles in fake show output for testing (#15196)

* Update arc specs (#15225)

* Update azdata Arc specs to match April azdata

* vcores -> cpu

* fix spacing

* Consolidate types and update storage volumes

* Fix compile

* Fix spec

* include coordinator

* Adding args

* Query call success

* Check for success in query

* List full coordinator params

* Change name

* Update unit test for engine settings

* Pr changes

* Fix query

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2021-05-19 13:46:24 -07:00
nasc17
7a726e5dfa Fix for PG parameters table disappearing when trying to reset a value (#15303)
* Working on table bug

* Removed unit test checking for onEngineSettingsUpdated event to fire since removed from model

* Moved instanceofcheckbox function to utils, pr fixes

* Fix comment
2021-04-30 20:50:39 -07:00
Charles Gagnon
ef57812a95 Arc april updates (#15237)
* Enables being able to view and edit Coordinator node scheduling params (#15114)

* Trying to save per role settings

* Updated spec

* Cleaning up

* Removed unneccessary code and comments

* Added separate type for { w?: string, c?: string}, PR fixes

* Added methods to refresh mr,ml,cr,cl versus per role

* Fixed spec

* Put back optional properties, removed passing empty string to reset scheduling params

* Spacing

* vBump arc

* Included roles in fake show output for testing (#15196)

* Update arc specs (#15225)

* Update azdata Arc specs to match April azdata

* vcores -> cpu

* fix spacing

* Consolidate types and update storage volumes

* Fix compile

* Update min azdata version

Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: nasc17 <nasc@microsoft.com>
2021-04-26 16:20:27 -07:00
Charles Gagnon
febd8b29c9 Arc updates for March release (#14970)
* Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)

* Added spec.engine.version, took out calling engine version with edit calls

* Added text wrong place

* missed updates

* PR fix

* Update Arc Postgres troubleshooting notebook

Co-authored-by: Brian Bergeron <brberger@microsoft.com>

* Remove AzdataSession from azdata commands (#14856)

* remove session

* Add in controller-context support

* Revert "Add in controller-context support"

This reverts commit 3b39b968efbf6054041cb01cb2d8443532643a82.

* Add azdataContext to login

* Undo book change

* Undo change correctly

* Add controller context support (#14862)

* remove session

* Add in controller-context support

* Add params to fake

* Fix tests

* Add info and placeholder for controller URL/name (#14887)

* Add info and placeholder for controller URL

* add period + update name

* update memento and allow editing of namespace/URL

* vBump

* vBump

* Fix tests

Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
2021-04-05 11:47:36 -07:00
nasc17
2164bc0bb9 Unit test for Postgres Connections Strings Page (#14905)
* Start writing test (2)

* How read property pairs

* Connection strings check

* Delete folder

* PR fixes
2021-03-31 13:21:44 -07:00
Charles Gagnon
72295d46c2 Add close method to ModelView dashboards (#14812)
* Add close method to ModelView dashboards

* fix closing

* remove accessors

* Update errors
2021-03-22 10:17:16 -07:00
Brian Bergeron
ce39b4bd19 Arc - Unit tests for deleting Postgres (#14502)
* tests for deleting postgres from overview page

* upgrade to azdata-test 1.5.0

* Fix api stubbing

Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2021-03-19 13:12:26 -07:00
Charles Gagnon
a0a97d1611 Revert "Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)" (#14794)
This reverts commit 318559dcd7.
2021-03-18 14:19:59 -07:00
nasc17
318559dcd7 Updated Postgres Spec for where to find engine version, removed calling calling -ev in edit commands (#14735)
* Added spec.engine.version, took out calling engine version with edit calls

* Added text wrong place

* missed updates

* PR fix
2021-03-16 08:25:16 -07:00
nasc17
98828aa67d Unit test for Postgres Model (#14651)
* Figure out initial test

* First trys at refresh unit test

* refresh unit test completed

* Connection profile unit test, need to pass in false

* Engine settings start

* All passing

* Clean up

* Removed class, updated showdialog stubs, using sinon spy

* Removed comment
2021-03-12 14:02:55 -08:00
Karl Burtram
ce612a3d96 Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79 (#14050)
* Merge from vscode 2c306f762bf9c3db82dc06c7afaa56ef46d72f79

* Fix breaks

* Extension management fixes

* Fix breaks in windows bundling

* Fix/skip failing tests

* Update distro

* Add clear to nuget.config

* Add hygiene task

* Bump distro

* Fix hygiene issue

* Add build to hygiene exclusion

* Update distro

* Update hygiene

* Hygiene exclusions

* Update tsconfig

* Bump distro for server breaks

* Update build config

* Update darwin path

* Add done calls to notebook tests

* Skip failing tests

* Disable smoke tests
2021-02-09 16:15:05 -08:00
Charles Gagnon
13255f845b Update azdata-test to official Microsoft org version (#14203) 2021-02-09 08:35:47 -08:00
Charles Gagnon
f6e39a7211 Fix other fields being editable in password reprompt for Arc (#14117) 2021-01-29 16:27:20 -08:00
Charles Gagnon
04dff9cdf2 Add acquireLoginSession API for Azdata (#13985)
* wip

* fix tests

* add tests

* PR comments
2021-01-20 10:35:26 -08:00
Arvind Ranasaria
f314a9e1e6 Change azdata executions to point to kube config and cluster contexts (#13569) 2020-12-23 23:45:00 -08:00
Charles Gagnon
7f38e87ef3 Use azdata-test modelview stubs (#13818) 2020-12-16 16:28:02 -08:00
Charles Gagnon
4575f2bbe6 Fix paths for tests (#13816) 2020-12-15 16:04:36 -08:00
Arvind Ranasaria
515b0794b0 Add kube config and kube cluster to arc data controller screens (#13551) 2020-12-10 02:47:39 -08:00
Charles Gagnon
e59de59e61 Add scan suppressions (#13705) 2020-12-07 13:31:59 -08:00
nasc17
67e3d2ebdb Added engine version argument to edit command. (#13610)
* Added engine version argument to edit command. Neccessary for not using pg12

* Included for changing password in overview page

* Updated fakeazdataapi test
2020-12-03 08:46:48 -08:00
Arvind Ranasaria
8027993ab4 Make 'Script to notebook' consistent with 'Deploy' when user cancels during password re-acquisition for controller (#13557) 2020-12-01 22:57:00 -08:00
Arvind Ranasaria
d060f1b9a0 Classes for adding kube config and kube cluster picker to Controller connection dialog (#13479) 2020-11-24 20:08:27 -08:00
Charles Gagnon
6edcbbb738 Suppress scan warnings (#13507) 2020-11-20 14:28:57 -08:00
Charles Gagnon
32ac586431 Add MIAA Compute+Storage page (#13367)
* Add MIAA Compute+Storage page

* update min memory limits

* update strings

* feedback
2020-11-13 07:20:46 -08:00
Brian Bergeron
d1b8c15e11 Arc Postgres - Rename shards to workers
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
2020-10-28 16:57:17 -07:00
nasc17
39b6cc193f Nasc/compute storage db tab (#12917)
* Git problem fix

* Formatted doc

* checkbox feature works correctly

* Functional page, edits needed for visual design

* Fix git problems

* Check which input have acceptable values before running edit commands

* fix git error

* Updating constants

* Format doc

* fix git error

* Corrected Worker node count and added missing localized constant

* Updated discard button function

* Fixed constants off of review

* Rework service updating and discard. Renaming of functions and variables. Rework box intialization

* Fix git error, redo UserInputSection

* Cleaning up

* Added unit tests for GiB conversion funtion

* Cleaned up edit vcores and memory input boxes

* Removed unused constants, added throw error to gib conversion function

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2020-10-16 14:40:55 -07:00
Charles Gagnon
288288df03 Add arc tree data provider tests (#12758)
* Add arc tree data provider tests

* Generic ResourceModel

* no message

* undo

* Fix compile error
2020-10-06 11:26:56 -07:00
Charles Gagnon
78de48391d Update deletion strings to refer to instances instead of resources (#12332)
* Update deletion strings to refer to instances instead of resources

* one more

* Remove unused

* More
2020-09-16 07:48:46 -07:00
Brian Bergeron
f79ff99d0b new postgres model (#12305)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
2020-09-15 14:52:04 -07:00
Arvind Ranasaria
c5d0c6f623 defining arc api (#12153)
* defining arcApi

* pr feedback

* activate arc extension in test

* skip failing test temporarily

* remove arcService test file
2020-09-05 10:09:15 -07:00
Charles Gagnon
47c1204e89 Fix arc node info updating (#12007)
* Fix arc node info updating

* Missed await
2020-08-28 15:53:17 -07:00
Charles Gagnon
8b52e7200c Add arc controllerModel tests (#11947)
* Add arc controllerModel tests

* Fix compile
2020-08-25 13:18:35 -07:00
Charles Gagnon
969932743a Add external miaa endpoint property (#11940) 2020-08-24 18:07:25 -07:00
Charles Gagnon
a6efd56844 Add Arc MIAA delete action back (#11901)
* Add Arc MIAA delete action back

* fix
2020-08-21 14:10:29 -07:00
Charles Gagnon
b2a1738836 Remove REST API from Arc extension (#11888)
* wip

* Remove old API

* Fix tests
2020-08-20 15:56:46 -07:00
Arvind Ranasaria
2b0b529b21 Add controller display name (#11675)
* Add controller display name

* pr feedback

* revert unneeded change

* pr feedback
2020-08-07 16:47:10 -07:00
Charles Gagnon
188cfdbd20 Update Arc extension version and fix Controller connectivity status names (#11498)
* Update connectivity mode names

(cherry picked from commit f0aabcfa86d178cdf74470f9fdeded19718bcea2)

* Bump package version

(cherry picked from commit e08370539006c638d6e25c2f4f23fa2754a3377d)
2020-07-23 16:37:48 -07:00
Charles Gagnon
0f2b463536 Add ConnectControllerDialog tests (#11443)
* Automatically fix up arc controller URL

* wip

* Force tests to pass

* Refactor

* comment
2020-07-21 17:15:13 -07:00
Charles Gagnon
a1f600657a Add more arc tests (#11145)
* Add more arc tests

* Update comment
2020-06-30 14:05:27 -07:00
Charles Gagnon
c62394262a Some cleanup and fixes for Arc/BDC dashboards (#11075) 2020-06-24 12:41:33 -07:00
Charles Gagnon
ca4ab55380 Add more arc tests (#11051)
* Add more arc tests

* fix errors
2020-06-24 08:33:16 -07:00