Commit Graph

226 Commits

Author SHA1 Message Date
Chris LaFreniere
171f091c88 Fix no books currently selected error in viewlet (#11269)
* Fix no books currently selected error

* check sections undefined vs length
2020-07-09 23:14:46 -07:00
Maddy
9c0f415bd9 Feat/search in books (#11117)
* clean up unsavedBooks to providedBooks

* added notebooks viewley contribution

* added notebookExporerAction context

* temp shortcut key B

* remove commenred code

* changes with master merge

* fix comments

* initial tests

* fix casing and description

* merged master and resolved errors

* initial commit

* search view changes

* remove extension point & add custom view container

* merge latest from master

* remove unused files

* move book images to common

* remove notebookExplorer contrib & move to notebook

* build fix

* remove explorer specific sryles from common

* vscode convention to define container actions

* rename notebooks/title

* show collapsible search view separately

* style changes

* rename method

* code cleanup

* enable search on type

* merged master and resolved compile errors

* highlight fix

* code cleanup

* rename interface

* fix hygiene floating promises errors

* more hygiene errors

* avoid circular dependency

* new ids for notebookSearch actions

* reuse SearchSortOrder from search

* merged main and resolved compile errors

* reuse search code

* vscode merge regression on highlight

* extend searchView

* missed resoved files

* null to undefined

* make treeView readonly

* revert carbon edit

* address PR comments

* convert async
2020-07-09 13:13:36 -07:00
Charles Gagnon
2a7483c036 Fix error when calling getParent (#11252) 2020-07-08 14:23:52 -07:00
Charles Gagnon
b3a01fcf77 Remove ApiWrapper from notebook extension (#11224)
* Remove ApiWrapper in notebook extension

* delete file

* Remove copyrights
2020-07-08 11:06:32 -07:00
Chris LaFreniere
5f8180ebbf Add Notebook Completion Item Provider Unit Tests (#11222)
* completion item provider tests

* Add nb completionItemProvider tests
2020-07-07 12:48:22 -07:00
Cory Rivera
f409abfc01 Disable python downloads when running notebooks on a SAW. (#11186) 2020-07-07 11:32:05 -07:00
Chris LaFreniere
a8a7559229 Add more notebook extension tests (#11143)
* more tests

* More tests

* More tests

* Add prompt tests
2020-06-30 11:01:51 -07:00
Maddy
561b881200 Fix/highlight correct item (#11016)
* get children of unexpanded books

* highlight item inside collapsed parent in treeView

* fix path issue on windows

* refactor common code into separate func

* refactor
2020-06-24 13:44:50 -07:00
Chris LaFreniere
7080e3ec4e Notebooks: Add Some Jupyter Controller Tests (#11053)
* First jupyter controller tests

* PR comments

* remove unnecessary checks for throw

* fix comment typo
2020-06-23 23:08:25 -07:00
ADS Merger
5e7071e466 Merge from vscode 4d91d96e5e121b38d33508cdef17868bab255eae 2020-06-19 10:59:23 -07:00
Chris LaFreniere
eaf753f79e Remove unused prompt code (#10996) 2020-06-18 17:23:32 -07:00
Chris LaFreniere
77ba5a36aa Add Jupyter Notebook Manager Tests (#10955)
* jupyter notebook manager tests

* cover config duplicate integrationTest
2020-06-17 14:42:35 -07:00
Charles Gagnon
94bc0d9559 Fix open notebook bug (#10930)
* Fix open notebook bug

* cleanup

* clean up spaces
2020-06-16 13:06:44 -07:00
Maddy
26a00696d4 Fix/prev next links issue (#10523)
* intital test code

* added tests

* remove commented code

* fix for failing tests

* reuse exported enum

* changes to address comments

* add back onVisibility highlight

* port highlight fix from Chris

* fix tests
2020-06-12 18:42:17 -07:00
Chris LaFreniere
960aa14027 stop running magics that dont exist (#10894) 2020-06-12 14:25:01 -07:00
Chris LaFreniere
168ef80d8f Fix Notebook Viewlet Highlighting (#10868)
* Stop double tree data provider registrations

* revert book finding logic, leverage currentBook
2020-06-10 22:27:16 -07:00
Charles Gagnon
dff43687e2 Clean up coverage and fix issue with notebook names (#10826)
* Clean up coverage and fix issue with notebook names

* update name
2020-06-10 13:44:38 -07:00
Maddy
22d7c9083e highlight correct notebook on navigation. (#10807)
* highlight correct notebook on navigation.

* add back behavior of highight on viewlet visible

* optimize bookViewer create

* createTreeView for every book
2020-06-08 19:09:43 -07:00
Cory Rivera
5d60254bb9 Add custom width to Python wizard to reduce wasted space. (#10705)
* Also use double quotes for localize calls in the wizard.
2020-06-03 14:41:39 -07:00
Charles Gagnon
4d6ec69eba Fetch password from credential store before connecting to knox endpoint (#10666)
* Fetch password from credential store before connecting to knox endpoint

* Add combined code coverage script

* Revert "Add combined code coverage script"

This reverts commit e538f2fb2a79993a77f749f384fbc306b18b9f64.
2020-06-02 13:27:37 -07:00
Maddy
3088c73e2b Feat/notebooks viewlet (#10170)
* clean up unsavedBooks to providedBooks

* added notebooks viewley contribution

* added notebookExporerAction context

* temp shortcut key B

* remove commenred code

* changes with master merge

* fix comments

* initial tests

* fix casing and description

* merged master and resolved errors

* remove extension point & add custom view container

* merge latest from master

* remove unused files

* move book images to common

* remove notebookExplorer contrib & move to notebook

* build fix

* remove explorer specific sryles from common

* vscode convention to define container actions

* rename notebooks/title
2020-06-01 15:47:56 -07:00
Cory Rivera
98ce3c74e6 Hide installation options in Configure Python wizard if python is already setup. (#10635) 2020-05-29 17:28:02 -07:00
Leila Lali
5955953b4a ML - displaying all Python and R packages (including system ones) (#10603)
* displaying all packages including readonly
2020-05-29 13:52:37 -07:00
Charles Gagnon
f568ff82d8 Fix HDFS support for CU5+ BDC instances (#10577)
* Fix HDFS node auth for non-root username

* more changes
2020-05-27 10:17:28 -07:00
Charles Gagnon
7496d09eb9 Add and fix Notebook tests (#10488)
* Add and fix Notebook tests

* Fix name

* Fix compile

* Acutally fix error

* Add Notebook title test and fix command

* Add extra check and add comments

* Remove extra show error message
2020-05-26 17:27:43 -07:00
Charles Gagnon
14554f0d11 Fix some issues with book tree view (#10521) 2020-05-20 11:54:25 -07:00
Maddy
e46521cafc open viewlet on showPreview (#10474)
* open viewlet on shoePreview

* on showPreview reveal explorer
2020-05-18 13:46:55 -07:00
Cory Rivera
d3e1675fc5 Only check if python is running before trying to overwrite an existing installation. (#10383) 2020-05-14 11:37:06 -07:00
Cory Rivera
fc548be2c1 Uncheck unselected radio buttons in Configure Python wizard. (#10344) 2020-05-12 13:02:35 -07:00
Maddy
f6e7b56946 opening as text document launches json (#10323) 2020-05-08 23:28:28 -07:00
Cory Rivera
f94a9d0d58 Update Configure Python dialog to allow packages to be installed for specific kernels. (#10286) 2020-05-08 16:02:59 -07:00
Chris LaFreniere
0fbc3d1cb6 Get rid of red herrings (#10309) 2020-05-08 14:49:49 -07:00
Charles Gagnon
6e5fc9c495 Add ModelView method SetItemLayout (#10306)
* Add ModelView method SetItemLayout

* Remove extra line break
2020-05-08 08:38:36 -07:00
ADS Merger
fa62ec1f34 Merge from vscode 7653d836944892f83ce9e1f95c1204bafa1aec31 2020-05-08 03:58:34 +00:00
Leila Lali
a7c4a259ad Fixed an issue with setting the default location in package management (#10263) 2020-05-04 17:00:51 -07:00
Cory Rivera
d7a425239b Only reveal items in the books viewlet if the viewlet is visible. (#10234) 2020-04-30 20:10:27 -07:00
Chris LaFreniere
0a3a0ec80f Notebooks: Support User-Installed Kernels (#10194)
* Fixes for attach to. Still need to update cache

* Don't have jupyter hardcoded

* Handle DOTNET_ROOT env var

* Fix on load

* Put behind feature flag

* Cleanup

* Error check

* PR feedback
2020-04-29 10:34:27 -07:00
Chris LaFreniere
5b57b13005 Update python Mac install url (#10200) 2020-04-29 10:29:52 -07:00
Charles Gagnon
586c28bf79 Add and fix notebook extension unit tests (#10156) 2020-04-24 22:05:36 -07:00
ADS Merger
7f1d8fc32f Merge from vscode 2e5312cd61ff99c570299ecc122c52584265eda2 2020-04-24 14:03:37 -07:00
Charles Gagnon
8311c3985d Add PropertiesContainer ModelView component (#10115)
* Add PropertiesContainer ModelView component

* Switch to component

* Remove unneeded interface

* Update names

* Fix names
2020-04-22 16:29:46 -07:00
Cory Rivera
097289d94c Check treeItem first when building search path in searchJupyterBooks. (#10083) 2020-04-20 15:30:52 -07:00
Cory Rivera
67b6f6ffcd Add tests for Open Notebook Folder functionality. (#10056) 2020-04-17 16:27:00 -07:00
Cory Rivera
2817316cf4 Check conda-forge channel first when installing conda packages. (#10035) 2020-04-16 16:58:32 -07:00
Maddy
a58d4d7d05 replaced watch with watchFile (#9873)
* replaced watch with watchFile

* testing debounce

* changed the beounce delay to 1500
2020-04-15 10:03:48 -07:00
Maddy
c728f23893 some more tests (#9933)
* some more tests

* changes to address comments
2020-04-14 22:33:23 -07:00
Cory Rivera
2b2a275fb0 Add Open Notebook Folder functionality to Books viewlet. (#9939) 2020-04-13 23:42:02 -07:00
Maddy
6bc123d76b Fix/open book spcl characters (#9888)
* upgrade fast-glob that escapes them.

* added tests

* added test with brackets in bookPath
2020-04-07 15:55:53 -07:00
Monica Gupta
63006e6e63 Undo default kqlmagic install (#9871)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-04-07 10:20:37 -07:00
Maddy
4c01482a8f fixes to the toc formatting (#9825)
* fixes to the toc formatting

* addressed comments
2020-04-06 15:30:08 -07:00