* log when an editor action doesn't run because of enablement
* notebooks create/dispose editors. this means controllers must be created eagerly (😢) and that notebooks need a custom way of plugging comparision keys for session. works unless creating another session for the same cell of a duplicated editor
* Set offSide to sql lang configuration to true (#183461)
* Fixes#181764 (#183550)
* fix typo
* Always scroll down and focus the input (#183557)
* Fixes#180386 (#183561)
* cli: ensure ordering of rpc server messages (#183558)
* cli: ensure ordering of rpc server messages
Sending lots of messages to a stream would block them around the async
tokio mutex, which is "fair" so doesn't preserve ordering. Instead, use
the write_loop approach I introduced to the server_multiplexer for the
same reason some time ago.
* fix clippy
* update for May endgame
* testing: allow invalidateTestResults to take an array (#183569)
* Document `ShareProvider` API proposal (#183568)
* Document `ShareProvider` API proposal
* Remove mention of VS Code from JSDoc
* Add support for rendering svg and md in welcome message (#183580)
* Remove toggle setting more eagerly (#183584)
* rm message abt macOS
* Change text (#183589)
* Change text
* Accidentally changed the wrong file
* cli: improve output for code tunnel status (#183571)
* testing: allow invalidateTestResults to take an array
* cli: improve output for code tunnel status
Fixes#183570
* [json/css/html] update services (#183595)
* Add experimental setting to enable this dialog
* Fix exporting chat model to JSON before it is initialized (#183597)
* minimum scrolling to reveal the next cell on shift+enter (#183600)
do minimum scrolling to reveal the next cell on Execute cell and select next
* Fixing Jupyter notebook issue 13263 (#183527)
fix for the issue, still need to understand why there is strange focusing
* Tweak proposed API JSDoc (#183590)
* Tweak proposed API JSDoc
* workbench -> workspace
* fix ? operator
* Use active editor and show progress when sharing (#183603)
Use active editor and show progress
* use scroll setting variable correctly
* Schedule welcome widget to show once between typing. (#183606)
* Schedule dialog to show once between typing
* Don't re-render if already displayed once
* Add F10 keybinding for debugger step, even on Web. (#183510)
Fixes#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
* Also pass process.env
* Restore missing chat clear commands (#183651)
* chore: update electron@22.5.4 (#183716)
* Show remote indicator in web when remoteAuthority is set (#183728)
* feat: .vuerc as json file (#153017)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Delete --compatibility=1.63 code from the server (#183738)
* Copy vscode.dev link to tunnel generates an invalid link when an untitled workspace is open (#183739)
* Recent devcontainer display string corrupted on Get Started page (#183740)
* Improve "next codeblock" navigation (#183744)
* Improve "next codeblock" navigation
Operate on the current focused response, or the last one, and scroll to the selected item
* Normalize command title
* Git - run git status if similarityThreshold changes (#183762)
* fix aria-label issue in kb editor
fixes A11y_GradeB_VSCode_Keyboard shortcut reads words together - Blind: Arrow key navigation to row Find the binding keys and "when" cell data are read together resulting in a word " CTRL + FeditorFocus instead of CTRL + F editorFocus" #182490
* Status - fix compact padding (#183768)
* Remove angle brackets from VB brackets (#183782)
Fixes#183359
* Update language config schema with more details about brackets. (#183779)
* fix comment (#183812)
* Support for `Notebook` CodeAction Kind (#183457)
* nb kind support -- wip
* allow notebook codeactions around single cell edit check
* move notebook code action type out of editor
---------
Co-authored-by: rebornix <penn.lv@gmail.com>
* cli: fix connection default being applied (#183827)
* cli: bump to openssl 1.1.1u (#183828)
* Implement "delete" action for chat history (#183609)
* Use desired file name when generating new md pasted file paths (#183861)
Fixes#183851
* Default to filename for markdown new file if empty (#183864)
Fixes#183848
* Fix small typo (#183865)
Fixes#183819
* Noop when moving a symbol into the file it is already in (#183866)
Fixes#183793
* Adjust codeAction validation to account for notebook kind (#183859)
* Make JS/TS `go to configuration` commands work on non-`file:` file systems (#183688)
Make `go to project` commands work on non-`file:` file systems
Fixes#183685
* Can't do regex search after opening notebook (#183884)
Fixes#183858
* Default to current dir for `move to file` select (#183875)
Fixes#183870
`showOpenDialog` seems to ignore `defaultUri` if the file doesn't exist
* Use `<...>` style markdown links when needed (#183876)
Fixes#183849
* Remove check for context keys
* Update xterm package
* Enable updating a chat model without triggering incremental typing (#183894)
* Enable chat "move" commands on empty sessions (#183895)
* Enable chat "move" commands on empty sessions
and also imported sessions
* Fix command name
* Fix some chat keybindings on windows (#183896)
* "Revert File" on inactive editors are ignored (fix#177557) (#183903)
* Empty reason while switching profile (fix#183775) (#183904)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4278 (#183910)
* fix https://github.com/microsoft/vscode/issues/183770 (#183914)
* code --status displays a lot of errors before actual status output (fix#183787) (#183915)
* joh/icy manatee (#183917)
* Use idle value for widget of interactive editor controller
https://github.com/microsoft/vscode/issues/183820
* also make preview editors idle values
https://github.com/microsoft/vscode/issues/183820
* Fix#183777 (#183929)
* Fix#182309 (#183925)
* Tree checkbox item -> items (#183931)
Fixes#183826
* Fixes#183909 (#183940)
* Fix#183837 (#183943)
fix#183837
* Git - fix#183941 (#183944)
* Update xterm.css
Fixes#181242
* chore: add @ulugbekna and @aiday-mar to my-endgame notebook (#183946)
* Revert "When snippet mode is active, make `Tab` not accept suggestion but advance placeholder"
This reverts commit 50a80cdb61511343996ff1d41d0b676c3d329f48.
* revert not focusing completion list when quick suggest happens during snippet
* change `snippetsPreventQuickSuggestions` default to false
* Fix#181446 (#183956)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4298 (#183957)
* fix: remove extraneous incorrect context keys (#183959)
These were actually getting added in getTestItemContextOverlay, and the test ID was using the extended ID which extensions do not know about.
Fixes#183612
* Fixes https://github.com/microsoft/monaco-editor/issues/3920 (#183960)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4324 (#183961)
* fix#183030
* fix#180826 (#183962)
* make message more generic for interactive editor help
* .
* fix#183968
* Keep codeblock toolbar visible when focused
* Fix when clause on "Run in terminal" command
* add important info to help menu
* fix#183970
* Set `isRefactoring` for all TS refactoring edits (#183982)
* consolidate
* Disable move to file in TS versions < 5.2 (#183992)
There are still a few key bugs with refactoring. We will ship this as a preview for TS 5.2+ instead of for 5.1
* Polish query accepting (#183995)
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280
* Allow widget to have focus (#184000)
So that selecting non-code text works.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4294
* Fix microsoft/vscode-internalbacklog#4257. Mitigate zindex for zone widgets. (#184001)
* Change welcome dialog contribution to Eventually
* Misc fixes
* Workspace folder picker entry descriptions are suboptimal for some filesystems (fix#183418) (#184018)
* cli - ignore std error unless verbose (#183787) (#184031)
* joh/inquisitive meerkat (#184034)
* only stash sessions that are none empty
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* only unstash a session once - unless new exchanges are made,
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* account for all exchange types
* Improve declared components (#184039)
* make sure to read setting (#184040)
d'oh, related to https://github.com/microsoft/vscode/issues/173387#issuecomment-1571696644
* [html] update service (#184049)
[html] update service. FIxes#181176
* reset context keys on reset/hide (#184042)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4330
* use `Lazy`, not `IdleValue` for the IE widget held by the eager controller (#184048)
https://github.com/microsoft/vscode/issues/183820
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4333 (#184067)
* use undo-loop instead of undo-edit when discarding chat session (#184063)
* use undo-loop instead of undo-edit when discarding chat session
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4118
* fix tests, wait for correct state
* Add logging to node download (#184070)
Add logging to node download. For #182951
* re-enable default zone widget revealing when showing (#184072)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4332, also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3784
* fix#178202
* Allow APIs in stable (#184062)
* Fixmicrosoft/vscode-internalbacklog#4206. Override List view whitespace css for monaco editor (#184087)
* Fix JSDoc grammatical error (#184090)
* Pick up TS 5.1.3 (#184091)
Fixes#182931
* Misc fixes
* update distro (#184097)
* chore: update electron@22.5.5 (#184116)
* Extension host veto is registered multiple times on restart (fix#183778) (#184127)
Extension host veto is registered multiple times on restart (#183778)
* Do not auto start the local web worker extension host (#184137)
* Allow embedders to intercept trustedTypes.createPolicy calls (#184136)
Allow embedders to intercept trustedTypes.createPolicy calls (#184100)
* fix: reading from console output for --status on windows and linux (#184138)
fix: reading from console output for --status on windows and linux (#184118)
* Misc fixes
* code --status displays a lot of errors before actual status output (fix#183787) (#184200)
fix 183787
* (cherry-pick to 1.79 from main) Handle galleryExtension failure in featuredExtensionService (#184205)
Handle galleryExtension failure in featuredExtensionService (#184198)
Handle galleryExtension failure
* Fix#184183. Multiple output height updates are skipped. (#184188)
* Post merge init fixes
* Misc build issues
* disable toggle inline diff of `alt` down
https://github.com/microsoft/vscode-internalbacklog/issues/4342
* Take into account already activated extensions when computing running locations (#184303)
Take into account already activated extensions when computing running locations (fixes#184180)
* Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (#184310)
Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (fixes#182217)
* WIP
* rm fish auto injection
* More breaks
* Fix Port Attributes constructor (#184412)
* WIP
* WIP
* Allow extensions to get at the exports of other extensions during resolving (#184487)
Allow extensions to get at the exports of other extensions during resolving (fixes#184472)
* do not auto finish session when inline chat widgets have focus
re https://github.com/microsoft/vscode-internalbacklog/issues/4354
* fix compile errors caused by new base method
* WIP
* WIP
* WIP
* WIP
* Build errors
* unc - fix path traversal bypass
* Bump version
* cherry-pick prod changes from main
* Disable sandbox
* Build break from merge
* bump version
* Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
* Git - only add --find-renames if the value is not the default one (#185053)
Git - only add --find-renames if the value is not the default one (#184992)
* Cherry-pick: Revert changes to render featured extensions when available (#184747)
Revert changes to render featured extensions when available. (#184573)
* Lower timeouts for experimentation and gallery service
* Revert changes to render extensions when available
* Add audio cues
* fix: disable app sandbox when --no-sandbox is present (#184913)
* fix: disable app sandbox when --no-sandbox is present (#184897)
* fix: loading minimist in packaged builds
* Runtime errors
* UNC allow list checks cannot be disabled in extension host (fix#184989) (#185085)
* UNC allow list checks cannot be disabled in extension host (#184989)
* Update src/vs/base/node/unc.js
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
* Add notebook extension
* Fix mangling issues
* Fix mangling issues
* npm install
* npm install
* Issues blocking bundle
* Fix build folder compile errors
* Fix windows bundle build
* Linting fixes
* Fix sqllint issues
* Update yarn.lock files
* Fix unit tests
* Fix a couple breaks from test fixes
* Bump distro
* redo the checkbox style
* Update linux build container dockerfile
* Bump build image tag
* Bump native watch dog package
* Bump node-pty
* Bump distro
* Fix documnetation error
* Update distro
* redo the button styles
* Update datasource TS
* Add missing yarn.lock files
* Windows setup fix
* Turn off extension unit tests while investigating
* color box style
* Remove appx
* Turn off test log upload
* update dropdownlist style
* fix universal app build error (#23488)
* Skip flaky bufferContext vscode test
---------
Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Julien Richard <jairbubbles@hotmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: rebornix <penn.lv@gmail.com>
Co-authored-by: Ole <oler@google.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Joao Moreno <Joao.Moreno@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* dashboard improvement - WIP (#8836)
* wip
* wip
* tabgroup
* tab group
* agent views
* clean up
* formats
* feedback
* fix error
* contribute top level server/db dashboard tab (#8868)
* tabbedPanel component (#8861)
* tabbed panel
* tabbed panel
* fix errors
* revert main.ts changes
* use margin
* address comments
* remove orientation property
* content tab group (#8878)
* add databases tab
* use more extensible approach
* remove unnecessary code
* add when expression
* objects tab for database dashboard (#8892)
* fix build errors
* fix build error
* Dashboard toolbar (#9118)
* remove old toolbar with only edit and refresh
* remove tasks widgets from server and databases dashboards
* adding toolbar to dashboardpage and clicking new query works
* restore and new notebook now do something
* add backup to toolbar for database dashboards
* new notebook connects to db
* only show backup and restore for non-azure
* new backup and restore svgs
* clean up
* got toolbar actions to show up from contribution
* some cleanup and add database dashboard toolbar contributions
* don't show all tasks when there should be no tasks
* fix toolbar showing multiple times when switching opening another dashboard from OE
* only show toolbar for home page
* update to new icons - same icons for light and dark theme
* don't show separator if there aren't any actions
* read toolbar actions from tasks-widget
* remove tasks widget from home dashboard page
* show extension's actions in toolbar
* clean up
* more cleaning up
* fix extension actions not always loading the first time
* add configure dashboard
* remove old edit icon css
* change tasks back to original order
* make sure tasks widget is the one being removed
* collapsible tab panel (#9221)
* collapsible vertical tab panel
* fix lint error
* comments batch 1
* pr comments
* update new query icon (#9351)
* Update toolbar actions (#9313)
* remove edit and configure dashboard and add refresh to toolbar for other dashboard pages too
* Add refresh for tabs that have container type with refresh implemented
* change refresh to only refresh the current tab
* remove map for tab to actions
* add back configure dashboard to home toolbar
* check if index is -1 before trying to remove tasks widget from widgets
* Move objects widget back to database home tab (#9432)
* move objects widget back to database home tab and reorder toolbar
* change order of actions back to previous order
* Allow extensions to add actions to home toolbar (#9269)
* add support for extensions to add actions to home toolbar
* fix spacing
* use menu contribution point
* undo previous changes that added dashboardToolbarHomeAction contribution
* remove home from name
* add context key for tab name
* allow actions to also be added to the toolbar of other tabs
* add extension contributed actions even if no tasks-widget
* fix refresh being added twice after merging
* hide the tab list when collapsed (#9529)
* update the order of css selectors (#9606)
* Update dashboard style to be closer to mockups (#9570)
* update style to be closer to mockups
* tab panel styling
* change back tab styling for tabs in a tab contributed by an extension
* change color of borders when theme changes
* set dark theme active tab background to same as OE for now
* update border colors
* move colors to theme file
* fix a few issues (#9690)
* couple fixes
* comments
* small dashboard toolbar fixes (#9695)
* fix backup icon in toolbar
* fix database page toolbar border color
* add back center center in common-icons.css (#9703)
* change padding so bottom border shows again (#9710)
* tab panel fixes (#9724)
* tab panel fixes
* fix package.nls.json
* feedbacks (#9761)
* feedbacks
* remove comments
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
- acounts view
- new tab view in dashboard
- many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.
Fixes#7827
* Remove unnecessary 'use strict' lines and add hygiene check for them
* Move check to under tslint filters to reduce number of filters needed
* Only take first 10 lines of file
* Merge from vscode 37cb23d3dd4f9433d56d4ba5ea3203580719a0bd
* fix issues with merges
* bump node version in azpipe
* replace license headers
* remove duplicate launch task
* fix build errors
* fix build errors
* fix tslint issues
* working through package and linux build issues
* more work
* wip
* fix packaged builds
* working through linux build errors
* wip
* wip
* wip
* fix mac and linux file limits
* iterate linux pipeline
* disable editor typing
* revert series to parallel
* remove optimize vscode from linux
* fix linting issues
* revert testing change
* add work round for new node
* readd packaging for extensions
* fix issue with angular not resolving decorator dependencies
* working on formatting
* fixed basic lint errors; starting moving things to their appropriate location
* formatting
* update tslint to match the version of vscode we have
* remove unused code
* work in progress fixing layering
* formatting
* moved connection management service to platform
* formatting
* add missing file
* moving more servies
* formatting
* moving more services
* formatting
* wip
* moving more services
* formatting
* move css file
* add missing svgs
* moved the rest of services
* formatting
* changing around some references
* formatting
* revert tslint
* revert some changes that brake things
* formatting
* fix tests
* fix testzx
* fix tests
* fix tests
* fix compile issue
