ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-22 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity
3,005 Commits 1 Branch 152 Tags
6e8cc3aaca3f47738a5bdf378d82977fb1138522
Commit Graph

151 Commits

Author SHA1 Message Date
Charles Gagnon
6e8cc3aaca Fix accessibility issues with Manage Access dialog (#8586) 
* Fix accessibility issues with Manage Access dialog

* implement more property interfaces

* Fix lgtm errors

* Simplify condition
 2019-12-06 15:09:42 -08:00
Charles Gagnon
d1c7370f1c Make links more descriptive (#8591) 2019-12-06 13:06:49 -08:00
Alan Ren
7cd2a6d6aa fix radio card group rendering error (#8587) 
* fix rendering error

* remove extra $ sign
 2019-12-06 10:20:37 -08:00
Leila Lali
0d9353d99e Manage Package Dialog Refactor (#8473) 
* Refactoring Manage Packages dialog so that other extensions can contribute to it by registering package mange providers for different location and package type
 2019-12-05 10:26:50 -08:00
Anthony Dresser
f5ce7fb2a5 Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c (#8525) 
* Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c

* remove files we don't want

* fix hygiene

* update distro

* update distro

* fix hygiene

* fix strict nulls

* distro

* distro

* fix tests

* fix tests

* add another edit

* fix viewlet icon

* fix azure dialog

* fix some padding

* fix more padding issues
 2019-12-04 19:28:22 -08:00
Charles Gagnon
6cce532ca4 Fix wizard not displaying error messages (#8545) 2019-12-03 17:40:19 -08:00
Alan Ren
b38b53b658 accessible radio card (#8514) 
* accessible radio card group

* set radio card group width

* address comments

* address comments 2

* fix the profile card not being focused issue
 2019-12-03 13:26:00 -08:00
Charles Gagnon
4f8ced1f6b More dangling promise cleanup (#8518) 
* More dangling promise cleanup

* return void

* Function to async

* Fix a couple missed promises
 2019-12-02 15:54:33 -08:00
Charles Gagnon
b8bc629970 Add aria labels and consolidate loc strings (#8494) 2019-12-02 13:33:24 -08:00
Charles Gagnon
3135b8525b Add styling and component column type to declarative table (#8476) 
* Initial wip

* wip

* Working implementation

* Make widths a bit nicer and remove sqlops addition

* Add sqlops back in

* Fix timing issue with tables

* Undo change to sql.bat and remove loading component when done
 2019-11-27 08:06:41 -08:00
Charles Gagnon
0e9797c394 Fix more floating promises (#8460) 2019-11-27 08:04:51 -08:00
Alan Ren
20e9b329b1 only handle the keyboard events on header (#8488) 2019-11-26 13:42:04 -08:00
Alan Ren
ffee69a765 set focus to default cards when loaded (#8480) 
* set focus to default cards when loaded

* add return type
 2019-11-25 20:31:39 -08:00
Anthony Dresser
43387f0d0b Rework how we handle custom editors (#5696) 
* update how we handle editors

* small edit

* handle changing languages

* implement generic language association

* implement notebook serializers

* fix tests

* formatting

* update how we handle editors

* small edit

* handle changing languages

* implement generic language association

* implement notebook serializers

* fix tests

* formatting

* fix broken

* fix compile

* fix tests

* add back in removed note book contributions

* fix layering

* fix compile errors

* fix workbench

* fix hanging promises

* idk why these changed

* fix change

* add comments to language change code

* fix a few bugs

* add query plan association
 2019-11-24 19:22:11 -08:00
Alan Ren
46a8410fc5 make group container accessible (#8452) 2019-11-24 12:23:16 -08:00
Alan Ren
be7c26ede5 update the card role and add aria-checked state (#8451) 2019-11-24 12:03:10 -08:00
Alan Ren
56182a53d1 add role to card component (#8447) 2019-11-22 17:31:22 -08:00
Alan Ren
c03cce7f60 set aria label for table (#8443) 2019-11-22 16:05:57 -08:00
Alan Ren
b333788c3c space key as click (#8437) 2019-11-22 11:24:28 -08:00
Charles Gagnon
52de2b4751 Fix clickable being announced for all modelview text (#8384) 
* Fix clickable being announced for all modelview text

* Remove unused method

* Move API changes into proposed
 2019-11-22 11:01:46 -08:00
Charles Gagnon
f26c790736 Add aria role and selected properties (#8405) 
* Add aria role and selected properties

* Add img role fix

* Add title to text
 2019-11-20 13:56:59 -08:00
Charles Gagnon
55059907a3 Fix a couple a11y issues with manage access (#8386) 
* Fix a couple a11y issues with manage access

* Fix strict null check

* Fix another strict null check
 2019-11-19 13:42:53 -08:00
Charles Gagnon
8ca0082ec4 Fix tab navigation within modal dialog (#8326) 
* Fix tab navigation within modal dialog

* Add import

* Fix spelling

* Change to just add/remove items from DOM as necessary
 2019-11-19 12:43:55 -08:00
Charles Gagnon
ae8304fc33 Add focus function for modelview components (#8348) 
* Add focus method for modelview components

* Remove focus properties from table and radiobutton

* Fix break
 2019-11-15 17:36:55 -08:00
Charles Gagnon
ba8c331356 Add alert role to error message element (#8354) 2019-11-15 11:51:08 -08:00
Charles Gagnon
7563416754 Fix a couple a11y issues (#8334) 
* Fix a couple a11y issues

* Add other dialog
 2019-11-15 07:41:09 -08:00
Anthony Dresser
7a2c30e159 move code from parts to contrib (#8319) 2019-11-14 12:23:11 -08:00
Charles Gagnon
18ab2ae799 Remove TelemetryUtils and use IAdsTelemetryService directly (#8289) 
* Remove TelemetryUtils and use IAdsTelemetryService directly

* Fix event names and cleanup

* Fix tests

* Fix strict null check
 2019-11-13 13:54:55 -08:00
Charles Gagnon
3f306d2396 Fix spacing for form layout (#8321) 2019-11-13 07:30:09 -08:00
Charles Gagnon
8b17b77010 Undo codicon change to fix modelview images (#8201) 2019-11-11 08:28:48 -08:00
Alan Ren
b364e32beb improve the loading component (#8251) 
* improve the loading component

* fix unused method warning

* revert the change
 2019-11-07 11:28:38 -08:00
Charles Gagnon
efebd681b6 Add level to dialog titles and form component titles (#8233) 
* Add level to dialog titles and form component titles

* Switch to h1

* h2 instead of role and aria-level
 2019-11-07 09:32:02 -08:00
Anthony Dresser
df0c505452 No unused locals (#8231) 
* add no unused local

* fix strict null

* fix compile errors

* update vscode comments
 2019-11-06 17:22:05 -08:00
Anthony Dresser
564f78b6f6 Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)"" (#8242) 
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240)"

This reverts commit e801a04bcf.

* fix runtime error

* add tests for chartview
 2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240) 
This reverts commit 22a427f934.
 2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934 Remove typings and replace missing methods with vscodes (#8217) 
* remove typings and replace missing methods with vscodes

* fix strict-null-checks

* fix tests
 2019-11-05 13:03:20 -08:00
Charles Gagnon
399788ccc1 Fix row/column count and table aria label (#8219) 2019-11-05 09:52:59 -08:00
Charles Gagnon
08fde8719d Make declarative table read blank for empty text cells (#8215) 2019-11-05 08:02:37 -08:00
Anthony Dresser
ade68b184d Move code around for more linting (#8190) 
* testing

* moving around all the code

* fix strict nulls
 2019-11-04 10:41:28 -08:00
Amir Omidi
b62c0cf2ab More promise cleanup (#8100) 
* Some promise cleanup

* Handle more promise issues

* Remove changes that aren't needed anymore

* Use log service

* another one

* Be more explicit

* Some more promises cleaned up

* Handle promises here too

* Strings for errors

* Some more cleanup

* Remove unused imports
 2019-10-31 14:30:08 -07:00
Charles Gagnon
ef9321ef2c Add error messages to BDC dashboard page (#8103) 
* Add error messages to BDC dashboard page

* Remove testing code

* PR fixes
 2019-10-30 15:23:34 -07:00
Anthony Dresser
827e6162c7 fix import (#8116) 2019-10-30 13:11:29 -07:00
Shafiq Ur Rahman
f8858a3511 Tab trap for modal (closes #5930) (#8043) 
* Tab trap for modal (closes #5930)

* Addressing PR comments

* Fixed formatting.
 2019-10-30 11:38:11 -07:00
Charles Gagnon
82e5221024 Fix modal event propagation (#8050) 
* Fix event propagation

* Remove unneeded onkeyup method

* Move event handling code into SQL classes
 2019-10-30 11:29:01 -07:00
Kim Santiago
ce5eb00177 Fix schema compare include/exclude behavior (#8042) 
* don't uncheck difference if unsuccessful

* changes after rebasing to get schema compare fix

* First cut of column checkbox checking reactive to include opteration

* handle blocking dependencies and affected dependencies

* Changing the checked property of table to be list

* Addressing comments

* add map to keep row number of diff entries

* remove findDifferenceRow() since it isn't needed anymore

* fix scrolling to the top when checking/unchecking and add info message

* change checked to updateCells

* improve warning cannot include/exclude message
 2019-10-29 11:55:31 -07:00
Charles Gagnon
bd15a96b83 Make form components use title as aria-label (#8040) 2019-10-27 14:37:34 -07:00
Kim Santiago
37426b0794 don't allow tabbing into table (#7769) 2019-10-22 16:25:37 -07:00
BranislavGrbicMDCS
397f6afaf1 ADS changes for new engine edition (#7695) 
* Sql on demand changes

* Formating files

* Removing features for new Engine Edition

* Fixing Restore & Backup issue. Adding support for multiple conditions per flavor

* tabifying

* Formating documents

* Work in progress

* Resolving comments

* Resolving comments.

* Fixing typo
 2019-10-22 12:50:15 +02:00
Anthony Dresser
1e22f47304 Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998 (#7880) 
* Merge from vscode c58aaab8a1cc22a7139b761166a0d4f37d41e998

* fix pipelines

* fix strict-null-checks

* add missing files
 2019-10-21 22:12:22 -07:00
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837) 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
 2019-10-21 12:02:30 -07:00