* add sdk style project template
* update description and order
* update template
* update template and add link
* remove ToolsVersion and xmlns from project node
* update template name to SQL Database (SDK)
* load name and options from publihs profile for vscode publish quickpick
* fix when a publish profile doesn't have the target db name
* update condition
* simplify
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit 2ed8aeb565.
* add back skipVersionSupportedCheck
* add back return false
* addressing comments
* [Loc] update to sql-database-projects xlf (#17743)
* Add additional notebook tests for handling relative links. (#17739)
* [Loc] Fix for duplicate strings in LCL files (#17756)
* WIP spanish lcl duplicate removal
* Revert "WIP spanish lcl duplicate removal"
This reverts commit 5f943153ec8980849a045c8bf7256d852571a778.
* fix for duplicate strings
* removed spaces
* Fixes ADS Web bug around copying user codes and opening a browser tab when adding an Azure Account. (#17760)
* Fixes bug around copying user codes and opening a browser tab.
* Code review changes
* Additional review changes.
* Unnecessary import removed
* Editing pipeline ACR service connection endpoint to the latest one created (#17767)
* using the new registry endpoint
* updating the service connection
* Changing the name of acr service endpoint to SqlToolsContainer
* Updating web build acr endpoint as well.
* Notebooks: Add Tooltips for Link/Image Buttons on Markdown Toolbar (#17763)
* Add title for tooltips
* Tweak tooltips
* Added UI for user to accept EULA when deploying sql proj to docker container (#17762)
* fix sorting bug (#17769)
* fix sorting bug
* comments
* Set default radio button selection, evaluate default component popula… (#17764)
* Set default radio button selection, evaluate default component population off of selection instead of unprocessed input
* rename var
* if -> switches
* Remove project radio buttons because they require commands that aren't yet checked in (and fail as a result)
* Added fix for Publish Target Label Position (#17771)
* Added fix for Publish Target Label Position
* renamed checkbox
* LEGO: check in for main to temporary branch. (#17775)
* LEGO: check in for main to temporary branch. (#17778)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* update dashboard taskbar separator (#17779)
* remove comments
* fix applying decorations
* add test
* enable find in sql result set
* add tests and update sql results highlight logic
* calculate the outputComponent index
* fix editor issues later
* remove newline replace on search
* address comments
* fix highlight issue
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Remove undo/redo listeners from notebook component (#17966)
* remove undo/redo hostlisteners
* fix table focus issue (#17970)
* fix table focus issue
* fix hygiene error
* web
* new sts
* add await
* pr comments
* comments
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
Co-authored-by: Alexander Ivanov <nahk-ivanov@users.noreply.github.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* Start rerouting VSCode cell execution APIs.
* Add more conversion code.
* Convert VSCode notebook registrations into ADS equivalents.
* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.
* Update an error message.
* Add another session argument.
* Add base classes for converting notebook serializers.
* Disable some vscode notebook methods.
* Disable more vscode APIs.
* Disable more stuff.
* Start implementing serializer notebook data conversions.
* Use direct references to extension host notebook methods, rather than azdata ones.
* Add a comment.
* Remove a space.
* Use import type to fix module loading errors.
* Use internal cancellation token class.
* Start adding cell output conversion.
* Convert data from byte array to a string.
* More output work.
* Use a Set for proxy filtering.
* Start adding tests.
* Include metadata in cell conversion. Fix other test failures.
* Fix serialize tests.
* Add more tests.
* Remove wildcard characters from vscode filenames.
* Start implementing session details.
* Add more kernel info.
* Add kernel spec.
* Add Future callback wrapper class.
* Start implementing execute conversion.
* Pass notebook URI to requestExecute.
* Start working on CellExecution methods.
* Move some code around to fix layering issues.
* Use proxy to access browser code, rather than direct imports.
* Move files around to fix layering issues.
* Remove unused imports.
* Start implementing some notebook cell execution behaviors.
* Revert some unnecessary extHost API changes.
* Check for nbformat.
* Also handle nbformat in serialize case.
* Active notebook extensions when resolving NotebookInput.
* Fix nbformat handling.
* Disable VSCode notebooks code.
* Filter out notebook services from registration assertion.
* Wait for providers to load before calling canResolve.
* Use controller's viewType for notebook provider ID, instead of controller ID.
* Start adding extHostNotebook tests for new APIs.
* Re-order proxy calls.
* Remove commented code.
* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.
* Add a comment.
* Remove unnecessary dispose call.
* Handle disposable from registerExecuteProvider.
* Remove a comment.
* Remove unnecessary provider fields.
* Remove reference to notebook service to fix circular reference issue in stringify.
* Add object types for methods in ADSNotebookController.
* Wait for controller languages to be ready before marking session manager as ready.
* Add correct promise.
* Add undefined return type for optional supportedLanguages property.
* Refine promise logic.
* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).
* Fix remaining issues from last commit.
* Replace "not implemented" methods with placeholder return types in order to enable testing.
* Also wait for execution handler to be set before marking session manager as ready.
* Fix usage of NotebookRegistry when updating provider description languages.
* Refine file extension conversion.
* Fix file extension conversion to match ADS extension behavior.
* Emit new provider registration event when adding supported languages.
* Remove checks for duplicate file providers and kernels.
* Fix a test failure.
* Fix file extension parsing.
* Use default executeManager if one isn't defined for provider in notebookModel.
* Add descriptors for waiting on standardKernels registration.
* Increase timeout
* Add an error message.
* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.
* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."
This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.
* Emit activation events after provider registration.
* Wait on standard kernels availability when getting an execute provider.
* Throw an error if session manager isn't ready yet.
* Actually resolve language promise correctly.
* Add some checks for undefined notebook data objects.
* Create kernel spec data correctly.
* Add extension changes for local testing only.
* Clean up test class.
* Add a reminder comment.
* Undo commented out notebook stuff
* Temporarily hard code default kernel.
* Retrieve default kernel in notebookModel if it's not already provided.
* Revert an import change.
* Remove unnecessary method from extHostNotebook.
* Move an interface around.
* wip
* Check for proposed API for some VSCode extHost methods.
* Remove a comment.
* Fix notebookUtils tests.
* Fix notebookModel tests.
* Fix notebookFindModel tests.
* Fix notebookViewsExtension tests.
* Fix remaining notebookView tests.
* Refactor output conversion functionality into separate methods.
* Update some unit tests for output conversion.
* Move a method.
* Rename conversion methods to fit acronym styling.
* Add another conversion test case.
* Revert local testing changes.
* Remove old method.
* cleanup
* Remove some comments.
* Move localized string to locConstants.
* Add a space to loc string.
* Add comments to new SQL Carbon Edit tags.
* Create constants for nbformat and nbformat_minor.
* Move some vscode-only fields to proposed APIs.
* Check for valid state
* Properly null check
* Adding logging for provider wait timeouts.
* wip update
* Fix compile
* Switch to cell edits
* Update docs
* Remove custom output type
* cleanup
* fix
* cleanup
* more cleanup
* Fixes
* Fix tests and lint errors
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* Added customlocation, location, resource group, and connection mode to controllerinfo. Updated SQL MIAA create notebook with direct mode params.
* Removed annotations from metadata in postgres test file.
* Only parse the customlocation if the connection mode is direct.
Co-authored-by: Candice Ye <canye@microsoft.com>
