Commit Graph

2611 Commits

Author SHA1 Message Date
Alan Ren
86cd0003fe add required indicator (#22971) 2023-05-04 15:23:22 -07:00
Cheena Malhotra
7b2a07befd Respect 'showDashboard' disabled by default (#22907) 2023-05-01 11:55:38 -07:00
Cheena Malhotra
ea6bb41f45 Allow 'ApplicationName' to be specified for MSSQL connections (#22890) 2023-05-01 10:55:05 -07:00
Cheena Malhotra
f4952c76b8 Handle no matching account scenario (#22908) 2023-05-01 10:54:42 -07:00
Charles Gagnon
519a42c5b3 Fix missing placeholder warning for infoboxes (#22898) 2023-05-01 09:30:02 -07:00
Aasim Khan
b86463ee71 Adding filtering to OE Service (#22900)
* Adding filtering to OE Service

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/serverTreeRenderer.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Fixing compile errors

* Fixing circular dependency

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
2023-04-29 17:22:38 -04:00
Alan Ren
468b3e4f06 update shortcut keys for parse query (#22896) 2023-04-28 14:45:28 -07:00
Aasim Khan
9c68043137 Adding OE filtering interfaces. (#22738)
* Adding interfaces for tree filtering

* fixing type

* Adding enums in sqlhost

* Fixing comment

* Fixed filters lol

* Fixing some contract definitions

* Removing flag

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Removing filters

* Removing filters2

* Fixing enum

* Fixing interface and enum names

* Fixing interface name

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Removing type from filter

* Adding is null and is not null operators

* Fixing enums

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/azdata.proposed.d.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-04-27 13:15:11 -04:00
Cheena Malhotra
24af5db4a2 Fix resetting tenant when dropdown is not visible (#22845) 2023-04-25 12:53:58 -07:00
Charles Gagnon
64dd4f0904 Fix IConnectionProfile to have same options key when generated from ConnectionProfile (#22840) 2023-04-25 09:52:51 -07:00
Cheena Malhotra
a887bb199e Fix username to respect existing values (#22837) 2023-04-24 15:28:44 -07:00
Cheena Malhotra
2247d5de88 Prevent reconnects for mssql provider (#22825) 2023-04-21 16:56:40 -07:00
Cheena Malhotra
8613176817 Cache access tokens in local cache file to prevent MSAL throttling (#22763) 2023-04-20 13:55:30 -07:00
Karl Burtram
e7d3d047ec Merge from vscode merge-base (#22780)
* Revert "Revert "Merge from vscode merge-base (#22769)" (#22779)"

This reverts commit 47a1745180.

* Fix notebook download task

* Remove done call from extensions-ci
2023-04-19 21:48:46 -07:00
Alan Ren
decbe8dded simplify object management feature APIs (#22781) 2023-04-19 19:26:29 -07:00
Alan Ren
35829acd00 fix error message steal focus issue (#22782)
* fix steal focus issue

* update comment
2023-04-19 11:39:45 -07:00
Cheena Malhotra
ba694a0558 Register mysql, pgsql with mssql as default 'sql' kernel providers (#22729) 2023-04-18 22:07:02 -07:00
Karl Burtram
47a1745180 Revert "Merge from vscode merge-base (#22769)" (#22779)
This reverts commit 6bd0a17d3c.
2023-04-18 21:44:05 -07:00
Lewis Sanchez
6bd0a17d3c Merge from vscode merge-base (#22769)
* Merge from vscode merge-base

* Turn off basic checks

* Enable compilation, unit, and integration tests
2023-04-18 18:28:58 -07:00
Alex Ma
b69e87df15 Connection URI with complete options (finalized) (#22735)
* Connection URI made to include every option available instead of basic details (#22045)

* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"

This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.

* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""

This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.

* Added changes and fixes for feat connectionuri (#22706)

* add title generation at start

* added await to refreshConnectionTreeTitles
2023-04-18 11:08:48 -07:00
Aasim Khan
fe086dc778 Fixing adding connections on a new ads install (#22760)
* Fixing stuff

* Fixing connection groups as well
2023-04-18 08:39:53 -07:00
Aasim Khan
b7d24dcecd Cleaning up some code in Async Server Tree. (#22732) 2023-04-17 23:23:41 -07:00
Alan Ren
f66d3349b9 add tooltip for dashboard learn more button (#22744) 2023-04-17 08:19:59 -07:00
Alan Ren
1f57a10f7f auto focus message area (#22743) 2023-04-14 16:30:47 -07:00
Alan Ren
46bc19bcb8 adjust the default max column width (#22740) 2023-04-14 15:29:12 -07:00
Aasim Khan
8d9ddebd98 Adding restart ads notification when async server tree is toggled (#22726) 2023-04-14 07:54:28 +01:00
Cheena Malhotra
87571b2706 Support placeholder text for connection dialog options (#22693) 2023-04-13 15:08:12 -07:00
Cory Rivera
8aade56214 Use column names as keys for table data in SQL cell outputs (#22688) 2023-04-13 13:26:12 -07:00
Christopher Suh
897f026d1e Firewall Dialog Account/Tenant Selection (#22695)
* preselect account in firewall dialog from connection details

* cleanup

* fix element reference

* add initial tenant selection

* fix compile & cleanup

* pr comments

* change to private
2023-04-12 15:59:31 -07:00
Charles Gagnon
df88d881c5 Remove disposable from connection (#22687)
* Remove disposable from connection

* Remove from group
2023-04-11 15:27:01 -07:00
Aasim Khan
577d99e790 Fixing dup connections (#22670) 2023-04-11 14:16:59 -07:00
Alan Ren
2ee7c2649d reduce toolbar space (#22647)
* reduce toolbar space

* feedback
2023-04-06 14:56:48 -07:00
Charles Gagnon
df1accf918 Improve missing placeholder warning message (#22630)
* Improve missing placeholder warning message

* stringify
2023-04-05 11:42:26 -07:00
Aasim Khan
958a3f85e5 Enabling async server tree in insiders (#22596) 2023-04-03 17:15:52 -07:00
Alan Ren
61b3285eaf make table keyboard shortcuts configurable (#22582)
* make table keyboard shortcuts configurable

* fix error

* new slickgrid version

* add comment

* tree grid
2023-04-03 13:21:00 -07:00
Aasim Khan
38a3312cb6 Fixing edited connections not working for root in Async Server Tree (#22580)
* Fixing edited connections not working for root

* Fixing comment
2023-04-03 11:58:19 -07:00
Alan Ren
2a14562ec7 update parse query action (#22577)
* update parse query action

* revert export notebook change

* comment
2023-03-31 18:24:47 -07:00
Alex Ma
0f21ecd531 Add fix to enter press on last row of Edit Data. (#22351)
* added fix to enter on null row for edit data

* added fix to displayValue after new row is added

* added suggested changes and fixes
2023-03-31 18:09:34 -07:00
Cory Rivera
1dbb2211e3 Use blue icon for dashboard New Notebook task (#22568) 2023-03-31 16:06:50 -07:00
Cheena Malhotra
152eb32278 Fix saving profile from Azure tree nodes (#22518) 2023-03-31 11:58:49 -07:00
Aasim Khan
d49ff85afc Fixing connection without saved password not connecting in Async Server Tree (#22535) 2023-03-31 09:19:01 -07:00
Aasim Khan
a1acaf2096 Adding caching in OE service (#22539) 2023-03-31 09:18:36 -07:00
Aasim Khan
4ff16885c1 Cleaning update children logic in async server tree (#22550) 2023-03-30 15:17:45 -07:00
Cory Rivera
621f390eef Add New Notebook task to server and database dashboards. (#22548) 2023-03-30 12:41:03 -07:00
Aasim Khan
2a9705c495 Fixing async server tree (#22511)
* Changing look of new OE

* Fixing styling

* Fixing moving of connected profile

* Fixing drag and drop where treenodes delete connection nodes

* Fixing Deleting and disconnecting in AsyncServerTree

* Adding constant for OE timeout

* Updated interfaces

* Removing test compilation errors

* Fixing most events in async server tree

* Fixing connection pane styling

* Fixing find node function

* Fixing some more operations

* Fixing some ops

* All operations done

* Fixed active connections

* Fixed data source

* Adding support for setting parents

* code cleanup

* Fixing icon styling issues

* Fix errors

* Fixing comment

* Fixing spacing

* Adding explanation to OE service.

* Reverting server delegate changes

* Reverting styling

* reverting more styling change

* reverting more styling

* Fixing has children

* Fixing drag and drop to tree nodes

* fixing drag and drop

* reverting timing

* fixing drag and drop

* cleaning some code

* Fixed server and group moving

* spell check

* consolidating some logic

* Fixed whitespace

* fixing moving to root group
2023-03-29 13:59:35 -07:00
Cheena Malhotra
e70865ff20 Send telemetry with Auth Library when adding/refreshing account (#22506) 2023-03-29 11:56:56 -07:00
Alan Ren
afafee844c fix notebook serialization issue for non-mssql providers (#22504)
* use mssql as notebook serialization provider

* comment

* use fallback
2023-03-28 21:34:38 -07:00
Hai Cao
83e35ad7f8 fix hover for cells with null value (#22507) 2023-03-28 20:19:15 -07:00
Aasim Khan
f60bd1335c Adding promises and operation timeouts to fix race conditions and infinite loading in OE (#22475)
* Adding promises and operation timeouts to fix race conditions

* cleaning up logic

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing promise type

* Reverting back to old error logic

* Making onsessioncreated async

* Removed polling and converted to event based

* removing connection variable out of promise

* Combining promises

* Update src/sql/workbench/services/objectExplorer/browser/treeUpdateUtils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing error messages and localizing user facing errors

* Fixing error message

* localizing config

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing comment

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-03-28 18:36:45 -07:00
Aasim Khan
3aee3f006a Fixing icon styling in tree (#22490) 2023-03-28 09:23:15 -07:00