Commit Graph

878 Commits

Author SHA1 Message Date
Alan Ren
86cd0003fe add required indicator (#22971) 2023-05-04 15:23:22 -07:00
Cheena Malhotra
7b2a07befd Respect 'showDashboard' disabled by default (#22907) 2023-05-01 11:55:38 -07:00
Cheena Malhotra
ea6bb41f45 Allow 'ApplicationName' to be specified for MSSQL connections (#22890) 2023-05-01 10:55:05 -07:00
Cheena Malhotra
f4952c76b8 Handle no matching account scenario (#22908) 2023-05-01 10:54:42 -07:00
Aasim Khan
b86463ee71 Adding filtering to OE Service (#22900)
* Adding filtering to OE Service

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/serverTreeRenderer.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>

* Fixing compile errors

* Fixing circular dependency

---------

Co-authored-by: Cheena Malhotra <13396919+cheenamalhotra@users.noreply.github.com>
2023-04-29 17:22:38 -04:00
Cheena Malhotra
24af5db4a2 Fix resetting tenant when dropdown is not visible (#22845) 2023-04-25 12:53:58 -07:00
Charles Gagnon
64dd4f0904 Fix IConnectionProfile to have same options key when generated from ConnectionProfile (#22840) 2023-04-25 09:52:51 -07:00
Cheena Malhotra
a887bb199e Fix username to respect existing values (#22837) 2023-04-24 15:28:44 -07:00
Cheena Malhotra
2247d5de88 Prevent reconnects for mssql provider (#22825) 2023-04-21 16:56:40 -07:00
Cheena Malhotra
8613176817 Cache access tokens in local cache file to prevent MSAL throttling (#22763) 2023-04-20 13:55:30 -07:00
Karl Burtram
e7d3d047ec Merge from vscode merge-base (#22780)
* Revert "Revert "Merge from vscode merge-base (#22769)" (#22779)"

This reverts commit 47a1745180.

* Fix notebook download task

* Remove done call from extensions-ci
2023-04-19 21:48:46 -07:00
Alan Ren
decbe8dded simplify object management feature APIs (#22781) 2023-04-19 19:26:29 -07:00
Cheena Malhotra
ba694a0558 Register mysql, pgsql with mssql as default 'sql' kernel providers (#22729) 2023-04-18 22:07:02 -07:00
Karl Burtram
47a1745180 Revert "Merge from vscode merge-base (#22769)" (#22779)
This reverts commit 6bd0a17d3c.
2023-04-18 21:44:05 -07:00
Lewis Sanchez
6bd0a17d3c Merge from vscode merge-base (#22769)
* Merge from vscode merge-base

* Turn off basic checks

* Enable compilation, unit, and integration tests
2023-04-18 18:28:58 -07:00
Alex Ma
b69e87df15 Connection URI with complete options (finalized) (#22735)
* Connection URI made to include every option available instead of basic details (#22045)

* Revert "Merge remote-tracking branch 'origin' into feat/connectionUri"

This reverts commit 11b2d31bf99e216daee823f732254f69a017fee1, reversing
changes made to 36e4db8c0744f81565efdfd2f56a3ae3c0026896.

* Revert "Revert "Merge remote-tracking branch 'origin' into feat/connectionUri""

This reverts commit f439673c2693e1144c52e04c14e82cd8566c13a6.

* Added changes and fixes for feat connectionuri (#22706)

* add title generation at start

* added await to refreshConnectionTreeTitles
2023-04-18 11:08:48 -07:00
Cheena Malhotra
87571b2706 Support placeholder text for connection dialog options (#22693) 2023-04-13 15:08:12 -07:00
Cory Rivera
8aade56214 Use column names as keys for table data in SQL cell outputs (#22688) 2023-04-13 13:26:12 -07:00
Christopher Suh
897f026d1e Firewall Dialog Account/Tenant Selection (#22695)
* preselect account in firewall dialog from connection details

* cleanup

* fix element reference

* add initial tenant selection

* fix compile & cleanup

* pr comments

* change to private
2023-04-12 15:59:31 -07:00
Charles Gagnon
df88d881c5 Remove disposable from connection (#22687)
* Remove disposable from connection

* Remove from group
2023-04-11 15:27:01 -07:00
Aasim Khan
958a3f85e5 Enabling async server tree in insiders (#22596) 2023-04-03 17:15:52 -07:00
Alan Ren
61b3285eaf make table keyboard shortcuts configurable (#22582)
* make table keyboard shortcuts configurable

* fix error

* new slickgrid version

* add comment

* tree grid
2023-04-03 13:21:00 -07:00
Aasim Khan
38a3312cb6 Fixing edited connections not working for root in Async Server Tree (#22580)
* Fixing edited connections not working for root

* Fixing comment
2023-04-03 11:58:19 -07:00
Aasim Khan
d49ff85afc Fixing connection without saved password not connecting in Async Server Tree (#22535) 2023-03-31 09:19:01 -07:00
Aasim Khan
a1acaf2096 Adding caching in OE service (#22539) 2023-03-31 09:18:36 -07:00
Aasim Khan
4ff16885c1 Cleaning update children logic in async server tree (#22550) 2023-03-30 15:17:45 -07:00
Aasim Khan
2a9705c495 Fixing async server tree (#22511)
* Changing look of new OE

* Fixing styling

* Fixing moving of connected profile

* Fixing drag and drop where treenodes delete connection nodes

* Fixing Deleting and disconnecting in AsyncServerTree

* Adding constant for OE timeout

* Updated interfaces

* Removing test compilation errors

* Fixing most events in async server tree

* Fixing connection pane styling

* Fixing find node function

* Fixing some more operations

* Fixing some ops

* All operations done

* Fixed active connections

* Fixed data source

* Adding support for setting parents

* code cleanup

* Fixing icon styling issues

* Fix errors

* Fixing comment

* Fixing spacing

* Adding explanation to OE service.

* Reverting server delegate changes

* Reverting styling

* reverting more styling change

* reverting more styling

* Fixing has children

* Fixing drag and drop to tree nodes

* fixing drag and drop

* reverting timing

* fixing drag and drop

* cleaning some code

* Fixed server and group moving

* spell check

* consolidating some logic

* Fixed whitespace

* fixing moving to root group
2023-03-29 13:59:35 -07:00
Cheena Malhotra
e70865ff20 Send telemetry with Auth Library when adding/refreshing account (#22506) 2023-03-29 11:56:56 -07:00
Aasim Khan
f60bd1335c Adding promises and operation timeouts to fix race conditions and infinite loading in OE (#22475)
* Adding promises and operation timeouts to fix race conditions

* cleaning up logic

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing promise type

* Reverting back to old error logic

* Making onsessioncreated async

* Removed polling and converted to event based

* removing connection variable out of promise

* Combining promises

* Update src/sql/workbench/services/objectExplorer/browser/treeUpdateUtils.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing error messages and localizing user facing errors

* Fixing error message

* localizing config

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Fixing comment

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-03-28 18:36:45 -07:00
Aasim Khan
3aee3f006a Fixing icon styling in tree (#22490) 2023-03-28 09:23:15 -07:00
Cory Rivera
97eb69477e Remove unused files in sql and extensions folders (#22444) 2023-03-27 16:40:32 -07:00
Aasim Khan
e80c6f2dcb Fixing async tree styling (#22458) 2023-03-27 13:16:23 -07:00
Alan Ren
35cb233851 support default action for OE node (#22455)
* support default action for OE node

* fix floating promise
2023-03-24 20:09:48 -07:00
Cheena Malhotra
d5c495f05a Address Secure enclaves feedback to show required indicator optionally (#22428) 2023-03-24 09:57:32 -07:00
Christopher Suh
14ea5e9dd7 fix logic (#22405) 2023-03-22 12:57:49 -07:00
Charles Gagnon
ed37ad315f Clean up buildConnectionInfo (#22407)
* Clean up buildConnectionInfo

* Add test and cleanup
2023-03-22 12:54:29 -07:00
Cheena Malhotra
a3e77c674c Address console warnings with new connection dialog (#22293) 2023-03-22 12:31:25 -07:00
Vsevolod Kukol
e3135aca4c Preserve name and group when using Connection String (#22341) 2023-03-22 07:55:18 -07:00
Aasim Khan
f9e72b0d93 Fixing connection group change for connections (#22379) 2023-03-20 15:37:47 -07:00
Alan Ren
aa47729f90 fix find parent node issue (#22356)
* fix find parent node issue

* sts update

* fix errors

* pr comments and a fix
2023-03-20 08:20:11 -07:00
Alan Ren
20cf2489a2 support rename for login, user and a few other types (#22331)
* rename object

* add comment

* use URN property

* vbump STS

* revert loc string change

* fix name check

* pr comments
2023-03-16 15:00:07 -07:00
Aasim Khan
f0a5d296bf Fixing new connections not expanding in object explorer. (#22307)
* Fixing new connection node not expanding in OE

* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.

* Fixing test

* Adding a setting for node expansion timeout

* Not saving when loading tree based connections

* Adding some logs

* Removing special casing for mssql provider

* Missing providers

* Adding user toast for node expansion timeout

* Adding notification service to test

* Fixing node type for mssql

* remove polling

* Fixing onNodeStatus

* Fixing stuff

* consolidating functions

* Consolidating resolve logic

* removing extra try catch

* code cleanup

* adding size checks

* Removing commented code

* Ignoring errors from other sessions and nodepaths.
2023-03-14 10:50:46 -07:00
Maddy
5fc69a0445 Fix find highlight on cell edits (#22080)
* update the rendered text onCellSourceChange

* fix test

* fix highlight in split mode

* update corresponding test

* update hasEditor with getEditor

* update event

* add comment
2023-03-08 22:26:07 -08:00
Aasim Khan
9fddefc8fb Fixing execution plan not finding provider (#22238) 2023-03-08 12:55:49 -08:00
Aasim Khan
d3f4f0daa4 Adding light contrast theme (#22028)
* Adding light contrast theme

* fixing oe icons

* Fixing more files

* Converting ep files to support hc light

* Revert "Copy Headers for Selected Columns (#21622)"

This reverts commit f74d6f6d9b.

* Adding more css rules

* Fixing modal

* Fixing azure icons
2023-03-06 17:31:27 -08:00
Charles Gagnon
a657aa6cb5 Remove hasEditor from ICellEditorProvider (#22145) 2023-03-06 11:02:41 -08:00
Aasim Khan
644f5a16ef Fixing URI openings for execution plans (#22139) 2023-03-04 15:14:50 -08:00
Lewis Sanchez
0f813a9900 Update add account icon (#22142)
* Update add account icon

* Remove unused icon from SqlIconId

* Remove unused accountActions.css

* Revert "Remove unused accountActions.css"

This reverts commit d31d17f5d2027f25f306e713abff14e750e7479a.

* Remove unused css file and svg's

* Remove unused import

* Revert "Remove unused import"

This reverts commit 91ad47da56d428d8805b65f685af76694b16ba6c.

* Remove unused import
2023-03-03 17:42:10 -08:00
Cheena Malhotra
07eb964c32 Fix AuthLibrary detection and use MSAL by default (#22140) 2023-03-03 14:33:29 -08:00
Cheena Malhotra
aa350f7e49 Enable SQL Auth Provider support (#21903) 2023-03-03 12:49:01 -08:00