Commit Graph

293 Commits

Author SHA1 Message Date
Karl Burtram
e7d3d047ec Merge from vscode merge-base (#22780)
* Revert "Revert "Merge from vscode merge-base (#22769)" (#22779)"

This reverts commit 47a1745180.

* Fix notebook download task

* Remove done call from extensions-ci
2023-04-19 21:48:46 -07:00
Cheena Malhotra
ba694a0558 Register mysql, pgsql with mssql as default 'sql' kernel providers (#22729) 2023-04-18 22:07:02 -07:00
Karl Burtram
47a1745180 Revert "Merge from vscode merge-base (#22769)" (#22779)
This reverts commit 6bd0a17d3c.
2023-04-18 21:44:05 -07:00
Lewis Sanchez
6bd0a17d3c Merge from vscode merge-base (#22769)
* Merge from vscode merge-base

* Turn off basic checks

* Enable compilation, unit, and integration tests
2023-04-18 18:28:58 -07:00
Cory Rivera
8aade56214 Use column names as keys for table data in SQL cell outputs (#22688) 2023-04-13 13:26:12 -07:00
Cory Rivera
97eb69477e Remove unused files in sql and extensions folders (#22444) 2023-03-27 16:40:32 -07:00
Maddy
5fc69a0445 Fix find highlight on cell edits (#22080)
* update the rendered text onCellSourceChange

* fix test

* fix highlight in split mode

* update corresponding test

* update hasEditor with getEditor

* update event

* add comment
2023-03-08 22:26:07 -08:00
Charles Gagnon
a657aa6cb5 Remove hasEditor from ICellEditorProvider (#22145) 2023-03-06 11:02:41 -08:00
Lucy Zhang
b3048213e8 Minor improvements in notebook edit mode handling (#21839)
* rename + remove duplicate calls

* only fire onCellEditModeChanged when changed
2023-02-06 10:42:19 -08:00
Cory Rivera
272e748424 Show a message if kernel is not supported when first opening a notebook. (#21376) 2022-12-08 10:27:57 -08:00
Cory Rivera
e2327c393a Remove all Big Data Cluster features (#21369) 2022-12-07 12:28:17 -08:00
Cory Rivera
728a90cd53 Move New Notebook command to core (#21247) 2022-11-18 14:54:58 -08:00
Cory Rivera
a37d6230f9 Remove API compatibility layer for VS Code notebook extensions (#21225) 2022-11-15 10:38:41 -08:00
Aasim Khan
00b797b4f3 Adding keyboard shortcuts for column resizing in slickgrid (#21100)
* Adding column resize keyboard shortcuts in slickgrid

* Switching to standard keyboard evt

* Adding comment for the functionality

* Cleaning up code and adding more comments

* Using quick input to get column resize width

* Adding check for negative sizes

* Fixing some stuff
2022-11-04 16:15:04 -07:00
Aasim Khan
4823a76833 Adding screen reader optimized mode to slickgrid (#21069) 2022-11-02 15:11:16 -07:00
Cory Rivera
f4711d3c9c Remove unused ClientSession members. (#21031) 2022-10-28 15:37:59 -07:00
Cory Rivera
82adcc0f20 Fix issues with loading aliased kernels in notebooks (#21018) 2022-10-28 13:22:52 -07:00
Cory Rivera
5f6eed12c2 Re-enable .NET Interactive in Ipynb notebooks (#21002) 2022-10-27 13:49:37 -07:00
Charles Gagnon
5032685162 Notebook cleanup (#20954) 2022-10-24 15:32:42 -07:00
Charles Gagnon
a64a33e091 ModeService to LanguageService var names (#20949) 2022-10-24 13:57:03 -07:00
Karl Burtram
de9dd34275 Fix Notebook language ids (#20938) 2022-10-24 13:56:10 -07:00
Karl Burtram
8a3d08f0de Merge vscode 1.67 (#20883)
* Fix initial build breaks from 1.67 merge (#2514)

* Update yarn lock files

* Update build scripts

* Fix tsconfig

* Build breaks

* WIP

* Update yarn lock files

* Misc breaks

* Updates to package.json

* Breaks

* Update yarn

* Fix breaks

* Breaks

* Build breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Missing file

* Breaks

* Breaks

* Breaks

* Breaks

* Breaks

* Fix several runtime breaks (#2515)

* Missing files

* Runtime breaks

* Fix proxy ordering issue

* Remove commented code

* Fix breaks with opening query editor

* Fix post merge break

* Updates related to setup build and other breaks (#2516)

* Fix bundle build issues

* Update distro

* Fix distro merge and update build JS files

* Disable pipeline steps

* Remove stats call

* Update license name

* Make new RPM dependencies a warning

* Fix extension manager version checks

* Update JS file

* Fix a few runtime breaks

* Fixes

* Fix runtime issues

* Fix build breaks

* Update notebook tests (part 1)

* Fix broken tests

* Linting errors

* Fix hygiene

* Disable lint rules

* Bump distro

* Turn off smoke tests

* Disable integration tests

* Remove failing "activate" test

* Remove failed test assertion

* Disable other broken test

* Disable query history tests

* Disable extension unit tests

* Disable failing tasks
2022-10-19 19:13:18 -07:00
Alan Ren
5d731fe0ad table cell selection improvement (#20854)
* Support SHIFT key for table cell selection

* fix for mac

* PR comment
2022-10-14 19:44:14 -07:00
Cory Rivera
806580fe44 Use SQL kernel as default when opening a notebook with an unknown provider (#20828) 2022-10-13 12:38:43 -07:00
Cory Rivera
acc9780f04 Update kernels dropdown after installing a notebook extension (#20759) 2022-10-12 14:44:31 -07:00
Maddy
7dd36ae7b4 fix: image disappear issue (#20039)
* check if base64 value is from image tag

* add test

* check image regex

* add comment

* update comment
2022-07-20 13:58:49 -07:00
Charles Gagnon
ba1f4db745 Make createEditorInput async (#20038) 2022-07-14 19:39:52 -07:00
Cory Rivera
e58aa90ac0 Set dotnet_interactive cell metadata when converting cell into JSON. (#20044) 2022-07-14 16:47:14 -07:00
Karl Burtram
26455e9113 Merge vscode source through 1.62 release (#19981)
* Build breaks 1

* Build breaks

* Build breaks

* Build breaks

* More build breaks

* Build breaks (#2512)

* Runtime breaks

* Build breaks

* Fix dialog location break

* Update typescript

* Fix ASAR break issue

* Unit test breaks

* Update distro

* Fix breaks in ADO builds (#2513)

* Bump to node 16

* Fix hygiene errors

* Bump distro

* Remove reference to node type

* Delete vscode specific extension

* Bump to node 16 in CI yaml

* Skip integration tests in CI builds (while fixing)

* yarn.lock update

* Bump moment dependency in remote yarn

* Fix drop-down chevron style

* Bump to node 16

* Remove playwrite from ci.yaml

* Skip building build scripts in hygine check
2022-07-11 14:09:32 -07:00
Lucy Zhang
4ec2d78269 Add Notebook telemetry events (#19848)
* add telemetry events

* remove error message in telemetry
2022-07-01 09:14:29 -07:00
Lucy Zhang
23feac100a Add telemetry for notebook toolbar actions (#19750)
* add telemetry for notebook toolbar actions

* fix tests

* remove events with no metadata + connection info

* add optional connectioninfo param

* fix param
2022-06-23 05:57:17 -07:00
Cory Rivera
a265224701 Show an error in cell output when trying to load an unsupported output type. (#19693) 2022-06-09 12:32:42 -07:00
Lucy Zhang
e2535c85c5 fix notebook provider (#19678) 2022-06-08 15:04:50 -07:00
Daniel Grajeda
4fd2f92e27 Introduce tabs for notebook views (#19526)
* Introduce tabs for notebook views

Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.

The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
2022-06-06 03:07:08 -07:00
Cory Rivera
950bb1e53b Fix issues with changing SQL notebook connection while a cell is executing (#19624) 2022-06-03 18:05:32 -07:00
Barbara Valdez
f06fd7f6f7 Fix split cell not working with attachments (#19587) 2022-06-01 16:23:46 -07:00
Lucy Zhang
4d8fdf5833 Have screen reader announce when cell execution is complete (#19249)
* add tab index to cell output

* add sr-only element to announce cell exe complete

* use onExecutionComplete event

* remove extra change

* simplify alert message

* add alert for cell execution start
2022-05-04 10:44:24 -07:00
Cory Rivera
8cc66dade3 Fix intellisense for .NET Interactive SQL kernel (#19254) 2022-05-02 13:44:33 -07:00
Cory Rivera
7b58568d26 Convert .NET Interactive notebook's kernel spec to a VS Code compatible kernel when saving. (#19176) 2022-04-22 16:00:13 -07:00
Cory Rivera
8bd5ea5c84 Only update hover execution state if cell is not active. (#19073) 2022-04-14 10:19:58 -07:00
Cory Rivera
c2cc32a4a0 Add option to use notebook json contents instead of file string when creating a notebook. (#18972) 2022-04-08 16:39:14 -07:00
Maddy
4191ef8aa5 Fix active cell update on tabbing (#18614)
* listen on focus_in of toolbar

* update styles on focus_in

* listen for active cell change on notebook componen

* add tabbing order to textcells

* remove duplicate listener

* clean up

* undo

* remove visible check from cellToolbar

* remove duplicate detectChanges on updateActiveCell

* only update active cell if it's already not

* add aria-label for accessibility

* localize the aria label

* refactor

* add cellLabel property to CellModel

* remove updateActiveCell from code component

* regression from merge fix

* set edit mode as true when focusing on cell

* moce check to model

* merge changes correctly

* update edit mode if code cell

* fixes

Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-04-08 12:31:30 -07:00
Cory Rivera
03d2e83250 Treat Jupyter's Python 3 Ipykernel alias as Python 3. (#18943) 2022-04-06 11:27:15 -07:00
Chris LaFreniere
af3d307d40 Restart kernel initial implementation (#18835)
* Restart kernel initial implementation

* Update notebook extension TestKernel

* PR comments
2022-03-29 12:56:52 -07:00
Cory Rivera
7914fcf101 Fix issues with unknown notebook file types not opening as a default notebook. (#18779) 2022-03-18 16:59:22 -07:00
Maddy
23a69f9b69 Add test for last edit mode (#18734)
* add test for persisting last edit mode

* remove empty line

* address comments

* update comment
2022-03-18 16:13:58 -07:00
Cory Rivera
95980130c8 Correctly handle creating and saving untitled notebook .dib files. (#18744) 2022-03-16 14:37:21 -07:00
Cory Rivera
206188f3ab Add missing onNotebook:* activation event for VS Code notebook compatibility. (#18710) 2022-03-14 10:32:26 -07:00
Cory Rivera
eccb77aca3 Preserve previous code cell's language when creating a new code cell from an existing context. (#18646) 2022-03-06 21:35:57 -08:00
Cory Rivera
0ab4752643 Add new errorCode property to notebook errors to see if starting a notebook session failed. (#18617) 2022-03-03 14:05:54 -08:00