Commit Graph

26 Commits

Author SHA1 Message Date
Charles Gagnon
8a6ea2669b Add additional properties to wizard page navigation events (#17716) 2021-11-19 10:18:13 -08:00
Alan Ren
b7b23dcecc add page custom buttons (#16797) 2021-08-17 09:32:07 -07:00
Alan Ren
eed792f3db fix keyboard focus issues (#16206) 2021-07-16 13:27:15 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
2021-06-17 08:17:11 -07:00
Kim Santiago
39a47b0053 Add telemetry for opening dacpac wizard (#14884)
* add telemetry for opening dacpac wizard

* add wizard open telemetry to core

* fix tests

* remove WizardOpen
2021-03-26 14:57:51 -07:00
Charles Gagnon
d2faf9075d Clean up dialog event hide reasons (#14566)
* Clean up dialog event hide reasons

* Remove done
2021-03-05 08:54:35 -08:00
Alan Ren
56a6557c6e show page first and then do the layout (#14307) 2021-02-16 14:41:39 -08:00
Alan Ren
a3cddbc8aa align with portal button style (#14187)
* align with portal button style

* fix welcome page

* image button

* more fixes

* use withProperties

* add comment back

* add border radius
2021-02-08 15:12:54 -08:00
Charles Gagnon
c3a00c2cc6 Clean up telemetry keys (#14093) 2021-01-28 13:33:12 -08:00
Sai Avishkar Sreerama
0316d9ac57 Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859)
* Dacpac telmetry code changes

* Removed added spaces

* Generate deployScript accessibility changed back to public

* code review suggessions updates

* dacpac extension tests fixes

* Updated time and filesize methods allowing general return values

* Telemetry code updates

* Dacpac Telemetry potential data loss capture and PII error excluded

* Dacpac telemetry code updates for comments

* Wizard pages navigation telemetry event capture moved to the core

* DacpacTelemetry code updates

* Extension wizard cancel telemetry for data loss

* Dacpac telemetry pagename and small code updates

* final Dacpac telemetry code updates...
2021-01-21 17:00:37 -06:00
Kim Santiago
abdf575885 fix wizard page name and step getting announced when pages are added and removed (#13362) 2020-11-12 09:44:33 -08:00
Charles Gagnon
807a4ae8c4 Add telemetry for ModelView wizards (#12596)
* Add telemetry for ModelView wizards

* Remove unnecessary params

* Fix compile error
2020-09-23 17:08:22 -07:00
Charles Gagnon
4e07685588 Strict compile for sql/workbench/services/dialog (#12578)
* Strict compile for sql/workbench/services/dialog

* fix errors
2020-09-23 13:15:59 -07:00
Amir Omidi
61e5003931 fix setCurrentPage (#12025)
* fix setCurrentPage

* Fix wrong import
2020-08-31 12:36:38 -07:00
Charles Gagnon
87b892d13f Update step when page is navigated to (#9839) 2020-04-03 08:57:57 -07:00
Amir Omidi
5ee7454793 Fixes error introduced in #9653 (#9655) 2020-03-17 17:50:36 -07:00
Alan Ren
1e1cd2f797 remove the alert role from the wizard page title (#9653)
* announce page change

* Use status() and update message

* localize the page number text

* comments
2020-03-17 16:43:59 -07:00
ADS Merger
4c3e48773d Merge from vscode cfc1ab4c5f816765b91fb7ead3c3427a7c8581a3 2020-03-11 04:19:23 +00:00
Anthony Dresser
74b89a0a85 No console linting (#9156)
* add no-console linting and change to just using overrides for sql files

* whitespace

* fix tests
2020-02-14 21:13:16 -06:00
Anthony Dresser
56695be14a More layering and compile strictness (#8973)
* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* remove jsdoc
2020-01-29 20:35:11 -08:00
Anthony Dresser
30d9e9c141 Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 (#8722)
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1

* remove tests that aren't working
2019-12-18 00:14:28 -08:00
Charles Gagnon
6cce532ca4 Fix wizard not displaying error messages (#8545) 2019-12-03 17:40:19 -08:00
Charles Gagnon
5b50696a1b Fix more floating promises (#8374)
* Fix more floating promises

* Fix a few more

* Test fixes

* Fix spellings

* More promise fixes

* couple more

* Few more fixes

* One more missed one
2019-11-18 17:11:25 -08:00
Charles Gagnon
18ab2ae799 Remove TelemetryUtils and use IAdsTelemetryService directly (#8289)
* Remove TelemetryUtils and use IAdsTelemetryService directly

* Fix event names and cleanup

* Fix tests

* Fix strict null check
2019-11-13 13:54:55 -08:00
Anthony Dresser
df0c505452 No unused locals (#8231)
* add no unused local

* fix strict null

* fix compile errors

* update vscode comments
2019-11-06 17:22:05 -08:00
Anthony Dresser
ade68b184d Move code around for more linting (#8190)
* testing

* moving around all the code

* fix strict nulls
2019-11-04 10:41:28 -08:00