* added doughnut chart component
* Changing chart to doughnutChart
* reverting to genreic chart component
* adding more chart supoort
* fix minor errors
* resolve some PR comments
* native chartjs, keyboard navigation and chart options
* fix build errors
* fix chart.js/auto error
* resolve PR comments
* modify chartdataset API
* Refactoring (#24327)
* working - displaying chart data with convert
* working - introduced typed properties
* working, added BarChartConfiguration to type param
* removed ChartProperties type param
* Adding doughnut support
* Correcting number vs. point issue
* including the right changes this time
* commenting out no-longer-used labels prop
* remove hardcoded canvasID, enabled Scatterplot config
* Moved graph testing to sample extension
* Reorganizing types; adding test back to assessment dialog
* Adding example for bubble chart
* Polar area working
* cleanup
* adding draw when options isn't set
* Moving chart example configs to other file
* some cleanup
* added some docstrings
* add multiple datasets to test scatter plot
* update scatter plot example in sample
* Adding height/width support
* swapping to `as` cast
* title working
* Settling chart title and legend display
* Adding comments
* updating data working
* Updating samples
* Typo in comment
* Reverting changes made for development
* Elaborating on color in docstrings
* Separating Data and Options in component payloads
* Removing chartId as an exposed property
* Changing chartType property to TChartType
* Fleshing out types file comments
* fixing scoping of chart component properties; renaming chart canvas ID prop
* correct internal chart options typing
* removing commented-out code
* removing unused ChartClickEvent type until data selection eventing is implemented
* renaming function
* deleted commented-out code
* Adding options setters that went missing after splitting Config to Data + Options
* adding type predicates for data conversion
* Adding back type setting (dropped when chart type conversion moved)
* Narrowing type for 'type'
* Fixing typos in docstring
---------
Co-authored-by: Deepak Saini <deepaksaini@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Aasim Khan <aaskhan@microsoft.com>
Co-authored-by: Deepak Saini <deepak.saini1996@gmail.com>
* Transition to withProps in arc
* Transition to withProps inputbox
* Transition to withProps in checkbox
* Transition to withProps text
* Transition to withProps in declarative table
* Transition to withProps hyperlink
* Transition to withProps in button
* Transition to withProps radiobutton
* Transition to withProps in input
* Transition to withProps button
* Transition to withProps in text
* Transition to withProps image
* Transition to withProps declare table
* Transition to withProps in table
* Transition to withProps radio button
* Transition to withProps in image
* Transition to withProps radio button
* Transition to withProps in commit
* Transition to withProps div cont
* Transition to withProps in comp
* Transition to withProps radio card
* Transition to withProps in comp icon
* Transition to withProps card
* Transition to withProps list
While working on the tree control for our extension, I noticed that the sample implementation was not optimal. For instance, `vscode.TreeDataProvider.onDidChangeTreeData` should only be called once for the top-most node that has changed, as all children will be refreshed as well.
This change updates the code of the sample to track state changes during propagation and only raise the event for the top-most parent node that has its state changing.
There also was an issue with root node `1` not rendering, which impacted the new algorithm, as it was not refreshing the tree, when invisible root was changing. In order to address this, I updated `getChildren` to actually return the `1` node, when root was requested. This in turn changed the presentation (`1` is now rendered in the tree) and addressed the problem with tree not refreshing when `1` is the node that raises the event.
Lastly, there is one more optimization that I didn't make due to the bug that is in the works: `getTreeItem` can actually return the `element` directly, without the copy, as it already implements `TreeComponentItem`. The problem currently is that `TreeNode` also defines an `id`, which causes an error during refresh. Once that is addressed - this part can be optimized as well.
- Upate vscode-nls to 4.0.0 in notebook extension. Should be fix for Insiders build failure due to localization package failing
- Updated samples to remove as vscode-nls if not needed, or update if still needed
- Updated samples using `npm audit fix`
- Fixed compile errors in all the samples
* fixed crashes from job dialog and new step dialog group options UI
* added placeholder for retry counters
* fixed alert general UI
* fixed misc dialog errors
* localized all strings
* destroy viewmodel when editor is closed and add example
* support retainContextWhenHidden option for webview component
* fix breaking change from master
* dispose html element during dispose
* add more comments
