Commit Graph

2573 Commits

Author SHA1 Message Date
Aasim Khan
8cc8dcc89c Added loading to dropdowns (#12214)
* Added loading prop to dropdowns

* Added property for setting loading text message

* removed unnecessary sets

* changed code to match new changes

* Changed the dropdown loader to use select component instead of edit.
Added missing props in dropdown loader
2020-09-11 16:57:28 -07:00
Chris LaFreniere
4fee0210f6 Notebooks: Add setting for default text cell edit behavior (#12245)
* Add setting for default text cell edit behavior

* string updates
2020-09-11 16:29:09 -07:00
Lucy Zhang
f99adf3de4 Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240)
* hide link and image buttons in WYSIWYG mode

* defined taskbar actions

* rename arrays
2020-09-11 15:55:06 -07:00
Kartik Arora
3d81da9762 fix bug that doesn't register double click enabled on new notebook contexts (#12239) 2020-09-11 14:42:13 -07:00
Amir Omidi
61ceb72cea Change tables to make them work for our scenario (#12193)
* Change tables to make them work for our scenario

* Comments & deprecate API

* Disable selections by default
2020-09-11 13:44:19 -07:00
Chris LaFreniere
58d3b969a2 Set items in cell model (#12237) 2020-09-11 13:12:41 -07:00
Monica Gupta
f8d725e15b Make SandDance work generically for Kusto (#12229)
* Make SandDance work generically for Kusto and Postgres

* Addressed comments

* removed param

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-11 11:28:30 -07:00
Aasim Khan
a823e44393 Resource Deployment UX Refresh (#12173)
* adding new card to styles

* renamed property, removed unnecessary css

* Fixed to match new props

* added horizontal class

* merged from master
2020-09-11 11:13:59 -07:00
Hale Rankin
6670289057 Hackathon - Better Markdown Editor (#11540)
* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.

* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.

* Modified preview icons

* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.

* add turndown and save markdown

* update model on UI when source changes

* Added conditional that sets element attribute contentEditable when it is in edit mode.

* Added textView component that can be used for editing.

* update source on MD view not on every keystroke

* Added markdown editor buttons that allow user to swap editor, preview views.

* Cleaning up implementation

* Setting base value of _showPreview to false.

* don't allow html edit on split view

* Update editor automagically

* Add an image picking dialog to notebook toolbar.

* Await transformText()

* revert pushEditOperations to fix cursor issue

* Implemented radio buttons for three view toggles.

* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.

* Style tweaks.

* Added new ViewAction file where the RadioButton action will reside.

* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.

* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.

* WYSIWYG 3 Modes

* Ensure one action active at a time

* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.

* Ensure we respect editMode, add showMarkdown

* hiding overflow on code-cell

* Empty text container needs 100% width. Eliminates weird selection border too.

* Initialize _previewMode

* Actions Compatibility

* Further toolbar enhancements

* Update yarn lock after merge

* Slim down changes

* Remove commented out code

* Added margins around notebook-preview container for more visual space for text

* Add turndown to workbench html

* Tweak import

* Add types/turndown

* Remove workbench.html fix

* Import cjs modules directly for turndown

* Leverage solution from github

* browser umd

* non browser umd

* welp dependency

* Modified updatePreview to insert a p tag only when text cell is empty.

* add listener for undo

* add turndown to remote and web

* Fix workbench, check in plugin

* PR comment

Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
2020-09-11 00:22:07 -07:00
Chris LaFreniere
0f8fa0ccef Quick tweaks to resource viewer (v1) (#12210) 2020-09-10 21:57:43 -07:00
Chris LaFreniere
1f0cdf82e4 Notebook Text Cell Highlight Improvements (#12197)
* 1st iteration

* works but multiple highlights

* remove comment

* Works but multiple selects

* wip

* cleanup

* cleanup

* Update TPN

* Add mark.js to remote + web

* PR feedback

* Tweak workbench html files
2020-09-10 21:40:29 -07:00
Lucy Zhang
e3ec6bf9c5 Add grid streaming support for notebooks (#12175)
* add onResultUpdate handler in gridoutput

* convert rows to mimetype and html

* wait for data conversion to finish before saving

* detach changeRef after output is created

* fix save grid action

* move data conversion check to each cell

* move conversion logic to dataprovider

* notify data converting when user saves

* add comments and remove unused methods

* fix method return type

* fix tests

* fix convertData method header

* move azdata changes to azdata proposed

* address PR comments

* display top rows message

* fix messages/table ordering and query 100 rows

* add missing escape import

* set default max rows to 5000

* add undefined check to updateResultSet

* change gridDataConversionComplete return type
2020-09-10 13:31:40 -07:00
Kartik Arora
1528c642d1 Enable double click edit (#12200)
* fix to working version

* add comment documentation

* minor changes based on review

* resolve comments

* remnove unnecessary assignment
2020-09-10 12:18:42 -07:00
Vasu Bhog
ff61eae164 Fixed Kusto change connections for previous notebooks (#12207)
* fix connection dialog for change connection on notebook

* Better way to show all connections for providers

* minor change
2020-09-10 13:20:35 -05:00
Anthony Dresser
8a8137e96c Add initial resource view (#12180)
* add inital resource view

* fix strict compile

* hide resource viewer behind arc

* fix arc detection

* fix hygiene

* add disposable

* make the css more specific
2020-09-09 10:49:14 -07:00
Vladimir Chernov
5ae9495bc6 Sql Assessment fixes (#12169)
* prevent simultaneous actions runs and label fix
* sqltools service version update
2020-09-09 17:54:48 +03:00
Vasu Bhog
3a0be70783 Kusto Kernel New Notebook Changes (#12085)
* Kusto New Notebook Action Changes

* Kusto Cluster properly switches context when kernel changes

* SQL Connections kernel change to Kusto works properly

* Multiple New Kusto Notebooks open properly and change kernels properly

* Fix SQL Notebook - Change to Kusto Kernel

* Fix unit tests

* Address comments

* Add test, and finalize changes
2020-09-09 09:19:36 -05:00
Amir Omidi
a840057cd8 Fix zonejs eating all errors (#12188) 2020-09-08 18:02:34 -07:00
Amir Omidi
9ed274fb39 Genericify components (#12158)
* Genericify components

* Fix compile issue

* Fix feedback

* Genericify azdata components (#12164)

* azdata generics

* Add the withProps method to azdata proposed as there may be mistakes with the interfaces in the generics

* Fix build issues because of other extensions

* Remove extra spaces
2020-09-08 16:15:24 -07:00
Anthony Dresser
f6c63f2dcb strict null chart (#12167) 2020-09-08 15:28:39 -07:00
Anthony Dresser
2b33c7c27f fix query plan css (#12181) 2020-09-08 15:18:58 -07:00
Anthony Dresser
d9b4af1217 strict null check contrib/editorReplace and services/queryEditor (#12166) 2020-09-08 14:06:43 -07:00
Anthony Dresser
3134449b38 Merge branch 'ads-main-vscode-2020-09-05T03-17-37' into main 2020-09-06 13:20:50 -07:00
Anthony Dresser
2b2b9ff44d add debug typings and comment out tests separtely for a few directories (#12163) 2020-09-05 20:32:06 -07:00
Charles Gagnon
3d7d1b23cb Add refresh/edit columns resource viewer actions (#12161)
* Add refresh/edit columns resource viewer actions

* add actions
2020-09-05 07:51:06 -07:00
Anthony Dresser
3b2cd653a7 rerender view on layout (#12143) 2020-09-05 00:27:39 -07:00
ADS Merger
6718c7565d Merge from vscode 892353d48e17303de203bb5071f21ea69573367d 2020-09-05 03:17:42 +00:00
Charles Gagnon
b8d0e2a9e3 Cleanup and fixes for resource viewer and filter plugin (#12154)
* Cleanup and fixes for resource viewer and filter plugin

* fix strict nulls
2020-09-04 19:10:26 -07:00
Anthony Dresser
704222b8d7 remove some vscode differences (#12146) 2020-09-04 18:04:30 -07:00
Anthony Dresser
503090856a Strict null scripting (#12126)
* strict null scripting

* fix compile

* fix tests

* fix icon
2020-09-04 18:04:08 -07:00
Amir Omidi
59bb827d2e Introduce vertical cards (#12125)
* Introduce vertical cards

* Simplify and add a css type

* Feedback

* Update yarn.lock
2020-09-04 15:15:58 -07:00
Maddy
a57379be49 add role on toggelMore action element (#11975)
* add role on toggelMore action element

* add aria-haspopup

* Fix localization and more descriptive

* single localized constant

Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
2020-09-03 23:37:39 -05:00
Charles Gagnon
787245b058 Don't propagate click when clicking on header filter (#12130) 2020-09-03 21:36:11 -07:00
Amir Omidi
1e5ab4d9f0 remove unnecessary import (#12129) 2020-09-03 21:17:58 -07:00
Anthony Dresser
b1ce53ade3 Merge branch 'ads-main-vscode-2020-09-03T02-34-50' into main 2020-09-03 19:05:37 -07:00
Charles Gagnon
1b4f6f8934 Add Data Grid Provider API (#12097)
* Add RegisterResourceDataProvider API

* Change to data grid provider

* fixes

* updates
2020-09-03 17:55:25 -07:00
Anthony Dresser
4eb98a9dcc fix hygiene
remove sqllint for now

fix hygiene

Revert "remove sqllint for now"

This reverts commit 981ff90b9a5bbf3710d0f0ce58a8b67a92fe64eb.

distro

update smoke version

fix default theme
2020-09-03 16:27:59 -07:00
ADS Merger
a63578e6f7 Merge from vscode 7eaf220cafb9d9e901370ffce02229171cbf3ea6 2020-09-03 16:27:57 -07:00
Alan Ren
39d9eed585 give back the getter for container property (#12110)
* give back the getter for container property

* parameter type
2020-09-03 13:59:38 -07:00
Anthony Dresser
b7c2eaa65d strict compile contrib/backup (#12088) 2020-09-03 11:50:53 -07:00
Charles Gagnon
887ce88100 Fix tree view icons (#12095) 2020-09-02 18:46:34 -07:00
Anthony Dresser
65e253ae0d attempt to adjust timing (#12064)
* attempt to adject timing

* add another animation frame wait

* add another debounce
2020-09-02 13:35:55 -07:00
Anthony Dresser
a6314b57b7 Add different flag for azure dialog (#12073)
* add different flag for azure dialog

* missing code change

* rename browser to browse
2020-09-02 13:35:36 -07:00
Charles Gagnon
e6d250c640 Base resource viewer editor (#12039)
* Base resource viewer editor

* Use table more directly

* Dispose listeners

* Fix strict compile

* undo

* More strict fixes

* Remove theming logic

* comments

* more fixes

* cleanup

* Remove actions contribution
2020-09-02 13:02:58 -07:00
Anthony Dresser
c982ea338d Update strict compile numbers (#12087)
* update strict compile numbers

* fix json
2020-09-02 12:15:16 -07:00
Anthony Dresser
8b8bef0401 add strict compile for restore (#12067) 2020-09-02 11:58:30 -07:00
Anthony Dresser
d8dcc90857 Strict nulls for contrib/restore and contrib/views (#12044)
* strict nulls for contrib/restore and contrib/views

* remove unnecessary function

* compile error
2020-09-01 17:53:29 -07:00
Monica Gupta
5d4afae616 Sets language mode based on connection type (#12065)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-09-01 15:43:37 -07:00
Alan Ren
b0211b434a fix the issue that error dialog is not showing (#12061) 2020-09-01 13:08:38 -07:00
Amir Omidi
7ceee95f52 radio card change (#12049)
* radio card change

* Clone the object

* freeze change description

* Change to deepClone
2020-09-01 12:06:38 -07:00