Hale Rankin
8f6c5af94f
Cleaned up code for Add cell button in both main toolbar and cell toolbar. Corrected toolip to read: Add cell. ( #10829 )
2020-06-26 13:46:31 -07:00
Hale Rankin
8d7b3ef6ec
Cell toolbar More Actions menu -- remove duplicate separators ( #10827 )
...
* Added code to remove multiple separators from more actions menu.
* Moved check for separators after list is deduped.
* Logic cleanup
* Added unit test for cell toolbar ellipses menu.
* Fix tests
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2020-06-26 13:45:53 -07:00
Arvind Ranasaria
c2ef27cd68
Second batch of tests for notebookEditor class ( #10999 )
...
* first few notebookEditor tests
* formating fixes
* unstash previous unfinished work
* saving
* PR feedback
* PR feedback
* copyright fixes
* improve test names and assertion messages
* saving
* PR feedback
* improve test names.
* test name change
* test name change
* remove unneeded cast
* remove spurious comment
* fix misplaced paranthesis - thanks hygiene checker!
* remove unused code
* remove deferredPromise
* createEditor test and dispose fixes
* remove unneeded import
* rempve unnecessary mock usage in dispose test
* use getContainer() for ['parent']
* use getContainer for ['parent']
* remove launch.json edits
* notebookService needs 9th constructor argument
* Add uploading debugging step
* minor changes
* remove changes to ci.yml
* working version
* formatting fixes
* pr fixes
* hygiene and exception path fixes
* remove minor debug changes
* pr feedback
* pr feedback
Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com >
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2020-06-24 13:19:12 -07:00
v-bbrady
17621e4df3
builds getting started tour ( #10546 )
...
* builds getting started tour
* reorganizes ts according to amirs comments
* Fix hygiene issues
* updates class names
* adds description to new configuration value
* uses core components
* PR fixes based on Charles comments
* formats css
* updates guided tour based on charles comments
* updates css formatting
* fixes read more link
* formats gettingStartedTour.ts
* updates copy
* Add CodeQL Analysis workflow (#10195 )
* Add CodeQL Analysis workflow
* Fix path
* updates pr based on pr comments
* removes unused decleration
* formatting
* reformats css document
* updates file path
* updates images
Co-authored-by: Amir Omidi <amomidi@microsoft.com >
Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com >
2020-06-23 18:59:02 -07:00
Charles Gagnon
a303144226
getCredentials returns credentials for any saved connection ( #11029 )
...
* getCredentials returns credentials for any saved connection
* Update doc comment
* Add tests
* cleanup
* cleanup
2020-06-23 11:04:13 -07:00
Chris LaFreniere
98ff618efd
Add deprecated tag for standardKernels property ( #11038 )
...
* Remove unnecessary prop from NotebookProvider API
* Add deprecated tag
* make standardKernels required again
* tweak comment
2020-06-22 21:15:39 -07:00
Alex Ma
e01723f195
Additional tests for connection ( #10944 )
...
* Added providerRegistered test
* test for EditConnectionDialog
* changed wording
* added test for connectionInfo
* utils.ts tests added
* hasRegisteredServers test
* commented out editconnection tests, addl. tests
* added onConnectionChangedNotification test
* added changeGroupId tests
* Added connection profile changes
* added connectIfNotConnected test
* added delete connection test
* isRecent and disconnect editor tests
* added registerIconProvider test
* Fix for ensureDefaultLanguageFlavor test
* added a few tests
* utils prefix test updated
* added utils tests
2020-06-22 13:51:39 -07:00
Laura Jiang
47f91b8efb
fix typo ( #11021 )
2020-06-19 17:04:44 -07:00
AzureDataStudio
c4c23aa40d
remove unused workflows
...
fix tests
disable vscode integration tests
distro
bump smoke test extension
ensure we register language register
fix compile
2020-06-19 10:59:24 -07:00
ADS Merger
5e7071e466
Merge from vscode 4d91d96e5e121b38d33508cdef17868bab255eae
2020-06-19 10:59:23 -07:00
Alex Ma
95107f1f61
Fix for auto resize column headers, ( #10909 )
...
* Fixed scroll to top
* removed brackets
* Don't trigger the cellSelectionModel when className is the resizable handler
* Added message for header listener
Co-authored-by: Amir Omidi <amomidi@microsoft.com >
2020-06-17 15:22:05 -07:00
Charles Gagnon
487bd2693e
MIAA Dashboard Updates ( #10960 )
...
* Add database info to MIAA dashboard
* hook up open in azure button
* Only use plural text
2020-06-17 12:35:14 -07:00
Amir Omidi
21fd8b22e7
Fix a memory leak on listener ( #10294 )
...
* Fix leak
* We don't need the full connection profiles for drag drop control
* Remove unused code
* Change test definition
* Change test definition
* Change equality check
2020-06-16 19:36:10 -07:00
Charles Gagnon
fb4e400919
Make property container values selectable ( #10946 )
2020-06-16 15:08:16 -07:00
Anthony Dresser
381a747b62
fix export for remote ( #10934 )
2020-06-16 12:10:05 -07:00
Alex Ma
f13a5954a9
Port of Maddy's Edit Data Line Fix ( #10676 )
2020-06-16 10:13:17 -07:00
Christopher Suh
0c56e4a603
Column/Table Drag & Drop ( #10702 )
...
* able to drag objects from left pane
* changed scheme from file
* base functionality working
* extended functionality to tables
* added string literals and formatting
* cleanup
* cleanup
* added table/column parsing
* removed bad logic
* updated to use metadata
* cleanup and added sql carbon edit tags
* moved changes from vs into sql code base
* refactoring drag and drop
* cleanup
* cleanup
* cleanup
* added unit tests
* pr changes
* moved treeMock file
* fixed small bug
2020-06-15 23:52:46 -04:00
Arvind Ranasaria
f02e2a4b72
Initial unit tests for class NotebookEditor ( #10926 )
...
* first few notebookEditor tests
* formating fixes
* PR feedback
* PR feedback
* copyright fixes
* improve test names and assertion messages
* PR feedback
* improve test names.
* test name change
* test name change
* remove unneeded cast
* remove spurious comment
* fix misplaced paranthesis - thanks hygiene checker!
* remove unused code
* remove deferredPromise
* rempve unnecessary mock usage in dispose test
* use getContainer for ['parent']
* notebookService needs 9th constructor argument
* Add uploading debugging step
* remove changes to ci.yml
Co-authored-by: Arvind Ranasaria MacPro <arvranmac@MININT-OE7B592.fareast.corp.microsoft.com >
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2020-06-15 15:27:42 -07:00
Anthony Dresser
16c27baf10
maintain scheme in insights ( #10904 )
...
* maintain scheme in insights
* fix compiles
* fix tests
* handle undefined
* fix windows tests
* fix imports
* handle remote resources
2020-06-15 14:23:31 -07:00
Brian Bergeron
a5cd755e41
support table with for DeclarativeTableComponent ( #10881 )
2020-06-15 10:12:49 -07:00
Maddy
26a00696d4
Fix/prev next links issue ( #10523 )
...
* intital test code
* added tests
* remove commented code
* fix for failing tests
* reuse exported enum
* changes to address comments
* add back onVisibility highlight
* port highlight fix from Chris
* fix tests
2020-06-12 18:42:17 -07:00
Amir Omidi
3608e132cb
Add close button ( #10898 )
...
* Add close button
* Change the localize key
2020-06-12 13:03:18 -07:00
Amir Omidi
83a8b13750
If the connectionProfile was undefined, then return undefined ( #10899 )
2020-06-12 12:46:34 -07:00
Anthony Dresser
535e9d012a
add getting started to contribution ( #10892 )
2020-06-12 12:21:04 -07:00
Anthony Dresser
46f72fef6a
change icon locations ( #10884 )
...
* change icon locations
* fix icon location
2020-06-11 17:10:29 -07:00
Charles Gagnon
8db272cea4
Fix deployment warnings to only show if no resources found ( #10878 )
2020-06-11 17:07:19 -07:00
Alan Ren
4322234d0b
use default row height and update button column ( #10885 )
2020-06-11 16:09:25 -07:00
Aasim Khan
bb244e4b91
Passing contained component required field to itemConfig ( #10858 )
2020-06-11 08:42:54 -07:00
Alan Ren
3f21caddb6
fix declarative table issue ( #10833 )
...
* fix declarative table issue
* check data
* comments
* comments and more fixes
2020-06-10 22:21:45 -07:00
Charles Gagnon
c6d494e160
Change "configure dashboard" icon ( #10856 )
2020-06-10 14:52:36 -07:00
Hale Rankin
6c68d742a7
Fixed notebook toolbar icon issue in dark and hc-black themes. ( #10802 )
2020-06-09 13:52:47 -07:00
Cory Rivera
59575aa305
Wait for clientSession to become available before running a cell. ( #10796 )
2020-06-09 05:30:13 -07:00
Alan Ren
7687d6e22a
reset valid status ( #10813 )
2020-06-08 22:53:45 -07:00
Aasim Khan
75e3e4c8c9
Fix for "Run Current Query" keybind no longer behaving as expected ( #10538 ) ( #10557 )
...
* -"Run current" command runs the entire selection instead of only first statement in the selection
* -brought some logic back from the old code to correct the behavior
* -Added unit tests for runCurrent command
* -Fixed a comment
* - Added checks for run input parameters
* -Added some extra checks
* -Fixed some spacing issue
* Changed to using verify instead of a counter variable
2020-06-08 14:42:07 -07:00
Alan Ren
9ca17dbe7f
fix button column click issue ( #10788 )
2020-06-08 11:48:50 -07:00
Amir Omidi
d08a224550
Fixes #10734 , register a container for the view ( #10750 )
...
* Fixes #10734 , register a container for the view
* Remove unused fields
2020-06-08 11:06:04 -07:00
Hale Rankin
52a12f0d51
Removed style that was interfering with text selection within code cell. ( #10769 )
2020-06-05 17:51:23 -07:00
Hale Rankin
eafe659ec9
10712, 10677 - Fixed focus indicators for both main toolbar and cell … ( #10756 )
...
* 10712, 10677 - Fixed focus indicators for both main toolbar and cell toolbar.
* Removed duplicated line
2020-06-05 17:46:19 -07:00
Hale Rankin
4339b5b7d3
Switched order of the two dropdowns in main toolbar in preview. ( #10717 )
...
* Switched order of the two dropdowns in main toolbar in preview.
* Reverting this single line b/c it's out of scope for the PR.
2020-06-05 17:41:14 -07:00
Anthony Dresser
72b2d9ef72
rework some of some, add query to smoke ( #10591 )
2020-06-05 17:25:24 -07:00
Hale Rankin
cf0f3b0426
Reduced margin between notebook cells. Increased space at top of page. ( #10735 )
2020-06-05 17:17:19 -07:00
Chris LaFreniere
48ec8e6dd8
Bring back hover state setting on cell model ( #10758 )
2020-06-05 17:14:36 -07:00
Alan Ren
3500ce08cc
fix profiler not launch issue ( #10757 )
2020-06-05 15:41:29 -07:00
Alex Ma
1f519024db
Fix for edit data grid not showing ( #10737 )
...
* Added null check in getHorizontalSashWidth
* simplified using tertiary operator
* more simplification
2020-06-05 13:32:16 -07:00
Amir Omidi
70af4cbe42
Fixes the azure auth for postgresql ( #10662 )
2020-06-04 16:01:50 -07:00
Chris LaFreniere
258310ba81
Change markdown cell to text cell ( #10715 )
2020-06-04 12:38:30 -07:00
Chris LaFreniere
cc3554e987
Only show edit cell action for markdown cells ( #10719 )
2020-06-04 10:20:47 -07:00
Amir Omidi
ce17a73ede
Open connection dialog with URI ( #10700 )
...
* Add the openConnectionDialog code
* don't ignore case
2020-06-03 16:53:13 -07:00
Brian Bergeron
65a31de166
Add readOnly property to InputBoxComponent ( #10687 )
2020-06-03 14:59:54 -07:00
Anthony Dresser
a68e74527e
Merge branch 'ads-master-vscode-2020-05-31T19-47-47'
2020-06-03 14:05:57 -07:00