90ef8e4907e17cecd56be2145c3c8ae8de235820
138
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Alex Ma
|
cffba368a9 |
Added reset password dialog upon SQL Server expired password error (#21295)
* Added initial password connection dialog box * made small changes * more preliminary work * more WIP changes * more cleanup done * added dialog instantiation * added placeholder dialog window * added changePasswordController * made some changes to changePasswordController * some changes made * added more changes * more changes made to dialogue * added password confirm box * added WIP change password function * small changes made to API * small changes for test * added uri * added valid password * added TODO comments * added small change to connectionManagementService * added connectionManagementService password change * added comment on what to do next * made some simplification of change password * added response callback * added fixes to protocol * added throw error for passwordChangeResult * WIP added call to self after password change * WIP changes to implementing new password change dialog * added changes to passwordChangeDialog * added launchChangePasswordDialog * remove erroneous css * added working dialog * removed old password change dialog * fixed space * added checkbox option to passwordChangeDialog * added test signatures * added error handling * added some changes * added changes to HTML for passwordChangeDialog * added CSS to passwordChangeDialog * added display none for matching passwords * added documentation changes * small cleanup * added working error catch and retry * added await * added recovery instructions * Added ok button hide for button click. * added loading spinner * fixed for semicolon * added updated message * Added message change * added minor fixes * added small fixes * made more changes * renamed messages to errorDetails * added styling to passwordChangeDialog * simplified error message * changed comment * modified azdata to be consistent * small changes * change to azdata for consistency * added clarification for provider * removed additional instructions * Added new dialog title * addressed feedback * added comments * added changes |
||
|
Aasim Khan
|
c0a194df4a |
Adding wizard and dialog footer loading spinner (#21230)
* Adding wizard and dialog loading * Moving apis to proposed * fixing namespace * Only firing event when the value changes * Only firing when value is changed * Adding loading complete message to dialog and wizard * Registering listeners and making a new base interface for loading components * Fixing api comment * Renaming prop to loadingCompleted * old loading icon |
||
|
Cory Rivera
|
728a90cd53 | Move New Notebook command to core (#21247) | ||
|
Cory Rivera
|
a37d6230f9 | Remove API compatibility layer for VS Code notebook extensions (#21225) | ||
|
Cory Rivera
|
facd317b4d | Create untitled notebook names in core code rather than in the notebook extension (#21111) | ||
|
Karl Burtram
|
8a3d08f0de |
Merge vscode 1.67 (#20883)
* Fix initial build breaks from 1.67 merge (#2514) * Update yarn lock files * Update build scripts * Fix tsconfig * Build breaks * WIP * Update yarn lock files * Misc breaks * Updates to package.json * Breaks * Update yarn * Fix breaks * Breaks * Build breaks * Breaks * Breaks * Breaks * Breaks * Breaks * Missing file * Breaks * Breaks * Breaks * Breaks * Breaks * Fix several runtime breaks (#2515) * Missing files * Runtime breaks * Fix proxy ordering issue * Remove commented code * Fix breaks with opening query editor * Fix post merge break * Updates related to setup build and other breaks (#2516) * Fix bundle build issues * Update distro * Fix distro merge and update build JS files * Disable pipeline steps * Remove stats call * Update license name * Make new RPM dependencies a warning * Fix extension manager version checks * Update JS file * Fix a few runtime breaks * Fixes * Fix runtime issues * Fix build breaks * Update notebook tests (part 1) * Fix broken tests * Linting errors * Fix hygiene * Disable lint rules * Bump distro * Turn off smoke tests * Disable integration tests * Remove failing "activate" test * Remove failed test assertion * Disable other broken test * Disable query history tests * Disable extension unit tests * Disable failing tasks |
||
|
Charles Gagnon
|
603ae9b94c |
Fix queryDocument.connect (#20682)
* Fix queryEditor.connect * Remove decorator * undo * fix test * Use connectionProfile for comparison * remove unused * Remove helper method |
||
|
Alan Ren
|
be8bf7fcdc |
handle unsupported connection provider (#20577)
* handle unknown connection provider * fix error |
||
|
Lewis Sanchez
|
7de5ee0427 |
Adds functionality to open execution plans from DB tables and DMVs. (#20377)
* Adds functionality to open execution plans from DB tables and DMVs. * Code review changes * Renames method to getProviderFromUri |
||
|
Karl Burtram
|
26455e9113 |
Merge vscode source through 1.62 release (#19981)
* Build breaks 1 * Build breaks * Build breaks * Build breaks * More build breaks * Build breaks (#2512) * Runtime breaks * Build breaks * Fix dialog location break * Update typescript * Fix ASAR break issue * Unit test breaks * Update distro * Fix breaks in ADO builds (#2513) * Bump to node 16 * Fix hygiene errors * Bump distro * Remove reference to node type * Delete vscode specific extension * Bump to node 16 in CI yaml * Skip integration tests in CI builds (while fixing) * yarn.lock update * Bump moment dependency in remote yarn * Fix drop-down chevron style * Bump to node 16 * Remove playwrite from ci.yaml * Skip building build scripts in hygine check |
||
|
Charles Gagnon
|
ed5a64f80f |
Switch query events to just send ranges instead of full query text (#19823)
* Switch query events to just send ranges instead of full query text * undo azdata changes * fix type * comment + remove unneeded ? |
||
|
Charles Gagnon
|
f7286b8e81 |
Add queryInfo to query events (#19777)
* Add queryInfo to query events * docs |
||
|
Charles Gagnon
|
41a3c8661c | Fix GetConnection (#19579) | ||
|
Aasim Khan
|
8bb6b5fc1a |
Redoing Execution Plan Comparison Editor (#19375)
* Adding code for execution plan comparison editor * Handling floating promises and fixing a loc string * Fixing some polygon stuff * Fixing azdatagraph null check bug * Adding progress notification for similar areas * Removing some floating promises * Fixing button enabled state |
||
|
Nemanja Milovančevićandchgagnon
|
65ef41d53d |
UI for the Backup/Restore Managed Instance Feature (#19244)
* Rebase from main branch * Made mssql a module * remove rpc specific stuff * Added create sas RPC call * Backup to url works now * Moved createSas RPC to the BlobService * Relocated createSas RPC from sql-dataprotocolclient to the mssql * After rebase * Removed duplicate symbol * Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension * Removed AzureBlobProvider, removed AzureBlobService feature * renamed blob to azureblob, converted thenable to promise * Simplify API * fixes * docs update, blob to azureblob update * UI design first commit * Detected Managed Instance, trying to script backup to url * azure subscription api added, but ADS crashes * Created url dialog component and added link account * Changed backup component UI logic * Changed b/r UI, added restore from URL, detected MI from restore component * Removed mocked and added real Azure API, changed RestoreDialog UI * Added file fetching API * added create sas RPC call * Backup to url works now * Fixed some bugs * Moved createSas RPC to the BlobService * Relocated createSas RPC from sql-dataprotocolclient to the mssql * Rebase createSas changed to the backupRestoreManagedInstance * PR comments fix * Enabled backup to url for gov clouds * Replaced anchor element with Link class * Fixed pick azure account logic * Removed duplicates from eslintrc * Fixed url browser dialog * Fixed restore UI, disabled url empty url browser dropdowns, fixed backup OK button * bumped sts version * bumped sts version * Fix config * Fixed URL browser dialog UX * Backup and restore dialog fix * Referencing azure resource types directly * Scoped url browser dialog css classes * Made the url browser dialog field a local variable * moved url browser files from fileBrowser to the urlBrowser folder * Changed deviceType from number to enum * Added all device type options * Moved mssql * Added MI backup button comment * Removed unhelpful comment * Revert differential copy only backup mistake * Renamed azurebrowser to urlBrowserDialog * Localize create sas button label * Removed unnecessary spinner * Use UTC date instead of locale date * Removed * and added required flag * Use async instead of nested thens * Added target database tooltip * Using deferred promise instead of event emitter * Added error handling to the url browser dialog * Registered backup component elements * Register backup component listeners * Removed redundant setDefaultBackupPaths call * Added setBackupPathList docs * Add return types * Remove code from comment * Register restore dialog elements * Register restore dialog listeners * Pass engine edition enum instead of boolean * Capitalize enum values * DatabaseEngineEdition fix * Use DeviceType instead of number * Use deferred pointer * Add new ModalDialogName * Use constructor fields * Register URL browser dialog components * Remove unnecessary helper function * nextYear function doc and move * split registerListeners method * showDialog returns promise * Backup device type comment * Pass aria label through constructor * Fix backup button * Remove comment * Comment unsupported MI backup options * Remove one liner helper function * Restore dialog methods return types * Remove comment * JS doc format * Renamed UrlBrowserDialog to BackupRestoreUrlBrowserDialog * Moved MediaDeviceType, added PhisicalDeviceType * Reorder and rename physical device type * remove extra spaces Co-authored-by: chgagnon <chgagnon@microsoft.com> |
||
|
Nemanja Milovančevićandchgagnon
|
1cf905a7b8 |
Create shared access signature RPC (#18823)
* Rebase from main branch * Made mssql a module * remove rpc specific stuff * Added create sas RPC call * Backup to url works now * Moved createSas RPC to the BlobService * Relocated createSas RPC from sql-dataprotocolclient to the mssql * After rebase * Removed duplicate symbol * Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension * Removed AzureBlobProvider, removed AzureBlobService feature * renamed blob to azureblob, converted thenable to promise * Simplify API * fixes * docs update, blob to azureblob update * bumped sts version * Fix config Co-authored-by: chgagnon <chgagnon@microsoft.com> |
||
|
Chris LaFreniere
|
af3d307d40 |
Restart kernel initial implementation (#18835)
* Restart kernel initial implementation * Update notebook extension TestKernel * PR comments |
||
|
Aasim Khan
|
a0c2dc199e |
Adding Execution Plan Editor to ADS (#18696)
* Pushing Execution Plan Editor * Renaming class Handling error * Awaiting for handlers to be registered * Addressing some PR comments * Fixing return type for provider * Fixing editor id and removing unnecessary overrides * Adding a namespace * adding execution plan namespace * Adding protocol comment * Fixing if logic * Fixing error message * Cleaning up code * cleanup code * Adding help comments * Fixing method call * Using path.ts to get the base file name * converting to lambda functions * Adding comment for run action * Fixing pr comments * Fixing editor label * Fixing doc comments * Adding some more comments * Fixign branding in comments |
||
|
Cory Rivera
|
95980130c8 | Correctly handle creating and saving untitled notebook .dib files. (#18744) | ||
|
Aditya Bist
|
822199c9be |
add ability for md + text reports (#18667)
* add ability for md + text reports * change report type * re add types for ads * match fields and add enum for mimetype * rename preview report * update type * rename generate report type * fix comment |
||
|
Alan Ren
|
e50bded5d1 |
table designer new features (#18682)
* support graph tables * ignore script compare * ability to refresh view after edit * reserve focus after refresh view * primary key and default constraint * bug fixes * vbump sts * comments * update type * fix issue |
||
|
Cory Rivera
|
ffdefd3b52 |
Add notebook extension support for .NET Interactive. (#18334)
* Also updated kernel dropdown to only include SQL aliased kernels when using SQL notebook provider. |
||
|
Charles Gagnon
|
5547c2baba | Add AzureAccount service (#18502) | ||
|
Alan Ren
|
c535c2dbde |
table designer improvements (#18206)
* new table experience * new table info for existing table * allow delete confirmation * fix editor lock isue * vbump sts * PR feedback |
||
|
Aditya Bist
|
de5090e47a |
Added data points for Table Designer (#18182)
* added server infor and metrics for table designer * update generate script * pr comments * format more files * pr comments * make changes to core * remove unused imports * add server info * revert enum change and add publish event * format doc * nitpicks * remove os version * remove modifier from telemetry info * remove error message |
||
|
Cory Rivera
|
050d2cc98f |
Enable VSCode extension APIs for opening notebooks. (#18080)
* Also moved notebook conversion classes to a common folder, and moved several conversion utility methods to a common file. |
||
|
+10
|
ff84cc17c4 |
save/generate script for table designer (#17972)
* save changes
* refactoring
* update height
* Register undo redo command (#17948)
* register undo redo command
* sql-migration vbump 0.1.12 (#17955)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects (#17954)
* fix pre/post deploy scripts getting double counted in the files for sdk style projects
* add test
* update comment
* vbump sql database projects to 0.15.0 (#17956)
* LEGO: check in for main to temporary branch. (#17957)
* null check before calling isDisposable (#17959)
* Updated credentials system (#17888)
* linting
* added flags
* remove testing values
* format
* format doc
* tested in linux
* remove unused interface
* comments
* review comments
* clean imports
* pr comments
* format doc
* changed promise location
* insiders december
* pr comments
* test ado change
* fix test
* comment out code for hygiene
* remove unused imports
* test creds from client only
* remove unused import
* trying enabling keytar
* trying enabling keytar
* disable in correct script
* print statements
* remove print statements
* check mock output
* add linux check
* remove print statements
* Consolidate INotebookEditOperation interfaces (#17944)
* Add redo action for split cells (#17947)
* add redo action for split cells
* Handle delete folder for SDK style sql projects (#17961)
* handle delete folder for sdk style projects
* cleanup
* compare original sqlproj contents
* remove redundant checks
* enable find in cell output when output is a data stream (#17759)
* initial changes
* add isCodeOutput and apply decorations on output
* Add extension gallery update reminder action (#17644)
* Fix extensionsGallery.json name (#17646)
* Remove galleries list action (#17648)
* multi-level table support (#17638)
* multi-level table support
* comments
* address comments
* add period to end of sentence.
* Show connection string example for add sql binding quickpick (#17650)
* add connection string example
* reorder
* Resolves same-origin-policy violation when ADS web is running in a container (#17555)
* Stops appending port to authority for web mode
* Clarifies comment
* Adds missing sql carbon edit tag
* vbump STS (#17653)
* use latest STS (#17658)
* Refactoring readProjFile() (#17637)
* move reading project parts to different helper functions
* cleanup
* remove comment
* addressing comments
* Corrects Web Build Pipeline ENOENT Error (#17656)
* Checks for successful directory creation
* Revert "Checks for successful directory creation"
This reverts commit 372409ef323f0d82e11992bc7bc33d607a7d5581.
* Checks for the existence of the logs directory before accessing.
* Adds SQL carbon edit comment
* Removing call to copy from non-existing directory.
* Removes unneeded import
* Checks for file existence before copying.
* Provides explanation for modification
* Replaces file existence check with exception handling.
* Bump tools service (#17671)
* Apply changes from Remote Database to sqlproj - mssql changes (#17655)
* update project from database
* update project from database
* update project from database
* Re-adding schemaComparePublishChanges for temporary backcompat
* Adding comment for keeping enum values in sync
* Correcting enum value
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* update add file/folder for msbuild sdk style projects (#17660)
* update add file for msbuild sdk style projects
* also handle add folder
* fix comment
* fix issue reported by component governance (#17678)
* update json-schema version
* remove unused packages
* update package.json
* SQL Binding: Give default connection setting name (#17659)
* show sqlconnectionstring in quickpick
* fix duplicate sqlconnectionstring setting
* add (new)
* add sqlconnectionstring as default setting name
* check if sqlconnectionstring already exists
* Provide aria-labels for node checkboxes in the tree view. (#17676)
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
* Respect ARIA label specified int he tree component options. (#17674)
During accessibility testing it was discovered that tree view in our wizard reads "Tree Node tree view" instead of the proper label that is specified. It turned out to be the problem with the tree component, where `ariaLabel` was hardcoded to "Tree Node", instead of the one provided in the options.
This change addresses the problem by passing through `ariaLabel` from the options object to the underlying tree control. I also removed the default `Tree Node` hardcoded label, as it didn't make much sense. This does mean that all tree-views that do not explicitly specify their aria-label will now get an empty label. I think this is better than having unrelated, unlocalized `Tree Node`.
I'm also worried about changes to the `ariaLabel` property after the component was initialized. I updated the code to propagate the value to the underlying tree view in the `setProperties` override of the tree component and hope that it will take care of it.
* Fix sql projects net6 warnings (#17673)
* fix .net 6 error showing on startup
* fix double warning
* addressing comments
* update key string
* undo adding space in net core sdk location setting (#17684)
* update names for msbuild sdk style projects (#17677)
* update names for msbuild sdk style projects
* remove msbuild from names
* update comments
* Designer: property descriptions (#17668)
* format
* added strings
* format doc
* use codicon instead
* show descriptions in property pane only
* fix ssdt string bug
* fix overflow option
* review comments
* review comments
* changes
* sts 156 vbump (#17683)
* Sql Binding: Add "Check out pane for more details" when nuget package download fails (#17680)
* check output for more details
* detail error
* wait for result from showerrormessage
* [Loc] Update to sql-database-projects and sql.xlf (#17687)
* update the vmImage for build jobs (#17689)
* update vmImage for windows build
* update tar command
* use specific macos version
* support building msbuild sdk style projects (#17675)
* support building msbuild sdk style projects
* fixes after merge
* add foreign keys and constraints (#17697)
* foreign keys and constraints
* refactoring
* fix issues
* properties pane improvements (#17700)
* [Loc] update to tabledesignercomponentinput (#17704)
* Add instructions for developing VS Code version of sql-database-projects (#17705)
* Adding UI for deploying a db proj to docker (#17495)
* code refactoring (#17706)
* Improve accessibility for wizard steps navigation (#17669)
Our extension is relying on the wizard dialog. During accessibility testing it was discovered that wizard step buttons are being reported as links by the screen reader (NVDA, JAWS). Claimed expected behavior by the tester is that they should be announced as buttons.
I discussed this issue with accessibility SMEs and they said it is perfectly fine to keep them as links. They did mention that they would probably design the UX differently from the start, but given that we already have it this way, links are fine. They did suggest to add few additional ARIA attributes to the link elements:
- `aria-current="step"` if the link is for the currently active step. This literally just announces "current step" at the end, when you focus on a link
- `aria-disabled="true"` makes it say "**unavailable**; link; *<step number>*" when in NVDA "browse" mode and move to the grayed-out link.
So this change implements the said improvements.
* bump sts version to 159 (#17709)
* LEGO: check in for main to temporary branch. (#17699)
* LEGO: check in for main to temporary branch. (#17702)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* [Loc] update to sql-database-projects (#17713)
* LEGO: check in for main to temporary branch. (#17715)
* Register additional editor overrides when adding new notebook file types (#17708)
* Also standardized file extension contributions to always start with a period, and to always do lower case string comparisons for file extensions.
* input width in designer (#17714)
* Add additional properties to wizard page navigation events (#17716)
* Fix open external not working (#17717)
* save password checkbox fix (#17718)
* save password checkbox fix
* remove code to reset the checkbox value
* allow build to continue when cache task fails (#17720)
* cache task should not fail the build
* update cachesalt
* Fix language flavor change on connection when in sqlcmd mode (#17719)
* Fix language flavor change on connection when in sqlcmd mode
* comment + fix
* LEGO: check in for main to temporary branch. (#17722)
* LEGO: check in for main to temporary branch. (#17724)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Update one more variable name for sdk style projects (#17710)
* LEGO: check in for main to temporary branch. (#17725)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17726)
Co-authored-by: Alex Ma <alma1@microsoft.com>
* LEGO: check in for main to temporary branch. (#17730)
* Fix "unsupported version" error when adding sql binding package (#17721)
* Apply changes from remote database to sqlproj - schema-compare changes (#17679)
* update project from database
* update project from database
* Merge from main
* Removing dupe test stub
* PR feedback
* cleanup
* PR feedback
* Fixing tests, adding stubs to update sqlproj as schema compare target
* updating code comment
Co-authored-by: Noureldine Yehia <t-nyehia@microsoft.com>
* [Loc] Update to schema-compare XLF (#17733)
* Enabled deployment of Azure Arc data controllers in directly connected mode (#17707)
* Added fields for connectivity mode, custom loc, auto-metrics, auto-logs, and the dynamic enablement of such fields.
* Changed the description of the data controller details page.
* Change notebook params to work for direct mode
* Added login to dc deployment notebooks
* Fixed auto upload metrics and logs true/false, separated login into another cell.
* Removed localization of indirect and direct connectivity labels.
* Fix ordering of reading sqlproj Build Includes and Removes (#17712)
* evaluate includes and removes in order in sqlproj
* fix after merge
* fix comment
* update comment
* Add resource deployment samples for (#17734)
* Update remove file for sdk style sql projects (#17688)
* add support for removing file in new style project
* fix test
* only load files, not whole project when checking if a <Build Remove> needs to be added
* merge changes
* fixes after merge
* [Loc] update to Arc XLF (#17737)
* Bump to latest version of azdata (#17735)
* Remove .net 6 version cutoff for building sql projects (#17736)
* remove .net 6 version cutoff for building sql projects
* Revert "Warning when .NET 6 SDK is detected (#17422)"
This reverts commit
|
||
|
Charles GagnonandCory Rivera
|
4a2b31f3ba |
Hook up Notebook execution edits (#17943)
* Start rerouting VSCode cell execution APIs. * Add more conversion code. * Convert VSCode notebook registrations into ADS equivalents. * Update vscode notebook provider kernels when notebook controller's supportedLanguages are set. * Update an error message. * Add another session argument. * Add base classes for converting notebook serializers. * Disable some vscode notebook methods. * Disable more vscode APIs. * Disable more stuff. * Start implementing serializer notebook data conversions. * Use direct references to extension host notebook methods, rather than azdata ones. * Add a comment. * Remove a space. * Use import type to fix module loading errors. * Use internal cancellation token class. * Start adding cell output conversion. * Convert data from byte array to a string. * More output work. * Use a Set for proxy filtering. * Start adding tests. * Include metadata in cell conversion. Fix other test failures. * Fix serialize tests. * Add more tests. * Remove wildcard characters from vscode filenames. * Start implementing session details. * Add more kernel info. * Add kernel spec. * Add Future callback wrapper class. * Start implementing execute conversion. * Pass notebook URI to requestExecute. * Start working on CellExecution methods. * Move some code around to fix layering issues. * Use proxy to access browser code, rather than direct imports. * Move files around to fix layering issues. * Remove unused imports. * Start implementing some notebook cell execution behaviors. * Revert some unnecessary extHost API changes. * Check for nbformat. * Also handle nbformat in serialize case. * Active notebook extensions when resolving NotebookInput. * Fix nbformat handling. * Disable VSCode notebooks code. * Filter out notebook services from registration assertion. * Wait for providers to load before calling canResolve. * Use controller's viewType for notebook provider ID, instead of controller ID. * Start adding extHostNotebook tests for new APIs. * Re-order proxy calls. * Remove commented code. * Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId. * Add a comment. * Remove unnecessary dispose call. * Handle disposable from registerExecuteProvider. * Remove a comment. * Remove unnecessary provider fields. * Remove reference to notebook service to fix circular reference issue in stringify. * Add object types for methods in ADSNotebookController. * Wait for controller languages to be ready before marking session manager as ready. * Add correct promise. * Add undefined return type for optional supportedLanguages property. * Refine promise logic. * Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error). * Fix remaining issues from last commit. * Replace "not implemented" methods with placeholder return types in order to enable testing. * Also wait for execution handler to be set before marking session manager as ready. * Fix usage of NotebookRegistry when updating provider description languages. * Refine file extension conversion. * Fix file extension conversion to match ADS extension behavior. * Emit new provider registration event when adding supported languages. * Remove checks for duplicate file providers and kernels. * Fix a test failure. * Fix file extension parsing. * Use default executeManager if one isn't defined for provider in notebookModel. * Add descriptors for waiting on standardKernels registration. * Increase timeout * Add an error message. * Start working on retrieving default kernel from registered providers, rather than always falling back to SQL. * Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL." This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc. * Emit activation events after provider registration. * Wait on standard kernels availability when getting an execute provider. * Throw an error if session manager isn't ready yet. * Actually resolve language promise correctly. * Add some checks for undefined notebook data objects. * Create kernel spec data correctly. * Add extension changes for local testing only. * Clean up test class. * Add a reminder comment. * Undo commented out notebook stuff * Temporarily hard code default kernel. * Retrieve default kernel in notebookModel if it's not already provided. * Revert an import change. * Remove unnecessary method from extHostNotebook. * Move an interface around. * wip * Check for proposed API for some VSCode extHost methods. * Remove a comment. * Fix notebookUtils tests. * Fix notebookModel tests. * Fix notebookFindModel tests. * Fix notebookViewsExtension tests. * Fix remaining notebookView tests. * Refactor output conversion functionality into separate methods. * Update some unit tests for output conversion. * Move a method. * Rename conversion methods to fit acronym styling. * Add another conversion test case. * Revert local testing changes. * Remove old method. * cleanup * Remove some comments. * Move localized string to locConstants. * Add a space to loc string. * Add comments to new SQL Carbon Edit tags. * Create constants for nbformat and nbformat_minor. * Move some vscode-only fields to proposed APIs. * Check for valid state * Properly null check * Adding logging for provider wait timeouts. * wip update * Fix compile * Switch to cell edits * Update docs * Remove custom output type * cleanup * fix * cleanup * more cleanup * Fixes * Fix tests and lint errors Co-authored-by: Cory Rivera <corivera@microsoft.com> |
||
|
Cory Rivera
|
2ecc3d35ca | Initial implementation for VSCode Notebook support (#17885) | ||
|
Charles Gagnon
|
82805638ad |
Add onClosed event to ModelView dialogs (#17531)
* Add onClosed event to ModelView dialogs * Use defined type * Fix compile * fix tests * fix tests2 * Remove unused |
||
|
Alan Ren
|
328ed83cb9 | add disposeTableDesigner (#17394) | ||
|
Alan Ren
|
569d5cf694 | rename dataModel to viewModel (#17387) | ||
|
Alan Ren
|
ce4459a7b2 |
Table Designer - Save Changes feature and Editor related features (#17335)
* table designer add/remove row support * save changes and editor support * address comments * fix build error * including missing change * lower case request name |
||
|
+18Alan Rendependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>kburtramKim SantiagocsigsBenjin DubisharAlex MaJustin MbnhouleAasim KhanbnhouleMonica GuptaMonica GuptaLeila LaliHai CaoDaniel Grajedabrian-harrisCharmaine ChanCharmaine ChanLewis SanchezChristopher SuhCandice YeCandice YeMartin AeschlimannVasu BhogCharles GagnonBarbara ValdezCory Rivera |
abe54a2b92 |
initial PR for table designer feature (#17200)
* wip * wire up e2e * hook up styler and add as dataprotocal feature * designer child component rendering * table component updates * styler and selectbox column editor * fix editor size and dupe component creation issue * fix checkbox column and add more testing data * properties pane * only rerender when needed * properties pane update * update commands * cleanup for PR * revert unwanted changes * Adding a few tests for Add SQL binding (#17079) * initial changes * add a couple more tests * LEGO: check in for main to temporary branch. (#17089) * LEGO: check in for main to temporary branch. (#17091) Co-authored-by: kburtram <karlb@microsoft.com> * Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078) * Initial changes * checkpoint * Constructing project with post deployment script * Correcting to intentionally read from cached list of projects * Adding activation event, fixing fresh workspace bug * Convert netcoreTool and autorestHelper to share a helper class for streamed command * Include npm package version to force update * test checkpoint * Unit tests * Added contextual quickpicks for autorest dialogs * Adding projectController test * Added projectController test, some refactoring for testability * Merge branch 'main' into benjin/autorest * Fixing 'which' import * PR feedback * Fixing tests * Adding additional information for when project provider tests fail * Hopefully fixing failing tests (unable to repro locally) * Adding Generate Project item to workspace menu * PR feedback * LEGO: check in for main to temporary branch. (#17097) * added sql database projects strings (#17100) * Set kernelAlias in startSession when isValidConnection is truthy (#17102) * PR follow-up comments (#17113) * Change recompare message after changing options to modal (#17103) * Change recompare message to modal * change options to yes and no * Remove commented code block in git extension (#17116) * Remove commented code block in git extension * Add SQL CARBON EDIT tag * [Loc] Small change to generatingProjectFailed (#17118) * Add Null Shortcut and added NULL text for default NULL value. (#17085) * added test key event * added null function to tryHandleKeyEvent * added null formatting * added working null insert. * added editDataGridPanel string null support * Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115) Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](https://github.com/fb55/nth-check/compare/v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add excludeFlags to extenson marketplace query (#17121) * Add excludeFlags to extenson marketplace query * Remove dead code * Remove extraneous blank line * Address code review feedback * Adding Derived Columns to ADS Flatfile Import (#16795) * Adding derived column boilerplate * brandan preliminary frontend changes * empty commit * added new param * updating contracts, dialogue changes * utils changes, saving timeout attempt * pushing for aasim * Cleaning up code and fixing the issue in theory * changing button, did not solve independent scroll * Fixing the scroll bar issue * updating flat file service * adding override keyword to overrriden method * improving UI * pushing changes associated with resolved comments * localizing strings, editing comments * all comments resolved * Fixing a test * updating import package Updating azure MFA bug * Clearing navigation validator Fixing broken table name change * fixed prose test * removing unused code from tests * Fixed PR comments * Fixing some PR comments * WIP * Fixing transformation code and create derived column dialog styling * removing unused code * Adding comment for console log * fixed table styling * Adding some aria labels * Fixed some code cleanup issues * update import service Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> * Change keybindings for copying query with Results (#17127) Co-authored-by: Monica Gupta <mogupt@microsoft.com> * sql proj - publish to docker improvements (#17124) * Add AAD token expiration handling for query runner (#17117) * Add AAD token refresh for notebook * move token refresh to query management and remove previous refresh calls * Add guids to RunAll and RunCell events (#17123) Add guids to RunAll and RunCell events * add error banner for failed migration cutover and cancel migration (#17106) * [Loc] update to sql migration, database projects and import extension strings (#17130) * Apply optional storage class settings in sql mi create command (#17129) * Make storage classes optional * Fix notebook to use storage class options Co-authored-by: Charmaine Chan <chachan@microsoft.com> * Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093) * be able to add new setting in local.settings.json * cleanup * addressing comments * remove todo comment * addressing comments * update some strings to uris * bump version of sqltoolsservice (#17133) * mark schema compare tests as unstable (#17140) * [Loc] Update for arc and sql-database-projects (#17148) * ML extension vbump (#17143) * Configure docker image and web smoke tests for ADSWeb. (#17136) * Adjusts timeout period * Revert "Adjusts timeout period" This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19. * Adds firefox as browser option * Corrects yaml smoke test script * Resets args array to original values * Corrects build path * Resolves ignoring browser option error * continue even after writing to stderr * Adjusts smoke test (browser) script * More adjustments to smoke test script * Corrects server path * Uses build variable directly in build path * Specifies browser type since cannot be ignored error * Adds browser option * Updates web build image and corrects smoke test exe command * Removes commented out task * Updates dockerfile to support web smoketests * Removes failOnStderr flag * Use curl instead of wget in Dockerfile * Fixed a bug with cancling publish (#17160) * Save And Close Functionality (#17000) * save and close * wip * working save and close * cleanup * pr changes * pr changes * fix capitalization * fix build * pr fix * Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119) * Dynamic enablement * Added new package.json field for dynamic options and corresponding functions and classes. * Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left. * Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal. * fix unit test Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> * LEGO: check in for main to temporary branch. (#17168) * [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171) * [Loc] added new arc strings and fix for sql-database-projects xlf * removed newline * Port of Vscode fix for colors too close (#17146) * default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes #127597 * remove activeSelectionBackground from theme-carbon as it conflicts with vscode. * remove dark carbon background Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> * Markdown Horizontal Scrollbar Fix (#17083) * dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed * LEGO: check in for main to temporary branch. (#17181) * Bump axios to 0.21.4 (#17161) * Kusto version bump to 0.5.6 (#17114) * Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6 * Changed netcoreapp3.1 to net5.0 in Kusto config.json * AzureMonitor bump ToolService version and extension version. (#17174) * Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158) Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0. - [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases) - [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits) --- updated-dependencies: - dependency-name: concat-with-sourcemaps dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update service downloader to 0.2.3 (#17186) * Notebook Views grid fixes (#17170) * update data workspace restart ADS to open workspace message (#17188) * update message * update string * Add back "Remove Project" (#17178) * remove project working with full paths * use relative paths * const * addressing comments * Bump github-auth axios to 0.21.4 (#17189) * LEGO: check in for main to temporary branch. (#17192) * LEGO: check in for main to temporary branch. (#17190) Co-authored-by: kburtram <karlb@microsoft.com> * [Loc] Add a small change to dataworkspace (#17194) * added bump to sqltoolsservice version (#17195) * Check if file is dirty before adding sql binding (#17175) * check if file is dirty before adding sql binding * Addressing comments * Add vertical scroll bar to Preview in Split View (#17164) * reset max height * add editor height * set md editor height * Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) * fix floating promises * pr comments * reuse component definition * comments * fix error Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: kburtram <karlb@microsoft.com> Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> Co-authored-by: Monica Gupta <scorpio90m@gmail.com> Co-authored-by: Monica Gupta <mogupt@microsoft.com> Co-authored-by: Leila Lali <llali@microsoft.com> Co-authored-by: Hai Cao <hacao@microsoft.com> Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com> Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com> Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com> Co-authored-by: Charmaine Chan <chachan@microsoft.com> Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Christopher Suh <chsuh@microsoft.com> Co-authored-by: Candice Ye <candiceye@berkeley.edu> Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Vasu Bhog <vabhog@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> |
||
|
Cory Rivera
|
14904bb671 | Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) | ||
|
|
8c2cea4ea6 |
Added saving query (#16883)
* removed clear results and results visible. * revert changes, still work in progress * added small debug message * added flag for state * removed clear in queryResultsView * moved carbon edit message * simplifcation * fixed spacing * added clarifying message * added clarifying comment * added original tab clear line for future things * added support for regular saves * removed vscode changes * added queryEditorTextInput to other versions * added stuff * reverted changes to queryTextEditorInput * deleted duplicates * moved untitledQueryEditorInput * added FileQueryEditorInput constructor * added instantiation * added queryEditorTest * added temporary state for save editor input * added back in FileQueryEditorInput * added example of both to test * restored input. * Added current results processing * removed queryeditor import * added disable dispose, WIP * added small change to dispose * added oldUri * added small changes for adding renameQuery * added first parts of renameQuery, need to add more in other parts. (Place next to disposeQuery). * moved rename around in queryModel * added rename to testQueryManagementServices, now need to add to queryrunner. * added to queryRunner, need to test * added renameQuery calls * added renameQuery to extensions * moved untitledQueryEditorInput to its old location * removed duplicate untitledQueryEditorInput * test import * test blah * moved fileQueryEditorInput to services * deleted original fileQueryEditorInput * Moved fileQueryEditorInput to new location * added workbenchinstantiationservice * added titledQueryEditorInput * restored untitledQueryEditorInput.ts * removed instantiation service * made changes to titledQueryEditorInput * Revert "deleted original fileQueryEditorInput" This reverts commit dd5eb19ea1489d9c0dda159e6a798975240dab65. * reverted back to pre move * added altered untitledQueryEditorInput * temporarily using old version of save until determining point where new URI is assigned. * renamed oldUri to newUri to better reflect its actual use. * added some debug messages for examining how uris work * made small changes to untitledQueryEditorInput * restored save to have actual code. * moved renameQuery to proposed. * added partially working save as for results (Pressing run breaks query) * removed instantiationservice * added newUri for dataservice * added queryRunner.uri for queryModelService * moved untitledQueryEditorInput to old location * changed todomessage * added explanation messages * fixed spaces and added description * moved untitledQueryEditorInput to new location * added rename for connectionmanagementservice * added carbon edit message * removed carbon edit to editorservice * removed another space * added get and set for isSaving value * removed accessor * Update azdata.proposed.d.ts added space * fixed azdata.proposed * added changeConnectionUriForQuery * restored request * replaced changeconnectionuri to changeuri * Revert "replaced changeconnectionuri to changeuri" This reverts commit eed8e518dee69cf2922ff86dc1763e6fb7715a71. * made required changes * fixed exclamation mark * removed error on queryRunner changeconnection * added save connect button status * added additional state properties to save * added wip setstate * added changes for better naming * added changes in preparation for vscode merge * take screenshot of failed test before close editor (#16876) * Add setting for enabling using new markdown renderer (#16864) * Add setting for enabling using new markdown renderer * Use const * Fix circular dependency * Default setting to false * fix refresh node and add sample (#16888) * Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) * Bump VS Code version to latest sync point (#16891) * Fix duplicate editor windows on reload (#16893) * reset the icon before use (#16896) * Undo merge icon change (#16894) * disable cancel button after clicked once (#16783) * disable cancel button after clicked once * remove enabling of cancel button when cancelling * Update sqlite version for smoke tests (#16903) * update sqlite * bump distro Co-authored-by: chgagnon <chgagnon@microsoft.com> * add autoCutoverConfiguration to getMigrationStatus (#16803) * Enable scripting for triggers and other objects (#16885) * WIP 1 * Add parentName to azdata * Add some additional types for scripting * Add parent type name to support view subobjects * bump dependencies and address review comments * Modify treeDataChange event (#125214) (#16907) Modify treeDataChange event to support firing arrays. * Move create new option for publish to top and filter out system dbs (#16908) * Move create new option for publish to top * Move New tag to description * fix * Open project to default location (#16910) * Have create proj from database show default save location as option (#16909) * Default create proj location to setting * update icons * undo * Put search/ status/refresh in single line (#16898) * add horizontal scroll bar to output (#16918) * Fix extension linting warnings and enable extension linting in pipelines (#16922) * Fix extension linting errors * fix test * Update public preview readme for sql migration extension (#16920) * Add sql bindings package reference to project (#16912) * list packages and add packages working * cleanup and remove list packages * cleanup * change to pull in latest package version * Add STS root folder override (#16927) * Add STS root folder override * Display message to user * Show once for any service * Fix some unhandled promise lint errors (#16924) * Moved items around to handle new untitledQueryEditorInput location (#16914) * moved items around to handle new untitledQueryEditorInput location * added editor inputs to constants. * added interface for untitledQueryEditorInput * added IUntitledQueryEditorInput * Revert "added IUntitledQueryEditorInput" This reverts commit 67955eb289458e7ac4e7e5ce0ee077f38ed82a2c. * Revert "added interface for untitledQueryEditorInput" This reverts commit 88552dbd811b643fd51d5d21f4571b677d7bfc73. * Revert "Revert "added interface for untitledQueryEditorInput"" This reverts commit 13a89c40e4cb0a3fa495f5b150c066892387e509. * Revert "Revert "added IUntitledQueryEditorInput"" This reverts commit 8b2258ab49275a271a39036ea1734feca98ee753. * added extends for IUntitledQueryEditorInput * added casting in editorGroupView * Revert "added casting in editorGroupView" This reverts commit 61500ea43690b08ba2393808a8d118abc60da4ac. * Revert "Moved items around to handle new untitledQueryEditorInput location (#16914)" This reverts commit 87a663ee6b7cc3330c0528b20fb74f557451f911. * Revert "Fix some unhandled promise lint errors (#16924)" This reverts commit 73218a840df188f1ae26ff1c2e1aa5b85b9cfcb0. * Revert "Add STS root folder override (#16927)" This reverts commit 35936d464f2e452cd29659fffef20018ac6ffdd4. * Revert "Add sql bindings package reference to project (#16912)" This reverts commit 72d29ed7a7d298716ba159548af1f08adc82db25. * Revert "Update public preview readme for sql migration extension (#16920)" This reverts commit 3b3c3921557aabe86c927e6a833c0c41b48f7e23. * Revert "Fix extension linting warnings and enable extension linting in pipelines (#16922)" This reverts commit f5ea3e69ae5132c09eba699e8c25d1a1a66e0914. * Revert "add horizontal scroll bar to output (#16918)" This reverts commit 76bf86a2536edfe84b0f323571e489d69fe9fe00. * Revert "Put search/ status/refresh in single line (#16898)" This reverts commit d9553d09141c159e8b1cc27f6422e51b68800c7c. * Revert "Have create proj from database show default save location as option (#16909)" This reverts commit 88b9b7734b467a2552dfeea9c844b90361a660de. * Revert "Open project to default location (#16910)" This reverts commit a46170b347a28ff77f40883b055153823a86308e. * Revert "Move create new option for publish to top and filter out system dbs (#16908)" This reverts commit 4be47daf63771b6c3b12b786ba687dfc6ca0e3c6. * Revert "Modify treeDataChange event (#125214) (#16907)" This reverts commit 4161c21abcc78a9b5a65e52ae7d7f960ea71219b. * Revert "Enable scripting for triggers and other objects (#16885)" This reverts commit 2ece3ffb12478faf0f49df1e66bcc7acc0631500. * Revert "add autoCutoverConfiguration to getMigrationStatus (#16803)" This reverts commit 366633e7247d508138b45e902d7e034c79763dec. * Revert "Update sqlite version for smoke tests (#16903)" This reverts commit 64f66d7b18418b028cfa56b984d6f9979f65cc50. * Revert "disable cancel button after clicked once (#16783)" This reverts commit 12044e30746f44188d46a781f582781bf3638762. * Revert "Undo merge icon change (#16894)" This reverts commit 0801d14267a9980a2c29374666ad7fee14dfcafb. * Revert "reset the icon before use (#16896)" This reverts commit 971c39e8bc5c774fb49d81c5c36617ec45b4078c. * Revert "Fix duplicate editor windows on reload (#16893)" This reverts commit 4df3085b09b645a3ef2728c3ab3778fb7a63f2ba. * Revert "Bump VS Code version to latest sync point (#16891)" This reverts commit c1bc6639efcdf69d9b9c57cc44af3a1d19514f83. * Revert "Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569)" This reverts commit c92da9c02ee221ca69813af69b039d3f3846aa42. * Revert "fix refresh node and add sample (#16888)" This reverts commit df820f6c03d167d933d089bfadf5296a7dcaf834. * Revert "Add setting for enabling using new markdown renderer (#16864)" This reverts commit e3c036dfbaa0a1e1588f348eb9eb4a7edb4f9bda. * Revert "take screenshot of failed test before close editor (#16876)" This reverts commit d466b19a6e56a43654c779c1dab60724b1f0c3db. * fix spaces * changed uri to public * fixed formatting on azdata.proposed * added queryprovider at the end * changed already in connections list message. * added notifyconnectionurichanged * added changes to fix * fixed testQueryModelService * fixed leftover stuff * more renames * Added small changes * added messages to untitledQueryEditorInput * added work in progress fileQueryEditorInput save as * fixed space * removed changeUri * remove saveAs from queryEditorInput * removed undefined from createFileQueryEditorInput in untitled. * changed saveAs for fileQueryEditorInput * changed saveAs to use createInstance * bumped version of STS in config.json * bump version of dataprotocol-client * update to yarn.lock * more changes * removed space for untitledQueryEditorInput * some refactoring done * removed already has provider check due to existing provider still existing * added a comment * fixed typo * change results order around * added already existing connection message * restored untitledQueryEditorInput * removed message * added existing connection * Revert "added existing connection" This reverts commit 3cc34f6b1e670bb7b257e046f53560471badfd34. * add try catch to restore older overwrite file behavior * added types and error handling * added error comments. * changed message of both files * fixed formatting for azdata.proposed.d.ts Co-authored-by: Lucy Zhang <luczhan@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> Co-authored-by: stuti149 <87131830+stuti149@users.noreply.github.com> Co-authored-by: Rachel Kim <rackim@microsoft.com> Co-authored-by: Karl Burtram <karlb@microsoft.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> |
||
|
Cory Rivera
|
cb7b7da0a4 | Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) | ||
|
Charles Gagnon
|
ea6e03f826 |
Fix azure account tree subscription check (#16822)
* Fix azure account tree subscription check * comment |
||
|
Charles Gagnon
|
379c60dd27 | Reduce the number of onUpdate events fired for dialog buttons (#16311) | ||
|
Charles Gagnon
|
a0f46fec65 |
Add openQueryDocument API (#16117)
* Add openQueryDocument API * Remove open call * Change try name |
||
|
Charles GagnonandADS Merger
|
3cb2f552a6 |
Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 * Fixes and cleanup * Distro * Fix hygiene yarn * delete no yarn lock changes file * Fix hygiene * Fix layer check * Fix CI * Skip lib checks * Remove tests deleted in vs code * Fix tests * Distro * Fix tests and add removed extension point * Skip failing notebook tests for now * Disable broken tests and cleanup build folder * Update yarn.lock and fix smoke tests * Bump sqlite * fix contributed actions and file spacing * Fix user data path * Update yarn.locks Co-authored-by: ADS Merger <karlb@microsoft.com> |
||
|
Charles Gagnon
|
57cd25fab9 | Fix dipose "method not implemented" errors in MainThread API classes (#15257) | ||
|
Vasu Bhog
|
d76a6698a9 |
[Notebook] Run Parameters Action openNotebook Functionality in Core (#14978)
* NotebookService update * openNotebook functionality in NbService * Add tests for RunParametersAction |
||
|
Kim Santiago
|
39a47b0053 |
Add telemetry for opening dacpac wizard (#14884)
* add telemetry for opening dacpac wizard * add wizard open telemetry to core * fix tests * remove WizardOpen |
||
|
Lucy Zhang
|
f59e9b5695 |
Notebooks: Use new Python installation after configuration change (#14765)
* start new jupyter server * restart session working (removed extra code) * only restart server once * shutdown session first then stop server * add comments remove extra lines * add comment * fix test * only restart jupyter sessions * Dispose jupytersessionmanager and create new one * move restart server logic out of notebookmodel * move methods to azdata proposed * pr comment |
||
|
Charles Gagnon
|
72295d46c2 |
Add close method to ModelView dashboards (#14812)
* Add close method to ModelView dashboards * fix closing * remove accessors * Update errors |
||
|
Charles Gagnon
|
31ce58a8fc |
Cleanup telemetry keys (#14795)
* Add event for connection error * Cleanup telemetry keys * Fix missed keys |
||
|
Kim Santiago
|
9cfba8e8e0 |
Reload ADS when data-workspace extension opens a workspace (#14540)
* reload ADS when workspace is entered * move reloading so that reload also happens for file save workspace as commands * fix build error |
||
|
Kim Santiago
|
42fba14d88 |
Fix how data workspace handles untitled workspaces (#14505)
* add more workspace apis * update dialog and check workspace scheme * cleanup * add comment * update create project from db dialog * cleanup * update names * add test |
||
|
+18Hale RankinMaddyCharles Gagnonnasc17Chris LaFreniereBarbara ValdezChristopher CMonica GuptaMonica GuptaBenjin DubisharKarl BurtramSakshi SharmaVasu BhogAlan Rendependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Lucy ZhangLeila LaliKim SantiagoAasim KhanSai Avishkar SreeramaAditya BistArvind RanasariaBenjin DubisharSai Avishkar SreeramaDrew Skwiers-KoballaBrian BergeronVladimir ChernovAlex Ma |
05f97411fa |
New feature for Notebooks - Callout (#13078)
* New feature for Notebooks - callout. This utilizes a modifed modal.ts that renders a small modal set to appear at the trigger event and disappear when user clicks off of it. This is intended only for micro-interactions such as inserting links, tables and images into Notebooks. Error dialogs dependent on modal have been updated to implement the modified width property correctlty. * Modified dialogStyle names in interface. Applied updates to files dependent on this. Wired up disposable listener for browsing local files in image select callout. Renamed callout to calloutDialog. * Converted double quotes in CSS to single quotes. Revised run method, removing the promise wrapping from the conditional. * Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag. * Revised structure and styles. * Updated component for use with ML extension. Updated ML extension code with changes for custom dialog creation. * Fixed async context for handleBrowse. Passing the new modal properties into Dialog implementation for ML. * Added option to suppress callout dialog header and footer from the machine learning view file. Added a compact variant of callout. Corrected Dialog tab initialization. * Maddy/callout modifications (#13586) * initial changes * canSelectFolders false * change label, placeholder text on radiobtn click * Added support for custom XY offset to account for modal size and to provide for fine-tuning of unique modal instances. * Updated Image icon with latest from Design. * Replaced node process with IPathService for retreiving image file. * Added theme color lookups to provide default colors when none are provided. * Added async/await to tests calling transformText. * textCell, modal - swapped out HostListener for a member method which listens for the Esc keyup. Updated templates with method call on keyup. This cleaned up the double event call whenever the Esc key was pressed. Added property to modal Cancel button call to make it a secondary button. * Cleaned up callout styles. * Removed color use for input fields because component code delivers theme-specific values. * Added check for CSS class `mac` on the body tag. Added conditionals to supply alternate dialogXYOffset in the case of non-Mac environment. * Cleanup: Simplified DialogPosition. Renamed telemtry references and dialog related methods. Corrected spelling. Added missing signatures and types. Updated warning callout link URLs. * Removed async and await as there are no promise dependencies. Added a signature. * Revert "Fix windows insiders icons (#13579)" (#13630) This reverts commit |