Commit Graph

1140 Commits

Author SHA1 Message Date
Alan Ren
6be1420220 do not run query in multi-selection mode (#20213)
* do not run query in multi-selection mode

* fix test

* fix more tests
2022-07-30 14:29:32 -07:00
Alan Ren
67ecd6d3d9 fix the grid goes blank issue (#20209) 2022-07-29 18:12:02 -07:00
Lewis Sanchez
9fc251259c Adds Ability to Search for Nodes in Compared Execution Plans (#20168)
* Adds find node button to comparison plans.

* Can search multiple nodes (improve widget UI and initialization)

* Adjusts how second plan is added to the node search widget

* Adds styling to the find node action bar

* Removes unused code

* Minor clean up

* Cleans up CSS redundancy

* Adjusts property names according to access specifiers

* Corrects find node behavior to match SSMS

* Dependency injects instantiation service

* Adds additional property to telemetry event.

* Adds undefined to getter return signatures for plans

* Adds checks around active execution plan properties

* Code review change

* Code review changes
2022-07-28 14:14:32 -07:00
Alan Ren
bb4b00a25a fix recent closed (#20188) 2022-07-27 18:44:08 -07:00
Aasim Khan
518bb33a2f Adding plan tree to execution plan (#20158)
* Adding plan tree

* Fixing localization keys

* Removed whitespace
2022-07-26 14:30:46 -07:00
Cory Rivera
c2be6447b5 Prevent cell's edit mode from being incorrectly cleared when a text component is initialized. (#20120) 2022-07-22 10:22:56 -07:00
Lewis Sanchez
43e7e35df5 Update azdataGraph version to 0.0.37 (#20140)
* Updates azdataGraph version to 0.0.37

* Enables collapse/expand node with highlight resize
2022-07-21 16:15:54 -07:00
Charles Gagnon
1367f29a8a Fix null ref in contributed tree views (#20138) 2022-07-21 12:26:22 -07:00
Maddy
7dd36ae7b4 fix: image disappear issue (#20039)
* check if base64 value is from image tag

* add test

* check image regex

* add comment

* update comment
2022-07-20 13:58:49 -07:00
Aasim Khan
67637a41f5 Making better ep highlights (#20055) 2022-07-15 15:31:01 -07:00
Charles Gagnon
ba1f4db745 Make createEditorInput async (#20038) 2022-07-14 19:39:52 -07:00
Cory Rivera
e58aa90ac0 Set dotnet_interactive cell metadata when converting cell into JSON. (#20044) 2022-07-14 16:47:14 -07:00
Lewis Sanchez
e5b0e0255c Updates azdataGraph version to 0.0.33 (#20028) 2022-07-13 18:59:22 -07:00
Lewis Sanchez
8f93fd9d09 Updates Actual Execution Plan button icon (#20018) 2022-07-12 17:14:49 -07:00
Chris LaFreniere
78b5e52bf7 re-enable notebook outputprocessor tests (#20000) 2022-07-12 10:11:35 -07:00
Aasim Khan
980a233aad Sorting top by cost initially (#19998) 2022-07-11 21:34:38 -07:00
Lewis Sanchez
e25a9574a7 Bump azdataGraph version to 0.0.32 (#19954)
* Update azdataGraph version to 0.0.31

* Adds icons

* Bumps azdataGraph version to 0.0.32

* Removes whitespace

* Uses icon that better adapts to color theme changes.

* Disables collapse for execution plans in plan comparison editor view
2022-07-11 21:26:34 -07:00
Aasim Khan
53a0388858 Deleting old query plan code (#19996) 2022-07-11 19:14:47 -07:00
Karl Burtram
26455e9113 Merge vscode source through 1.62 release (#19981)
* Build breaks 1

* Build breaks

* Build breaks

* Build breaks

* More build breaks

* Build breaks (#2512)

* Runtime breaks

* Build breaks

* Fix dialog location break

* Update typescript

* Fix ASAR break issue

* Unit test breaks

* Update distro

* Fix breaks in ADO builds (#2513)

* Bump to node 16

* Fix hygiene errors

* Bump distro

* Remove reference to node type

* Delete vscode specific extension

* Bump to node 16 in CI yaml

* Skip integration tests in CI builds (while fixing)

* yarn.lock update

* Bump moment dependency in remote yarn

* Fix drop-down chevron style

* Bump to node 16

* Remove playwrite from ci.yaml

* Skip building build scripts in hygine check
2022-07-11 14:09:32 -07:00
Cory Rivera
6b535b7945 Dispose underlying text model when disposing notebook editor model (#19955) 2022-07-08 11:23:50 -07:00
Lewis Sanchez
5fbea7a39c Property view labels update when execution plan orientation changes (#19924)
* Updates properties view title when the orientation changes

* Property orientation labels change when the plan orientation changes.

* Renames top and bottom containers to secondary and primary

* Minor clean up

* Removes unnecessary class members

* Promotes constants to module level

* Moves function to module level

* Renames value1 and value2 to primary and secondary

* Replaces orientation string literal type with enum

* Resolves undefined orientation bug

* Removes unused orientation getter

* Updates property table columns only

* Uses orientation enum in editor view and properties view

* Clean up
2022-07-07 13:26:08 -07:00
Aasim Khan
9cfa1436d9 Adding top operations to execution plans (#19902)
* Adding top operations to execution plans

* Adding title to links

* Fixing pr comments

* Hiding top operations icon in execution plan editor

* Reducing outline width, adding separator and removing placeholder text

* Registering TopOperationsTabView
2022-07-07 12:50:52 -07:00
Lucy Zhang
2e2fcbe5fc Add telemetry for WYSIWYG (#19908)
* add telemetry for wysiwyg

* add view mode

* add back WYSIWYGKeyboardAction

* nit extra line

* update action property to transformAction
2022-07-06 09:39:02 -07:00
Lucy Zhang
4ec2d78269 Add Notebook telemetry events (#19848)
* add telemetry events

* remove error message in telemetry
2022-07-01 09:14:29 -07:00
Barbara Valdez
74f01c429a Add more tests to cell image attachments (#19851)
* add more tests to cell image attachments

* remove cell attachment image name with spaces test
2022-06-29 14:13:54 -07:00
Lewis Sanchez
96d29bcbc1 Actual Execution Plan No Longer Executes Queries (#19840)
* Ctrl/Cmd + m, no longer executes queries.

* Adjusts command label

* Code review changes

* Uses category parameter to categorize actual plan command

* Actual execution plan command label matches estimated plan command label

* Revert "Actual execution plan command label matches estimated plan command label"

This reverts commit 15f301dfc64341d631ca5e9b1314d8cf739b2088.

* Centralizes localized category string (#19857)

* Actual Plan action uses centralized category
2022-06-28 18:31:41 -07:00
Lewis Sanchez
811aa18862 Centralizes localized category string (#19857) 2022-06-28 16:58:09 -07:00
Lewis Sanchez
b01642aec1 Adds "Execution Plan" prefix to Execution Plan commands (#19842)
* Prefixes execution plan commands, so they are easier to find

* Provides category argument to categorize commands.
2022-06-28 11:42:25 -07:00
Lucy Zhang
23feac100a Add telemetry for notebook toolbar actions (#19750)
* add telemetry for notebook toolbar actions

* fix tests

* remove events with no metadata + connection info

* add optional connectioninfo param

* fix param
2022-06-23 05:57:17 -07:00
Lewis Sanchez
800f2cebb5 Updates actual plan text to enable/disable instead of include/exclude (#19796)
* Updates actual plan text to enable/disable instead of include/exclude

* Makes actual plan button text static and readonly
2022-06-22 14:59:13 -07:00
Charles Gagnon
c24305f9d8 Move query history into extension (#19794)
* initial

* more

* Remove connectionId

* cleanup

* cleanup

* Remove core contributions, add to panel by default

* Add enabled state

* Update config

* cleanup

* Move

* Remove newlines

* update README
2022-06-22 12:37:32 -07:00
Aasim Khan
15a611d4a4 Fixing tabbing logic for tab headers (#19770)
* Fixing tabbing logic for tab headers

* Renaming stuff
Making null checks concise
Adding comments

* Renaming css class and interfaces from active to selected

* Renaming styling classes and objects

* Changing tabbing logic to match w3 behavior

* Fixing focus logic in tab

* Adding helper comment

* Code cleanup
2022-06-21 13:13:10 -07:00
Barbara Valdez
7b16a78176 add tests for anchor links (#19659) 2022-06-20 09:29:33 -07:00
Cory Rivera
7696157084 Refresh cell toolbar when changing cell type. (#19704) 2022-06-10 17:15:50 -07:00
Aasim Khan
489259d364 Fixing graph root padding and truncating long queries in execution plan (#19703)
* Fixing graph root padding
Truncating queries to one line

* Updating remote package
2022-06-09 17:05:35 -07:00
Lewis Sanchez
20d2256709 Adds toggle button to switch between estimated and actual execution plans (#19629)
* Creates toggle button to switch between estimate and actual query plans

* Renames ID for the toggleActualExecutionPlanModeAction class

* Renames button back to explain

* Creating actual execution plans resembles SSMS

* Adds CTRL/CMD + L shortcut to display estimated execution plans

* Alphabetically organizes telemetry actions

* Adds telemetry when the setting for actual execution plan toggle is used

* Resolves build errors

* Fixes broken unit tests.

* Code review changes

* Removes unnecessary null-coalescing operator.

* Creates placeholder icons for actual execution plans enabled

* Code review changes

* Shortens label names

* Telemetry moved to toggle button

* Telemetry review changes

* Clarifies misleading label
2022-06-09 16:07:12 -07:00
Aasim Khan
b1d8e43569 Changing plan comparison properties table logic and icons (#19700)
* Changing plan comparison logic and icons

* Removing empty class ref
2022-06-09 14:15:35 -07:00
Cory Rivera
a265224701 Show an error in cell output when trying to load an unsupported output type. (#19693) 2022-06-09 12:32:42 -07:00
Alex Ma
fc7a27171d Fix for editData tab switch back when adding new row. (#19634)
* added filter for AsyncDataProvider Filter crash

* fixed cell switch back for editdata

* Added new setData check

* disable selecting of all columns when new row is being added

* Changed comment

* removed try catch check due to Aasim's PR

* added previous dataset to handlechange

* added feedback changes

* added fix for infinite loop

* changes made as suggested by Alan

* following Charles' feedback

* removed onGridRendered as its pointless jumping
2022-06-09 10:51:03 -07:00
Cory Rivera
7007e18314 Add new cells after the current one when adding a cell from the notebook toolbar. (#19649) 2022-06-07 10:12:15 -07:00
Daniel Grajeda
4fd2f92e27 Introduce tabs for notebook views (#19526)
* Introduce tabs for notebook views

Cards have been restructured to contain tabs instead of cells directly.
Tabs then contain the cards that are displayed. Cards may contain one or
more cards.

The panel component has been reused to implement the cells. There is
still some cleanup left to do of unused functions, but I want to reduce
the size of the PR as much as possible.
2022-06-06 03:07:08 -07:00
Aasim Khan
b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Lewis Sanchez
b52386a36a Execution Plan Telemetry for Plan Comparisons (#19610)
* Adds telemetry when plan comparison is invoked

* Small formatting change.

* Adds telemetry to add execution plan button

* Removes unused ExecutionPlanComparisonEditorView constructor parameters

* Small formatting adjustment

* Adds telemetry to ExecutionPlanComparisonEditorView properties

* Code review changes
2022-06-03 13:56:32 -07:00
Christopher Suh
1b9f4cbbae Changed add connection -> new connection (#19596)
* changed add connection -> new connection

* remove xlf file changes

* fix spacing

* fix workspace settings
2022-06-02 14:04:34 -07:00
Kim Santiago
1bbf5a78c1 enable table designer for table script in sql database project (#19237)
* add 'open in designer' to context menu of tables in sql projects

* fix tests

* Address comments

* enable table designer for sql database proj

* update label and issues on init

* vbump sts

* use promisified fs

* pr comments

Co-authored-by: Alan Ren <alanren@microsoft.com>
2022-06-02 13:27:47 -07:00
Charles Gagnon
d3c474162d Fix renderer error string (#19599)
* Fix error string localization

* fix

* fix
2022-06-02 12:42:27 -07:00
Barbara Valdez
f06fd7f6f7 Fix split cell not working with attachments (#19587) 2022-06-01 16:23:46 -07:00
Charles Gagnon
071f631c34 Fix null ref in tree (#19589)
* Fix null ref in tree

* Correct type
2022-06-01 12:47:52 -07:00
Charles Gagnon
41a3c8661c Fix GetConnection (#19579) 2022-05-31 21:32:44 -07:00
Alan Ren
11a969f44f workaround for the dashboard resets zooming issue (#19576) 2022-05-31 21:04:23 -07:00