Alex Ma
9a7810cbee
removal of unnecessary spaces. ( #10275 )
2020-05-05 14:58:13 -07:00
Alex Ma
921e546fd7
Edit Connection Feature added, edit existing connection in connection tree. ( #10214 )
...
* Added Edit Connection Command
* Wip changes for new connection dialog
* Testing
* WIP commit
* added ID check to ensure connection
* wip commit
* model id check implemented
* addfooterbutton now accepts events
* wip commit
* message explaining check
* temporary change
* connectionManagementService restored
* Revert "connectionManagementService restored"
This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.
* formatting test
* editConnection promise testing
* edit existing connection command added
* WIP Connection Edit
* disconnect added to editConnection promise
* WIP on editExistingConnection
* changed isEdit to true
* Amir/edit connection (#10112 )
* Get edit connection working
* Delete unused code
* check for isEdit as well
* connection tree test added
* WIP connection management tests
* comment out test to find out what's wrong
* fix for one error
* added note about test skipped
* changed signature of saveprofile
* saveprofile fixed
* wrote working test
* added additional test
* changed message
* Fixes made
* fix for matcher
Co-authored-by: Amir Omidi <amomidi@microsoft.com >
2020-05-05 13:21:05 -07:00
Charles Gagnon
cb26c1c409
Fix arrow alignment for connection dialogs ( #10064 )
2020-04-17 19:11:41 -07:00
Anthony Dresser
5b19fe7c67
Revert "Stop executing the same code three times ( #9835 )" ( #10026 )
...
This reverts commit 97108bdeea
2020-04-16 14:54:25 -07:00
Amir Omidi
97108bdeea
Stop executing the same code three times ( #9835 )
...
* Stop executing the same code three times
* Remove one more extra call
2020-04-15 13:56:12 -07:00
Anthony Dresser
6e6649d006
Smoke tests ( #9814 )
...
* move
* add inital test; need basic sqllite connection
* before sqlite
* sqlite
* add smoke tests
* working tests
* fix app names
* fix quick open
* fix smoke tests
* add win32 smoke tests
* fix smoke test
* fix win32 smoke
* no continue
* continue on error
* add vscode smokes
* remove vscode tests
* continue on error
* allow sqlite to use relative paths
* add linux smoke tests
* fix build files
* use dispatch instead of select
* fix linux build again
* fix darwin
* get select working
* try and use screen shots
* screen shots
* remove smoke tests linux
* try vscodes sqlite
* fix compile
* fix webpack
* fix deps
* try this again
* try force a rebuild
* try npm rebuild
* add sqlite to be rebuilt
* distro
* try vscode sqlite again
* revert changes to driver and simplify edits
* fix compile
* fix imports
* move sqlite out
* remove unneeded change
* add extensions path
* fix web tests
* no continue on error
2020-04-03 00:01:32 -07:00
Amir Omidi
77db2d3ac0
connection widget wasn't getting the correct account for the dialog ( #9834 )
2020-04-02 17:05:51 -07:00
ADS Merger
a64304602e
Merge from vscode 1ec43773e37997841c5af42b33ddb180e9735bf2
2020-03-29 01:29:32 +00:00
Amir Omidi
176edde2aa
Connection management service updates to support multiple providers ( #9698 )
...
* Connection management service work
* Fix tests
* Change how accounts are deleted
* Be consistent with names
* feedback
* Fix based on feedback
* Change sqltoolsservice version
2020-03-25 12:48:01 -07:00
Anthony Dresser
bd8c4a44c8
change to freeze configuration models ( #9644 )
2020-03-17 15:45:29 -07:00
Charles Gagnon
64eb406fdc
Add connecting title to spinner for Connection dialog ( #9623 )
2020-03-16 08:26:35 -07:00
Anthony Dresser
324451ea22
fix hygiene
2020-03-10 22:02:15 -07:00
ADS Merger
4c3e48773d
Merge from vscode cfc1ab4c5f816765b91fb7ead3c3427a7c8581a3
2020-03-11 04:19:23 +00:00
Anthony Dresser
506c6a5e5f
More Layering ( #9139 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* wip
* wip
* wip
* remove no longer good parts
* fix strict-nulls
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
* wip
* finished layering
* fix imports
* fix valid layers
* fix layers
2020-02-15 01:54:23 -06:00
Anthony Dresser
9af1f3b0eb
More layering ( #9111 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* rip
* reworking results serializer
* move some files around
* move capabilities to platform wip
* implement capabilities register provider
* fix capabilities service
* fix usage of the regist4ry
* add contribution
* remove no longer good parts
* fix issues with startup
* another try
* fix startup
* fix imports
* fix tests
* fix tests
* fix more tests
* fix tests
* fix more tests
* fix broken test
* fix tabbing
* fix naming
2020-02-12 18:24:08 -06:00
Anthony Dresser
0f934081e1
More layering and strictness ( #9004 )
...
* move handling generated files to the serilization classes
* remove unneeded methods
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* wip
* remove jsdoc
* fix layering
* fix compile
* fix compile errors
* wip
* wip
* finish layering
* fix css
* more layering
* remove no longer good parts
* fix issues with startup
* another try
* fix startup
2020-02-11 00:47:17 -06:00
ADS Merger
2af13c18d2
Merge from vscode 718331d6f3ebd1b571530ab499edb266ddd493d5
2020-02-08 04:50:58 +00:00
Anthony Dresser
56695be14a
More layering and compile strictness ( #8973 )
...
* add more folders to strictire compile, add more strict compile options
* update ci
* wip
* add more layering and fix issues
* add more strictness
* remove unnecessary assertion
* add missing checks
* fix indentation
* remove jsdoc
2020-01-29 20:35:11 -08:00
kenvanhyning
dd8b12f805
Kenvh/noazurecms ( #8755 )
...
* Disallow Azure SQL DB servers for CMS
* removed commented out lines
* added check for valid serverInfo
2020-01-06 16:53:06 -08:00
Charles Gagnon
fa2fcf2e40
Log original kerberos errors to console ( #8804 )
...
* Log original kerberos errors to console for debugging purposes
* Fix compile error
2020-01-03 15:30:42 -08:00
osmant
48dcb7258e
Guest account connection issue while using ( #8726 )
...
AAD authentication
2019-12-18 12:13:46 -08:00
swjain23
e181cf2fcd
Bug fix to return authType as undefined if displayName is not set ( #8731 )
...
We noticed that if displayName is undefined this method would return the first auth type it found as getAuthTypeDisplayName() would return undefined.
If the displayName is undefined, we would not have a matchingTYpe and it should be undefined.
2019-12-18 11:40:20 -08:00
Anthony Dresser
30d9e9c141
Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 ( #8722 )
...
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1
* remove tests that aren't working
2019-12-18 00:14:28 -08:00
Anthony Dresser
ea5f9be441
Properly expose errors in ads and tests ( #8692 )
...
* add code to expose errors outside zone
* remove unexpect error hiding
* remove uncessary code
* fix tests
* trying to catch more errros
* revert for testing
* wip
* wip
* figured out what was going on
* wip
* fix tests
* fix tests
2019-12-17 12:06:36 -08:00
Aditya Bist
ef8c0e91e6
fix provider dropdown option for cms dialog ( #8711 )
2019-12-16 18:50:50 -08:00
swjain23
0bf4790a64
Add changes for flavor selection ( #8419 )
...
* Add changes for flavor selection
* Use getDefaultProviderId method
* Update default engine user setting description
* Add back check for codeEditor
* Add test for multiple providers
* Removing extra merge line
* Add an attribute to ConnectionProviderProperties for language flavor
Adding a boolean property to ConnectionProviderProperties for providers that are language flavors. When it is set to true, the provider will be part of drop down for changing SQL language flavor.
* Update variable name
* Put logic for removing CMS at one place and remove flag for flavor provider
* Using keys instead of entries
Using Object.keys instead of entries as doing [0] can be error prone if no provider matches.
* Adding logic to check from params
* Updating variable names
* Rename dedup map
* Fix action
2019-12-05 15:28:35 -08:00
Charles Gagnon
4f8ced1f6b
More dangling promise cleanup ( #8518 )
...
* More dangling promise cleanup
* return void
* Function to async
* Fix a couple missed promises
2019-12-02 15:54:33 -08:00
Rich Smith
b631530753
Modify connection management to support Active Directory authType for non-SQL DBs ( #8434 )
...
* First attempt to add Azure MFA login for PostgreSQL
* Finish merge with master
* Fix auth type default selection
* Add AzureMFAAndUser auth type for Orcas
* Fix formatting
* Update change log
* Incorporate some review comments
* Missed an occurrence of AzureResource
* Try to move all changes out of azdata.d.ts and sqlops.d.ts
* Concrete implementation of ConnectionProfile in azdata no longer has azureAccount
* Use enum names instead of numbers in config files
2019-11-26 10:32:59 -08:00
Charles Gagnon
019d5088ec
Add engine edition to connection telemetry ( #8425 )
2019-11-21 10:05:44 -08:00
Anthony Dresser
7a2c30e159
move code from parts to contrib ( #8319 )
2019-11-14 12:23:11 -08:00
Charles Gagnon
18ab2ae799
Remove TelemetryUtils and use IAdsTelemetryService directly ( #8289 )
...
* Remove TelemetryUtils and use IAdsTelemetryService directly
* Fix event names and cleanup
* Fix tests
* Fix strict null check
2019-11-13 13:54:55 -08:00
Anthony Dresser
df0c505452
No unused locals ( #8231 )
...
* add no unused local
* fix strict null
* fix compile errors
* update vscode comments
2019-11-06 17:22:05 -08:00
Anthony Dresser
564f78b6f6
Revert "Revert "Remove typings and replace missing methods with vscodes ( #8217 )"" ( #8242 )
...
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217 )" (#8240 )"
This reverts commit e801a04bcf
2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf
Revert "Remove typings and replace missing methods with vscodes ( #8217 )" ( #8240 )
...
This reverts commit 22a427f934
2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934
Remove typings and replace missing methods with vscodes ( #8217 )
...
* remove typings and replace missing methods with vscodes
* fix strict-null-checks
* fix tests
2019-11-05 13:03:20 -08:00
Anthony Dresser
ade68b184d
Move code around for more linting ( #8190 )
...
* testing
* moving around all the code
* fix strict nulls
2019-11-04 10:41:28 -08:00
Charles Gagnon
5dc7049f8c
Fix floating promises in connection widget ( #8198 )
...
* Fix floating promises in connection widget
* PR feedback
* More feedback changes
* Couple missed promises
2019-11-04 07:24:38 -08:00
Amir Omidi
b62c0cf2ab
More promise cleanup ( #8100 )
...
* Some promise cleanup
* Handle more promise issues
* Remove changes that aren't needed anymore
* Use log service
* another one
* Be more explicit
* Some more promises cleaned up
* Handle promises here too
* Strings for errors
* Some more cleanup
* Remove unused imports
2019-10-31 14:30:08 -07:00
Charles Gagnon
2aa7a145d4
Fix connection group input not correctly selecting nested groups ( #7625 )
2019-10-10 11:21:13 -07:00
Euler
ac87346507
Prevent connections from moving on click ( #7528 )
2019-10-07 08:49:05 -07:00
Anthony Dresser
db498db0a8
Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f ( #7282 )
...
* Merge from vscode 1eb87b0e9ce9886afeaecec22b31abd0d9b7939f
* fix various icon issues
* fix preview features
2019-09-19 21:50:52 -07:00
Anthony Dresser
ea0f9e6ce9
Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 ( #7206 )
...
* Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463
* fix config changes
* fix strictnull checks
2019-09-15 22:38:26 -07:00
Anthony Dresser
d9c5b7ea9e
Clean up some more disposable usage ( #7190 )
...
* clean up some more disposable usage
* fix a bug
* add more to register
2019-09-13 12:28:33 -07:00
Anthony Dresser
823d136a00
No browser from common ( #7178 )
...
* no browser from common
* clean up some imports
2019-09-12 14:52:42 -07:00
Anthony Dresser
02f497712d
clean up some promise use in cms ( #7004 )
2019-09-06 15:58:47 -07:00
Anthony Dresser
5b9a08359d
remove circular dependency between server group and connection management ( #6916 )
2019-08-23 14:53:54 -07:00
Charles Gagnon
8a6dc02e5b
Change double-quote hygiene rule to tslint rule ( #6514 )
2019-08-05 09:46:22 -07:00
Anthony Dresser
c1acf6ae93
More work around isolating node imports ( #6512 )
...
* more work around isolating node imports
* rewrite query plan input
* fix hygiene errors
* fix tests
* address feedback
* remove welcome page changes
2019-07-30 14:01:37 -07:00
Charles Gagnon
86cde4c511
Fix some connection listener leaks ( #6357 )
...
* Fix some connection listener leaks
* More descriptive name and update summary
* Dispose some more connections and fix a few spelling errors
2019-07-29 11:00:11 -07:00
Charles Gagnon
b2b2840990
Add double quotes for localize hygiene check ( #6492 )
...
* Add localize single quote hygiene task
* Update localize calls
* Update comment
* Fix build failures and remove test code
2019-07-25 10:35:14 -07:00
