ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 01:25:39 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,153 Commits 1 Branch 152 Tags
9aaa78e0201afeac5b4c9638ec00585f08355142
Commit Graph

244 Commits

Author SHA1 Message Date
Chris LaFreniere
9aaa78e020 Stop forcing left text align on tables (#13840) 2020-12-17 13:15:40 -08:00
Hale Rankin
385800553c Removed padding-top / bottom declarations for text cell notebook-preview. This compacts the text cell by 14px on top and bottom. (#13815) 2020-12-17 12:33:22 -08:00
Chris LaFreniere
e9964a4dfd Fix duplicate SVG rendering (#13828) 2020-12-16 18:25:05 -08:00
Chris LaFreniere
7b06194199 Remove hardcoded search box height (#13823) 2020-12-16 15:08:06 -08:00
Chris LaFreniere
1f630b9767 Notebook Deep Link to Section (#13795) 
* Notebook deep link to section

* fragment wip
 2020-12-14 17:20:29 -08:00
Vasu Bhog
133958ea47 renable kernels dropdown test (#13727) 
Verify no skipped core tests
 2020-12-11 17:49:20 -08:00
Lucy Zhang
f96fd911c1 Notebooks: Remove result set summary from saved metadata (#13616) 
* remove result set summary from metadata

* remove batchId and id from celloutputmetadata

* remove extra line
 2020-12-07 12:28:07 -08:00
Chris LaFreniere
6349f1bd49 Prevent Table from Disappearing due to exception when looking for tHead (#13680) 
* Prevent exception when tHead doesn't exist at node

* Add test for no thead
 2020-12-04 14:42:24 -08:00
Vasu Bhog
048f85d918 Fix notebook unordered grid values after papermill execution (#13614) 
* Fix unordered table

* check entire first row schema:

* SQL Notebooks should not get affected

* delete unused variable and edit comments

* refactor for efficient table ordering

* nit naming
 2020-12-03 19:37:22 -06:00
Barbara Valdez
08735c9434 add right padding to notebook toolbar action item (#13640) 
* add right padding to action item

* remove extra line and add space
 2020-12-03 10:23:20 -08:00
Chris LaFreniere
d86e1eec10 WYSIWYG Improvements to highlight (#13032) 
* Improvements to highlight

* wip

* Tests pass

* Leverage escaping mechanism

* Tweak highlight logic

* PR comments
 2020-12-02 15:51:40 -08:00
Vasu Bhog
2a7b90fd70 Fix WYSIWYG text + image paste (#13542) 
* Fix WYSIWYG text + image paste

* add test for a link and text
 2020-11-25 12:42:07 -06:00
Maddy
4b7baa652f update css to remove extra padding (#13491) 2020-11-24 10:47:52 -08:00
Lucy Zhang
aa30b52d03 Notebooks: Fix query results not displaying table rows (#13488) 
* fix PQSQL queries not displaying rows

* comment

* change comment and fix unit test
 2020-11-20 15:31:01 -08:00
Justin M
271fe62344 12567 Fixed Notebooks not adding to recent connections (#13113) 
* 12567 Changed tryAddActiveConnection to always add recent connection

* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel

* 12567 Simplified conditional in connectionDialogService
 2020-11-16 11:27:09 -08:00
Lucy Zhang
32a6385fef Notebooks: Save cell connection name in cell metadata (#13208) 
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* save/read cell connection name to/from metadata

* get started on toggling multi connection mode

* add activeConnection property to cell model

* add changeContext method for cell

* add comments

* add unit test for reading connection name

* save connection mode in metadata

* clean up code

* address PR comments
 2020-11-12 10:44:34 -08:00
Lucy Zhang
b397150264 Notebooks: Add smoke test (#13196) 
* add new smoketest

* change repro

* rename methods

* add waitforallresults method

* pr comment
 2020-11-10 17:31:17 -08:00
Chris LaFreniere
8c6a966bb9 Re-enable notebook editor unit tests (#13328) 
* wip

* Re-enable notebook editor tests

* PR Feedback
 2020-11-10 17:04:30 -08:00
Vasu Bhog
7cd4964f35 Fix for < > (non HTML) tags disappearing in WYSIWYG (#13267) 
* Push the latest update for WYSIWYG bug

* Improvements to nested lists

* OL tests and PR feedback

* Fixed all toolbar options for tags

* Address PR comments

* Ensure style is kept and not escaped

* Add all markdown toolbar action tests

* Style text edge case fix

* Address repeat function and type comment

* add more clarifying test
 2020-11-09 20:26:28 -06:00
Aditya Bist
9d766198b5 fix connection and notebook icons not highlighting (#13314) 2020-11-09 13:12:34 -08:00
Barbara Valdez
3f76d343a5 Table with no headings gets corrupted when editing (#13293) 
* fix data loss issue when modifying table with no headings

* fix comment

* Add tests and extra empty space to empty header format
 2020-11-09 09:42:42 -08:00
Barbara Valdez
e83d3ba57f Remove button property setter causing exception (#13284) 
* Fix navigation buttons

* Remove icon set in welcome page
 2020-11-06 14:49:14 -08:00
Chris LaFreniere
e4390db779 WYSIWYG fix list nesting (#13251) 
* Improvements to nested lists

* OL tests and PR feedback
 2020-11-05 18:21:33 -08:00
Maddy
6c37ac56b7 fix delete behavior on text cells. (#13153) 
* remove default <p> text and add css instead

* remove the top/bottom padding on preview markdown
 2020-11-05 14:19:11 -08:00
Chris LaFreniere
8877d74034 Check for clientSession before property (#13198) 2020-11-04 16:28:59 -08:00
Lucy Zhang
7bdb7c328a add unit test for data conversion (#13190) 2020-11-03 15:05:57 -08:00
Chris LaFreniere
7559d8463f Ensure trusted action is enabled (#13174) 2020-11-02 10:48:13 -08:00
Charles Gagnon
341f7aa7ad Enable script to notebook actions under preview flag (#13164) 2020-10-30 15:24:35 -07:00
Lucy Zhang
69527f91b0 Notebooks: Save connection information in metadata (#13060) 
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* dont show saved conn if seting off + added test

* show conn dialog if save conn name setting off

* address PR comments and fix unit test

* change connectionName to connection_name
 2020-10-30 13:56:33 -07:00
Chris LaFreniere
31817c5494 Fix plotly responsiveness (#13119) 2020-10-28 15:40:46 -07:00
Lucy Zhang
86357b45b0 Notebooks: re-factor grid streaming (#12937) 
* refactor grid streaming (convert to data first)

* change convertRowsToHtml method to return value

* remove griddataconversioncomplete checks

* send row data from STS to gridoutput component

* clean up code

* send data updates to cell model

* serialize cell output at the end of cell execution

* remove unused parameters

* update output contents instead of output reference

* remove unnecessary promise

* move azdata changes to proposed

* update comment
 2020-10-28 09:08:15 -07:00
Vasu Bhog
cb30dd1893 Notebook Parameterization - Papermill Compatibility (#13034) 
* Parameterization papermill fix

* Utilize isParameter instead

* Address PR comments, and fix tests

* Address comment
 2020-10-23 20:32:55 -05:00
Vasu Bhog
bf9fd5a3b8 UI Component for Parameterized Notebook (#13021) 
* Backend work for  Parameterization + Tests

* address comments

* Add Parameters Tag upon state change

* Edit CSS Styling for accessibility

* more generic tag names
 2020-10-23 19:51:03 -05:00
Charles Gagnon
2d182fcd03 Remove calls to DOM.addClass and DOM.removeClass (#13063) 2020-10-23 14:42:22 -07:00
Chris LaFreniere
ff8e451af9 Further enhancements to spans (#13035) 2020-10-22 13:21:05 -07:00
Chris LaFreniere
a427606050 WYSIWYG Span Style Fixes, Refactor, and Tests (#13011) 
* Refactor into own class, add tests

* Add more tests

* Test fixes

* Test fix hopefully

* Tests D vs C drive
 2020-10-21 16:55:41 -07:00
Vasu Bhog
fcec690546 Backend work for Notebook Parameterization and Tests (#12914) 
* Backend work for  Parameterization + Tests

* minor comments

* fix test

* address comments
 2020-10-20 13:26:59 -05:00
Barbara Valdez
2801e59edc Fix links on WYSIWYG (#12952) 
* fix for removed links in untrusted notebooks

* replace whitespaces on link for %20

* remove dot from hyperlinks

* Address PR comments

* Change name of variable
 2020-10-16 17:51:14 -07:00
Tony Xia
c7e4cf7ca4 Componenet -> Component (#12934) 2020-10-15 10:47:47 -07:00
Lucy Zhang
7bc26cc493 Add simple notebook smoke test (#12898) 
* add simple notebook smoke test

* add id for notebook dropdown elements
 2020-10-14 05:58:32 -07:00
Lucy Zhang
b910bf2f33 Notebooks: Fix strict compile errors (#12591) 
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
 2020-10-08 15:39:57 -07:00
Chris LaFreniere
e61cc474a3 default to relative links in images and links (#12802) 2020-10-08 10:50:34 -07:00
Chris LaFreniere
23e2a5dd12 Notebooks: WYSIWYG Add Redo, Fix Shortcuts (#12752) 
* Add redo and out/indent

* Check for active cell before doing shortcut

* PR feedback

* Remove unnecessary parameter
 2020-10-06 21:47:07 -07:00
Barbara Valdez
825663fd77 Fix search for pinned notebooks (#12719) 
* fix search for pinned notebooks

* fix filtering when verifying that a search folder is not a subdirectory from the current folder queries path

* Show book node on pinned notebooks search results

* fix parent node on pinned notebooks search results

* fix search for pinned notebook and modify how pinned notebooks are stored in workspace

* update format of pinned notebooks for users that used the september release version

* removed unused functions

* Address PR comments

* fix parent node for legacy version of jupyter books

* remove cast from book path
 2020-10-06 11:54:42 -07:00
Vasu Bhog
726f0cef0e Add Notebook tests for Kernel Alias connections (#12722) 
* More Generic tests for kernel alias connections

* Kernel Alias tests for the Notebook Model

* Updated titles of tests
 2020-10-05 23:17:41 -05:00
Christopher Suh
6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295) 
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
 2020-10-03 11:42:05 -07:00
Lucy Zhang
cf9754f627 revert grid streaming changes (#12650) 2020-09-28 18:34:58 -07:00
Lucy Zhang
f8eb203643 add event.preventDefault() (#12564) 2020-09-23 07:10:36 -07:00
Lucy Zhang
3fd92adf78 Add test for notebook result grid streaming (#12539) 
* start testing convertAllData

* add test for convertAllData method

* clean up code
 2020-09-22 12:15:33 -07:00
Barbara Valdez
b110e4dea1 In-Viewlet Notebooks Search (#12455) 
* fix search

* Add sql carbon tags to vs files

Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: abist <adbist@microsoft.com>
 2020-09-19 14:38:27 -07:00