ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-02 09:35:40 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,473 Commits 1 Branch 152 Tags
9ae254c91ed6192bcb080482f50170922f534337
Commit Graph

2896 Commits

Author SHA1 Message Date
Alan Ren
4772be5dcc handle query gallery with tags (#14633) (#14636) 
* handle query gallery with tags

* fix typo
 2021-03-10 16:10:42 -08:00
Aasim Khan
41e756b906 Fixing welcome page tour. (#14640) (#14661) 
* Fixing the icon names

* Fixing settings card position

* getting icon selectors from their source

* Changing var name from dataExplorer to dataExplorerId
 2021-03-10 16:09:06 -08:00
Hale Rankin
972b649beb Connection error box style fix (#14469) 
* Modified modal styles, limiting height of basic modal to 480px.

* wip - added new attachCalloutDialogStyler. Moved callout-specific styler code out of modal.ts

* Moved attach styler code to workbench/common. Added custom styles to imageCalloutDialog

* Moved styler code into calloutDialog. Added callout-specific theme colors to colorRegistry. Removed color styles from modal and callout stylesheets.

* Added CalloutDialogModal that extends CalloutDialog so that the callout can be instantiated from core. Revised calloutDialog so the position cn be passed in from where it is instantiated.

* Revised refactor of modal and image/link callouts so that callout dialog invoked by core can also use the styler. Removed unused properties from dialog code.

* Added conditional to dialogModal to use correct styler for callouts.

* Cleaned up styles. Modified custom colors.

* Wrapped call to positionCalloutDialog in conditional.

* Style, colors, styler and modal updates to align callout with latest OPAC toolkit styles.

* Moved calloutDialog stylesheet

* Consolidated styler code and added a flexible custom styler to provide values for dialogModal

* Added image callout code.

* Remove image callout dialog until wired fully

* Test fixes

Co-authored-by: chlafreniere <hichise@gmail.com>
 2021-03-05 17:34:02 -08:00
Lucy Zhang
f125b9b2c7 Notebooks: Fix callout dialog being cut off at the bottom of the document (#14579) 
* add above position for callout dialog

* use if else
 2021-03-05 15:23:44 -08:00
Drew Skwiers-Koballa
733c3628a1 drag n drop bounding characters (pgsql fix) (#14376) 
* specifies object handling for all current providers

* implements the same for column dragndrop

* adjusted test

* adds pgsql provider name constant
 2021-03-05 15:22:47 -08:00
Alan Ren
1d60287795 give more flexibility to the dialog width setting (#14570) 
* give more flexibility to the dialog width setting

* one more place
 2021-03-05 15:01:29 -08:00
Charles Gagnon
df06afa2ab Fix undefined error in telemetry service (#14577) 2021-03-05 12:46:03 -08:00
Vladimir Chernov
89c3207c94 sqlAssessment sync display fix (#14574) 
* sqlAssessment sync display fix

* making append data Thenable<void>
 2021-03-05 23:42:07 +03:00
Maddy
b82942a030 show find in notebook when opening from searchResults view (#14447) 
* initial changes

* open notebook through our command

* address comments
 2021-03-05 10:49:09 -08:00
Charles Gagnon
f6f45bc3f9 Add event for connection error (#14564) 2021-03-05 09:02:54 -08:00
Charles Gagnon
d2faf9075d Clean up dialog event hide reasons (#14566) 
* Clean up dialog event hide reasons

* Remove done
 2021-03-05 08:54:35 -08:00
Karl Burtram
1167e247af Fix hover tooltips (#14561) 2021-03-04 17:38:59 -08:00
Alan Ren
99d46917e8 remove refreshNode method (#14552) 
* remove refreshNode method

* fix issue with finding required node handles
 2021-03-04 15:15:15 -08:00
Kim Santiago
9cfba8e8e0 Reload ADS when data-workspace extension opens a workspace (#14540) 
* reload ADS when workspace is entered

* move reloading so that reload also happens for file save workspace as commands

* fix build error
 2021-03-04 13:40:13 -08:00
Chris LaFreniere
69a35b38b2 Callout Dialog Fixes + WYSIWYG Improvements for Insert Link (#14494) 
* wip

* Works in all edit modes

* Default value set

* wip

* preventdefault

* cleanup, add tests

* markup -> markdown

* Ensure selection is persisted for WYSIWYG

* Add simple dialog tests and some PR feedback

* floating promise

* PR comments, formatted markdown refactor

* Change escaping logic + PR comments

* PR feedback
 2021-03-04 12:51:13 -08:00
Vasu Bhog
0141db80bc [Notebook] Open Kernel Alias (Kusto) notebook with Kernel Alias (Kusto) as selected kernel (#14504) 
* Open kernel alias notebook with kernel alias as selected kernel

* Add language info test

* fix test

Co-authored-by: Vasu Bhog <bhogvu@mail.uc.edu>
 2021-03-04 12:36:25 -08:00
Chris LaFreniere
8c04266ff4 Notebooks: Persist Chart Data when Re-Executing Cell (#14512) 
* empty chart

* Update chart data appropriately

* Adding tests

* wip, cleanup

* PR feedback
 2021-03-03 22:40:11 -08:00
Kim Santiago
42fba14d88 Fix how data workspace handles untitled workspaces (#14505) 
* add more workspace apis

* update dialog and check workspace scheme

* cleanup

* add comment

* update create project from db dialog

* cleanup

* update names

* add test
 2021-03-03 15:31:21 -08:00
Chris LaFreniere
6ecacd6faa wip (#14530) 2021-03-03 11:50:44 -08:00
Maddy
ae55da3c35 fix the check (#14529) 2021-03-03 11:28:12 -08:00
Charles Gagnon
625c4520da Fix input box validation (#14508) 
* Fix input box validation

* just use return from inputbox validate
 2021-03-03 10:19:10 -08:00
Chris LaFreniere
56dcd4ba50 Only serialize attachments in JSON if exists (#14516) 2021-03-03 09:06:16 -08:00
Alan Ren
36e228ebf7 fix description not provided issue (#14510) 2021-03-02 18:07:40 -08:00
Alan Ren
18bdb0f37d pass in notification service (#14499) 
* pass in notification service

* make the parameter required
 2021-03-02 13:39:31 -08:00
Hale Rankin
3c38e0cc8b Notebook cell and modal fix - follow up after Lucy's 14433. (#14457) 
* Modal - added code to stop the keyboard event after it is handled. textCell and codeCell - onKey now fired on keydown.

* Moved stop method into the conditional with Escape key.
 2021-03-02 12:11:57 -08:00
Chris LaFreniere
9273572d5a Fix cell attachment types (#14485) 2021-03-01 15:06:12 -08:00
Charles Gagnon
ff508b1bf4 Lint typings (#14488) 2021-03-01 14:42:26 -08:00
Maddy
af3373bc4b check for isDirty false explicitly (#14427) 
* check for isDirty false explicitly

* revert back test to not pass isDirty
 2021-03-01 14:14:00 -08:00
Maddy
14b9628b52 fix: find highlight disappears on clicking the cell (#14342) 
* update content only when changed

* maintain thr highlight on rerenders

* pr comments
 2021-03-01 13:43:41 -08:00
Chris LaFreniere
48a63e1f50 Notebooks: Add Support for Cell Attachment Images (#14449) 
* Add to interfaces

* Works E2E

* Consolidate interface

* Add comments, cleanup

* Add some tests

* Cleanup

* interface cleanup

* Add more tests

* Add comments

* Add type for cell attachment

* wip
 2021-02-28 16:40:41 -08:00
Justin M
c6c65000ca Added NoAuth authenticationType for Kusto (#14375) 
* Added NoAuth authenticationType for Kusto

* Added SqlLogin to Kusto as an AuthType. Renamed NoAuth to None
 2021-02-26 12:28:43 -08:00
Lucy Zhang
ab114376aa fix python wizard behavior and enable smoke test (#14433) 2021-02-26 05:04:27 -08:00
Chris LaFreniere
dbc655a8f5 Notebooks: Ensure WYSIWYG Mode for Keyboard Shortcuts (#14416) 
* Ensure WYSIWYG Mode for kb shortcuts

* Move logic down to cell model
 2021-02-25 16:57:06 -08:00
Hale Rankin
9e02cf86a4 calloutDialog refactor - new superclasses for insert image and insert link (#14385) 
* calloutDialog refactor - split code specific to image and link into their own super classes. Moved callout styles into a new stylesheet.

* Image and Link inserts working.

* Stylesheets cleanup. Refactor cleanup.

* Removed CSS comment. Added missing image callout style. Revised generic open and cancel classes. Moved all remaining localized strings into shared constants file.
 2021-02-25 14:44:25 -08:00
Aditya Bist
2a125ee43b normalize sql carbon tag (#14445) 2021-02-25 13:32:12 -08:00
Alan Ren
b28e845506 fix multiple button issue (#14443) 2021-02-25 13:23:56 -08:00
Alan Ren
48c456709e limit the digits after decimal point (#14422) 2021-02-24 13:07:37 -08:00
Charles Gagnon
4b40d66bca Add IconPath type (#14420) 
* Add IconPath type

* Add ThemedIconPath subtype

* Update type
 2021-02-24 12:49:54 -08:00
Chris LaFreniere
94f7b329d6 Remove CSS Class that doesn't exist (#14401) 2021-02-23 18:28:25 -08:00
Alan Ren
561242a0d9 implement styler for infobutton (#14396) 
* implement styler for infobutton

* comments

* one more comment
 2021-02-23 13:28:48 -08:00
Alan Ren
e266bbd562 fix the dashboard toolbar not load issue (#14397) 2021-02-23 09:43:04 -08:00
Alan Ren
eb58cd74e7 add attach styler for modal dialog footer buttons (#14395) 2021-02-23 09:40:10 -08:00
Alan Ren
289dd3ba65 fix a few issues (#14378) 2021-02-21 17:58:39 -08:00
Alan Ren
83da03a728 selected cell summary for status bar (#14358) 2021-02-19 11:29:04 -08:00
Chris LaFreniere
f528ffea9b Hide Open in Editor for notebook search (#14356) 
* Hide Open in Editor for notebook search

* Add type to new parameter
 2021-02-19 11:05:02 -08:00
Christopher Suh
fcd099dd64 Bumped turndown version (#14343) 
* bumped turndown

* fix WYSIWYG test

* remove comment

Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
 2021-02-18 20:36:32 -05:00
v-bbrady
ce18341284 Updates welcome page responsiveness (#13913) 
* updates copy

* localizes copy

* updates welcome page UI responsiveness at direction from designers

* adjusts layout

* updates pr according to review comments

* localizes copy on welcome page
 2021-02-18 10:52:33 -08:00
Justin M
aff9adf730 Add dstsAuth as option for saved credential in connectionStore.ts (#14332) 2021-02-18 10:30:02 -08:00
Alan Ren
30f55be67d fix the header filter plugin issue (#14333) 2021-02-18 00:10:41 -08:00
Maddy
87a9ae0975 fix for parameterized notebook closure. (#14324) 
* Two options

* remove commented line and add the null check

* fix tests: pass isDirty explicitly

* remove commented line

Co-authored-by: chlafreniere <hichise@gmail.com>
 2021-02-17 19:16:31 -08:00