Commit Graph

29 Commits

Author SHA1 Message Date
Alan Ren
9ec68087ac allow database name to be empty (#20221)
* allow database to be empty

* test changes

* fix import

* fix test cases

* comment
2022-08-11 10:26:55 -07:00
Alan Ren
6be1420220 do not run query in multi-selection mode (#20213)
* do not run query in multi-selection mode

* fix test

* fix more tests
2022-07-30 14:29:32 -07:00
Lewis Sanchez
8f93fd9d09 Updates Actual Execution Plan button icon (#20018) 2022-07-12 17:14:49 -07:00
Lewis Sanchez
811aa18862 Centralizes localized category string (#19857) 2022-06-28 16:58:09 -07:00
Lewis Sanchez
800f2cebb5 Updates actual plan text to enable/disable instead of include/exclude (#19796)
* Updates actual plan text to enable/disable instead of include/exclude

* Makes actual plan button text static and readonly
2022-06-22 14:59:13 -07:00
Lewis Sanchez
20d2256709 Adds toggle button to switch between estimated and actual execution plans (#19629)
* Creates toggle button to switch between estimate and actual query plans

* Renames ID for the toggleActualExecutionPlanModeAction class

* Renames button back to explain

* Creating actual execution plans resembles SSMS

* Adds CTRL/CMD + L shortcut to display estimated execution plans

* Alphabetically organizes telemetry actions

* Adds telemetry when the setting for actual execution plan toggle is used

* Resolves build errors

* Fixes broken unit tests.

* Code review changes

* Removes unnecessary null-coalescing operator.

* Creates placeholder icons for actual execution plans enabled

* Code review changes

* Shortens label names

* Telemetry moved to toggle button

* Telemetry review changes

* Clarifies misleading label
2022-06-09 16:07:12 -07:00
Aditya Bist
a2c39369c9 Add and move editable dropdown (#18589)
* add and move editable dropdown

* merge dropdowns

* merge dropdown cell factories

* add new column and hide in properties

* remove editable property
2022-03-03 20:23:20 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Alan Ren
b48f392ab2 optional database name option (#17538)
* optional database name option

* object explorer connection title

* revert unexpected change

* bug fixes
2021-10-29 16:37:35 -07:00
Hai Cao
0e4c67dc0c Add AAD token expiration handling for query runner (#17117)
* Add AAD token refresh for notebook

* move token refresh to query management and remove previous refresh calls
2021-09-21 18:57:54 -07:00
Hai Cao
e9c48da4b7 Simplify connection checks in RunQueryAction (#17018) 2021-09-07 16:48:23 -07:00
Hai Cao
0bc2a50d78 Add token expiration handling for AzureMFA auth (#16936)
* refresh azure account token if it's expired before sending query/list requests

* fix several connection checks && add more logging

* fix async UI glitch during token refreshing

* cleanup

* minor fix

* add test for refreshAzureAccountTokenIfNecessary

* address comments

* comments

* comments

* comments

* error handling
2021-09-02 17:24:45 -07:00
Chris LaFreniere
502feba76d Hide suggest widget on cell execution (#16895)
* Hide suggest widget on cell execution

* Also hide for query editor

* Fix compile issue with tests
2021-09-01 16:27:08 -07:00
Lewis Sanchez
02dbac3b5f Enable Azure Data Studio's database selector to behave like SSMS' (#16681)
* Enable Azure Data Studio's database selector to behave like the one in SSMS

* Revert "Enable Azure Data Studio's database selector to behave like the one in SSMS"

This reverts commit d146eef998a3192f76df80794a31a45c8be7f786.

* Database selector auto commits selection

* Adds comment explaining change

* Auto commits selected database on blur

* Confirms db name changed before committing db selection

* Moves changed db check to selected database method

* Makes use of dbName instead of having to get value from dropdown

* Code review change
2021-08-23 11:26:33 -07:00
Alan Ren
2e2e6e2767 remove special case (#16779) 2021-08-16 10:47:39 -07:00
Aditya Bist
2f8e2f3132 Synapse query editor dropdown fix (#16684)
* formatting

* update comment

* format doc

* fix connection test

* remove unused imports

* test server info mock

* try with mocks

* add server info check for tests

* added logic for corner case
2021-08-12 12:28:55 -07:00
Charles Gagnon
3cb2f552a6 Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898 (#15681)
* Merge from vscode a348d103d1256a06a2c9b3f9b406298a9fef6898

* Fixes and cleanup

* Distro

* Fix hygiene yarn

* delete no yarn lock changes file

* Fix hygiene

* Fix layer check

* Fix CI

* Skip lib checks

* Remove tests deleted in vs code

* Fix tests

* Distro

* Fix tests and add removed extension point

* Skip failing notebook tests for now

* Disable broken tests and cleanup build folder

* Update yarn.lock and fix smoke tests

* Bump sqlite

* fix contributed actions and file spacing

* Fix user data path

* Update yarn.locks

Co-authored-by: ADS Merger <karlb@microsoft.com>
2021-06-17 08:17:11 -07:00
Charles Gagnon
dcd952b903 Fix error when disconnecting database (#15146)
* Fix error when disconnecting database

* correctly print error
2021-04-16 09:24:22 -07:00
Charles Gagnon
ce6ea8af41 Fix dropdown error & editor database dropdown validation (#14946)
* Fix dropdown error & editor database dropdown validation

* Set initial values

* Update comment

* hygiene

* remove unused

* Fix tests
2021-04-01 14:52:55 -07:00
Alan Ren
99e3da5b48 Editable dropdown component improvement (#13389)
* replace Tree with List

* comments
2020-11-13 13:36:54 -08:00
Shafiq Ur Rahman
97b6d71a06 Kusto - ADS Core changes (#11750)
* ADS Core changes

* Generic fix to get language mode based on providerId

* Addressed comments

* Fix failing tests

* Fix for "New Notebook" from file menu option

* Remove line

* Fix for merge conflict

* Add removed comment back

* Addressed comments

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
2020-08-19 12:27:16 -07:00
Charles Gagnon
694f34a4cd Add Notebook <-> SQL convert (#11590)
* Add Notebook <-> SQL convert

* Update STS
2020-08-03 14:50:24 -07:00
Aasim Khan
75e3e4c8c9 Fix for "Run Current Query" keybind no longer behaving as expected (#10538) (#10557)
* -"Run current" command runs the entire selection instead of only first statement in the selection

* -brought some logic back from the  old code to correct the behavior

* -Added unit tests for runCurrent command

* -Fixed a comment

* - Added checks for run input parameters

* -Added some extra checks

* -Fixed some spacing issue

* Changed to using verify instead of a counter variable
2020-06-08 14:42:07 -07:00
Anthony Dresser
df5df38a55 Query Runner Tests (#10252)
* rework some code and write an inital test

* fix strict

* add more to standard test

* add to existing workflow test

* fix tests

* simplify the code

* add more tests

* remove bad import

* fix compile

* fix timestampiong
2020-05-06 13:38:12 -07:00
Anthony Dresser
a7dbb68f7d Fix handling of connections in editors (#9682)
* fix handling of connections in editors

* initial tests

* remove test
2020-03-21 14:13:32 -07:00
Anthony Dresser
506c6a5e5f More Layering (#9139)
* move handling generated files to the serilization classes

* remove unneeded methods

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* wip

* remove jsdoc

* fix layering

* fix compile

* fix compile errors

* wip

* wip

* finish layering

* fix css

* more layering

* rip

* reworking results serializer

* move some files around

* move capabilities to platform wip

* implement capabilities register provider

* fix capabilities service

* fix usage of the regist4ry

* add contribution

* wip

* wip

* wip

* remove no longer good parts

* fix strict-nulls

* fix issues with startup

* another try

* fix startup

* fix imports

* fix tests

* fix tests

* fix more tests

* fix tests

* fix more tests

* fix broken test

* fix tabbing

* fix naming

* wip

* finished layering

* fix imports

* fix valid layers

* fix layers
2020-02-15 01:54:23 -06:00
Anthony Dresser
74b89a0a85 No console linting (#9156)
* add no-console linting and change to just using overrides for sql files

* whitespace

* fix tests
2020-02-14 21:13:16 -06:00
Anthony Dresser
56695be14a More layering and compile strictness (#8973)
* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* remove jsdoc
2020-01-29 20:35:11 -08:00
Anthony Dresser
7a2c30e159 move code from parts to contrib (#8319) 2019-11-14 12:23:11 -08:00