Commit Graph

580 Commits

Author SHA1 Message Date
Lewis Sanchez
20d2256709 Adds toggle button to switch between estimated and actual execution plans (#19629)
* Creates toggle button to switch between estimate and actual query plans

* Renames ID for the toggleActualExecutionPlanModeAction class

* Renames button back to explain

* Creating actual execution plans resembles SSMS

* Adds CTRL/CMD + L shortcut to display estimated execution plans

* Alphabetically organizes telemetry actions

* Adds telemetry when the setting for actual execution plan toggle is used

* Resolves build errors

* Fixes broken unit tests.

* Code review changes

* Removes unnecessary null-coalescing operator.

* Creates placeholder icons for actual execution plans enabled

* Code review changes

* Shortens label names

* Telemetry moved to toggle button

* Telemetry review changes

* Clarifies misleading label
2022-06-09 16:07:12 -07:00
Aasim Khan
0b89272739 Removing filter from set Data (#19640) 2022-06-06 13:44:42 -07:00
Aasim Khan
36c480699f Surfacing extension install errors (#19613)
* Surfacing extension install error

* Fixing error property

* removing unncessary await

* Fixing error type and message

* Fixing some more strings

* Adding missing period

* Consolidating some strings

* consolidating strings

* revert vbump

* Switching to ExtensionManagementError
2022-06-03 19:41:09 -07:00
Aasim Khan
b63fd59372 Adding plan properties comparison, fixed dark icons, fixed dropdown text. (#19601)
* Adding prop compare logic

* Fixed using semaphore

* Adding dark icons
Adding dropdown prefix
Adding all visible plans from plan comparison

* Reverting mssql vbump

* Fixing icon name

* executionPlanComparisonPropertiesView

* Fixing icon paths and adding preselect model

* Fixed icon spacing

* Removing styling in formatter

* Adding tooltip to plugs
switching to plugins

* Removing unecessary calls to getSkeletonNodes()

* Renaming variable

* Fixed column value formatting

* Undoing formatter change
2022-06-03 16:31:03 -07:00
Alan Ren
b8858f011d support for connect with connection string (#19355)
* wip

* WIP

* radio button

* handle connection string

* fix test

* fix test

* fix test cases

* remember password

* pr comments

* pr comments
2022-05-13 14:48:12 -07:00
Aditya Bist
784d8e9e96 Table Designer: Move columns UI (#19154)
* format

* added buttons and initial drag plugin

* initial drag and drop working

* add actions and taskbar

* drag and drop bugfix and other changes

* fix few issues

* more changes

* fix all move and insertion issues

* PRcomments

* fit and finish comments

* remove dead code

* bump sts

* add style for object being dragged

* add plugin to copyright filter

* Add to eslintrc

* fix drag contrast ratio

* generalize logic for cell focus

* demo feedback

* feedback

* add action state

* feedback

* remove unncecessary check

* add move actions to context menu

* change to const

* fix bug with tables and fix drop color

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-05-12 10:49:45 -07:00
Aasim Khan
7e57503aa6 Adding ability to expand and columns slickgrid table rows (#19168)
* Adding ability to expand and columns tables

* Bolding icons
Fixing variable names

* Adding helper function
Making css more target

* Adding keyboard navigation and parsing treegrid data

* Adding attributes, data transformations and key events to the treegrid

* Expanded

* changing var name

* FIxing formatter name

* Adding back cell styling

* Removing comments

* Making a new TreeGrid component.
Separating treegrid logic from tableDataView

* Fixing comments

* changing method name

* Modifying only visible row dom attributes

* Removing white space, moving role attribute setter to constructor.

* Fixing some more PR comments

* Adding comments and renaming functions

* Fixing comments

* Fixing comments

* Fixing comments

* Fixing some logic and removing unused attributes from element

* Adding expandable formatter to the first column

* Making the formatter generic

* Reverting formatter code

* Adding doc comments

* Fixing comments

* Removing duplicated code

* Adding comments

* Setting columns only when the table is initialized

* Letting users set expanded state instead of forcing it to false
2022-05-09 15:53:22 -07:00
Aasim Khan
d0aae8e95b Adding ability to style cells in slickgrid (#19195) 2022-04-25 09:09:53 -07:00
Alan Ren
5ec567a4f7 add title for color box (#19121) 2022-04-15 12:56:07 -07:00
Aasim Khan
dd2d6e0b5c Adding link support to infobox. (#18876) 2022-04-11 20:39:41 -07:00
Alan Ren
fe1aefdd5f fix table designer issues (#18988)
* fix table designer issues

* commit change on blur

* new sts
2022-04-10 12:09:33 -07:00
Aasim Khan
4db0814b94 Adding context menu to table component (#18914)
* Adding context menu to table component

* Removing extra whitespace

* Some logic fixes

* Fixing focus logic
2022-04-04 23:47:39 -07:00
Alan Ren
a795e64bed fix language change issue (#18906) 2022-04-01 17:52:11 -07:00
Alan Ren
b6083b6447 handle special values in the table filter (#18872)
* handle special values in the table filter

* pr comments
2022-03-31 11:17:55 -07:00
Alan Ren
f2d4801634 change the trigger of inputbox commit event (#18776) 2022-03-18 13:16:43 -07:00
Aasim Khan
6c51b934f9 Fixing clickable state of infobox not setting properly when initializing it. (#18763)
* Fixing clickable state of infobox not set when initializing it.

* Removing unnecessary calls to a method
2022-03-17 14:11:15 -07:00
Alan Ren
4551329db0 table designer bug fixes (#18701)
* table designer bug fixes

* pr comments

* fix debounce issue
2022-03-11 12:14:51 -08:00
Aasim Khan
b299f7ed3f Making infobox clickable (#18676)
* Making infobox clickable

* Making it accessible

* Moving API to proposed

* Matching styling from portal

* Fixing some styling

* Moving to proposed

* Removing extra spacing

* Registering and Unregistering listeners

* Fixing listeners

* Registering emitter only once.

* Changing emitter type from undefined to void

* Adding arialabel to clickable link

* Changing property name to suit its purpose
2022-03-09 18:43:39 -08:00
Alan Ren
e50bded5d1 table designer new features (#18682)
* support graph tables

* ignore script compare

* ability to refresh view after edit

* reserve focus after refresh view

* primary key and default constraint

* bug fixes

* vbump sts

* comments

* update type

* fix issue
2022-03-09 14:17:01 -08:00
Aditya Bist
a2c39369c9 Add and move editable dropdown (#18589)
* add and move editable dropdown

* merge dropdowns

* merge dropdown cell factories

* add new column and hide in properties

* remove editable property
2022-03-03 20:23:20 -08:00
Cory Rivera
ffdefd3b52 Add notebook extension support for .NET Interactive. (#18334)
* Also updated kernel dropdown to only include SQL aliased kernels when using SQL notebook provider.
2022-02-25 11:58:59 -08:00
Alan Ren
28ab7372d2 table designer validation support (#18438)
* table designer validation

* vbump sts
2022-02-17 13:07:19 -08:00
Aasim Khan
8ac09917ca Adding search, zoom, custom zoom and additional stylings to showplan (#18255)
* Lot of changes
-Updating azdata to 0.0.13
-Updating prop views on node clicks
-Context menu on graphs
-Updating edge color on theme
-Scrolling graph control like ssms
-Zooming in, out and custom zoom on graph
-Custom zoom widget
-Node search widget

* Fixing hygine errors

* Code cleanup

* Fixing action name

* Renaming actions

* equals dropdown

* fixing tooltip

* Code cleanup
Fixing sorting function
Adding functionality for replacement strings

* Removing internal facing props from azdata proposed

* Fixing hygine issue

* Fixing web package hygiene

* Updating yarn lock files

* Fixing initial click
2022-02-10 14:43:35 -08:00
Maddy
f17e70472f check for encoded components (#18231)
* check for encoded components

* address comments

* relocate and simplify test

* move encodeUrl to notebookLinkHandler

* added comments

* add containsEncodedUri to network.ts
2022-02-09 13:36:23 -08:00
Aasim Khan
e40c31559a Adding properties view and action bar to graph and fixing styling. (#18185)
* Adding properties view and action bar to graph.

* Open Graph File

* replacing innerhtml with  innertext

* Fixing floating promises

* Fixed typo

* renaming

* Fixing hardcoded colors and comments

* Removing todo and hardcoded colors

* renaming method

* removed unused contract

* Fixed path in comment

* converting div to button

* adding checks to table width and height setter

* Make method name more meaningful

* adding method return types

* concising repeated logic

* removing unused styling

* better sorting logic

* Fixing graph parsing
Renaming some stuff
Implementing IDisposable

* Fixing bad props logic

* Fixed image loading issue

* Removing hardcoded colors

* Adding comments to localize and handling undefined cases in sort

* Changed ch to px

* moving util function to strings
2022-02-02 14:17:01 -08:00
Cory Rivera
9685393975 Add placeholders for missing VSCode notebook events that are used by the Jupyter extension. (#18138)
* Also reduced the number of timeouts for waiting on notebook provider descriptors, and fixed an issue with undefined cancellation tokens in vscode notebook conversion code.
2022-01-25 14:03:33 -08:00
Cory Rivera
050d2cc98f Enable VSCode extension APIs for opening notebooks. (#18080)
* Also moved notebook conversion classes to a common folder, and moved several conversion utility methods to a common file.
2022-01-13 16:40:48 -08:00
Charles Gagnon
2bc6a0cd01 VS Code merge to df8fe74bd55313de0dd2303bc47a4aab0ca56b0e (#17979)
* Merge from vscode 504f934659740e9d41501cad9f162b54d7745ad9

* delete unused folders

* distro

* Bump build node version

* update chokidar

* FIx hygiene errors

* distro

* Fix extension lint issues

* Remove strict-vscode

* Add copyright header exemptions

* Bump vscode-extension-telemetry to fix webpacking issue with zone.js

* distro

* Fix failing tests (revert marked.js back to current one until we decide to update)

* Skip searchmodel test

* Fix mac build

* temp debug script loading

* Try disabling coverage

* log error too

* Revert "log error too"

This reverts commit af0183e5d4ab458fdf44b88fbfab9908d090526f.

* Revert "temp debug script loading"

This reverts commit 3d687d541c76db2c5b55626c78ae448d3c25089c.

* Add comments explaining coverage disabling

* Fix ansi_up loading issue

* Merge latest from ads

* Use newer option

* Fix compile

* add debug logging warn

* Always log stack

* log more

* undo debug

* Update to use correct base path (+cleanup)

* distro

* fix compile errors

* Remove strict-vscode

* Fix sql editors not showing

* Show db dropdown input & fix styling

* Fix more info in gallery

* Fix gallery asset requests

* Delete unused workflow

* Fix tapable resolutions for smoke test compile error

* Fix smoke compile

* Disable crash reporting

* Disable interactive

Co-authored-by: ADS Merger <karlb@microsoft.com>
2022-01-06 09:06:56 -08:00
Cory Rivera
2ecc3d35ca Initial implementation for VSCode Notebook support (#17885) 2022-01-03 15:59:37 -08:00
Alan Ren
af5575a852 fix table focus issue (#17970)
* fix table focus issue

* fix hygiene error

* web
2021-12-21 12:46:48 -08:00
Alan Ren
4608a4714d Revert "table keyboard focus (#17903)" (#17946)
This reverts commit 177663cc29.
2021-12-15 20:48:58 -08:00
Charles Gagnon
be933c88c0 Update setting description product name (Code -> ADS) (#17912) 2021-12-14 10:59:40 -08:00
Alan Ren
177663cc29 table keyboard focus (#17903)
* fix table keyboard focus issue

* add comments

* pr comment

* pr comments
2021-12-13 13:00:27 -08:00
Alan Ren
381dd901cc fix table focus issue (#17895) 2021-12-10 19:08:49 -08:00
Alan Ren
1006652a31 fix sorting bug (#17769)
* fix sorting bug

* comments
2021-11-30 17:11:57 -08:00
Aditya Bist
2a127beb28 Designer: property descriptions (#17668)
* format

* added strings

* format doc

* use codicon instead

* show descriptions in property pane only

* fix ssdt string bug

* fix overflow option

* review comments

* review comments

* changes
2021-11-16 14:50:05 -08:00
Alan Ren
c00c5e044b move the designer component to workbench layer (#17620) 2021-11-08 10:26:27 -08:00
Alan Ren
5f8e1f384f table designer editor icon (#17608)
* icon for table designer

* use more specific name

* use sql defined schema
2021-11-05 16:26:17 -07:00
Alan Ren
f5b1e7feb8 a couple properties pane UI changes (#17601) 2021-11-05 11:08:43 -07:00
Aditya Bist
99f5c406e3 Added editor to table designer (#17576)
* format doc

* correct class name

* set content

* remove mssql commands

* merge classes

* code refactoring and bug fixing

* remove unnecessary class

* handle promise

Co-authored-by: Alan Ren <alanren@microsoft.com>
2021-11-03 21:07:36 -07:00
Alan Ren
f3e1c2cc8b a few table designer improvements (#17588) 2021-11-03 17:57:47 -07:00
Charles Gagnon
43fe0ce482 VS Code -> ADS setting descriptions (#17563) 2021-11-03 10:05:56 -07:00
Alan Ren
a3a91fbdfc add column properties (#17574) 2021-11-02 18:50:44 -07:00
Alan Ren
12261aa7a2 text editor interface (#17527) 2021-10-28 13:23:33 -07:00
Alan Ren
8230d39120 add designer property grouping support (#17485)
* add properties grouping support

* revert unexpected changes

* use common color
2021-10-25 11:25:19 -07:00
Alan Ren
4ba192a5c3 make the designer event based (#17472)
* make the designer event based

* pr comments
2021-10-22 17:25:12 -07:00
Alan Ren
5fe569e864 fix scrolling issue (#17443) 2021-10-21 15:51:46 -07:00
Alan Ren
c89aa26c0a loading indicator for table designer (#17407)
* loading indicator for table designer

* fix layering error

* bug fix
2021-10-20 12:54:23 -07:00
Alan Ren
569d5cf694 rename dataModel to viewModel (#17387) 2021-10-19 09:52:03 -07:00
Alan Ren
fbdb434f3a designer pane separator (#17366)
* designer pane separator

* comments
2021-10-15 11:03:26 -07:00