Commit Graph

350 Commits

Author SHA1 Message Date
Vasu Bhog
a8ee26ed89 Move split cell icon (#17383)
* move split cell icon before delete icon
2021-10-18 16:43:25 -07:00
Vasu Bhog
c368fcab25 Add Markdown Keybindings (#17359)
* add markdown keybindings

* remove add link keybinding

* move files

* fix layering
2021-10-15 11:40:19 -07:00
Lucy Zhang
e315115f00 Hide notebook toolbar icons in diff editor (#17303)
* hide notebook toolbar icons in diff editor

* move showActions to notebookInput

* make showActions readonly
2021-10-15 05:19:14 -07:00
Maddy
53ab99761f save lastEditMode and use that as default (#17206)
* save lastEditMode

* change style to active

* addActiveClassFromEditMode

* add undefined to declaration

* remove from public interface

* private

* lastEditMode to last selected mode

* comments

* set active in one place

* rename method
2021-10-14 11:01:54 -07:00
Alan Ren
156f8f1d5f only show new query when query is supported (#17346)
* only show new query when query is supported

* test case fix and pr comments

* rename context key
2021-10-13 13:01:31 -07:00
rajeshka
f5331e3d69 Added code to enable disable split cell icon (#17331)
* Added code to enable diable split cell icon

* adding back the deleted code

* refactored

* minimized lines

* simplified code

* minor change

* minor change

* Addressed PR

* Addressed PR

* removing unused enum value
2021-10-11 09:47:25 -07:00
Vasu Bhog
faa29945a3 Fix Link Callout Dialog consistency in split/md (#17313)
* fix consistency with space and %20 files in split/md

* add a test
2021-10-08 15:24:00 -07:00
Vasu Bhog
c35cd3e48f Fixes Encoding / Decoding issues with Notebook Linking (#17304)
* fixes encoding / decoding issues with %20 files

* fix windows test

* address PR comments and absolute path setting
2021-10-08 15:22:10 -07:00
Maddy
f88bef8b4c save richTextCursorPosition/markdownCursorPosition (#17180)
* save richTextCursorPosition/markdownCursorPosition

* rename variables

* check to see if the nodes exist

* added comments

* add comments

* check if valid offset

* pr comments

* sqllint error fix
2021-10-06 23:24:22 -07:00
rajeshka
671c062e59 Split notebookcell (#17185)
* Initial Split code

* minor change

* minor changes

* Added split cell button to initActionBar, created split cell class to pss cell context.

* added changes

* fixed index

* Split Cell Working in markdown mode

* Fixed highlighting

* Preserve the edit state

* Added new icon and updated styles and cellToolbar component with new icon name.

* Addressed PR

* Addressed PR

* Added back isEditMode flag

* Moved split action to after edit toggle.

* Fixed typo

* Addressed PR

* Addressed PR

* Removed deletion of the cell

* fixed the comments

Co-authored-by: Hale Rankin <harankin@microsoft.com>
2021-10-06 18:18:22 -07:00
Vasu Bhog
a0576456b6 Add Keybindings for some Markdown Toolbar Actions (#17198)
* Add Keybindings for some markdown toolbar

* add extension registry

* when in text cell stopPropagation to only trigger one command
2021-09-30 15:20:45 -07:00
Cory Rivera
14904bb671 Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) 2021-09-29 16:15:28 -07:00
Barbara Valdez
dfc2635aa7 Add vertical scroll bar to Preview in Split View (#17164)
* reset max height

* add editor height

* set md editor height
2021-09-29 15:29:03 -07:00
Daniel Grajeda
08acd6aadc Notebook Views grid fixes (#17170) 2021-09-28 14:52:00 -07:00
Vasu Bhog
db1d3cc517 Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar

* working horizontal scrollbar

* created new event to handle both scrollbar and mouse wheel

* only show scrollbar when needed
2021-09-27 16:54:43 -07:00
Daniel Grajeda
4a715e473a Add guids to RunAll and RunCell events (#17123)
Add guids to RunAll and RunCell events
2021-09-21 20:56:46 -07:00
Charles Gagnon
8d3b57cb76 Add no-cond-assign rule (#17039) 2021-09-09 16:23:18 -07:00
Chris LaFreniere
d32f25425b Use updated markdown renderer from vscode (#16988) 2021-09-03 10:43:25 -07:00
Chris LaFreniere
b27bdb0027 Add tooltip for WYSIWYG callout link (#16967) 2021-09-01 17:24:06 -07:00
Daniel Grajeda
e02ae0865a Notebook Views Insert Cells Modal (#16836)
* Add html-to-image package

* Add image card type
2021-08-31 13:11:21 -07:00
Vasu Bhog
529e4fe0de Fix ADS Web notebook cross linking (#16926)
* fix cross linking files

* use host location instead
2021-08-30 15:43:16 -07:00
Lucy Zhang
ea5f9091d1 add horizontal scroll bar to output (#16918) 2021-08-27 11:42:02 -07:00
Charles Gagnon
0aede16aaa Fix duplicate editor windows on reload (#16893) 2021-08-25 20:07:58 -07:00
Cory Rivera
cb7b7da0a4 Merge from vscode e3c4990c67c40213af168300d1cfeb71d680f877 (#16569) 2021-08-25 16:28:29 -07:00
Charles Gagnon
fe1f8fb2f3 Add setting for enabling using new markdown renderer (#16864)
* Add setting for enabling using new markdown renderer

* Use const

* Fix circular dependency

* Default setting to false
2021-08-25 12:43:32 -07:00
Daniel Grajeda
ed280cb003 Add html-to-image library (#16845)
For use by the Notebook Views insert cells modal
2021-08-20 17:18:23 -07:00
Daniel Grajeda
640c6f30f4 Notebook views UI 2 (#15865)
Provide access to the Notebook Views UI. Feature is hidden behind a feature flag.

Co-authored-by: rkselfhost <rkselfhost@outlook.com>
2021-08-17 14:15:28 -07:00
Daniel Grajeda
10ee4f2d7c Notebook Views Actions fix for ADS Web (#16707) 2021-08-11 13:19:02 -07:00
Lucy Zhang
9f761c44c4 Add incremental grid loading option to notebooks (#16577)
* render grids incrementally

* add loading spinner

* fix loading animation

* move rendergrids to notebook editor component

* add setting for incremental grid loading

* check configuration

* just use setTimeout to queue grids

* remove extra line

* add setter/getter for isloading

* add comment
2021-08-05 13:44:26 -07:00
Daniel Grajeda
0567141bc4 Notebook Views Actions (#16207)
This adds the actions currently needed by the views
2021-08-03 22:52:27 -07:00
Daniel Grajeda
e2dd257fa9 Add Notebook Views dropdown (#16228)
This adds the entry point to NVs. It is currently hidden behind a feature flag, which can be enabled in the settings.
2021-08-03 21:15:11 -07:00
Vasu Bhog
179678b495 Refactor Notebook Link Handling (#16473)
* add keep absolute paths instead convert setting

* update tests/config

* refactor links in NotebookLinkHandler
2021-07-30 19:20:38 -07:00
Vasu Bhog
788c84a1ee fix email else condition (#16491) 2021-07-29 18:37:06 -07:00
Cory Rivera
63a65f5821 Remove quotes from inserted markdown links (#16457) 2021-07-27 16:40:20 -07:00
Charles Gagnon
2d8e0d648a Fix SQL/Notebook editors opening as plaintext (#16442)
* Register overrides at startup

* Always wait for extensions

* Fix compile errors
2021-07-27 13:46:16 -07:00
Vasu Bhog
151522013f Notebook Markdown email rendering fix (#16417)
* fix email WYSIWYG rendering
2021-07-23 15:24:34 -07:00
Charles Gagnon
66c62fcce3 Fix relative path check in HtmlMarkdownConverter (#16192) 2021-07-23 12:33:45 -07:00
Daniel Grajeda
fd954ddcb2 Plotly output resize (#16313)
Allow plotly to resize based on the size of the output itself, not only when the window is resized. This allows cells in Notebook Views to adjust based on  resize.
2021-07-21 21:06:26 -07:00
Daniel Grajeda
c5c7ca019d Notebook Views autodash feature (#16238)
The autodash feature in notebook views creates an initial grid layout for users when a view is created. It is intended to reduce the effort required by the user to start editing their view. Instead of displaying every cell and stacking them vertically like the default notebook layout, we use guidelines to determine which cells are worth displaying and how to arrange them.
2021-07-21 20:46:58 -07:00
Barbara Valdez
f17689319c Revert to previous markdown renderer (#16246)
* Add marked files under sql/base/common
2021-07-16 17:51:53 -07:00
Vasu Bhog
63e97caa94 Fix Windows WYSIWYG linking issue (switching to splitview and resolving links in WYSIWYG) (#16133)
* fix relative links not correctly formatted due to marked js

* logic in one place
2021-07-16 13:27:45 -07:00
Charles Gagnon
8faa0cf0e2 Update compile pipeline and fix eslint (#16129)
* Update pipelines

* eslint

* Fix layering

* update tsec exemption
2021-07-14 14:43:23 -07:00
Vasu Bhog
27823e9900 Fix CalloutDialog not opening after bad link (#16051)
* fix null parentNode
2021-07-09 09:01:48 -07:00
Charles Gagnon
8f202d91b6 editorReplacer -> editorOverride (#16041)
* editorReplacer -> editorOverride

* Update lifecycle phsae

* add back input factories

* Add comment

* add back tests

* comments

* fix log

* comments
2021-07-09 08:46:50 -07:00
Alan Ren
c5893a488f toolbar separator overlapping with other items (#16012)
* separator overlapping with other items

* Update notebook.css
2021-07-07 14:44:41 -07:00
Lucy Zhang
f8c4d332bb add height css (#16026) 2021-07-07 13:49:33 -07:00
Lucy Zhang
9ba4057a3c fix notebook icon highlights (#16009) 2021-07-06 17:50:54 -07:00
Lucy Zhang
9ac1f16cea Fix notebook toolbar when ADS screen width is decreased (#15987)
* fix toolbar when width is decreased

* remove height css
2021-07-06 11:45:46 -07:00
Barbara Valdez
0e10e3e3ca fix WYSIWYG toolbar (#15901)
* fix WYSIWYG toolbar

* add height

* remove new rule and specify css selectors
2021-06-30 17:28:11 -07:00
Lucy Zhang
189fe762a9 remove layout call in output component init (#15905) 2021-06-28 14:48:44 -07:00