ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-18 17:22:45 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,021 Commits 1 Branch 152 Tags
aa30b52d036b70792dee6f1ad968f9d86e59b235
Commit Graph

438 Commits

Author SHA1 Message Date
Lucy Zhang
aa30b52d03 Notebooks: Fix query results not displaying table rows (#13488) 
* fix PQSQL queries not displaying rows

* comment

* change comment and fix unit test
 2020-11-20 15:31:01 -08:00
Chris LaFreniere
8d42182db8 Attempt to Colorize Code Cells from Notebook Contents (#13473) 
* Attempt to colorize from saved language info

* Simplify colorization change

* Fixup
 2020-11-19 19:54:09 -08:00
Justin M
271fe62344 12567 Fixed Notebooks not adding to recent connections (#13113) 
* 12567 Changed tryAddActiveConnection to always add recent connection

* 12567 Reverted change to tryAddActiveConnection. Removed this._params.input from connectionDialogService > createModel

* 12567 Simplified conditional in connectionDialogService
 2020-11-16 11:27:09 -08:00
Justin M
c18a54bc1d 12666 Passed azureAccount into onFetchDatabases and set on tempProfile. (#13239) 2020-11-16 11:24:22 -08:00
Alan Ren
99e3da5b48 Editable dropdown component improvement (#13389) 
* replace Tree with List

* comments
 2020-11-13 13:36:54 -08:00
Aasim Khan
bd4676ac8c removing separate heading for page number and clubbing it with wizard title (#13380) 2020-11-13 00:38:04 -08:00
Lucy Zhang
32a6385fef Notebooks: Save cell connection name in cell metadata (#13208) 
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* save/read cell connection name to/from metadata

* get started on toggling multi connection mode

* add activeConnection property to cell model

* add changeContext method for cell

* add comments

* add unit test for reading connection name

* save connection mode in metadata

* clean up code

* address PR comments
 2020-11-12 10:44:34 -08:00
Kim Santiago
abdf575885 fix wizard page name and step getting announced when pages are added and removed (#13362) 2020-11-12 09:44:33 -08:00
Alan Ren
3be00b1635 add tabindex and handle keyboard selection (#13348) 2020-11-10 23:00:03 -08:00
Aditya Bist
8bbcfff119 fix agent types (#13340) 2020-11-10 13:38:57 -08:00
Aditya Bist
fa9a38d74a Update/agent (#13298) 
* Revert "Fix Agent not working (#13126)"

This reverts commit a0ee8b00fb.

* agent fix and bump
 2020-11-09 09:00:03 -08:00
Charles Gagnon
a0ee8b00fb Fix Agent not working (#13126) 
* Fix Agent display

* more fixes

* cleanup
 2020-11-04 09:23:16 -08:00
Vasu Bhog
351516f08d Change the way we insert Injected Parameter (#13171) 2020-11-02 09:14:37 -08:00
Alan Ren
cb1c8503b0 handle keyboard selection (#13175) 2020-10-30 21:17:49 -07:00
Charles Gagnon
d7767c7d91 Resource viewer cleanup (#13168) 
* Resource viewer cleanup

* uneeded

* Only show in insiders
 2020-10-30 16:48:50 -07:00
Alan Ren
2f571d868b show folder icon for some tree nodes (#13161) 2020-10-30 15:38:23 -07:00
Charles Gagnon
3015845093 Add title property for data grid providers (#13155) 2020-10-30 15:37:11 -07:00
Lucy Zhang
69527f91b0 Notebooks: Save connection information in metadata (#13060) 
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* dont show saved conn if seting off + added test

* show conn dialog if save conn name setting off

* address PR comments and fix unit test

* change connectionName to connection_name
 2020-10-30 13:56:33 -07:00
Alan Ren
82d5fe3821 put feature behind preview flag (#13147) 
* put feature behind preview flag

* remove unused import
 2020-10-30 10:17:54 -07:00
Alan Ren
ac476ba973 make the tree theme aware and remove group color (#13143) 
* make the tree theme aware and remove group color

* fix eslint error
 2020-10-29 22:46:11 -07:00
Alan Ren
7819d25c95 resource label update (#13129) 
* resource label update

* preserve existing behavior

* fix connection group color

* comments
 2020-10-29 14:42:01 -07:00
Alan Ren
1d4398388c bring Azure context menu to the new tree and enhance start cloud shell command (#13101) 
* bring context menu to the new tree

* enhance start cloud shell command

* text
 2020-10-28 13:48:28 -07:00
Lucy Zhang
86357b45b0 Notebooks: re-factor grid streaming (#12937) 
* refactor grid streaming (convert to data first)

* change convertRowsToHtml method to return value

* remove griddataconversioncomplete checks

* send row data from STS to gridoutput component

* clean up code

* send data updates to cell model

* serialize cell output at the end of cell execution

* remove unused parameters

* update output contents instead of output reference

* remove unnecessary promise

* move azdata changes to proposed

* update comment
 2020-10-28 09:08:15 -07:00
Alan Ren
e2c9d3899b make sure saved connections are up to date (#13098) 2020-10-27 19:41:44 -07:00
Alan Ren
79800902db enable filtering, account node context menu and introduce flat account tree node (#13066) 
* add search box

* switch back to the traditional azure tree

* Revert "switch back to the traditional azure tree"

This reverts commit 7904b9cd599591e94412ec79da23590068de46b6.

* flat account tree node and filtering

* add comment

* context menu

* fix test

* handle disposable

* add logging
 2020-10-26 17:00:44 -07:00
Vasu Bhog
cb30dd1893 Notebook Parameterization - Papermill Compatibility (#13034) 
* Parameterization papermill fix

* Utilize isParameter instead

* Address PR comments, and fix tests

* Address comment
 2020-10-23 20:32:55 -05:00
Charles Gagnon
2d182fcd03 Remove calls to DOM.addClass and DOM.removeClass (#13063) 2020-10-23 14:42:22 -07:00
Charles Gagnon
656d727854 Skip getting icon if we don't have a server info (#13017) 2020-10-21 15:56:22 -07:00
Vasu Bhog
fcec690546 Backend work for Notebook Parameterization and Tests (#12914) 
* Backend work for  Parameterization + Tests

* minor comments

* fix test

* address comments
 2020-10-20 13:26:59 -05:00
Alan Ren
49983a6f05 fix connection dialog scroll issue (#12956) 2020-10-16 11:09:30 -07:00
Alan Ren
545a5504e0 fix missing icon issue (#12928) 
* fix missing icon issue

* move the logic to renderServerIcon
 2020-10-15 12:01:35 -07:00
Tony Xia
607447365d Fixed minor typos (#12936) 2020-10-15 09:55:00 -07:00
Anthony Dresser
9fdb5037bc Connection Browse Tab (#12222) 
* add browse tab and flat tree provider for azure

* fix tests

* add comment

* fix build errors

* fix test cases

Co-authored-by: Alan Ren <alanren@microsoft.com>
 2020-10-13 14:58:09 -07:00
Vasu Bhog
53f00bee12 Fix connection when changing kernel from Kusto to SQL (#12881) 
* Fix Kusto to SQL kernel connection change

* Updated Fix - removes kernel alias mapping while ensuring multi kusto notebooks work properly

* Fix tests
 2020-10-10 00:10:33 -05:00
Lucy Zhang
b910bf2f33 Notebooks: Fix strict compile errors (#12591) 
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
 2020-10-08 15:39:57 -07:00
Vasu Bhog
726f0cef0e Add Notebook tests for Kernel Alias connections (#12722) 
* More Generic tests for kernel alias connections

* Kernel Alias tests for the Notebook Model

* Updated titles of tests
 2020-10-05 23:17:41 -05:00
Christopher Suh
6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295) 
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
 2020-10-03 11:42:05 -07:00
Monica Gupta
b574f2aa32 Fix notebook issue when creating Kusto notebooks 2nd time after launching ADS (#12700) 
* Fix notebook issue

* Removed not required code

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
 2020-10-01 16:27:41 -07:00
Alex Ma
82648fab3e connection tests for connectionDialogWidget (#11160) 
* Added providerRegistered test

* test for EditConnectionDialog

* changed wording

* added test for connectionInfo

* utils.ts tests added

* hasRegisteredServers test

* commented out editconnection tests, addl. tests

* added onConnectionChangedNotification test

* added changeGroupId tests

* Added connection  profile changes

* added connectIfNotConnected test

* added delete connection test

* isRecent and disconnect editor tests

* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* added registerIconProvider test

* Fix for ensureDefaultLanguageFlavor test

* added a few tests

* utils prefix test updated

* added utils tests

* disconnect tests added

* Added additional get connection info tests

* added some more tests

* minor additions to tests

* again another commit

* another change

* connectionManagementService finalized

* connectionDialogWidget test WIP

* wip connectiondialogwidget test

* added working connectionDialogWidget test

* added more tests

* current connectionDialogWidget tests

* undid space

* hanging promise addressed

* added open test

* finished connectionDialogWidget tests

* Added showDialog test

* mockConnectionDialogService added

* added accessorConnectionDialogService

* removed accessor service

* added openDialogAndWait test

* added fake error to test

* added error tests

* Added comments to test

* more coverage

* async to await change

* registerCapabilities test added

* connectionDialogService tests finished

* undefined added

* Added views for tests

* tslint disable added

* error catchers added

* added empty connectioninfo

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
 2020-09-30 08:39:54 -07:00
Lucy Zhang
cf9754f627 revert grid streaming changes (#12650) 2020-09-28 18:34:58 -07:00
Justin M
5396ed855c 3707 Kusto Icon Fix (#12621) 
* 3707 Changed getIconpath in serverTreeRenderer to always set iconPath if iconId is undefined. Changed renderConnection to always renderServerIcon

* 3707 Added default flag to KustoIcon in package.json

* fix caching issue

* 3707 Changed default to optional variable. Updated asyncServerTreeRenderer > getIconPath to check for default

* 3707 Changed logic for setting iconPath in getIconPath

Co-authored-by: chgagnon <chgagnon@microsoft.com>
 2020-09-25 16:49:33 -07:00
Charles Gagnon
1ea33d83bf Fix undefined error in server tree data source (#12616) 
* Fix undefined error in server tree data source

* Add comment
 2020-09-24 12:51:07 -07:00
Charles Gagnon
807a4ae8c4 Add telemetry for ModelView wizards (#12596) 
* Add telemetry for ModelView wizards

* Remove unnecessary params

* Fix compile error
 2020-09-23 17:08:22 -07:00
Charles Gagnon
4e07685588 Strict compile for sql/workbench/services/dialog (#12578) 
* Strict compile for sql/workbench/services/dialog

* fix errors
 2020-09-23 13:15:59 -07:00
Vasu Bhog
eea35d4920 Fix Spark kernel connections and switch from Kusto to Spark kernels (#12436) 
* Fix connection dialog for Spark and issue when switching from Kusto to Spark

* Address comments
 2020-09-17 22:16:42 -05:00
Aditya Bist
a0886b9152 Fix connection dialog indentation (#12401) 
* fix connection dialog indentation

* indent tab body
 2020-09-17 13:31:29 -07:00
Lucy Zhang
945e04ed92 Fix notebook table rendering with multiple code cells (#12363) 
* create unique query runner for each cell

* use cellUri instead of cellId to identify runner

* disconnect each query runner connection

* remove queryrunners size check
 2020-09-17 09:44:10 -07:00
Chris LaFreniere
ffb81d88fd Watch for on load event (#12309) 2020-09-15 23:27:05 -07:00
Lucy Zhang
0be5f67621 Fix notebook cancel query bug (#12300) 
* fix undefined query runner error

* store connection id

* revert sqlSessionManager change
 2020-09-15 11:31:31 -07:00
Vasu Bhog
7a524d7a35 Fix Notebook Kusto Kernel Consistency (#12256) 
* fix kusto notebook consistency

* Address undefined
 2020-09-14 14:18:53 -05:00