Kevin Cunnane
27cbd53253
Fix notebook dirty state after save ( #6096 )
...
Was getting a content changed loop in the events
Fix is to ignore save events from the input since it sends them
2019-06-18 17:38:20 -07:00
Kevin Cunnane
36fe725cf0
Fix RunAllCells throwing unhandled exception ( #6089 )
...
- Added await here.
- There's a 2nd entry point already doing it the right way, in the Notebook extension.
No need to change that
2019-06-18 16:19:32 -07:00
Charles Gagnon
373c3488bb
Fix Add Azure Account dialog constantly reappearing ( #6048 )
2019-06-18 21:48:11 +00:00
Alan Ren
58e5e095e5
add PGSQL to integration test ( #6040 )
...
* Verify providers in integration test
* include pgsql
2019-06-18 14:35:08 -07:00
Charles Gagnon
9e7282d16a
Connection dialog cleanup ( #6076 )
...
* Update names to be clearer and remove some unnecessary code
* Remove unused/inaccurate CMS display name value
2019-06-18 21:33:21 +00:00
Karl Burtram
561b7575ba
Fix arith abort default value ( #6080 )
2019-06-18 14:11:15 -07:00
Cory Rivera
cecc899949
Disable Manage Packages button if python is not installed ( #6008 )
2019-06-17 18:28:16 -07:00
Charles Gagnon
59b0e6737f
Update provider correctly when showing the dialog ( #5995 )
2019-06-17 15:32:36 +00:00
Aditya Bist
449cd9ea27
added run job context menu to jobs view page ( #6011 )
2019-06-14 16:20:49 -07:00
Aditya Bist
256ef072df
fix header options ( #6036 )
2019-06-14 15:45:55 -07:00
Anthony Dresser
7a31d66d2c
ensure we set group for both editors ( #6016 )
2019-06-14 14:00:28 -07:00
udeeshagautam
f494c7af4e
Schema compare Icon and other fixes ( #6009 )
...
* Changes to 1. Enable Icon for Schema Compare model view editor 2. Set context setting in editable drop down 3. Fix a console error
* new icons
* Changes as per PR comments
* Adding PR comments
* Fixing a spelling mistake
2019-06-14 13:28:46 -07:00
Charles Gagnon
363af2a85c
Add telemetry for all commands ( #6025 )
2019-06-14 16:16:21 +00:00
Kevin Cunnane
6ff34d9894
Fix #6022 connection dialog broken ( #6023 )
...
Opening connection dialog was broken if you have a postgres connection
listed in the Connections view and the extension isn't installed.
The capabilities service breaks as it returns an undefined object.
Added handling, so now it does show as "loading..." forever
but doesn't crash
2019-06-13 16:50:00 -07:00
Aditya Bist
a566fa9728
Agent - fix edit step ( #6010 )
...
* made all jobs get focus and keyboard friendly
* added tooltip for steps image
* made operator dialog accessible
* change job name as soon as job name changes in text box
2019-06-13 14:08:58 -07:00
Kim Santiago
248f2f5071
Formatting diff editor title ( #6013 )
...
* add background color and more formatting to diff editor title
* also handle hc-black
2019-06-13 13:07:52 -07:00
Gene Lee
a79f1ac830
Added 'New Notebook' task on database dashboard ( #5996 )
2019-06-12 18:33:52 -07:00
Aditya Bist
073a372d4d
Agent: Accessibility bugs 2 ( #5994 )
...
* made all jobs get focus and keyboard friendly
* added tooltip for steps image
* made operator dialog accessible
* localized tooltip
2019-06-12 14:40:57 -07:00
Charles Gagnon
5aa730b5d4
Add logging to try and find a possible connection race condition ( #5813 )
...
* Add logging to try and find a possible connection race condition
* Fix tests
* More test fixes
* Update error message and use error level
2019-06-12 00:08:51 +00:00
Charles Gagnon
33a9f2e3e4
Plumb editor state change through to state object ( #5931 )
2019-06-11 23:05:40 +00:00
Karl Burtram
5a7562a37b
Revert "Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d ( #5949 )" ( #5983 )
...
This reverts commit d15a3fcc98 .
2019-06-11 12:35:58 -07:00
Kim Santiago
95a50b7892
Remove DacFx deploy action page ( #5942 )
...
* remove deploy action page since generated script is opened instead of saved now
* bump sqltoolsservice version to 1.5.0-alpha.100
2019-06-11 11:16:48 -07:00
Chris LaFreniere
86a3217e98
Notebooks: Log telemetry when all markdown cells rendered ( #5862 )
...
* Log telemetry when all markdown cells rendered
* Enable referencing previous telemetry timestamps
* Fix broken unit test to do a null check
* Undo loading icon changes in textcelll
* Addressing PR comments
* PR comments II
2019-06-10 21:55:49 -07:00
Chris LaFreniere
d15a3fcc98
Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d ( #5949 )
...
* Merge from vscode 81d7885dc2e9dc617e1522697a2966bc4025a45d
* Fix vs unit tests and hygiene issue
* Fix strict null check issue
2019-06-10 18:27:09 -07:00
Kevin Cunnane
14a6bf581c
Fix New Notebook issues ( #5958 )
...
* Fix New Notebook issues
- Fix #5338 New Notebook menu item should be next to New Query
- Fix #4936 Add a shortcut to create a notebook in the document well
Created a built-in New Notebook command
that routes to the existing extension-based command.
This avoided a rearchitecture that was more complex that seemed worth it.
Per VSCode patterns, used a _ modifier for the existing command so it's "private"
2019-06-10 16:38:07 -07:00
Kevin Cunnane
730ad4b814
Fix outputs constantly focusing on new output ( #5959 )
...
- Only scroll if it's the 1st output, not for subsequent ones
- Otherwise can't use notebook while a cell is running & regularly updating the outputs
2019-06-10 16:28:59 -07:00
Kevin Cunnane
f05260d95a
Fix #5379 markdown Gray code makes code look wrong ( #5954 )
2019-06-10 14:29:29 -07:00
Charles Gagnon
673ecc3870
Change hardcoded MSSQL provider name to use constant instead ( #5953 )
2019-06-10 18:10:39 +00:00
Aditya Bist
d9b48bae80
Agent - Accessibility Bugs (WIP) ( #5807 )
...
* fix accessbility issue where tabbing would get wrong focus
* dialogs open one at a time
* get focus on filter headers
* added tool tips to proxy dialog
* added labels to step dialog
2019-06-07 09:41:00 -07:00
Gene Lee
43457c0184
Fixed run cell error message in Notebook ( #5912 )
2019-06-06 13:18:50 -07:00
Anthony Dresser
76a84a2cf4
fix dimensions of the query editor ( #5910 )
2019-06-06 12:31:12 -07:00
Kevin Cunnane
44d6bb66da
Add saved and executed events to notebook changed ( #5848 )
...
- Updated the notebook API to add a change kind, and support saved, executed and other simplified status
- Plumbed this through to the main thread classes
- Support sending the events from cell / input to the notebook model so they loop over the extension host as a content changed event
- Add executed event from the cell
2019-06-05 16:34:26 -07:00
Gene Lee
a518c4a529
Making Notebook to scroll to output area only when Notebook command is executed ( #5893 )
2019-06-05 12:07:31 -07:00
Chris LaFreniere
da164cec0a
remove tabindex=0 for notebook component ( #5851 )
2019-06-05 08:28:00 -07:00
Aditya Bist
685a608518
Make sure the first Connection Dialog has correct provider. ( #5884 )
...
* force a restart for cms
* remove unneeded existing conditional
* fix for random provider when opening a connection dialog
2019-06-04 17:11:36 -07:00
Gene Lee
bf643cc85f
Fixed bug: Execute cell should scroll to its results ( #5861 )
2019-06-04 16:03:55 -07:00
Anthony Dresser
eda96c046a
fix strict-null check ( #5878 )
2019-06-04 15:31:34 -07:00
Anthony Dresser
912c80e496
store active tab so it isn't overwritten ( #5875 )
2019-06-04 12:55:55 -07:00
Anthony Dresser
7390dce536
Fix handling of state in the grid panel ( #5867 )
...
* fix handling of state in the grid panel
* trigger rebuild
* trigger rebuild
2019-06-04 12:55:20 -07:00
Anthony Dresser
67859ab139
dont focus panels when they are shown; dont swallow keys for message panel ( #5872 )
2019-06-04 12:54:54 -07:00
Anthony Dresser
540635c54f
make sure we update our sizes when we update the size of items ( #5874 )
2019-06-04 12:53:17 -07:00
Aditya Bist
6197279e83
remove SQL Login from CMS and add error messages ( #5873 )
2019-06-04 12:52:46 -07:00
Anthony Dresser
4ad226570a
Add no implicit any to the strict null check ( #5635 )
...
* wip
* working through adding no implicit any
2019-06-04 09:29:40 -07:00
Gene Lee
9f7d96bad3
Fixed bug: Notebooks Vertical Scrollbar is Unnecessary for Some Grid Outputs ( #5847 )
2019-06-03 16:47:07 -07:00
Chris LaFreniere
8d70544374
Notebooks: Adding Change Kernel API, 3 Integration Tests ( #5287 )
...
* Notebook change kernel
* Fix notifying of k change too many times add tests
* Fix broken unit test
* Deal with comment
2019-06-03 14:49:40 -07:00
Chris LaFreniere
34bc0efc1c
Check if sessionManager exists ( #5811 )
2019-05-31 17:42:12 -07:00
Anthony Dresser
23e4a30cd1
dispose and clear things out when they are not needed to free up memory ( #5805 )
2019-05-31 17:24:01 -07:00
Anthony Dresser
33ff8ec5a3
Fix instances of listeners not being disposed in Query Editor ( #5798 )
...
* fix instances of listeners not being disposed
* spelling mistake
2019-05-31 15:14:03 -07:00
Anthony Dresser
dc2ff2295e
change message focus only on query end ( #5793 )
2019-05-31 13:23:17 -07:00
Anthony Dresser
f231d6945f
clear indicator when a query starts ( #5795 )
2019-05-31 13:19:03 -07:00