Commit Graph

185 Commits

Author SHA1 Message Date
Charles Gagnon
aeb22011d2 Remove placeholder on deployment wizards when field is disabled dynamically (#13658) 2020-12-04 09:25:56 -08:00
Charles Gagnon
3d82074656 Remove debug console log (#13669) 2020-12-04 09:25:44 -08:00
Charles Gagnon
6dc07e5804 Add test for dynamic enablement (#13602)
* Add test for dynamic enablement

* update names
2020-12-04 09:15:34 -08:00
Arvind Ranasaria
8027993ab4 Make 'Script to notebook' consistent with 'Deploy' when user cancels during password re-acquisition for controller (#13557) 2020-12-01 22:57:00 -08:00
Charles Gagnon
b03a914934 Update required icon for labels for dynamic enablement (#13515) 2020-11-24 15:05:29 -08:00
Charles Gagnon
84822b23ac Fix BDC Deployment table (#13538)
* Fix BDC Deployment table

* fix mappings

* Fix names
2020-11-24 14:28:19 -08:00
Charles Gagnon
145b2491df Cleanup Resource Deployment ModelView (#13510) 2020-11-20 18:29:00 -08:00
Charles Gagnon
172a044ba7 Remove inputValueTransformer and getInputComponentValue (#13502) 2020-11-20 10:51:00 -08:00
Charles Gagnon
175d46d508 Add support for dynamic enablement of resource deployment components (#13464)
* saving wip to merge main

* temp fixes for textValidation* removal

* save wip to switch tasks

* save wip to switch tasks

* save wip to switch tasks

* code complete - with known bugs

* missed test file

* fix extHostModelView changes

* validation module

* missed test changes

* missed change

* pr feedback

* pr feedback

* revert inadvertent change

* remove unneeded change

* merge from bug/12082-2

* pr feedback

* pr feedback

* bdd -> tdd for validation tests

* bdd -> tdd for validation tests

* pr feedback

* remove unneeded file

* pr feedback

* EOL instead of '\n'

* pr feedback

* pr feedback

* minor fixes.

* pr feedback

* fix comment

* comments and var renames

* test fixes

* working version after validation simplification

* working version after validation simplification

* remove inadvertent change

* simplified validations

* undo uneeded change

* cleanup

* working version after latest merge

* comments and whitespace fixes

* remove is_integer checks

* sentence case field validation messages

* Use generic strings in sample fields

* minor fixes to sample extension strings

* spaces to tabs for indentation

* request fields before limit fields

* reaarange request/limit fields

* is_integer checks for PG Server Group number fields

* Thenable to Promise

* InputBoxInfo

* pr feedback

* pr feedback

* isUndefinedOrEmpty to utils

* include asde package.json

* use ValidationValueType

* ValidationValueType -> InputValueType

* Add support for dynamic enablement of resource deployment components

* use instanceof function

* getValue returns InputValueType

Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
2020-11-19 16:23:28 -08:00
Arvind Ranasaria
c7cca5afea Improved Validations for ARC Wizards (#12945) 2020-11-18 22:03:59 -08:00
Aasim Khan
438bc67072 Fixed the generate script logic for notebook wizards. (#13418)
* Fixed the generate script logic for notebook wizards.

* -reverted previous changes
-added last page check to the page validation change logic.

* checking if the page is valid when entering it.

* removing unnecessary index variable in forEach loop

* added comments for generate script button enabling on notebookwizard page.
2020-11-17 10:26:45 -08:00
Arvind Ranasaria
39e1181c5d Remove WizardBase.ts (#13350) 2020-11-16 19:21:26 -08:00
Arvind Ranasaria
b3d99117ca onComplete -> onLeave for toolsAndEulaPage (#13394) 2020-11-13 09:59:08 -08:00
Aasim Khan
6c920f6d54 Fixed the table width so it does not overflow from the wizard. (#13372) 2020-11-12 15:06:03 -08:00
Arvind Ranasaria
d7a6b55f82 Hook up generateScriptButton to lastPageValidation (#13339) 2020-11-10 13:16:25 -08:00
Aasim Khan
1c9322c0e8 Fixes for incorrect button labels and the password validation error. (#13333) 2020-11-10 09:05:28 -08:00
Aasim Khan
712c6ae5d8 Adding tools and Eula page to Resource Deployment (#13182)
* SQL VM wizard migration to ResourceType Wizard

* Revert "SQL VM wizard migration to ResourceType Wizard"

This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.

* migrated notebook wizard

* SQL VM wizard migration to ResourceType Wizard

* Fixed some imports on SQL VM wizard

* migrated sqldb wizard to generic ResourceTypeWizard

* Added missing import
Solving errors from the merge

* Moved some common functionality into ResourceTypeWizard

* Changed logic of start deployment

* fixed some import after changing files.

* added pagelss model and tools and Eula Page

* Hacky solution to fix wizard update bugs

* Removed tools and Eula components from resourceTypePickerDialog

* Removing changes in ext host

* reverting every change in ext host dialog

* Fixed setting the first provider for resourceTypeWizard.

* Some PR related changes
-Fixed typo in localized constants
-made some code logic concise
-Removed unnecessary check in tools&Eula

* Added some fixes for compilation error

* some refactoring for PRs

* moved comment

* cleaning up some code to make it more readable

* fixed comment typo

* Some additional cleaning up of code.

* Adding a public getter for model

* -Adding error message for failed EULA validation
-Removed unnecessary check for selected resource.

* Added comment to explain model variable behavior

* Added additional comments

* Fixed a comment to make it accurate

* Better phrasing for a comment
2020-11-06 13:05:41 -08:00
Arvind Ranasaria
3ec1f7cc2b Kube Service tests (#13183) 2020-11-03 15:46:31 -08:00
Arvind Ranasaria
b175c97dfe Notebook Service tests (#13181) 2020-11-03 14:16:11 -08:00
Arvind Ranasaria
f10ac10f6d platformService tests and move tests from tdd to bdd (#13131) 2020-11-03 13:34:33 -08:00
Aasim Khan
4f96ac46be Migrating other deployment wizards to the generic ResourceTypeWizard (#13132)
* SQL VM wizard migration to ResourceType Wizard

* Revert "SQL VM wizard migration to ResourceType Wizard"

This reverts commit e58cd47707a7e2812be20d915f1fe638b96b035f.

* migrated notebook wizard

* SQL VM wizard migration to ResourceType Wizard

* Fixed some imports on SQL VM wizard

* migrated sqldb wizard to generic ResourceTypeWizard

* Added missing import
Solving errors from the merge

* Moved some common functionality into ResourceTypeWizard

* Changed logic of start deployment

* fixed some import after changing files.
2020-10-30 12:42:20 -07:00
Aasim Khan
e15ad17967 Aasim/fix/sqldbtypos (#13130)
* fixed some easy typos on sql db wizard.

* Fixed some instructions in the notebook

* - Added option to enable or disable firewall rules

* converted toggle firewall dropdown to checkbox
2020-10-29 11:53:56 -07:00
Aasim Khan
dd77c79090 Refactoring Deploy Cluster to use the a generic Wizard (#13105)
* Refactoring Deploy Cluster to use the generic ResourceTypeWizard

* - Remove unnecessary error message
- Fixed spacing
- Fixed onCancel method implementation in deploy cluster
2020-10-28 20:47:27 -07:00
Charles Gagnon
2db51ca243 Allow string for deployment icons and update a couple (#13076)
* Update to colorized versions of bdc and container deployment icons

* update edge

* Allow string for icons
2020-10-26 13:27:12 -07:00
Arvind Ranasaria
2bc2f7f520 New Validation Module for Resource Deployment Extension (#13075) 2020-10-26 11:41:04 -07:00
Arvind Ranasaria
1c6d7866e8 Revert "New Validation Module for Resource-Deployment extension. (#12953)" (#13074)
quick revert of a merge done from PR too soon. Will merge it again later.
2020-10-26 10:03:37 -07:00
Arvind Ranasaria
c810c5a0bb New Validation Module for Resource-Deployment extension. (#12953) 2020-10-26 09:50:25 -07:00
Charles Gagnon
3ef2650e69 Fix kubectl storage class check (#13046) 2020-10-22 15:05:14 -07:00
Arvind Ranasaria
98774527bc Bdc wizard pages now track all components in wizard.InputCompnentsInfo (#13023)
* track all components in wizard.InputCompnentsInfo

* pr feedback

* fix formatting
2020-10-22 08:49:48 -07:00
Alan Ren
72f7e8de52 add password validation regex (#12976) 2020-10-19 10:52:17 -07:00
Alex Ma
f6949d834b When Clause processing added to getokbutton and getprovider (#12886)
* processwhenclause added

* processWhenClause explanation added

* changed comment to be more generic.

* changed expected comparison

* test and space fix added

* fixed tests

* resourceTypeService now uses forloop
2020-10-16 09:38:07 -07:00
Arvind Ranasaria
10d3a6b2ba throw when onOk, onGenerateScript errors (#12838)
* throw when onOk, onGenerateScript errors

* pr feedback

* remove try catch in onOk && onGenerateScript
2020-10-12 17:08:52 -07:00
Aasim Khan
f61ffae15c Updated Fix for Deployment defaulting to first item when filter filters out all items (#12876)
* Fix where update table is not called

* Clearing table when no resource is selected
2020-10-12 11:53:28 -07:00
Alex Ma
0f6bb683d6 sql db deployments into main (WIP) (#12767)
* added my resource-deployment

* changed notebook message

* Add more advanced properties for spark job submission dialog (#12732)

* Add more advanced properties for spark job submission dialog

* Add queue

* Revert "Add more advanced properties for spark job submission dialog (#12732)"

This reverts commit e6a7e86ddbe70b39660098a8ebd9ded2a1c5530c.

* Changes made for simplification

* changed error messages

* tags added

* tags removed due to redundancy

* Update package.json

* Update resourceTypePickerDialog.ts

* changes based on feedback

* activaterealtimevalidation removed

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2020-10-09 15:46:41 -07:00
Aasim Khan
daf40393d9 Fix for Depoyment defaults to first item when filter filters out all items (#12871)
* disabled ok button when there are no resources

* added missing space
2020-10-09 14:42:43 -07:00
Arvind Ranasaria
d9ca879533 disableControlButtons disables generateScriptButton (#12835) 2020-10-09 12:19:09 -07:00
Aasim Khan
280a9d20f9 Added categories and search based filtering to the resource dialog. (#12658)
* added filtering to the resource type along with a new component.

* -Added caching of cards
-Removed unused component props
-localized tags
-limited the scope of list items

* Made some changes in the PR

* - Added Iot Category to SQL edge
- Moved category names to constants
- Moved localization strings to localized constants
- Made filtering logic more concise
- Changed how category list is generated
--Category list can now be ordered
-Added back event generation for selectedCard

* Fixed bugs, and some additional changes
-Fixed radiogroup height to avoid the movement of options below it
-Restoring the focus back to the search and listview components
- Added focus behaviour for listview
- Fixed a typo in comment

* Made categories an Enum

* Added localized string

* localized category string
converted categories to enum.

* made the filtering logic more concise.

* returning string if no localized string formed
removed unnecessary returns

* fixed the filtering tag logic
resetting search when category is changed

* removing the iot tag from sql edge deployment

* made filtering logic more concise
made enum const

* added vscode list

* some cleanup

* Some PR changes
- Made PR camelcase
- added comments to SQL
- removed unnecessary export

* -Some PR related changes
-Removing unsupported style property
-scoping down css and removing unused ones.

* Fixed a comment text

* Fixed typings for listview event
2020-10-07 13:38:12 -07:00
Alan Ren
c1267a9387 use undefined instead of home directory (#12763)
* use undefined instead of home directory

* fix error
2020-10-06 13:34:16 -07:00
Arvind Ranasaria
c679d5e1f0 allow registering options source providers to resource-deployment (#12712)
* first draft

* compile fixes

* uncomment code

* waitForAzdataToolDisovery added to azdata api

* missed change in last commit

* remove switchReturn

* contributeOptionsSource renamed

* remove switchReturn reference

* create optionSourceService

* azdataTool usage more reliable

* package.json fixes and cleanup

* cleanup

* revert 4831a6e6b8b08684488b2c9e18092fa252e3057f

* pr feedback

* pr feedback

* pr feedback

* cleanup

* cleanup

* fix eulaAccepted check

* fix whitespade in doc comments.
2020-10-05 19:29:40 -07:00
Arvind Ranasaria
39e43d2401 use selected subscriptions (#12691)
* working version

* pr feedback
2020-10-01 09:08:04 -07:00
Arvind Ranasaria
7bfea07b9b Fetch arc dc config profile list from azdata (#12678) 2020-09-30 14:25:15 -07:00
Arvind Ranasaria
b8de69dfac GenerateToNotebook and Deploy buttons for Notebook Wizards (#12656)
* enable userChooses how to run notebook

* arc ext changes

* nb fixes

* working version

* revert unneeded changes

* fix comments

* Update interfaces.ts

* fix comments

* fix comments

* fix comments

* runAllCells instead of background execute

* pr feedback

* PR feedback

* pr feedback

* arc ext changes for new WizardInfo syntax

* fix doc comments

* pr feedback
2020-09-29 18:12:30 -07:00
Arvind Ranasaria
f47c5dcc75 Improved behavior for accepting EULA. (#12453)
* working version of overloading "select" button

* promptForEula to use showErrorMessage

* make parameter optional in promptForEula

* remove test code

* PR feedback

* eula to EULA

* minor fix
2020-09-23 18:36:11 -07:00
Charles Gagnon
807a4ae8c4 Add telemetry for ModelView wizards (#12596)
* Add telemetry for ModelView wizards

* Remove unnecessary params

* Fix compile error
2020-09-23 17:08:22 -07:00
Charles Gagnon
4f433772af Remove command link from deployment error (#12573) 2020-09-22 14:16:40 -07:00
Chris LaFreniere
82749989e6 Arc good ARC bad (#12499) 2020-09-19 10:09:30 -07:00
Charles Gagnon
1355431a36 Revert BDC deployment back to using old azdata check (#12470) 2020-09-18 14:36:18 -07:00
Alex Ma
949f40d07e small optimization for select (#12419) 2020-09-18 14:21:01 -07:00
Arvind Ranasaria
36d78242f7 start with eulaCheckButton hidden (#12427)
* start with eulaCheckButton hidden

* reset buttons on card select

* remove testcode
2020-09-17 19:24:42 -07:00
Charles Gagnon
068ba5b4f4 Fix resource deployment text field validation (#12421) 2020-09-17 17:08:15 -07:00