Alan Ren
afafee844c
fix notebook serialization issue for non-mssql providers ( #22504 )
...
* use mssql as notebook serialization provider
* comment
* use fallback
2023-03-28 21:34:38 -07:00
Hai Cao
83e35ad7f8
fix hover for cells with null value ( #22507 )
2023-03-28 20:19:15 -07:00
Aasim Khan
f60bd1335c
Adding promises and operation timeouts to fix race conditions and infinite loading in OE ( #22475 )
...
* Adding promises and operation timeouts to fix race conditions
* cleaning up logic
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Fixing promise type
* Reverting back to old error logic
* Making onsessioncreated async
* Removed polling and converted to event based
* removing connection variable out of promise
* Combining promises
* Update src/sql/workbench/services/objectExplorer/browser/treeUpdateUtils.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Fixing error messages and localizing user facing errors
* Fixing error message
* localizing config
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Update src/sql/workbench/services/objectExplorer/browser/objectExplorerService.ts
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Fixing comment
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-03-28 18:36:45 -07:00
Charles Gagnon
5c6ea2890a
Switch "Install" to "Download" for downloaded extensions ( #22498 )
2023-03-28 15:35:43 -07:00
Aasim Khan
3aee3f006a
Fixing icon styling in tree ( #22490 )
2023-03-28 09:23:15 -07:00
Cory Rivera
97eb69477e
Remove unused files in sql and extensions folders ( #22444 )
2023-03-27 16:40:32 -07:00
Aasim Khan
e80c6f2dcb
Fixing async tree styling ( #22458 )
2023-03-27 13:16:23 -07:00
Alan Ren
86e6b42bdc
select the row on double click ( #22456 )
...
* select row on double click
* skip row number column
2023-03-24 20:10:05 -07:00
Alan Ren
35cb233851
support default action for OE node ( #22455 )
...
* support default action for OE node
* fix floating promise
2023-03-24 20:09:48 -07:00
Kim Santiago
31ac636222
make screenreader announce task status ( #22434 )
2023-03-24 11:14:10 -07:00
Cheena Malhotra
d5c495f05a
Address Secure enclaves feedback to show required indicator optionally ( #22428 )
2023-03-24 09:57:32 -07:00
Christopher Suh
14ea5e9dd7
fix logic ( #22405 )
2023-03-22 12:57:49 -07:00
Charles Gagnon
ed37ad315f
Clean up buildConnectionInfo ( #22407 )
...
* Clean up buildConnectionInfo
* Add test and cleanup
2023-03-22 12:54:29 -07:00
Cory Rivera
9f435e271a
Establish connection after running New Notebook from Azure data explorer view ( #22408 )
2023-03-22 12:53:03 -07:00
Cheena Malhotra
a3e77c674c
Address console warnings with new connection dialog ( #22293 )
2023-03-22 12:31:25 -07:00
Vsevolod Kukol
e3135aca4c
Preserve name and group when using Connection String ( #22341 )
2023-03-22 07:55:18 -07:00
Kim Santiago
21bb7eb482
add aria label for checkboxes in declrative table ( #22393 )
2023-03-21 16:35:28 -07:00
Charles Gagnon
62ece298cc
Some MSSQL strict null check fixes ( #22383 )
2023-03-21 16:10:57 -07:00
Hai Cao
ffc7f05c10
Add background color for null cell in query editor result grid ( #22370 )
2023-03-20 15:55:57 -07:00
Aasim Khan
f9e72b0d93
Fixing connection group change for connections ( #22379 )
2023-03-20 15:37:47 -07:00
Alan Ren
aa47729f90
fix find parent node issue ( #22356 )
...
* fix find parent node issue
* sts update
* fix errors
* pr comments and a fix
2023-03-20 08:20:11 -07:00
Kim Santiago
931c44ac41
add ariaLive to publish options description ( #22338 )
...
* add ariaLive to publish options description
* use correct string and update typings
* update type
* remove comment update
* create type AriaLiveType
* update MockInputBoxComponent with AriaLiveValue
* update azdata-test and add comment
2023-03-16 16:08:24 -07:00
Alan Ren
20cf2489a2
support rename for login, user and a few other types ( #22331 )
...
* rename object
* add comment
* use URN property
* vbump STS
* revert loc string change
* fix name check
* pr comments
2023-03-16 15:00:07 -07:00
Aasim Khan
f0a5d296bf
Fixing new connections not expanding in object explorer. ( #22307 )
...
* Fixing new connection node not expanding in OE
* Fixing new connections not expanding and fixing expand request not resolving because of some provider error.
* Fixing test
* Adding a setting for node expansion timeout
* Not saving when loading tree based connections
* Adding some logs
* Removing special casing for mssql provider
* Missing providers
* Adding user toast for node expansion timeout
* Adding notification service to test
* Fixing node type for mssql
* remove polling
* Fixing onNodeStatus
* Fixing stuff
* consolidating functions
* Consolidating resolve logic
* removing extra try catch
* code cleanup
* adding size checks
* Removing commented code
* Ignoring errors from other sessions and nodepaths.
2023-03-14 10:50:46 -07:00
Alan Ren
653293aad9
fix action bar size ( #22301 )
2023-03-10 14:39:45 -08:00
Alex Ma
344ca478ef
Fix for Edit Data grid newline on multiline strings ( #22269 )
...
* Fix for newline replacement
* added proper null regex and null character check
* removed cell class
* removed unnecessary function
* revert back to old check
* change onbeforeeditcell
* small fix to typo in onBeforeEditCell
* made changes based on feedback
* added comments clarifying isDBCellValue
2023-03-09 16:10:31 -08:00
Cheena Malhotra
f51fe75397
Null & Error handling in Azure core ( #22259 )
2023-03-09 14:34:39 -08:00
Maddy
5fc69a0445
Fix find highlight on cell edits ( #22080 )
...
* update the rendered text onCellSourceChange
* fix test
* fix highlight in split mode
* update corresponding test
* update hasEditor with getEditor
* update event
* add comment
2023-03-08 22:26:07 -08:00
Aasim Khan
9fddefc8fb
Fixing execution plan not finding provider ( #22238 )
2023-03-08 12:55:49 -08:00
Aasim Khan
d3f4f0daa4
Adding light contrast theme ( #22028 )
...
* Adding light contrast theme
* fixing oe icons
* Fixing more files
* Converting ep files to support hc light
* Revert "Copy Headers for Selected Columns (#21622 )"
This reverts commit f74d6f6d9b
2023-03-06 17:31:27 -08:00
Charles Gagnon
a657aa6cb5
Remove hasEditor from ICellEditorProvider ( #22145 )
2023-03-06 11:02:41 -08:00
Aasim Khan
644f5a16ef
Fixing URI openings for execution plans ( #22139 )
2023-03-04 15:14:50 -08:00
Lewis Sanchez
0f813a9900
Update add account icon ( #22142 )
...
* Update add account icon
* Remove unused icon from SqlIconId
* Remove unused accountActions.css
* Revert "Remove unused accountActions.css"
This reverts commit d31d17f5d2027f25f306e713abff14e750e7479a.
* Remove unused css file and svg's
* Remove unused import
* Revert "Remove unused import"
This reverts commit 91ad47da56d428d8805b65f685af76694b16ba6c.
* Remove unused import
2023-03-03 17:42:10 -08:00
Cheena Malhotra
07eb964c32
Fix AuthLibrary detection and use MSAL by default ( #22140 )
2023-03-03 14:33:29 -08:00
Cheena Malhotra
aa350f7e49
Enable SQL Auth Provider support ( #21903 )
2023-03-03 12:49:01 -08:00
Cheena Malhotra
0ac6f40559
Fixes clearing of username/password on auth type change ( #22138 )
2023-03-03 12:45:09 -08:00
Cheena Malhotra
19d77f02dd
Pre-populate username for selected user account (AzureMFAAndUser) ( #22126 )
2023-03-03 12:11:52 -08:00
Cheena Malhotra
b310e3eed4
Fixes a console error raised from error dialog action ( #22124 )
2023-03-02 21:02:31 -08:00
Lewis Sanchez
eb3c5f1f47
Moves New Deployment from connections pane to file menu bar. ( #22090 )
...
* Moves New Deployment to file menu bar.
* Add deployment back to breadcrumb menu
* Update extensions/resource-deployment/DEVELOPER_GUIDE.md
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
* Adjust new deployment mnemonic
* Remove unused localized string
---------
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com >
2023-03-02 16:26:38 -08:00
Christopher Suh
20c290aa91
Better error messages from connection failures in MSAL ( #22065 )
...
* better error messages from connection failures in MSAL\, fix typo
* cleanup
* pr comments
* rename error interface
* address pr comments
* update api
* fix typings
* change one more typing
* fix build
* fix tests
2023-03-02 15:38:12 -08:00
Charles Gagnon
6172b4677f
Update ads-extension-telemetry ( #22112 )
2023-03-02 15:20:04 -08:00
Cory Rivera
075b3cb35e
Remove unused $connect arg leftover from vscode notebooks change. ( #22108 )
2023-03-02 13:26:44 -08:00
Hai Cao
20969bf244
Add perf marks for query execution ( #22082 )
2023-03-02 11:36:29 -08:00
Aasim Khan
9033ed5583
Adding group by schema button to OE ( #22083 )
2023-03-02 11:35:33 -08:00
Cheena Malhotra
35f7736b96
Add Secure Enclaves dropdown with customizable Advanced options ( #22019 )
2023-03-01 11:01:50 -08:00
Aasim Khan
555f8fbb1e
Adding null checks to prevent runtime exceptions ( #22054 )
2023-02-27 23:46:14 -08:00
Aasim Khan
45d41347ba
Adding null checks and fixing values in slickgrid checkbox column plugin ( #22050 )
...
* Adding null checks to checkbox column
* Setting default value for undefined checkbox
2023-02-27 18:52:16 -08:00
Aasim Khan
dbd1c1b5b3
Fixing table being announced for button ( #22024 )
...
* Fixing table being announced for button
* Fixing issue in the component
* Reverting other changes
2023-02-27 11:24:58 -08:00
Cory Rivera
f53119c2a6
Enable VS Code notebooks with a built-in SQL kernel. ( #21995 )
2023-02-23 16:22:46 -08:00
Charles Gagnon
290687a207
Remove unused things from ads telemetry service ( #22016 )
2023-02-23 15:34:47 -08:00
