Commit Graph
2076 Commits
Author SHA1 Message Date
Hale Rankinandchlafreniere b2e0291a95 10551 - Notebook UI: Added cell toolbar component (#10558)
* 10551 - Notebook UI: Added cell toolbar component, actions scaffolding, styles and theme colors. Removed markup for legacy, hidden hover buttons. Updated instaces of icon class: mask to masked-icon.

* Uncommented lines for CellToggleMoreActions so we can see how the ellipses currently work.

* Added EditCellAction which toggles between two icons.

* Cleaned up comments and removed some unused code.

* Copied DeleteCellAction into celltoolbarActions

* Connecting model and cell model to toolbar component for necessary context.

* Pass in cell + nb model from notebook component

* Adding context for EditCellAction so we can activate a cell via icon.

* Removed my copy of AddCellAction and simply referred to the existing one.

* Fixes to propogate cell model edit mode changes

* Added onCellModeChanged event registration to code.component.

* Moved cellToggleMoreActions into cellToolbarActions. Suppressing ellipses in code and textCell components.

* Fix adding cells

* Copied and modified ToggleMoreWidgetAction for use in cellToolbarActions. Instantiating cellToggleMoreActions and adding to toolbar.

* Removed unused markup, code and styles. Moved cell toolbar template into compoent.

* Removed double-click from textCell. Changed message to indicate where content goes - without it the cell does not have dimension and cannot be found by the user.

* Removed unused code file.

* Fixing my boo boo

* Updated AddCellAction with null coalescer. Set Promise to type: void.

Co-authored-by: chlafreniere <hichise@gmail.com>
2020-05-29 18:27:36 -07:00
Alan Ren 1305743479 fix object filtering regression (#10609)
* fix object filtering regression

* add comments
2020-05-29 10:19:44 -07:00
Alan Ren 7e49eb85fb table style clean up (#10608) 2020-05-29 10:19:09 -07:00
Charles Gagnon 107b3171f2 Add isBigDataCluster property to connection event (#10606) 2020-05-29 06:47:03 -07:00
Vladimir Chernov 8288360cc4 Assessment core extension (#10154) 2020-05-29 01:17:41 +03:00
Alan Ren 032b625ed1 check undefined (#10596) 2020-05-27 16:51:52 -07:00
Amir Omidi 8f33e1c4c0 Introduces decorators to handle multiple authorities for URIs (#10507)
* Introduces decorators to handle multiple authorities for URIs

* Check for undefined first

* Add result type checking
2020-05-26 16:32:25 -07:00
Sakshi Sharma 9a55b0275d Import project from database (#10326)
* Initial changes for Import database as new project

* Functionally complete code

* Initial changes for Import database as new project

* Functionally complete code

* Resolved conflicts with latest changes. Also did some code refactoring.

* Addressed comments. Added unit tests.

* Addressed comments

* Moved ExtractTarget enum from azdata to mssql

* Addressed comments

* Fixed indentation in project templates
2020-05-26 16:08:24 -07:00
Aditya Bist 690e3c582c fix horizontal scroll bug (#10554) 2020-05-26 12:51:18 -07:00
Chris LaFreniere 6d710c7144 Add plumbing and simple notebookService tests (#10349) 2020-05-19 21:36:59 -07:00
Anthony Dresser 0ad7810ba0 fix styles to apply to error message correctly (#10505) 2020-05-19 15:42:34 -07:00
Amir Omidi b02b41815d Don't do any extra parsing, put the responsibility on the caller (#10489)
* Don't do any extra parsing, put the responsibility on the caller

* make integrated default

* Fix the tests

* Fix test
2020-05-19 12:18:18 -07:00
Amir Omidi 21b650ba49 Fixes the DE icons (#10478)
* Fixes the DE icons

* Fixes the commands
2020-05-18 14:04:37 -07:00
Charles Gagnon c70d68f889 Fix text component link to use link component directly (#10457)
* Fix text component link to use link component directly

* Attach styler
2020-05-18 08:25:39 -07:00
Hale Rankin 47687ff6b2 Notebook main toolbar additions (#10271)
* Reworking notebook action bar functionality and appearance.

* added separator

* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.

* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.

* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.

* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.

* Adjusted styles for the cell and run all icons in notebook toolbar.

* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.

* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.

* Added new icon for Underline action.

* Removed comment from needed markup.

* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.

* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.

* Removed unnecessary !important from style override.

* Removed reference to unused color entry.

* Syntax cleanup.

* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.

* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.

* Replaced SVG code for not-trusted icon.

* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
2020-05-15 19:13:31 -07:00
Charles Gagnon 0f10f44755 Fix link styling for text components (#10449) 2020-05-15 15:20:19 -07:00
Chris LaFreniere 452bd6a0cb Notebook model ready sooner (#10420) 2020-05-15 11:48:11 -07:00
Anthony Dresser dd697b337d clear buffer when a batch is completed (#10382) 2020-05-15 11:34:48 -07:00
Amir Omidi b519d51052 Replace the ID of the generated connection profile with the one through edit data (#10413) 2020-05-15 10:48:56 -07:00
Alan Ren 9680b1e2cf create a new connection (#10412) 2020-05-14 16:07:51 -07:00
Alan Ren f934dea6ea use listdatabases for sqlondemand (#10398)
* use listdatabases for sqlondemand

* comments

* use enum
2020-05-14 14:25:29 -07:00
Alex Ma 8f7861deac Keybinding for Show SQL Pane (#9750)
* WIP registerKeybind

* testing command

* Moved command to query.contribution

* Moved command to editData.contribution

* simplified command

* more simplification

* Working keybind for toggle query pane added.

* removed space

* added option to always show sql pane

* removed keybind default and changed option
2020-05-14 14:06:58 -07:00
Alex Ma e3218ade02 Alex/fixforqueryrefresh (#9032)
* added some checks

* Added return undefined

* added handling for multiple loads

* added more error handling

* minor space change

* added explanation message

* simplification

* added changes from create new row

* added some checks

* Added return undefined

* added handling for multiple loads

* added more error handling

* minor space change

* added explanation message

* simplification

* editDataGridPanel corrected

* updated to most recent master version

* removed space at end

* added newline

* added another try catch

* changed message

* added check and message

* added clarifying message

* removed redundant try catch loop

* grid data is now backed up

* wording change
2020-05-14 14:06:26 -07:00
Alan Ren 3212b06d49 set context (#10391) 2020-05-14 10:56:58 -07:00
alljamziMicrosoft ab374e362a Enabling Script as Create for SqlOnDemand (#10362)
* Update scriptingUtils.ts

* Update scripting.contribution.ts
2020-05-12 14:53:45 -07:00
Charles Gagnon 3fa0deed71 Add doAction API call for ModelView (#10345)
* Add doAction API call for ModelView

* cleanup
2020-05-12 10:47:20 -07:00
Christopher Suh 21e6ba92c2 fixed icon spacing in query editor toolbar (#10329) 2020-05-11 18:23:47 -04:00
Charles Gagnon 264c34af97 Add more debug logging to fillInOrClearAzureToken (#10336)
* Add more debug logging to fillInOrClearAzureToken

* Use toErrorMessage
2020-05-11 15:09:34 -07:00
Charles Gagnon 2893659983 Hyperlink Component improvements (#10330)
* Hyperlink Component improvements

* Remove hyperlink CSS styles
2020-05-08 16:49:07 -07:00
Amir Omidi f220f6486a Stops caching the AAD token (#10251) 2020-05-08 16:46:18 -07:00
Cory Rivera f94a9d0d58 Update Configure Python dialog to allow packages to be installed for specific kernels. (#10286) 2020-05-08 16:02:59 -07:00
Charles Gagnon 9bcd7cdd80 Fix tabbed panel not updating correctly when layout updated (#10328)
* Fix tabbed panel not updating correctly when layout updated

* Add comment
2020-05-08 15:56:59 -07:00
Chris LaFreniere 5e1978e29f Ensure ipynb is associated with editor (#10055) 2020-05-08 14:50:48 -07:00
Chris LaFreniere e4614582cd Cleanup nbformat, more common tests (#10311) 2020-05-08 14:50:24 -07:00
Alan Ren 3a70bea70d fix button column accessibility issue (#10307)
* fix accessibility issue

* comment
2020-05-08 14:24:03 -07:00
Charles Gagnon 6e5fc9c495 Add ModelView method SetItemLayout (#10306)
* Add ModelView method SetItemLayout

* Remove extra line break
2020-05-08 08:38:36 -07:00
Chris LaFreniere dac1970c43 Notebooks: Refactor Empty Session Classes (#10265)
* Cleanup empty sessionmanager

* Cleanup

* PR Feedback import noKernel from notebookActions
2020-05-07 16:20:14 -07:00
Alan Ren e27a57715c set provider (#10302) 2020-05-07 13:46:04 -07:00
Vladimir Chernov 57d2ceec9d mssql sqlAssessmentService (#10299)
mssql sqlAssessmentService
2020-05-07 21:35:44 +03:00
Alan Ren d87855cf1f force the isDirty flag to always be false (#10295) 2020-05-07 10:08:22 -07:00
Alan Ren 0ace033a6f table based explorer widget (#10279)
* bump sts

* extend widget container

* remove title

* wip

* refactoring

* Revert "extend widget container"

* showTitle option

* fix properties widget error

* icon column

* icon and button columns

* use textwithicon column

* icon

* refactor and filter

* context menu

* refactor

* tests

* fix hygiene

* tests

* comments
2020-05-06 13:52:20 -07:00
Anthony Dresser df5df38a55 Query Runner Tests (#10252)
* rework some code and write an inital test

* fix strict

* add more to standard test

* add to existing workflow test

* fix tests

* simplify the code

* add more tests

* remove bad import

* fix compile

* fix timestampiong
2020-05-06 13:38:12 -07:00
rajeshkaandRajesh Kamath 4199cec393 Add Cell after current active cell (#10203)
* Add Cell after current active cell

* fixed error

* more fixes

* Addressed PR

* merged with master

* Fixed the tests and code

* removed try catch and modified the test to check the method does not throw.

Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
2020-05-06 11:42:01 -07:00
ADS Merger 8420d9f04e Merge from vscode bd0efff9e3f36d6b3e1045cee9887003af8034d7 2020-05-06 02:35:49 +00:00
Alex Ma 9a7810cbee removal of unnecessary spaces. (#10275) 2020-05-05 14:58:13 -07:00
Alan Ren 0fd3b25ccd remove table setActive (#10256)
* remove setActive method

* another place
2020-05-05 13:21:26 -07:00
Alex MaandAmir Omidi 921e546fd7 Edit Connection Feature added, edit existing connection in connection tree. (#10214)
* Added Edit Connection Command

* Wip changes for new connection dialog

* Testing

* WIP commit

* added ID check to ensure connection

* wip commit

* model id check implemented

* addfooterbutton now accepts events

* wip commit

* message explaining check

* temporary change

* connectionManagementService restored

* Revert "connectionManagementService restored"

This reverts commit 9704a63184a06a33bee2648ef0a899229d117cc0.

* formatting test

* editConnection promise testing

* edit existing connection command added

* WIP Connection Edit

* disconnect added to editConnection promise

* WIP on editExistingConnection

* changed isEdit to true

* Amir/edit connection (#10112)

* Get edit connection working

* Delete unused code

* check for isEdit as well

* connection tree test added

* WIP connection management tests

* comment out test to find out what's wrong

* fix for one error

* added note about test skipped

* changed signature of saveprofile

* saveprofile fixed

* wrote working test

* added additional test

* changed message

* Fixes made

* fix for matcher

Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-05-05 13:21:05 -07:00
Kim Santiago 5fe72d318b Fix toolbar overflow focus not always going to first element in overflow (#10246)
* fix overflow focus not always going to first element in overflow

* adding tests
2020-05-05 13:02:06 -07:00
Amir Omidi 5105694fb3 Render before adding to the splitView (#10261) 2020-05-05 12:05:12 -07:00
Jeff Trimmer 53cb97af9b Add Always Encrypted Parameterization Option (#10182) 2020-05-05 12:01:01 -07:00