Commit Graph

121 Commits

Author SHA1 Message Date
Charles Gagnon
4a2b31f3ba Hook up Notebook execution edits (#17943)
* Start rerouting VSCode cell execution APIs.

* Add more conversion code.

* Convert VSCode notebook registrations into ADS equivalents.

* Update vscode notebook provider kernels when notebook controller's supportedLanguages are set.

* Update an error message.

* Add another session argument.

* Add base classes for converting notebook serializers.

* Disable some vscode notebook methods.

* Disable more vscode APIs.

* Disable more stuff.

* Start implementing serializer notebook data conversions.

* Use direct references to extension host notebook methods, rather than azdata ones.

* Add a comment.

* Remove a space.

* Use import type to fix module loading errors.

* Use internal cancellation token class.

* Start adding cell output conversion.

* Convert data from byte array to a string.

* More output work.

* Use a Set for proxy filtering.

* Start adding tests.

* Include metadata in cell conversion. Fix other test failures.

* Fix serialize tests.

* Add more tests.

* Remove wildcard characters from vscode filenames.

* Start implementing session details.

* Add more kernel info.

* Add kernel spec.

* Add Future callback wrapper class.

* Start implementing execute conversion.

* Pass notebook URI to requestExecute.

* Start working on CellExecution methods.

* Move some code around to fix layering issues.

* Use proxy to access browser code, rather than direct imports.

* Move files around to fix layering issues.

* Remove unused imports.

* Start implementing some notebook cell execution behaviors.

* Revert some unnecessary extHost API changes.

* Check for nbformat.

* Also handle nbformat in serialize case.

* Active notebook extensions when resolving NotebookInput.

* Fix nbformat handling.

* Disable VSCode notebooks code.

* Filter out notebook services from registration assertion.

* Wait for providers to load before calling canResolve.

* Use controller's viewType for notebook provider ID, instead of controller ID.

* Start adding extHostNotebook tests for new APIs.

* Re-order proxy calls.

* Remove commented code.

* Move vscode provider files to browser folder. Fix RPC serialization issues by using readonly field instead of getter for providerId.

* Add a comment.

* Remove unnecessary dispose call.

* Handle disposable from registerExecuteProvider.

* Remove a comment.

* Remove unnecessary provider fields.

* Remove reference to notebook service to fix circular reference issue in stringify.

* Add object types for methods in ADSNotebookController.

* Wait for controller languages to be ready before marking session manager as ready.

* Add correct promise.

* Add undefined return type for optional supportedLanguages property.

* Refine promise logic.

* Move vscode functionality back to ExtHostNotebook, since the NotebookService can't be passed back over RPC (some kind of circular reference error).

* Fix remaining issues from last commit.

* Replace "not implemented" methods with placeholder return types in order to enable testing.

* Also wait for execution handler to be set before marking session manager as ready.

* Fix usage of NotebookRegistry when updating provider description languages.

* Refine file extension conversion.

* Fix file extension conversion to match ADS extension behavior.

* Emit new provider registration event when adding supported languages.

* Remove checks for duplicate file providers and kernels.

* Fix a test failure.

* Fix file extension parsing.

* Use default executeManager if one isn't defined for provider in notebookModel.

* Add descriptors for waiting on standardKernels registration.

* Increase timeout

* Add an error message.

* Start working on retrieving default kernel from registered providers, rather than always falling back to SQL.

* Revert "Start working on retrieving default kernel from registered providers, rather than always falling back to SQL."

This reverts commit 1916ea1ce3a0072f51bec683116dc7bb6c7aefdc.

* Emit activation events after provider registration.

* Wait on standard kernels availability when getting an execute provider.

* Throw an error if session manager isn't ready yet.

* Actually resolve language promise correctly.

* Add some checks for undefined notebook data objects.

* Create kernel spec data correctly.

* Add extension changes for local testing only.

* Clean up test class.

* Add a reminder comment.

* Undo commented out notebook stuff

* Temporarily hard code default kernel.

* Retrieve default kernel in notebookModel if it's not already provided.

* Revert an import change.

* Remove unnecessary method from extHostNotebook.

* Move an interface around.

* wip

* Check for proposed API for some VSCode extHost methods.

* Remove a comment.

* Fix notebookUtils tests.

* Fix notebookModel tests.

* Fix notebookFindModel tests.

* Fix notebookViewsExtension tests.

* Fix remaining notebookView tests.

* Refactor output conversion functionality into separate methods.

* Update some unit tests for output conversion.

* Move a method.

* Rename conversion methods to fit acronym styling.

* Add another conversion test case.

* Revert local testing changes.

* Remove old method.

* cleanup

* Remove some comments.

* Move localized string to locConstants.

* Add a space to loc string.

* Add comments to new SQL Carbon Edit tags.

* Create constants for nbformat and nbformat_minor.

* Move some vscode-only fields to proposed APIs.

* Check for valid state

* Properly null check

* Adding logging for provider wait timeouts.

* wip update

* Fix compile

* Switch to cell edits

* Update docs

* Remove custom output type

* cleanup

* fix

* cleanup

* more cleanup

* Fixes

* Fix tests and lint errors

Co-authored-by: Cory Rivera <corivera@microsoft.com>
2022-01-04 16:35:16 -08:00
Charles Gagnon
2da29f17c2 Fix API docs for NotebookEditorEdit (#17902) 2021-12-13 10:16:00 -08:00
Charles Gagnon
ca20ae4d64 Fix typings files (#17509) 2021-10-27 12:29:00 -07:00
Cory Rivera
14904bb671 Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) 2021-09-29 16:15:28 -07:00
Aasim Khan
95e82d53e6 Adding lists support in text component (#17065)
* Adding lists support in text component

* Fixing get textType

* Code cleanup

* Combining values into value
2021-09-14 12:43:14 -07:00
Alan Ren
ac76409335 update typings file (#16832) 2021-08-19 13:33:53 -07:00
Charles Gagnon
da73265c9e Promote some proposed APIs (#16831)
* Promote some proposed APIs

* Remove buttoncell

* Fix location
2021-08-19 12:29:48 -07:00
Charles Gagnon
ea6e03f826 Fix azure account tree subscription check (#16822)
* Fix azure account tree subscription check

* comment
2021-08-18 14:35:16 -07:00
Charles Gagnon
1015b2f960 Fix schema compare diff editor not showing (#16733)
* Fix schema compare diff editor not showing

* remove unneeded

* remove more unused
2021-08-11 23:15:08 -07:00
Aasim Khan
4bc75ef6d6 Updating mssql to get azure dashboard fixes: (#16658)
1. making cpucount and phy mem props optional in ServerInfo
2. Moving the 2 props to azdata.proposed
2021-08-10 13:06:36 -07:00
Charles Gagnon
68a22421f7 Fix some ModelView API definitions (#16497)
* Remove duplicate title property

* More fixes

* Removed a few unnecessary extends
2021-07-30 11:44:45 -07:00
Charles Gagnon
b2a9074a25 Fix azdata.d.ts linting issues (#16405) 2021-07-22 15:53:18 -07:00
Charles Gagnon
88d28b7d51 Update azdata.d.ts (#16398) 2021-07-22 13:44:42 -07:00
Aasim Khan
3ce6f9e78c adding cpu count and ram to server info (#16109) 2021-07-20 09:56:52 -07:00
Alan Ren
5bd1552a59 add null check for errors in the console while using query editor (#15711)
* add null check

* another null check

* pr comments

* update typing
2021-06-15 16:05:38 -07:00
Charles Gagnon
c8ef4ee47a Promote updated width parameter for createModelViewDialog to stable (#15648) 2021-06-09 12:28:12 -07:00
Alan Ren
2e9555f24a update typing file (#15518) 2021-05-19 13:04:26 -07:00
Charles Gagnon
8fb54710fb Promote CssStyles to stable API (#14824)
* Promote CssStyles to stable API

* add comment

* Fix compile
2021-03-22 12:16:59 -07:00
Charles Gagnon
c65c856d2f Fix API issues for external extensions (#14796)
* Fix azdata API break

* Move dialogwidth to azdata.d.ts

* re-add parameter

* add comment back
2021-03-18 16:46:32 -07:00
Charles Gagnon
11d4ea3232 Promote some proposed APIs to stable (#14788)
* Promote some proposed APIs to stable

* Fix spelling

(cherry picked from commit b88a9ba33e644f83a2b8deac9d99d86803605a85)
2021-03-18 13:11:43 -07:00
Charles Gagnon
6c877a4e20 Update commands and param names (#14658) 2021-03-11 07:29:19 -08:00
Charles Gagnon
ff508b1bf4 Lint typings (#14488) 2021-03-01 14:42:26 -08:00
Charles Gagnon
4b40d66bca Add IconPath type (#14420)
* Add IconPath type

* Add ThemedIconPath subtype

* Update type
2021-02-24 12:49:54 -08:00
Charles Gagnon
d159a1eb50 Remove DOM component (#14328)
* Remove DOM component

* fix compile

* Remove enum type

* one more
2021-02-17 15:16:42 -08:00
Charles Gagnon
3a89731036 Add version to azdata api (#14155) 2021-02-03 17:56:01 -08:00
Aasim Khan
5d1b328866 Fixing the checked variable in radio buttons (#13909)
* Fixing the checked variable in radio buttons

* Emitting the checked state of radio button.

* Adding onChanged event to radioButtons (exposing it)
Deprecating onClick event for radioButtons
Fixing radio button stubs

* Made some type fixes

* Firing event in checked event setter

* updating azdata-test to 1.1 in arc extension

* Some logic fixes in checked setter

* added proper typings and updated package version for azdata-data

* Renamed the event to onDidChangeCheckedState

* Fixed deprecation message

* Fixed broken Schema compare stubs
2021-01-07 23:25:21 -08:00
Alan Ren
ae6494f3e4 table component improvement (#13801)
* hyperlink column

* fixed width for image only button - old behavior
2020-12-14 20:28:43 -08:00
Charles Gagnon
f5e737c760 Use correct Azure graph endpoint & cleanup (#13786)
* Use correct Azure graph endpoint

* Add enum
2020-12-14 10:12:01 -08:00
Charles Gagnon
a926f87965 Clean up Loading Component typings (#13785)
* Clean up Loading Component typings

* add properties to impl
2020-12-11 12:57:46 -08:00
Charles Gagnon
7ad328ee95 Lint azdata.d.ts (#13728) 2020-12-08 13:20:17 -08:00
Lucy Zhang
c898b50b94 Remove resultSet from IDisplayResult metadata (#13450)
* remove resultSet from IDisplayResult metadata

* remove metadata from IDisplayResult
2020-11-16 17:54:09 -08:00
Lucy Zhang
32a6385fef Notebooks: Save cell connection name in cell metadata (#13208)
* save connection info in notebook metadata

* update attachTo dropdown based on saved alias

* add setting for saving connection (default=false)

* save/read cell connection name to/from metadata

* get started on toggling multi connection mode

* add activeConnection property to cell model

* add changeContext method for cell

* add comments

* add unit test for reading connection name

* save connection mode in metadata

* clean up code

* address PR comments
2020-11-12 10:44:34 -08:00
Lucy Zhang
86357b45b0 Notebooks: re-factor grid streaming (#12937)
* refactor grid streaming (convert to data first)

* change convertRowsToHtml method to return value

* remove griddataconversioncomplete checks

* send row data from STS to gridoutput component

* clean up code

* send data updates to cell model

* serialize cell output at the end of cell execution

* remove unused parameters

* update output contents instead of output reference

* remove unnecessary promise

* move azdata changes to proposed

* update comment
2020-10-28 09:08:15 -07:00
Arvind Ranasaria
f4c7ab29f0 Allow WithValidation on ComponentBuilder to register async callbacks (#12950) 2020-10-15 17:38:20 -07:00
Alan Ren
bc3527d310 API improvement: make registerConnectionEventProvider return disposable (#11880)
* promote api to official

* add comments

* disposable

* move getConnection out

* comment for connection namespace

* remove extra line

* also fix registerQueryInfoHandler
2020-10-12 14:29:48 -07:00
Lucy Zhang
b910bf2f33 Notebooks: Fix strict compile errors (#12591)
* strict compile for sqlSessionManager.ts

* start clientSession.ts fixes

* strict compile for clientSession.ts

* strict compile for notebookModel.ts

* add display name

* clean up code

* clean up code

* initialize string to empty string

* address PR comments

* address PR comments

* address PR comments

* remove errorMessage check
2020-10-08 15:39:57 -07:00
Charles Gagnon
f633e07ed1 Add more advanced properties for spark job submission dialog (#12732)
* Add more advanced properties for spark job submission dialog

* Add queue
2020-10-06 09:50:32 -07:00
Lucy Zhang
cf9754f627 revert grid streaming changes (#12650) 2020-09-28 18:34:58 -07:00
Charles Gagnon
bf9646ba98 Add ModelViewEditorOpened event (#12597)
* Add ModelViewEditorOpened event

* fix

* Fix compile
2020-09-24 12:53:28 -07:00
Lucy Zhang
945e04ed92 Fix notebook table rendering with multiple code cells (#12363)
* create unique query runner for each cell

* use cellUri instead of cellId to identify runner

* disconnect each query runner connection

* remove queryrunners size check
2020-09-17 09:44:10 -07:00
Charles Gagnon
dcc8ef54b9 Fix DT linting issues (#12290) 2020-09-16 07:59:06 -07:00
Amir Omidi
61ceb72cea Change tables to make them work for our scenario (#12193)
* Change tables to make them work for our scenario

* Comments & deprecate API

* Disable selections by default
2020-09-11 13:44:19 -07:00
Amir Omidi
9ed274fb39 Genericify components (#12158)
* Genericify components

* Fix compile issue

* Fix feedback

* Genericify azdata components (#12164)

* azdata generics

* Add the withProps method to azdata proposed as there may be mistakes with the interfaces in the generics

* Fix build issues because of other extensions

* Remove extra spaces
2020-09-08 16:15:24 -07:00
Anthony Dresser
503090856a Strict null scripting (#12126)
* strict null scripting

* fix compile

* fix tests

* fix icon
2020-09-04 18:04:08 -07:00
Amir Omidi
59bb827d2e Introduce vertical cards (#12125)
* Introduce vertical cards

* Simplify and add a css type

* Feedback

* Update yarn.lock
2020-09-04 15:15:58 -07:00
Anthony Dresser
b7c2eaa65d strict compile contrib/backup (#12088) 2020-09-03 11:50:53 -07:00
Anthony Dresser
8b8bef0401 add strict compile for restore (#12067) 2020-09-02 11:58:30 -07:00
Shafiq Ur Rahman
2f94307635 Kusto extension for ADS (#11752)
* Kusto extension

* Add kusto to extensions.ts

* Remove objectExplorerNodeProvider

* Removed some BDC items + CR cleanup

* Cleanup unused strings in package.nls.json

* Remove unused svgs, and some cleanup

* Bringing objectExplorerNode back and hygiene changes

* rename to KustoObjectExplorerNodeProvider

* rename to KustoIconProvider

* Cleanup SQL code

* Fix compilation error

* Clean up in objectExplorerNodeProvider folder

* Some more clean up based on comments

* apiWrapper add

* changed to camelCase

* Remove unused functions/files

* Removed AgentServicesFeature

* dacfx, cms, schemacompare clean up

* Clean up and addressed few comments

* Remove apWrapper from kusto extension

* Addressed few comments

* credentialstore and escapeexception changes

* Added strict check for Kusto extension

* Fix error and addressed comment

* Saving Kusto files shoulf default to .kql

* package.json changes

* Fix objectExplorerNodeProvider

* Amir/kusto fix (#11972)

* Add the compiled extensions.js

* Fix strict compile rules

Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
2020-08-26 14:13:31 -07:00
Amir Omidi
4659d727b7 strict null checks azure (#11928)
* strict null checks azure

* strict compilation

* Fix compilation issues

* Return empty arrays instead
2020-08-25 18:12:47 -07:00
Charles Gagnon
d073cd595b Disable connectivity mode selection (#11911)
* Disable connectivity mode selection until Direct mode is fully completed

* add azdata change
2020-08-21 13:08:49 -07:00