Charles Gagnon
55059907a3
Fix a couple a11y issues with manage access ( #8386 )
...
* Fix a couple a11y issues with manage access
* Fix strict null check
* Fix another strict null check
2019-11-19 13:42:53 -08:00
Charles Gagnon
8ca0082ec4
Fix tab navigation within modal dialog ( #8326 )
...
* Fix tab navigation within modal dialog
* Add import
* Fix spelling
* Change to just add/remove items from DOM as necessary
2019-11-19 12:43:55 -08:00
Charles Gagnon
5b50696a1b
Fix more floating promises ( #8374 )
...
* Fix more floating promises
* Fix a few more
* Test fixes
* Fix spellings
* More promise fixes
* couple more
* Few more fixes
* One more missed one
2019-11-18 17:11:25 -08:00
Charles Gagnon
8a44de27e7
monacoworkbench -> adsworkbench ( #8380 )
...
* monacoworkbench -> adsworkbench
* Fix typo
2019-11-18 10:57:39 -08:00
Anthony Dresser
fa9bbd4e1e
remove commented our code that is removed elsewhere ( #8370 )
2019-11-18 10:55:31 -08:00
Charles Gagnon
66048f1d63
Default checkbox aria label to label ( #8367 )
2019-11-18 10:24:27 -08:00
Charles Gagnon
ae8304fc33
Add focus function for modelview components ( #8348 )
...
* Add focus method for modelview components
* Remove focus properties from table and radiobutton
* Fix break
2019-11-15 17:36:55 -08:00
Amir Omidi
d6ef42c8b0
Change how dropdowns get their lengths - take 2 ( #8356 )
...
* Add an element for width control
* Change the method that retrieves length
* Change to a readonly element
2019-11-15 15:17:46 -08:00
Charles Gagnon
82185f75d7
Fix tab focus for select box ( #8349 )
2019-11-15 14:31:40 -08:00
Charles Gagnon
ba8c331356
Add alert role to error message element ( #8354 )
2019-11-15 11:51:08 -08:00
Charles Gagnon
7563416754
Fix a couple a11y issues ( #8334 )
...
* Fix a couple a11y issues
* Add other dialog
2019-11-15 07:41:09 -08:00
Charles Gagnon
6ef87d7067
Insiders icons ( #8313 )
...
* Add separate icons for non-stable builds (#8078 )
* Fixes
* Fix linux icon path
* WIP
* WIP
* WIP
* Undo all
* Try removing insiders icons completely
* Revert "Try removing insiders icons completely"
This reverts commit 7cdb04fcc3ba6ed92132e5d9113cc331e24b3c26.
* Revert "Undo all"
This reverts commit efac800b63483fbbcacdac45d885275c53350941.
* Revert "WIP"
This reverts commit b20517f374b85f6b02c665b86e73d9ae1b45258b.
* Revert "WIP"
This reverts commit 01383896ccc4939b000d0f08a1b370f6e66b0f3c.
* Revert "WIP"
This reverts commit da7da0a43401f1c97f1bfa66f255666cffe22948.
* Fixes
* Remove test
* Switch logic check
* Use insiders icons only
* Add newline
2019-11-14 17:21:57 -08:00
Anthony Dresser
7a2c30e159
move code from parts to contrib ( #8319 )
2019-11-14 12:23:11 -08:00
Charles Gagnon
18ab2ae799
Remove TelemetryUtils and use IAdsTelemetryService directly ( #8289 )
...
* Remove TelemetryUtils and use IAdsTelemetryService directly
* Fix event names and cleanup
* Fix tests
* Fix strict null check
2019-11-13 13:54:55 -08:00
Charles Gagnon
86d6295bf0
Fix welcome page icon ( #8318 )
...
* Fix welcome page icon
* Remove title metadata
* Add comment
2019-11-13 07:31:04 -08:00
Charles Gagnon
3f306d2396
Fix spacing for form layout ( #8321 )
2019-11-13 07:30:09 -08:00
Chris LaFreniere
2f1f5b2376
Prevent Markdown Cells from Collapsing ( #8317 )
2019-11-12 18:40:06 -08:00
Charles Gagnon
4f69ed5745
Fix missing icon and add test ( #8307 )
...
* Fix missing icon and add test
* Remove debug statement
2019-11-12 16:31:39 -08:00
Charles Gagnon
ddddf3beb4
Fix null ref error in query history ( #8304 )
...
* Fix null ref error in query history
* Add null check
2019-11-12 13:38:58 -08:00
Charles Gagnon
0ae525cbd5
Fix a few more floating promises ( #8290 )
...
* Fix a few more floating promises
* More explicit calls
2019-11-11 13:42:03 -08:00
Chris LaFreniere
0520870754
notebooks lgtm cleanup part 1 ( #8280 )
2019-11-11 13:40:48 -05:00
Charles Gagnon
8b17b77010
Undo codicon change to fix modelview images ( #8201 )
2019-11-11 08:28:48 -08:00
Alan Ren
e2ef1f8a89
remove the extension name link ( #8271 )
...
* remove the extension name link
* pr comments
* pr comments
2019-11-09 13:37:09 -08:00
Anthony Dresser
7f7052ad42
Clean up some of the extensions ( #8267 )
...
* 💄
* prune unused code
* more cleanup
* remove abunch of used code
2019-11-08 11:44:43 -08:00
Alan Ren
b364e32beb
improve the loading component ( #8251 )
...
* improve the loading component
* fix unused method warning
* revert the change
2019-11-07 11:28:38 -08:00
Alan Ren
7f51921176
fix the scroll issue of modal dialog and wizard ( #8239 )
...
* fix the scrolling issue of dialog and wizard
* revert unwanted changes
2019-11-07 10:50:00 -08:00
Charles Gagnon
efebd681b6
Add level to dialog titles and form component titles ( #8233 )
...
* Add level to dialog titles and form component titles
* Switch to h1
* h2 instead of role and aria-level
2019-11-07 09:32:02 -08:00
Charles Gagnon
d635390b33
Fix missing dashboard icons ( #8249 )
2019-11-07 08:05:06 -08:00
Anthony Dresser
df0c505452
No unused locals ( #8231 )
...
* add no unused local
* fix strict null
* fix compile errors
* update vscode comments
2019-11-06 17:22:05 -08:00
Anthony Dresser
564f78b6f6
Revert "Revert "Remove typings and replace missing methods with vscodes ( #8217 )"" ( #8242 )
...
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217 )" (#8240 )"
This reverts commit e801a04bcf .
* fix runtime error
* add tests for chartview
2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf
Revert "Remove typings and replace missing methods with vscodes ( #8217 )" ( #8240 )
...
This reverts commit 22a427f934 .
2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934
Remove typings and replace missing methods with vscodes ( #8217 )
...
* remove typings and replace missing methods with vscodes
* fix strict-null-checks
* fix tests
2019-11-05 13:03:20 -08:00
Amir Omidi
1b88c10197
Some promise fixes ( #8216 )
...
* Some promise fixes
* changes to how we're logging errors
* Fix the tests
* Fix a few other issues
2019-11-05 11:50:39 -08:00
Charles Gagnon
e49ff93122
Fix link for manual install of VSIX's ( #8221 )
2019-11-05 10:44:26 -08:00
Charles Gagnon
399788ccc1
Fix row/column count and table aria label ( #8219 )
2019-11-05 09:52:59 -08:00
Charles Gagnon
08fde8719d
Make declarative table read blank for empty text cells ( #8215 )
2019-11-05 08:02:37 -08:00
Anthony Dresser
ade68b184d
Move code around for more linting ( #8190 )
...
* testing
* moving around all the code
* fix strict nulls
2019-11-04 10:41:28 -08:00
Cory Rivera
3c702c15e2
Initialize cell source to empty array if notebook file's source is undefined. ( #8189 )
2019-11-04 10:38:14 -08:00
Anthony Dresser
76e8805a6b
Remove should ( #8196 )
...
* remove should
* fix a few tests
2019-11-04 09:59:18 -08:00
Charles Gagnon
5dc7049f8c
Fix floating promises in connection widget ( #8198 )
...
* Fix floating promises in connection widget
* PR feedback
* More feedback changes
* Couple missed promises
2019-11-04 07:24:38 -08:00
Maddy
c2c64293f5
missed insiders-only check removal ( #8184 )
2019-11-01 17:06:38 -07:00
Anthony Dresser
1d31a6ef98
Bump some packages ( #8096 )
...
* update packages
* remove fs
* fix more deps
* test adding governance to ci
* ignore samples for cacheing
* fix save cache too
* bump more packages
* attempt to fix slickgrid
* add more deps
* use slickgrid version
* bump https-proxy
* bump more packages.
* fix service-downloader
* remove typings
* fix compile
* update more packages
* add vscode back to the extensions that need it for testing
* add fail on critical
* regrab proxy agent
* lock more deps
* replace final high warning
* revert service downloader changes
* remove the deps on jquery ui and event drag
2019-11-01 12:55:58 -07:00
Amir Omidi
b62c0cf2ab
More promise cleanup ( #8100 )
...
* Some promise cleanup
* Handle more promise issues
* Remove changes that aren't needed anymore
* Use log service
* another one
* Be more explicit
* Some more promises cleaned up
* Handle promises here too
* Strings for errors
* Some more cleanup
* Remove unused imports
2019-10-31 14:30:08 -07:00
BranislavGrbicMDCS
572a83dac7
Hidding error message for sql on demand on server dashboard ( #8146 )
...
* Hidding error message for sql on demand
* Using constant instead of hardcoded value
2019-10-31 21:25:39 +01:00
Alan Ren
23da6155dd
fix the missing icon issue of expand/collapse btn ( #8132 )
2019-10-30 20:10:34 -07:00
Charles Gagnon
ef9321ef2c
Add error messages to BDC dashboard page ( #8103 )
...
* Add error messages to BDC dashboard page
* Remove testing code
* PR fixes
2019-10-30 15:23:34 -07:00
Alex Ma
9eb319f392
ImageInsight Image Error Notification ( #8086 )
...
* image visualization printout (needs localization)
* Add error image and log error
* "added alert error for invalid image"
* removed unnecessary spaces
* removed spaces on 61 and 66
* Added image and used notification service
* Removed unused import
* Changed wording for error
2019-10-30 14:48:12 -07:00
Chris LaFreniere
dd270a78fc
Notebooks: Improvements to Connection Profile Passing ( #8105 )
...
* Fix relative images on notebook markdown pc
* PR feedback around replace ordering
* update databaseName when it's set to master
* usinng query as example
2019-10-30 13:22:17 -07:00
Anthony Dresser
827e6162c7
fix import ( #8116 )
2019-10-30 13:11:29 -07:00
Alan Ren
9f54fbc8cc
profiler icon issue ( #8115 )
2019-10-30 12:32:37 -07:00