Commit Graph

1769 Commits

Author SHA1 Message Date
Anthony Dresser
bd7aac8ee0 Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2 (#8911)
* Merge from vscode a234f13c45b40a0929777cb440ee011b7549eed2

* update distro

* fix layering

* update distro

* fix tests
2020-01-22 13:42:37 -08:00
Charles Gagnon
8b9aeb8679 Fix some dtslint errors in azdata.d.ts (#8931)
* Fix some dtslint errors in azdata.d.ts

* Undo return type change
2020-01-22 13:04:52 -08:00
Cory Rivera
52e3c2f9c7 Clear cell execution count when clearing output. (#8908) 2020-01-21 13:56:38 -08:00
Charles Gagnon
d517cf0c8c Fix new editor windows to open with global connection (#8901)
* Fix new editor windows to open with global connection

* Fix test

* Fix tests

* Move logic to queryInputFactory

* Remove unused function

* Remove unneeded check

* Add tests
2020-01-17 07:44:28 -08:00
Maddy
74c2d16660 getter for markdown editor on edit mode (#8871)
* getter for markdown editor on edit mode

* use first and find to work-around the code editor changes
2020-01-14 15:29:55 -08:00
Anthony Dresser
88126c68e7 fix issues with uri being different format for query results (#8850) 2020-01-11 00:22:48 -08:00
Anthony Dresser
2f6c944317 Add editor contribution tests (#8784)
* wip

* rewrite association

* fix tests

* add more tests

* fix tests

* fix more tests

* fix tests
2020-01-10 18:57:47 -08:00
Alex Ma
c161f8d8ad Added fix for italics for last row (#8773)
* Added fix for italics for last row

* Added null handling in formatters

* Fixed issue with null not italicizing on grid

* small formatting fix

* some consolidation

* removed null check

* minor change

* removed null check in formatters
2020-01-09 10:23:11 -08:00
Maddy
61cbc5eff0 uncommented old tests and fixed them (#8834)
* uncommneted old tests and fixed them

* removed comments
2020-01-08 13:21:40 -08:00
Leila Lali
fa4ad6cdb9 Adding a n activation event for opening the dashboard (#8733) 2020-01-08 12:18:17 -08:00
Amir Omidi
1b26dc0558 Consolidate connection namespace (#8844) 2020-01-08 12:08:59 -08:00
Amir Omidi
833313c72b Use the user's locale (#8843) 2020-01-08 12:02:18 -08:00
Aditya Bist
774151b6e9 Fixes job history for Agent (#8847)
* fix job history function

* unbump version
2020-01-08 11:19:40 -08:00
Maddy
b1526603cc Tests/notebook find tests (#8827)
* updates to existing book tests

* notebookFindModal tests

* remove commented code

* undo book test changes

* undo book test changes

* resolve the find array

* additional tests
2020-01-07 16:35:28 -08:00
kenvanhyning
dd8b12f805 Kenvh/noazurecms (#8755)
* Disallow Azure SQL DB servers for CMS

* removed commented out lines

* added check for valid serverInfo
2020-01-06 16:53:06 -08:00
Alan Ren
c5d3251bb5 remove sql ops (#8805) 2020-01-06 15:37:09 -08:00
Charles Gagnon
fa2fcf2e40 Log original kerberos errors to console (#8804)
* Log original kerberos errors to console for debugging purposes

* Fix compile error
2020-01-03 15:30:42 -08:00
Anthony Dresser
5b34dd2eee add listening for refreshing the top operations table (#8780) 2020-01-03 11:28:32 -08:00
Charles Gagnon
d647dbde09 Make dropdown update width immediately upon opening (#8716)
* Make dropdown update width immediately upon opening

* remove type

* min size of the input container width

* use clamp
2020-01-03 11:07:24 -08:00
Cory Rivera
d2e367c139 Use a single button for expanding and collapsing a notebook cell. (#8797) 2020-01-03 10:34:45 -08:00
Maddy
c3ddbba997 Only show find when modal is loaded and expand the collapsed cell on find. (#8790) 2020-01-01 20:17:50 -08:00
Anthony Dresser
03df1edcf8 use URI to equal (#8770) 2019-12-23 18:03:38 -08:00
Anthony Dresser
5bd983e7a3 fix icon for dataexplorer (#8769) 2019-12-23 12:15:46 -08:00
Anthony Dresser
4293d53e79 Merge from vscode d06f0e877ceaf3a35a283f1bfdc50927ec8dfd1e (#8767) 2019-12-22 08:53:45 -08:00
Alex Ma
ce10c3ac3f Added check for the last null row (#8764) 2019-12-20 15:16:56 -08:00
Maddy
778a34a9d2 Books/search within notebook (#8426)
* initial commit

* get notebook content

* skeleton for find in notebookModel

* add search function and keyboard shortcut

* add command for hiding find widget

* started on search logic

* continue search logic

* continue search logic

* add findcountchange listener

* notebook find position

* added css class

* hide find widget

* focus find input

* search for multiple occurrences in one line

* start notebook find decorations

* start adding decorations to notebook model

* added editor_model_defaults

* added cursor position

* merged master and resolved husky erros

* initial changes added to Lucyls base implementation

* pass NotebbokRange instead of Range to decorations

* changes after merging master

* temp changes for testing

* style updates from vscode merge

* implemented the empty methods and added supporting functionality from textModel

* just a little error checking

* It gets more and more yellow

* making highlight work between code cells

* highlight only word

* remove highlight on close and maintain the position

* cleanup of unused references

* clean up

* find between code cells refactored

* highlight markdown line and scroll to it

* find index fix

* find index fix

* code clean up

* remove commented code

* tslint fix for: Cannot use global 'NodeJS'

* linting rule fixes

* deltaDecoration base implementation on the base class

* moced class defnitions from interface fikle

* updated action names

* DOM.addClass instead of overwriting

* resooved conflicts

* moved 'find' code away from notebookmodel to sep class

* moved find realted code to seperate folder

* created notebookFindModel

* clean up

* highlight color changes

* spacing and typo fixes

* highlight correct element for nested elements

* do not iterate through paragraphs and li

* find accross notebooks

* keep track of index

* clear decorations on close

* floating promises

* maintain search context

Co-authored-by: Lucy Zhang <lucyzhang929@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
2019-12-19 17:21:03 -08:00
Anthony Dresser
099916bf19 Merge from vscode e74405d11443c5361c31e2bc341866d146eee206 (#8740) 2019-12-18 23:36:29 -08:00
osmant
48dcb7258e Guest account connection issue while using (#8726)
AAD authentication
2019-12-18 12:13:46 -08:00
swjain23
e181cf2fcd Bug fix to return authType as undefined if displayName is not set (#8731)
We noticed that if displayName is undefined this method would return the first auth type it found as getAuthTypeDisplayName() would return undefined.
If the displayName is undefined, we would not have a matchingTYpe and it should be undefined.
2019-12-18 11:40:20 -08:00
Maddy
746b4d7815 Book/untitled file name updates (#8579)
* file-name has entire path as name, changes to address that

* await promises
2019-12-18 09:09:17 -08:00
Anthony Dresser
30d9e9c141 Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 (#8722)
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1

* remove tests that aren't working
2019-12-18 00:14:28 -08:00
Anthony Dresser
1c0f7c6702 open external for files from results serialize (#8666) 2019-12-17 12:47:23 -08:00
Anthony Dresser
9e0ba700c1 defensive about query rows; fix styling on dropdown; fix bug with always using the first dataset (#8680) 2019-12-17 12:26:33 -08:00
Anthony Dresser
ea5f9be441 Properly expose errors in ads and tests (#8692)
* add code to expose errors outside zone

* remove unexpect error hiding

* remove uncessary code

* fix tests

* trying to catch more errros

* revert for testing

* wip

* wip

* figured out what was going on

* wip

* fix tests

* fix tests
2019-12-17 12:06:36 -08:00
Anthony Dresser
8e4d0ad446 remove unnecessary info from problem svgs (#8712) 2019-12-17 10:13:06 -08:00
Aditya Bist
ef8c0e91e6 fix provider dropdown option for cms dialog (#8711) 2019-12-16 18:50:50 -08:00
rajeshka
73b9849dd5 Toggle Trusted Button (#8569)
* Toggle Trusted Button

* Persist Trusted information to Cache

* Trusted toggle unit test fixed

* Updated test comment
2019-12-16 13:32:56 -08:00
Alan Ren
64e217eac2 change order of tasks (#8703) 2019-12-16 13:21:03 -08:00
Chris LaFreniere
826e069b63 Fix passing in connection profile (#8689) 2019-12-16 13:20:43 -08:00
Chris LaFreniere
6e8a08c27a Fix Notebook Scrolling by Setting alwaysConsumeMouseWheel to False (#8686)
* flip alwaysConsumeMouseWheel to false for nb

* remove semicolon
2019-12-16 13:17:02 -08:00
Charles Gagnon
a42407b81a Fix missing action buttons with single view (#8694) 2019-12-16 10:33:21 -08:00
Charles Gagnon
a622e4ac40 Fix options dropdown arrow alignment in options dialog (#8695) 2019-12-16 09:58:57 -08:00
Aditya Bist
a0c3f8f614 fix modelview tables failing for number columns (#8681) 2019-12-13 16:46:57 -08:00
Charles Gagnon
01b9754c80 Fix alignment of select dropdown in modal dialogs (#8683) 2019-12-13 16:23:25 -08:00
Charles Gagnon
b650168704 Add de viewlet tests back (#8673) 2019-12-13 14:08:01 -08:00
Anthony Dresser
642920504a Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12 (#8670)
* Merge from vscode cbeff45f80213db0ddda2183170281ed97ed3b12

* fix null strict checks
2019-12-13 00:50:37 -08:00
Amir Omidi
67abc2f690 zonejs changes (#8664) 2019-12-12 17:07:26 -08:00
Charles Gagnon
5bf85a2855 Add tests for refresh scripting action (#8648)
* Add tests for refresh action

* Revert changes to make tree public

* Move tests into subsuite
2019-12-12 16:04:28 -08:00
Cory Rivera
866bfc61ba Add more unit tests for NotebookInput (#8654) 2019-12-12 14:59:56 -08:00
BranislavGrbicMDCS
6638db1f35 Brgrbic/code cleanup issue8158 (#8655)
* Removing engine edition specific condition from displaying error message

* Removing unused import
2019-12-12 13:24:31 -08:00