Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
- acounts view
- new tab view in dashboard
- many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.
Fixes#7827
* Fix don't like; unclear if grammar necessssary too
* Cleanup and sanity check
* Cleanup and sanity check
* Add test
* Call onBeforeAttached for 3 types of editor models
* add saved/untitled views to the books viewlet and provide save option to untitled
* addressed comments
* fixes after merge
* await on async methods
* reverted back
* await on promise
* added localize for books view names
* initial commit
* missed a file change
* changes to make the merges work part1
* fixes after merges 2
* getChildren to get all books
* chnages to address comments
* fsPromises instead of fs.readSync
* merged master
* replaced deprecated fs.exists async call with pathExists
* renamed method
* replaced fs with IFileService
* work around for URI with relative paths
* updates to comments
* renamed existsSync to exists
* await on promise inside non-async method
* .then change
* await async calls
* removed the old code
* include everthing in .then
* remove file exists check
* added _ for consistency
* use path.abosult method
* fixed the cleanIrl calls back and path.sep change
* reverted path.sep for now
* edit perf
* Save multiline source in notebooks
* More merges
* Single, multi line works needs work
* Works with single + multi and recomputes active
* Actual perf improvements this time
* code cleanup
* Calculating output position on the fly
* Hmm can we use brackets to make this simpler?
* monday progress
* output working. lots of improvements.
* First tests working
* 10 tests now, fixed bugs
* Cleanup, add output test
* More fixes
* Need to still fix execution count bug
* Tests pass, added comments
* Cleanup
* PR comments round 1
* Deal with merge issues from master, layering
* Deleting duplicate file
* More PR Comments
* PR Comments
* initial commit
* fix: added initialize method to fix the previous/next links rendering
* added checks
* open first markdown/ipynb in the book ans expand the view
* added launch book from command pallete, removed the pick folder and save option added launching the first notebook/markdown
* moved the open book command pallet action from mssql to notebooks
* open as untitled to true
* opening markdown files issue fix
* removed opening as untitled files
* open ipynb files as untitled and changes for previous&next links to work
* add books as seperate viewlet
* localize double quote issues and renamed treeCollapsibleState
* renames and added logic to conditionally show Preview command
* moved registerCommands from widget to extension contribution
* isEditorUntitled check
* async comment updates
* formatting issues.
* promisfying the async calls
* moved existsAsync to top
* working; new query and scripting
* working; removing manage from menus and combining data explorer contributions
* consolidate dashboard contributions; move manage action to dashboard contributions; make groupings the same
* fix notebook actions not firing
* fix notebook actions
* notebooks working
* move backup and restore entry points into their own file; move explorerwidget contribution into their respective files
* fix tests
* move extension actions to their own file
* fix tests
* change tests