Commit Graph

673 Commits

Author SHA1 Message Date
Cory Rivera
c2cc32a4a0 Add option to use notebook json contents instead of file string when creating a notebook. (#18972) 2022-04-08 16:39:14 -07:00
Hai Cao
0738c148ca A few table designer improvements && bump STS to .227 (#18982)
* Add unified col for data type deit

* remove seperate type setting cols and rename unified col to 'type'

* remove advanced type from properties window

* add description to col, idx, constraints

* nit

* bump STS to .227
2022-04-08 15:00:56 -07:00
Maddy
4191ef8aa5 Fix active cell update on tabbing (#18614)
* listen on focus_in of toolbar

* update styles on focus_in

* listen for active cell change on notebook componen

* add tabbing order to textcells

* remove duplicate listener

* clean up

* undo

* remove visible check from cellToolbar

* remove duplicate detectChanges on updateActiveCell

* only update active cell if it's already not

* add aria-label for accessibility

* localize the aria label

* refactor

* add cellLabel property to CellModel

* remove updateActiveCell from code component

* regression from merge fix

* set edit mode as true when focusing on cell

* moce check to model

* merge changes correctly

* update edit mode if code cell

* fixes

Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-04-08 12:31:30 -07:00
Cory Rivera
03d2e83250 Treat Jupyter's Python 3 Ipykernel alias as Python 3. (#18943) 2022-04-06 11:27:15 -07:00
Lewis Sanchez
a6000aef67 Resolves undefined tenant error while adding an account. (#18937)
* Selects the first tenant that appears in the drop down list of tenants

* Fixes tenant undefined while adding account error
2022-04-05 13:14:06 -07:00
Alan Ren
a795e64bed fix language change issue (#18906) 2022-04-01 17:52:11 -07:00
Aditya Bist
bab5118996 Add graph icons to OE and TD (#18808)
* add graph icons to OE and TD

* PR comments

* change enum type

* change sub type to icon and make basic as default

* changed icontype to icon

* change default logic location

* change icon name to be more generic

* use right icons
2022-04-01 00:27:59 -07:00
Aditya Bist
e7773425ee added graph node types from edit and publish results (#18891)
* added graph node types from edit and publish results

* make generic property bag

* review comments

* add comment for function

* edit comment

* change name to telemetry info
2022-03-31 21:50:26 -07:00
Chris LaFreniere
af3d307d40 Restart kernel initial implementation (#18835)
* Restart kernel initial implementation

* Update notebook extension TestKernel

* PR comments
2022-03-29 12:56:52 -07:00
Lewis Sanchez
85b4bf13f9 Initial sets up of new execution plan comparison result endpoint (#18813)
* Initial sets up of new execution plan comparison result endpoint

* Makes query execution plan endpoint URI's more consistent.
2022-03-25 11:47:46 -07:00
Cory Rivera
7914fcf101 Fix issues with unknown notebook file types not opening as a default notebook. (#18779) 2022-03-18 16:59:22 -07:00
Maddy
23a69f9b69 Add test for last edit mode (#18734)
* add test for persisting last edit mode

* remove empty line

* address comments

* update comment
2022-03-18 16:13:58 -07:00
Alan Ren
d6abcb892d handle validation error (#18766) 2022-03-17 19:43:02 -07:00
Alan Ren
9f2940e8f8 add severity support for issues (#18761)
* add severity support for issues

* vbump STS

* pr comments
2022-03-17 14:09:02 -07:00
Aasim Khan
a0c2dc199e Adding Execution Plan Editor to ADS (#18696)
* Pushing Execution Plan Editor

* Renaming class
Handling error

* Awaiting for handlers to be registered

* Addressing some PR comments

* Fixing return type for provider

* Fixing editor id and removing unnecessary overrides

* Adding a namespace

* adding execution plan namespace

* Adding protocol comment

* Fixing if logic

* Fixing error message

* Cleaning up code

* cleanup code

* Adding help comments

* Fixing method call

* Using path.ts to get the base file name

* converting to lambda functions

* Adding comment for run action

* Fixing pr comments

* Fixing editor label

* Fixing doc comments

* Adding some more comments

* Fixign branding in comments
2022-03-16 15:07:29 -07:00
Cory Rivera
95980130c8 Correctly handle creating and saving untitled notebook .dib files. (#18744) 2022-03-16 14:37:21 -07:00
Cory Rivera
206188f3ab Add missing onNotebook:* activation event for VS Code notebook compatibility. (#18710) 2022-03-14 10:32:26 -07:00
Alex Ma
26e6cd28c2 Add account loading screen until provider accounts have finished loading (#18692)
* Added wait for accounts to be loaded to prevent premature loading

* revert changes

* WIP loading screen

* added work in progress emitter.

* added test event fire

* added test for accountDialogController emitter

* fixed test

* added event emitters inside accountDialog

* WIP changes to loading

* added fixed filter removed unnecessary emitters

* added working loading page

* fix for spaces

* added improvements

* fixed space

* added loading provider label xlf

* moved spinner = false to show views

* Added loadingSpinner

* removed additional localization

* removed change to css

* removed newline

* small changes

* fixed spaces

* fixed line positions

* removed loadingComplete

* added spinner container (so that account loading spinner appears on top)

* added small fix

* changed wording

* changed wording slightly

* removed comment
2022-03-14 09:44:09 -07:00
Aditya Bist
822199c9be add ability for md + text reports (#18667)
* add ability for md + text reports

* change report type

* re add types for ads

* match fields and add enum for mimetype

* rename preview report

* update type

* rename generate report type

* fix comment
2022-03-09 15:48:21 -08:00
Alan Ren
e50bded5d1 table designer new features (#18682)
* support graph tables

* ignore script compare

* ability to refresh view after edit

* reserve focus after refresh view

* primary key and default constraint

* bug fixes

* vbump sts

* comments

* update type

* fix issue
2022-03-09 14:17:01 -08:00
Aditya Bist
1be5c926d3 added markdown renderer for publish dialog (#18645) 2022-03-07 10:57:37 -08:00
Cory Rivera
eccb77aca3 Preserve previous code cell's language when creating a new code cell from an existing context. (#18646) 2022-03-06 21:35:57 -08:00
Charles Gagnon
1c83aa61d7 Fix error displayed when insights files can't be found and fix server-report insights in dev build (#18635)
* Fix error

* fix queries
2022-03-04 13:10:35 -08:00
Aditya Bist
a2c39369c9 Add and move editable dropdown (#18589)
* add and move editable dropdown

* merge dropdowns

* merge dropdown cell factories

* add new column and hide in properties

* remove editable property
2022-03-03 20:23:20 -08:00
Cory Rivera
0ab4752643 Add new errorCode property to notebook errors to see if starting a notebook session failed. (#18617) 2022-03-03 14:05:54 -08:00
Cory Rivera
79cda5cbe5 Add language picker to notebook cells. (#18601) 2022-03-02 10:25:55 -08:00
Charles Gagnon
3b4800de51 Remove duplicate AzureResource enum (#18501)
* Remove duplicate AzureResource enum

* comment
2022-02-28 12:19:38 -08:00
Cory Rivera
ffdefd3b52 Add notebook extension support for .NET Interactive. (#18334)
* Also updated kernel dropdown to only include SQL aliased kernels when using SQL notebook provider.
2022-02-25 11:58:59 -08:00
Aasim Khan
02341088eb Renaming query plan to execution plan (#18551) 2022-02-25 00:49:34 -08:00
Charles Gagnon
5547c2baba Add AzureAccount service (#18502) 2022-02-22 09:00:07 -08:00
Alan Ren
40ee82ee3e highlight problematic property in the designer when error is selected (#18512)
* navigate to property when selecting error message

* use list component

* highlight problematic property

* remove unnecessary call

* comment

* comment
2022-02-21 20:49:12 -08:00
Charles Gagnon
8da49ff14e Remove connection error popup notification (#18476)
* Remove connection error popup notification

* Fix compile
2022-02-18 09:04:13 -08:00
Christopher Suh
bafbca492b Clear account tokens before refresh (#18452)
* clear account tokens on refresh

* update refresh button after refresh
2022-02-17 17:25:05 -08:00
Alan Ren
28ab7372d2 table designer validation support (#18438)
* table designer validation

* vbump sts
2022-02-17 13:07:19 -08:00
Barbara Valdez
87d5da00bf Fix on click edit mode states (#18321)
* fix click code cell

* modified editmode when updating active cell
2022-02-16 15:52:05 -08:00
Alan Ren
89cc59a2fd avoid auto language detection for sql editor (#18402)
* avoid auto lang detection for sql editor

* update comment
2022-02-15 17:11:43 -08:00
Charles Gagnon
f5392e3c8f Bump ansi_up (#18190) 2022-02-14 16:06:23 -08:00
Alan Ren
57d5d94c46 fix connection error scenario (#18335)
* fix connection error scenario

* pr comments
2022-02-11 18:49:29 -08:00
Aasim Khan
b25935f8a5 removing feature specific query plan flag (#18330) 2022-02-11 14:17:39 -08:00
Alan Ren
e82b4da0b9 use error dialog instead of notification (#18313) 2022-02-10 19:22:29 -08:00
Barbara Valdez
8695b463dc Enable keyboard navigation in notebooks (#18176) 2022-02-08 14:30:58 -08:00
Alan Ren
bba1ea32a8 fix double click issue in browse connections (#18237) 2022-02-07 13:05:41 -08:00
Charles Gagnon
6c8e2bf8f3 Fix export results default save location (#18224)
* Fix export results default save location

* cleanup
2022-02-04 16:20:10 -08:00
Charles Gagnon
d9967cf527 Fix drag and drop for columns (#18223)
* Fix drag and drop for columns

* Finish doc
2022-02-04 13:19:24 -08:00
Alan Ren
4c49e1cd41 refresh the table designer after publishing (#18220) 2022-02-04 09:32:07 -08:00
Alan Ren
c535c2dbde table designer improvements (#18206)
* new table experience

* new table info for existing table

* allow delete confirmation

* fix editor lock isue

* vbump sts

* PR feedback
2022-02-02 18:46:09 -08:00
Aasim Khan
e40c31559a Adding properties view and action bar to graph and fixing styling. (#18185)
* Adding properties view and action bar to graph.

* Open Graph File

* replacing innerhtml with  innertext

* Fixing floating promises

* Fixed typo

* renaming

* Fixing hardcoded colors and comments

* Removing todo and hardcoded colors

* renaming method

* removed unused contract

* Fixed path in comment

* converting div to button

* adding checks to table width and height setter

* Make method name more meaningful

* adding method return types

* concising repeated logic

* removing unused styling

* better sorting logic

* Fixing graph parsing
Renaming some stuff
Implementing IDisposable

* Fixing bad props logic

* Fixed image loading issue

* Removing hardcoded colors

* Adding comments to localize and handling undefined cases in sort

* Changed ch to px

* moving util function to strings
2022-02-02 14:17:01 -08:00
Aditya Bist
de5090e47a Added data points for Table Designer (#18182)
* added server infor and metrics for table designer

* update generate script

* pr comments

* format more files

* pr comments

* make changes to core

* remove unused imports

* add server info

* revert enum change and add publish event

* format doc

* nitpicks

* remove os version

* remove modifier from telemetry info

* remove error message
2022-02-02 12:40:05 -08:00
Charles Gagnon
1c9ba64ee0 check-param-names (#18189) 2022-01-31 12:39:22 -08:00
Cory Rivera
9685393975 Add placeholders for missing VSCode notebook events that are used by the Jupyter extension. (#18138)
* Also reduced the number of timeouts for waiting on notebook provider descriptors, and fixed an issue with undefined cancellation tokens in vscode notebook conversion code.
2022-01-25 14:03:33 -08:00