Alexander Ivanov
42b9f3b552
Provide aria-labels for node checkboxes in the tree view. ( #17676 )
...
During accessibility testing, it was discovered that screen reader does not announce what checkboxes in the tree view represent. It was merely announcing "checkbox unchecked", so it was not clear without visuals which checkbox the focus is on.
This change sets an `aria-label` of the checkbox elements to match the label of the owning tree node. This way the announcement becomes "My Node; checkbox; unchecked". This is fine as a quick solution to the problem, but in the future we may want to consider adding additional checkbox label property to the nodes exposed by the tree provider, so that each checkbox can announce additional information, if needed.
2021-11-16 08:13:18 -08:00
Alan Ren
1a9f2a5903
multi-level table support ( #17638 )
...
* multi-level table support
* comments
* address comments
* add period to end of sentence.
2021-11-10 17:15:08 -08:00
Maddy
6b226de450
refactor deltaDecorations logic ( #17630 )
2021-11-10 13:38:30 -08:00
Charles Gagnon
615df975ec
Fix query editors restoring as plain text ( #17643 )
2021-11-10 12:31:43 -08:00
Alan Ren
6fb6f51295
fix dirty state of table designer ( #17640 )
...
* dirty state
* update original value on save
2021-11-10 11:39:53 -08:00
Maddy
1d3debb897
Maddy/edit mode events cleanup ( #17636 )
...
* remove multiple events
* correct preview check
* add test
2021-11-10 10:59:29 -08:00
Cory Rivera
329ea4103c
Make various enhancements to Notebook Provider registration. ( #17609 )
...
* Use built-in SQL ExecuteProvider by default if no other provider exists.
* Gracefully handle case where standardKernels are not defined for a provider.
* Standardize on just using arrays for various provider registration details.
2021-11-09 16:00:34 -08:00
Alan Ren
c00c5e044b
move the designer component to workbench layer ( #17620 )
2021-11-08 10:26:27 -08:00
Alan Ren
5f8e1f384f
table designer editor icon ( #17608 )
...
* icon for table designer
* use more specific name
* use sql defined schema
2021-11-05 16:26:17 -07:00
Alan Ren
c9be45b9c7
feature flag for table designer ( #17597 )
2021-11-05 11:19:59 -07:00
Alan Ren
1fe3f38c14
separate title and name for table designer editor ( #17600 )
2021-11-05 11:09:17 -07:00
Alan Ren
f5b1e7feb8
a couple properties pane UI changes ( #17601 )
2021-11-05 11:08:43 -07:00
Alan Ren
f07427f2c1
add open table designer event telemetry ( #17595 )
...
* add open table designer telemetry event
* rename variables to reflect the text change
* format code
2021-11-04 17:00:32 -07:00
Aditya Bist
99f5c406e3
Added editor to table designer ( #17576 )
...
* format doc
* correct class name
* set content
* remove mssql commands
* merge classes
* code refactoring and bug fixing
* remove unnecessary class
* handle promise
Co-authored-by: Alan Ren <alanren@microsoft.com >
2021-11-03 21:07:36 -07:00
Alan Ren
893563c9c3
rename 'Advanced' tab to General ( #17591 )
2021-11-03 21:06:29 -07:00
Charles Gagnon
84ae306d57
Fix not being able to type in code cell after switching from text ( #17590 )
...
* Fix not being able to type in code cell after switching from text
* comment
2021-11-03 19:48:04 -07:00
Alan Ren
f3e1c2cc8b
a few table designer improvements ( #17588 )
2021-11-03 17:57:47 -07:00
Charles Gagnon
43fe0ce482
VS Code -> ADS setting descriptions ( #17563 )
2021-11-03 10:05:56 -07:00
Alan Ren
a3a91fbdfc
add column properties ( #17574 )
2021-11-02 18:50:44 -07:00
Karl Burtram
2be1ec0656
Update reference to html-query-plan to use npm.js ( #17558 )
...
* Update reference to html-query-plan to use npm.js
* Change some references to html-query-plan package
2021-11-01 20:46:54 -07:00
Charles Gagnon
25711acde0
Add a few missed instantiation service usages ( #17554 )
...
* Add a few missed instantiation service usages
* remove unused
2021-11-01 14:32:37 -07:00
Aditya Bist
6dda9392e0
respect include header option ( #17134 )
...
* respect include header option
* use correct option for copying
* check for setting when copying
* add dependency injection
* use instantiation service
Co-authored-by: chgagnon <chgagnon@microsoft.com >
2021-11-01 12:36:19 -07:00
Alan Ren
b48f392ab2
optional database name option ( #17538 )
...
* optional database name option
* object explorer connection title
* revert unexpected change
* bug fixes
2021-10-29 16:37:35 -07:00
Charles Gagnon
82805638ad
Add onClosed event to ModelView dialogs ( #17531 )
...
* Add onClosed event to ModelView dialogs
* Use defined type
* Fix compile
* fix tests
* fix tests2
* Remove unused
2021-10-28 20:53:20 -07:00
Alan Ren
12261aa7a2
text editor interface ( #17527 )
2021-10-28 13:23:33 -07:00
Charles Gagnon
ca20ae4d64
Fix typings files ( #17509 )
2021-10-27 12:29:00 -07:00
Alan Ren
8230d39120
add designer property grouping support ( #17485 )
...
* add properties grouping support
* revert unexpected changes
* use common color
2021-10-25 11:25:19 -07:00
Charles Gagnon
7049890f24
Don't log internal command executions from ext host ( #17482 )
2021-10-25 10:53:09 -07:00
Alan Ren
4ba192a5c3
make the designer event based ( #17472 )
...
* make the designer event based
* pr comments
2021-10-22 17:25:12 -07:00
Daniel Grajeda
6200a61382
Notebook Views initialization fix ( #17109 )
...
Separate the Views load from the initialization. This way we can load previously created views, and only add the new views data to the document when needed. For now, this happens only when a view is created.
2021-10-22 14:50:21 -07:00
Charles Gagnon
f57c41fead
Fix backups not restoring in correct editor ( #17466 )
2021-10-22 12:15:30 -07:00
Alan Ren
5fe569e864
fix scrolling issue ( #17443 )
2021-10-21 15:51:46 -07:00
rajeshka
914ac2b09d
remove trailing line after the cursor ( #17431 )
...
* remove trailing line after the cursor
* Addressed PR
2021-10-21 11:04:31 -07:00
rajeshka
d196588661
fixing the svg ( #17427 )
2021-10-20 19:11:13 -07:00
Cory Rivera
0bc8e54568
Fix quoted link failures by removing quotes from unescaped paths, rather than just the escaped paths. ( #17419 )
2021-10-20 18:12:39 -07:00
rajeshka
d251bbd1a1
Fix for Split Cell duplicates cell #17400 ( #17417 )
2021-10-20 14:47:58 -07:00
Lucy Zhang
8212eecec7
add listener for celltype change ( #17414 )
2021-10-20 13:51:27 -07:00
Alan Ren
c89aa26c0a
loading indicator for table designer ( #17407 )
...
* loading indicator for table designer
* fix layering error
* bug fix
2021-10-20 12:54:23 -07:00
Alan Ren
328ed83cb9
add disposeTableDesigner ( #17394 )
2021-10-19 14:28:56 -07:00
Alan Ren
569d5cf694
rename dataModel to viewModel ( #17387 )
2021-10-19 09:52:03 -07:00
Lucy Zhang
9a05d81215
use setContent instead of addElement ( #17386 )
2021-10-18 18:32:05 -07:00
Vasu Bhog
a8ee26ed89
Move split cell icon ( #17383 )
...
* move split cell icon before delete icon
2021-10-18 16:43:25 -07:00
Vasu Bhog
c368fcab25
Add Markdown Keybindings ( #17359 )
...
* add markdown keybindings
* remove add link keybinding
* move files
* fix layering
2021-10-15 11:40:19 -07:00
Alan Ren
fbdb434f3a
designer pane separator ( #17366 )
...
* designer pane separator
* comments
2021-10-15 11:03:26 -07:00
Lucy Zhang
e315115f00
Hide notebook toolbar icons in diff editor ( #17303 )
...
* hide notebook toolbar icons in diff editor
* move showActions to notebookInput
* make showActions readonly
2021-10-15 05:19:14 -07:00
Alan Ren
af8611455c
use STS to process the requests ( #17358 )
2021-10-14 13:36:46 -07:00
Maddy
53ab99761f
save lastEditMode and use that as default ( #17206 )
...
* save lastEditMode
* change style to active
* addActiveClassFromEditMode
* add undefined to declaration
* remove from public interface
* private
* lastEditMode to last selected mode
* comments
* set active in one place
* rename method
2021-10-14 11:01:54 -07:00
Alan Ren
156f8f1d5f
only show new query when query is supported ( #17346 )
...
* only show new query when query is supported
* test case fix and pr comments
* rename context key
2021-10-13 13:01:31 -07:00
Alan Ren
ce4459a7b2
Table Designer - Save Changes feature and Editor related features ( #17335 )
...
* table designer add/remove row support
* save changes and editor support
* address comments
* fix build error
* including missing change
* lower case request name
2021-10-11 15:09:25 -07:00
rajeshka
f5331e3d69
Added code to enable disable split cell icon ( #17331 )
...
* Added code to enable diable split cell icon
* adding back the deleted code
* refactored
* minimized lines
* simplified code
* minor change
* minor change
* Addressed PR
* Addressed PR
* removing unused enum value
2021-10-11 09:47:25 -07:00