* Added CSS to treat manage packages icon position.
* Wired up a rough concept showing how I propose to pass a masked-icon class, along with the icon name - derived from the action icon path - to the injected action prior to rendering. The end result is an injected action with an icon which behaves like the others in the notebook toolbar.
* Revert "Added CSS to treat manage packages icon position."
This reverts commit 215a67244a78224fe8fd2e6480b7e50d37a15dc0.
* Revert "Wired up a rough concept showing how I propose to pass a masked-icon class, along with the icon name - derived from the action icon path - to the injected action prior to rendering. The end result is an injected action with an icon which behaves like the others in the notebook toolbar."
This reverts commit 1e0cf116602192aa554334d564e855167b0e8bb6.
* Modified LabeledMenuItemActionItem to add masked-icon class to injected label element.
* Modified LabeledMenuItemActionItem to add masked-icon class and styles for injected label element.
* To prevent conflict with Dashboard, I duplicated the existing LabelMenuItemActionItem and odified it.
* Added comment to new method. Added non-prefixed mask-image style.
* Renamed method and modified comments.
* New feature for Notebooks - callout. This utilizes a modifed modal.ts that renders a small modal set to appear at the trigger event and disappear when user clicks off of it. This is intended only for micro-interactions such as inserting links, tables and images into Notebooks. Error dialogs dependent on modal have been updated to implement the modified width property correctlty.
* Modified dialogStyle names in interface. Applied updates to files dependent on this. Wired up disposable listener for browsing local files in image select callout. Renamed callout to calloutDialog.
* Converted double quotes in CSS to single quotes. Revised run method, removing the promise wrapping from the conditional.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revised structure and styles.
* Updated component for use with ML extension. Updated ML extension code with changes for custom dialog creation.
* Fixed async context for handleBrowse. Passing the new modal properties into Dialog implementation for ML.
* Added option to suppress callout dialog header and footer from the machine learning view file. Added a compact variant of callout. Corrected Dialog tab initialization.
* Maddy/callout modifications (#13586)
* initial changes
* canSelectFolders false
* change label, placeholder text on radiobtn click
* Added support for custom XY offset to account for modal size and to provide for fine-tuning of unique modal instances.
* Updated Image icon with latest from Design.
* Replaced node process with IPathService for retreiving image file.
* Added theme color lookups to provide default colors when none are provided.
* Added async/await to tests calling transformText.
* textCell, modal - swapped out HostListener for a member method which listens for the Esc keyup. Updated templates with method call on keyup. This cleaned up the double event call whenever the Esc key was pressed. Added property to modal Cancel button call to make it a secondary button.
* Cleaned up callout styles.
* Removed color use for input fields because component code delivers theme-specific values.
* Added check for CSS class `mac` on the body tag. Added conditionals to supply alternate dialogXYOffset in the case of non-Mac environment.
* Cleanup: Simplified DialogPosition. Renamed telemtry references and dialog related methods. Corrected spelling. Added missing signatures and types. Updated warning callout link URLs.
* Removed async and await as there are no promise dependencies. Added a signature.
* Revert "Fix windows insiders icons (#13579)" (#13630)
This reverts commit a0ef594792.
* Changed cores validation message (#13617)
* Changed cores validation message
* Missed validation
* Remove cores validation message
* Applied verification for cores change to miaa c+s page
* WYSIWYG Improvements to highlight (#13032)
* Improvements to highlight
* wip
* Tests pass
* Leverage escaping mechanism
* Tweak highlight logic
* PR comments
* add await to thenable method (#13635)
* Delete ConnectionDialogue.ipynb (#13634)
this nb was an attempt at creating a connection dialog. removing
not found in toc
* Added engine version argument to edit command. (#13610)
* Added engine version argument to edit command. Neccessary for not using pg12
* Included for changing password in overview page
* Updated fakeazdataapi test
* Fix empty column issue (#13641)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* add right padding to notebook toolbar action item (#13640)
* add right padding to action item
* remove extra line and add space
* Adding SQL Edge project template (#13558)
* Checkpoint
* removing flag for not creating subfolder
* Adding Edge template
* Removing janky map function
* Adding templates for additional objects
* Updating tests, fixing bug
* Added Edge project icon
* Updating strings to Drew-approved text
* Cleaning up template scripts and Edge project template names
* Update package.json (#13626)
* Update Import UI to match other UIs (#13637)
* Update Import UI to match other UIs
* Fixed another bug
* Fix notebook unordered grid values after papermill execution (#13614)
* Fix unordered table
* check entire first row schema:
* SQL Notebooks should not get affected
* delete unused variable and edit comments
* refactor for efficient table ordering
* nit naming
* Normalize path to change (#13660)
* vbump asde deployment extension (#13662)
do a patch version update, will adjust if the next change is a major one.
* Add test for dynamic enablement (#13602)
* Add test for dynamic enablement
* update names
* Remove debug console log (#13669)
* Remove placeholder on deployment wizards when field is disabled dynamically (#13658)
* Bump highlight.js in /extensions/markdown-language-features (#13675)
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.15.10 to 10.4.1.
- [Release notes](https://github.com/highlightjs/highlight.js/releases)
- [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md)
- [Commits](https://github.com/highlightjs/highlight.js/compare/9.15.10...10.4.1)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add ability to control the enabled state of checkbox cells (#13644)
* control enabled state of checkbox cells
* add more check
* Prevent Table from Disappearing due to exception when looking for tHead (#13680)
* Prevent exception when tHead doesn't exist at node
* Add test for no thead
* Fix issue with pasting results in Teams (#13673)
* Fix issue with pasting results in Teams
* Addressed comment to change header tag to th
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* Add descriptions and validation to connected mode (#13676)
* Add dependent field provider to resource deployment (#13664)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* remove placeholder
* Have resource deployment providers return disposables (#13690)
* Add dependent field provider to resource deployment
* Change name to value provider service
* Add error handling
* providerId -> id
* Set dropdown value correctly
* missed id
* back to providerId
* fix updating missed id
* Make resource deployment providers disposable
* Retry publish and always try adding asset (#13700)
* Retry publish and always try adding asset
* Undo asset upload change
* Add logging
* Notebooks: Remove result set summary from saved metadata (#13616)
* remove result set summary from metadata
* remove batchId and id from celloutputmetadata
* remove extra line
* Add scan suppressions (#13705)
* Add action for responding to Needs Logs label (#13707)
* Fix action name (#13708)
* Add action for responding to Needs Logs label
* Fix action name
* Rename action config file (#13709)
* Add action for responding to Needs Logs label
* Fix action name
* Rename config file
* remove quotes
* Adding unit tests for schema compare service (#13642)
* Retry getConfig (#13712)
* Retry getConfig
* Add logging
* vBump Arc and Azdata (#13717)
* switch schema compare to use inputbox instead of table headers (#13715)
* Added Accounts and Database Backup Page to Migration wizard (#13548)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Use console.log for retry logging (#13722)
* Fixed Schema compare integration tests by adding retry (#13649)
* Add workspace information in Import UI (#13648)
* Add workspace information in Import UI
* Addressed comments
* Reduced space between Workspace heading and the label
* Lint azdata.d.ts (#13728)
* Added developer name to the list of developers. (#13725)
onboarding commit: Added developer name to the list.
* Fix environment variables for controller create (#13732)
* vbump schema compare and sql database projects (#13730)
* December release readme (#13733)
* Change server group look (#13608)
* change server group look
* remove dead code
* add top padding
* add bot padding as well
* fix heights to account for padding
* fix arrow alignment
* fix ellipses and node length parity
* fix alignment
* Make loading components not valid and improve RD radio group (#13738)
* Revert "Added Accounts and Database Backup Page to Migration wizard (#13548)" (#13742)
This reverts commit e169005571.
* Add loading text properties for option sources (#13743)
* Add loading text to deployment radio options
* Fix loading race condition
* Update text
* Add kube config and kube cluster to arc data controller screens (#13551)
* Un-skip and fix a few of the db projects tests (#13726)
* Un-skip and fix a few of the db projects tests
* Addressed comments
* Fix one test failure on Linux/Mac
* Update STS to revert SqlClient update (#13758)
* Update required azdata versions (#13762)
* fix the recent list (#13770)
* Adding base classes for data dev extension telemetry (#13763)
* adding telemetry dependencies for data-workspaces and sql-database-projects
* Adding telemetry dependencies for dacpac extension
* Adding telemetry base to data workspaces and projects
* Adding telemetry base code to the dacpac extension
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
* Update changelog (#13773)
* Notebook Extension: First logging improvements (#13729)
* First logging improvements
* PR feedback for err output
* Add BEGIN/END to snippet (#13784)
* Adding database backup and accounts page to migration wizard (#13764)
* Added localized strings
Created a db backup page
added radio buttons
* created components for database backup page
* Added account selection page
* Added accounts page
* Some more work done
- Added page validations
- Almost done with db backup except for a few api calls.
* Some more progress
added graph api for storage account
* Finished hooking up all the endpoints on db page.
* Some code fixed and refactoring
* Fixed a ton of validation bugs
* Added common localized strings to the constants file
* some code cleanup
* changed method name to makeHttpGetRequest
* change http result class name
* Added return types and return values to the functions
* removed void returns
* Added more return types and values
* Storing accounts in the map with ids as key
Fixed a bug in case of no subscriptions found
* cleaning up the code
* Fixed localized strings
* Added comments to get request api
Added validation logic to database backup page
removed unnecessary page validations.
* Added some get resource functions in azure core
* Changed thenable to promise
* Added arm calls for file shares and blob storage
* Added field specific validation error message
* Added examples in validation error message.
* Fixed some typings and localized string
* Added live validations to dropdowns
* Fixed method name to getSQLVMservers
* Using older storage package
* Update typings/namings (#13767)
* Update typings
* more typings fixes
* switched fileshares and blobcontainers api to http requests
* removed the extra line
* Adding resource graph documentation link as a comment
* remove makeHttpRequest api from azurecore
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
* change afterClean to beforeBuild for removing the generated assests.json (#13736)
* change afterClean to beforeBuild for removing the generated assests.json
* fix merge conflict
* rename files
* Clean up Loading Component typings (#13785)
* Clean up Loading Component typings
* add properties to impl
* Log active element when notebook smoke test fails (#13724)
* add error log for active element
* fix active element selector
* await isActiveElement call
* call waitforactiveleement
* Bump ini from 1.3.5 to 1.3.7 in /samples/sqlservices (#13776)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.7 in /build (#13765)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.7)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.4 to 1.3.8 (#13792)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.4 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.4...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ini from 1.3.5 to 1.3.8 in /extensions/markdown-language-features (#13791)
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* renable kernels dropdown test (#13727)
Verify no skipped core tests
* Remove redundant parameter in test scripts (#13755)
* Fire onDidSelect event when selecting event from code (#13691)
* Fire onDidSelect event when selecting event from code
* Fix import tests
* fix typo
* Use correct Azure graph endpoint & cleanup (#13786)
* Use correct Azure graph endpoint
* Add enum
* Update CODEOWNERS (#13798)
* Make project workspace selectable if no workspace is open yet (#13508)
* allow new workspace location to be editable
* fix workspace inputbox not showing up after toggling open workspace radio buttons
* add a few tests
* cleanup
* fix errors
* addressing comments
* fix filter for windows
* add error message if existing workspace file is selected and change picker to be folder only
* address comments
* fix typos and update tests
* vbump 2018 -> 2019 (#13800)
* Fix "not externalized correctly" warnings (#13806)
* Notebook Deep Link to Section (#13795)
* Notebook deep link to section
* fragment wip
* table component improvement (#13801)
* hyperlink column
* fixed width for image only button - old behavior
* Server Reports extension: fix for start and stop xevent sessions (#13565)
* fix for start and stop xevent sessions
* vscode.open for help URL
* setup info messages for localization
@kburtram - I could use an assist on updating the v# and publishing the vsix, but there's no rush this can wait until after the holidays
* Arc - Update Postgres name length limit (#13807)
Arc - Update Postgres name length limit. It was recently reduced from 12 to 11.
* Fix whitespace differences in sqlproj (#13805)
* add whiteSpaceAtEndOfSelfclosingTag
* update test baselines
* Fix paths for tests (#13816)
* Fixed the stray validation error message in Resource Deployment wizard (#13747)
* Fixed the stray validation error message
* Removed not working ' with validation
Adding back cancel button disabling
* mark a couple data workspace tests as unstable (#13822)
* cosmetic changes (#13820)
* cosmetic changes
* moved limitLongName function to the utils
* add . as trigger character (#13811)
* Remove hardcoded search box height (#13823)
* Use azdata-test modelview stubs (#13818)
* Filter vscode delegate command events (#13832)
* Fix duplicate SVG rendering (#13828)
* Fix select box event ordering (#13831)
* Fix select box event ordering
* more fixes
* Fix page
* Revert typing change
* Undo param
* Fix compile error
* Completely remove typings
* Dacpac - Showing error message to user if operation fails (#13830)
* Showing error message to user if operation fails.
* Added more tests
* Fix unstable data-workspace tests (#13824)
* stub file existing validation
* add error message
* change back to calling dialog.validate()
* move tests to separate dialogbase file and add more error message validation
* comment out the unstable unit test step (#13834)
* remove --build flag
* comment out unstable test
* add build tag back
* Removed padding-top / bottom declarations for text cell notebook-preview. This compacts the text cell by 14px on top and bottom. (#13815)
* Stop forcing left text align on tables (#13840)
* Have same connection logic for all nb int tests (#13844)
* Added fix for the infinite page refresh in resource Deployment tools page (#13813)
* Added fixed for the infinite loop in resource Deployment tools page
Generating events for select boxes only when the select box value is changed.
* Fixed the check logic in select method
* Reverted to old code and fixed some bugs
* Fixed event generation check logic
* Make new workspace inputbox editable in Create project from database dialog (#13842)
* update create project from database dialog to have editable new workspace
* add validation
* add test
* add error message
* Remove test for now
* cleanup
* add periods
* throw errors
* change return type to void
* Removal of Components folder, moving ADP notebook to its own notebook. (#13848)
* adp folder removed, notebook moved.
* moved ADP notebook to own folder.
* Passing click target to modal for positioning. Created custom buttons and click event handlers for Insert image and Insert link. Set feature behind preview flag.
* Revert "Revert "Fix windows insiders icons (#13579)" (#13630)"
This reverts commit 111dcb4c6885d9ab1a24398b13f103835789e6e0.
* Corrected button style and declared dialogStyle for ManageModelsDialog. This fixes broken layout see when user clicks: Import or view models.
* Revised suppressHeader/Footer to renderHeader/Footer and fixed logic. Code cleanup. Changed how calloutType: IMAGE and LINK are implemented. Added comments where neeed.
* Fixed callout separator: Swapped out transparent for notebookToolbarLines
* Removed promise context from image callout logic.
* Moved calloutDialog into modal folder.
* Code and style adjustments per feedback. Removed dependency on mac body class. Cleaned up dialog theme. Revsied modal callout logic.
* Corrected CSS for notebook toolbar. Removed unused code. Added code to ensure that renderFooter would occur whether true or undefined.
* Code cleanup. Clarified more details in my code comments. Added comments to values that needed identification. Escaping user-supplied text before it is rendered.
* Renamed TriggerProperties interface and implementations to DialogProperties. Added default value for DialogStyle to sqlExtHost.api.impl so existing dialogs take flyout by default.
* Replaced null value with undefined. Revised theme logic to account for undefined color value.
* Fixed top 30px offset rule so callout dialogs do not get this added.
* Revised undefined check for modal theme color. Removed calloutCompact. Moved callout dialog widths into DialogWidth property when calling methods to create callout or dialog. Added comments. Revised CSS.
* Providing fallback value in the case of null. Hex: FFFFFF00 is white with no transparency.
* Removed fallback hex color for foreground. Added check for foregroundRgb before attempting to grab rgba values. Added footer top border color.
* Added formatting after resolving conflicts.
* Corrected implementation after taking changes from main.
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Christopher C <37060219+cavonac@users.noreply.github.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
Co-authored-by: Sakshi Sharma <57200045+SakshiS-harma@users.noreply.github.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Aditya Bist <adbist@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Benjin Dubishar <benjin@Largo.local>
Co-authored-by: Sai Avishkar Sreerama <ssreerama@microsoft.com>
Co-authored-by: Drew Skwiers-Koballa <dzsquared@users.noreply.github.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Vladimir Chernov <v-chvlad@microsoft.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
* Add notebook editor
Introduce notebook editor component to allow for separate notebook displays in order to accomodate notebook views
* Localize notebook views configuration title
* Refactor view mode and remove the views configuration while it is unused
* Only fire view mode changed event when the value has been changed
* Remove notebook views contribution
* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
* Able to get Kernel Alias using extension registery
* Get Kernel Alias through Capability Services
* Notebook Action feature to add kusto to dropdown based on extension - complete
* Fixed indexing issue when Kusto is in kernels Dropdown
* Kusto Kernel listed properly and selected when kernel changes
* Added kernel change when user Attaches To Kusto connection
* Deleted unnecessary code/refactored
* Fix Merge Issues
* Resolving Compile issues - test file error
* Capabilities Provider Changes
* Fixed Notebook Tests
* Rearchitect kernel changes to Notebook Model
* Address minor changes
* Notebook cell toolbar additions - move up and move down added. Stubbed out related actions. Cleaned up component code.
* Added new more actions menu item: Convert cell.
* add move cell support in model
* Schema Compare cleanup (#11418)
* cleanup async and await stuff
* remove awaits
* remove more awaits
* fix (#11437)
* Add some unit tests for PyPiClient. (#11442)
* handle invalid character in kubectl version output (#11460)
* Add tests for azdata extension (#11423)
* Add tests for azdata extension
* Fail on stderr
* Skip test for not implemented logic
* Move executeCommand stub
* Add missing packages
* let semver to parse the version (#11463)
* let semver to parse the version
* check
* Stop hardcoding python3 (#11464)
* Add ConnectControllerDialog tests (#11443)
* Automatically fix up arc controller URL
* wip
* Force tests to pass
* Refactor
* comment
* adds role of button to all links that are buttons (#11465)
* Merge from vscode 0a7364f00514c46c9caceece15e1f82f82e3712f
* bump smoke extensions
* bump node version in builds
* bump smoke extensions
* Add query-history and sql-assessment to recommended extensions (#11477)
* First draft of outputProcessor tests (#11368)
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Adds support for installing azdata on Linux (#11469)
* Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)
* do a large cleanup of azurecore
* Fix tests
* Rework Device Code
* Fix tests
* Fix AE scenario
* Fix firewall rule - clenaup logging
* Shorthand syntax
* Fix firewall tests
* Start on tests for azureAuth
* Add more tests
* Address comments
* Add a few more important tests
* Don't throw error on old code
* Fill in todo
* Adding button plugin to table component (#10918)
* Added delete plugin to table component
* Arc - Remove Azure params from Postgres deployment (#11478)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* tests for KernelsDropdown class (#11476)
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* implement review feedback (#11470)
* fix sql proj sqlcmd table showing after loading profile when it shouldn't (#11479)
* Feature/outer paths for project (#11445)
* allow relative paths in project file outside of project folder
* Adding some tests
* Adding error string to loc strings
* Fixed test
* fix error message
* PR comments and some more fixes
* change userName to match what the azure account display name is (#11484)
* change userName to match what the azure account display name is
* Handle undefined value
* Merge from vscode 8c426f9f3b6b18935cc6c2ec8aa6d45ccd88021e
* recomment out integration tests
* Fix/open book error (#11379)
* add isNotebook param and showPreview option
* showPreview changes
* update OpenNotebookFolder to open a specific path
* added test for showPreviewFile
* test name typo
* remove isNotebook from openBook
* Add test coverage for dacpac wizard import flow (#11483)
* Adding importConfig onPageEnter() test
* Removing redundancy from dacpac wizard pages
* promisifying file selection so it can be awaited in the test
* removing debug prints
* PR feedback
* Remove all accounts regardless of failure in one account (#11431)
* distro (#11487)
* distro
* distro
* distro
* distro
* Adding icons to Database Projects' tree view (#11488)
* Add images
* Splitting to light and dark mode icons
* Hooks up icons to treeItems
* updating package.json with new icon and vbump
* move icon loader before tree view created
* Update Arc extension version and fix Controller connectivity status names (#11498)
* Update connectivity mode names
(cherry picked from commit f0aabcfa86d178cdf74470f9fdeded19718bcea2)
* Bump package version
(cherry picked from commit e08370539006c638d6e25c2f4f23fa2754a3377d)
* deploy to single existing device (#11494)
* deploy to single existing device
* comments
* Add versioning for accounts (#11497)
* Add versioning for accounts
* deletion value
* Changes to getAccountSecurityToken (#11502)
* Hook up convert cell
* Fix tests
* Add convert cell tests
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: v-bbrady <60623315+v-bbrady@users.noreply.github.com>
Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* Reworking notebook action bar functionality and appearance.
* added separator
* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.
* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.
* Adjusted styles for the cell and run all icons in notebook toolbar.
* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
* Added new icon for Underline action.
* Removed comment from needed markup.
* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.
* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
* Removed unnecessary !important from style override.
* Removed reference to unused color entry.
* Syntax cleanup.
* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.
* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
* Replaced SVG code for not-trusted icon.
* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
* Fixes for attach to. Still need to update cache
* Don't have jupyter hardcoded
* Handle DOTNET_ROOT env var
* Fix on load
* Put behind feature flag
* Cleanup
* Error check
* PR feedback
* Addresses bug: 10062. Replaced scrollTop with getBoundingClientRect.top minus the combined height of the top tabs and action bar.
* Setting initial value of chrome offset, and checking for existence of both tool bars before getting their heights.
* Adding enablePreviewFeatures check before showing the new toolbar.
* Removed unused code.
* Added hook to trigger onDidChangeConfiguration -- this makes the UI change after user has checked or unchecked, without having to restart the app.
* Initializing the component with the current config value of enablePreviewFeatures.
* Added Notebook telemetry for livesite
* added back the metadata retension code
* Unified Telemetry services
* fixed names
* Fixed texts to use new NullAdsTelemetryService
* Validate GUID before sending it
* made GUID check a bit more robust
Co-authored-by: Rajesh Kamath <rajkashop@hotmail.com>
* Add Reveal in Books editor tab context option
* Select item in books viewlet automatically
* changes
* easier than i thought it'd be
* Merge from Feat/create book
* Undo Merge from Feat/create book
* Use fsPath instead of path
* PR comments
* Fix tests
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
* initial commit
* get notebook content
* skeleton for find in notebookModel
* add search function and keyboard shortcut
* add command for hiding find widget
* started on search logic
* continue search logic
* continue search logic
* add findcountchange listener
* notebook find position
* added css class
* hide find widget
* focus find input
* search for multiple occurrences in one line
* start notebook find decorations
* start adding decorations to notebook model
* added editor_model_defaults
* added cursor position
* merged master and resolved husky erros
* initial changes added to Lucyls base implementation
* pass NotebbokRange instead of Range to decorations
* changes after merging master
* temp changes for testing
* style updates from vscode merge
* implemented the empty methods and added supporting functionality from textModel
* just a little error checking
* It gets more and more yellow
* making highlight work between code cells
* highlight only word
* remove highlight on close and maintain the position
* cleanup of unused references
* clean up
* find between code cells refactored
* highlight markdown line and scroll to it
* find index fix
* find index fix
* code clean up
* remove commented code
* tslint fix for: Cannot use global 'NodeJS'
* linting rule fixes
* deltaDecoration base implementation on the base class
* moced class defnitions from interface fikle
* updated action names
* DOM.addClass instead of overwriting
* resooved conflicts
* moved 'find' code away from notebookmodel to sep class
* moved find realted code to seperate folder
* created notebookFindModel
* clean up
* highlight color changes
* spacing and typo fixes
* highlight correct element for nested elements
* do not iterate through paragraphs and li
* find accross notebooks
* keep track of index
* clear decorations on close
* floating promises
* maintain search context
Co-authored-by: Lucy Zhang <lucyzhang929@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
