ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-24 17:23:05 -05:00
Code Issues Packages Projects Releases Wiki Activity
5,260 Commits 1 Branch 152 Tags
c3a00c2cc6ecf35c2958111a12d2b3b8faea6d40
Commit Graph

47 Commits

Author SHA1 Message Date
Charles Gagnon
c3a00c2cc6 Clean up telemetry keys (#14093) 2021-01-28 13:33:12 -08:00
Sai Avishkar Sreerama
0316d9ac57 Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859) 
* Dacpac telmetry code changes

* Removed added spaces

* Generate deployScript accessibility changed back to public

* code review suggessions updates

* dacpac extension tests fixes

* Updated time and filesize methods allowing general return values

* Telemetry code updates

* Dacpac Telemetry potential data loss capture and PII error excluded

* Dacpac telemetry code updates for comments

* Wizard pages navigation telemetry event capture moved to the core

* DacpacTelemetry code updates

* Extension wizard cancel telemetry for data loss

* Dacpac telemetry pagename and small code updates

* final Dacpac telemetry code updates...
 2021-01-21 17:00:37 -06:00
Charles Gagnon
2d182fcd03 Remove calls to DOM.addClass and DOM.removeClass (#13063) 2020-10-23 14:42:22 -07:00
Christopher Suh
6ff1e3866b Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 (#12295) 
* Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

* Fix test build break

* Update distro

* Fix build errors

* Update distro

* Update REH build file

* Update build task names for REL

* Fix product build yaml

* Fix product REH task name

* Fix type in task name

* Update linux build step

* Update windows build tasks

* Turn off server publish

* Disable REH

* Fix typo

* Bump distro

* Update vscode tests

* Bump distro

* Fix type in disto

* Bump distro

* Turn off docker build

* Remove docker step from release

Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Karl Burtram <karlb@microsoft.com>
 2020-10-03 11:42:05 -07:00
Charles Gagnon
807a4ae8c4 Add telemetry for ModelView wizards (#12596) 
* Add telemetry for ModelView wizards

* Remove unnecessary params

* Fix compile error
 2020-09-23 17:08:22 -07:00
Anthony Dresser
8d88791a0b fix hygiene 
fix compile errors

fix build; disable a bunch of failing tests

update smoke extension

fix modals

fix icons
 2020-08-31 12:35:57 -07:00
Anthony Dresser
1b02fb6906 Add strict compiling for profiler service (#11898) 
* add strict compiling for profiler

* fix up strict

* add contrib
 2020-08-21 12:52:24 -07:00
Anthony Dresser
9327624930 Add more to strict nulls (#11871) 
* add more to strict nulls

* maintain error handling properly

* fix lint
 2020-08-19 18:38:34 -07:00
Alan Ren
c4be667567 add custom width support for dialogs (#10641) 
* add custom width support for dialogs

* comments

* fix test
 2020-06-03 13:08:48 -07:00
Charles Gagnon
68510d54cb Clean up modal/options dialog disposable use (#9739) 
* Fix duplicate options and clean up disposable use

* Remove unneeded import

* Undo options fix - separating out in different PR
 2020-03-26 14:46:22 -07:00
Alan Ren
5a0dd18cba restore focus (#9668) 
* restore focus

* update default config

* update
 2020-03-23 12:09:13 -07:00
Alan Ren
7ed072c44d do nothing if the focus is already in dialog (#9629) 
* do nothing if the focus is already in dialog

* use document.activeElement instead
 2020-03-16 11:51:57 -07:00
Charles Gagnon
64eb406fdc Add connecting title to spinner for Connection dialog (#9623) 2020-03-16 08:26:35 -07:00
ADS Merger
4c3e48773d Merge from vscode cfc1ab4c5f816765b91fb7ead3c3427a7c8581a3 2020-03-11 04:19:23 +00:00
Cory Rivera
0a117fbd00 Add separate dialog to notebook charts for specifying chart options. (#9454) 2020-03-10 14:10:34 -07:00
Charles Gagnon
964ff0119e Update aria label for modal dialog when title is updated (#9492) 2020-03-09 08:25:04 -07:00
Anthony Dresser
0f934081e1 More layering and strictness (#9004) 
* move handling generated files to the serilization classes

* remove unneeded methods

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* wip

* remove jsdoc

* fix layering

* fix compile

* fix compile errors

* wip

* wip

* finish layering

* fix css

* more layering

* remove no longer good parts

* fix issues with startup

* another try

* fix startup
 2020-02-11 00:47:17 -06:00
Anthony Dresser
30d9e9c141 Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1 (#8722) 
* Merge from vscode 4636be2b71c87bfb0bfe3c94278b447a5efcc1f1

* remove tests that aren't working
 2019-12-18 00:14:28 -08:00
Anthony Dresser
f5ce7fb2a5 Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c (#8525) 
* Merge from vscode a5cf1da01d5db3d2557132be8d30f89c38019f6c

* remove files we don't want

* fix hygiene

* update distro

* update distro

* fix hygiene

* fix strict nulls

* distro

* distro

* fix tests

* fix tests

* add another edit

* fix viewlet icon

* fix azure dialog

* fix some padding

* fix more padding issues
 2019-12-04 19:28:22 -08:00
Charles Gagnon
6cce532ca4 Fix wizard not displaying error messages (#8545) 2019-12-03 17:40:19 -08:00
Charles Gagnon
8ca0082ec4 Fix tab navigation within modal dialog (#8326) 
* Fix tab navigation within modal dialog

* Add import

* Fix spelling

* Change to just add/remove items from DOM as necessary
 2019-11-19 12:43:55 -08:00
Charles Gagnon
ba8c331356 Add alert role to error message element (#8354) 2019-11-15 11:51:08 -08:00
Charles Gagnon
7563416754 Fix a couple a11y issues (#8334) 
* Fix a couple a11y issues

* Add other dialog
 2019-11-15 07:41:09 -08:00
Charles Gagnon
18ab2ae799 Remove TelemetryUtils and use IAdsTelemetryService directly (#8289) 
* Remove TelemetryUtils and use IAdsTelemetryService directly

* Fix event names and cleanup

* Fix tests

* Fix strict null check
 2019-11-13 13:54:55 -08:00
Anthony Dresser
564f78b6f6 Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)"" (#8242) 
* Revert "Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240)"

This reverts commit e801a04bcf.

* fix runtime error

* add tests for chartview
 2019-11-06 15:00:34 -08:00
Elliot Boschwitz
e801a04bcf Revert "Remove typings and replace missing methods with vscodes (#8217)" (#8240) 
This reverts commit 22a427f934.
 2019-11-06 11:33:55 -08:00
Anthony Dresser
22a427f934 Remove typings and replace missing methods with vscodes (#8217) 
* remove typings and replace missing methods with vscodes

* fix strict-null-checks

* fix tests
 2019-11-05 13:03:20 -08:00
Shafiq Ur Rahman
f8858a3511 Tab trap for modal (closes #5930) (#8043) 
* Tab trap for modal (closes #5930)

* Addressing PR comments

* Fixed formatting.
 2019-10-30 11:38:11 -07:00
Kevin Cunnane
c1e95a2246 Fix errors due to icon to codicon rename in VSCode (#7837) 
Found numerous errors where icons weren't rendering correctly.
- Anything that's an action must have CSS using "codicon" not "icon"
since VSCode sets the "codicon" class automatically.
This affected Agent view in particular, but also:
  - acounts view
  - new tab view in dashboard
 - many more
- Anything referencing the common-icons.css icons needed updating.
This hid help tooltip text in FormContainer UI for example.
- Finally I tried to convert all references from icon -> codicon,
even when the CSS was technically correct. This was done
for maintainability reasons - from now on always add codicon.

Fixes #7827
 2019-10-21 12:02:30 -07:00
Kim Santiago
087f7fc43d remove role=document ffrom dialog so screenreader doesn't read it (#7685) 2019-10-14 16:57:09 -07:00
Udeesha Gautam
5ae8017233 Bug/accessibility 5 (#7008) 
* fixing 6946 and 6796(second part)

* fix for https://github.com/microsoft/azuredatastudio/issues/6726

* comments cleanup

* taking PR comments

* adding strong border for HC focus

* convert to string template
 2019-09-09 15:37:12 -07:00
Anthony Dresser
4966ed8b42 Strict Null Checks on platform/accounts (#6735) 
* add some patches for strict null

* renable strict null checks

* wip

* finish adding account to strict nulls

* fix backup component

* wip

* fix tests
 2019-08-14 20:26:21 -07:00
Anthony Dresser
c1acf6ae93 More work around isolating node imports (#6512) 
* more work around isolating node imports

* rewrite query plan input

* fix hygiene errors

* fix tests

* address feedback

* remove welcome page changes
 2019-07-30 14:01:37 -07:00
Charles Gagnon
b2b2840990 Add double quotes for localize hygiene check (#6492) 
* Add localize single quote hygiene task

* Update localize calls

* Update comment

* Fix build failures and remove test code
 2019-07-25 10:35:14 -07:00
Anthony Dresser
c23738f935 Inital platform relayering (#6385) 
* moving test files and inital refactoring

* relayer extension host code

* fix imports

* make insights work

* relayer dashboard

* relayer notebooks

* moveing more code around

* formatting

* accept angular as browser

* fix serializer

* add missing files

* remove declarations from extensions

* fix build errors

* more relayering

* change urls to relative to help code relayering

* remove layering to prep for merge

* fix hygiene errors

* fix hygiene errors

* fix tests
 2019-07-18 17:29:17 -07:00
udeeshagautam
c4e59027fc Backup to open correctly from insights dialog (#5737) 
* recreate modal dialog button to ensure onDidClick works properly

* fixing comment message

* Adding PR comments
 2019-05-30 12:32:38 -07:00
Anthony Dresser
b4cce9f147 adjust modals for title bar (#5648) 2019-05-27 14:40:16 -07:00
Anthony Dresser
ab0cd71d10 Remove logging and clone utlities (#5309) 
* remove log utility functions; remove custom mixin

* fix tests

* add log service as required by telemetry utils

* remove unused code

* replace some console.logs with logservice
 2019-05-04 22:37:15 -07:00
Anthony Dresser
ddd89fc52a Renable Strict TSLint (#5018) 
* removes more builder references

* remove builder from profiler

* formatting

* fix profiler dailog

* remove builder from oatuhdialog

* remove the rest of builder references

* formatting

* add more strict null checks to base

* enable strict tslint rules

* fix formatting

* fix compile error

* fix the rest of the hygeny issues and add pipeline step

* fix pipeline files
 2019-04-18 00:34:53 -07:00
Anthony Dresser
9e56187c16 Remove sql/common (#4990) 
* remove sql/common/

* formatting

* fix cyclic dependency
 2019-04-12 12:47:48 -07:00
Anthony Dresser
4ece9b0085 remove dispose of button listeners (#4914) 2019-04-09 01:08:56 -07:00
Anthony Dresser
a4bd31e96a Removes Builder references from modal (#4869) 
* remove builder from modal

* add more DOM methods
 2019-04-09 00:28:52 -07:00
Anthony Dresser
22ec1d5f0a Strict Null Checks, Builder Removal, Formatting (#4849) 
* remove builder; more null checks

* null checks

* formatting

* wip

* fix dropdown themeing

* formatting

* formatting

* fix tests

* update what files are checked

* add code to help refresh bad nodes
 2019-04-08 13:27:41 -07:00
Anthony Dresser
87765e8673 Vscode merge (#4582) 
* Merge from vscode 37cb23d3dd4f9433d56d4ba5ea3203580719a0bd

* fix issues with merges

* bump node version in azpipe

* replace license headers

* remove duplicate launch task

* fix build errors

* fix build errors

* fix tslint issues

* working through package and linux build issues

* more work

* wip

* fix packaged builds

* working through linux build errors

* wip

* wip

* wip

* fix mac and linux file limits

* iterate linux pipeline

* disable editor typing

* revert series to parallel

* remove optimize vscode from linux

* fix linting issues

* revert testing change

* add work round for new node

* readd packaging for extensions

* fix issue with angular not resolving decorator dependencies
 2019-03-19 17:44:35 -07:00
Anup N. Kamath
0a268f35bc Fix backup (#4274) 
* check to see whether options is available

* removing options state and using _modelOptions

* removed additional space

* making options getter private as not intended to expose
 2019-03-05 19:17:42 -08:00
Raj Musuku
666ae11639 Merge from master 2019-02-21 17:56:04 -08:00
Anthony Dresser
d4704e39ac Another code layering (#4037) 
* working on formatting

* fixed basic lint errors; starting moving things to their appropriate location

* formatting

* update tslint to match the version of vscode we have

* remove unused code

* work in progress fixing layering

* formatting

* moved connection management service to platform

* formatting

* add missing file

* moving more servies

* formatting

* moving more services

* formatting

* wip

* moving more services

* formatting

* move css file

* add missing svgs

* moved the rest of services

* formatting

* changing around some references

* formatting

* revert tslint

* revert some changes that brake things

* formatting

* fix tests

* fix testzx

* fix tests

* fix tests

* fix compile issue
 2019-02-19 12:11:54 -08:00