Commit Graph

88 Commits

Author SHA1 Message Date
Barbara Valdez
c641865891 Use vertical tabs in server and database properties (#24521)
* use vertical tabs

* remove always show tabs option

* remove extra comma
2023-10-03 13:15:50 -07:00
Sai Avishkar Sreerama
5ed263ecd2 fixing double scroll bar issue on DSC tab (#24560) 2023-10-03 11:40:55 -05:00
Sai Avishkar Sreerama
549464dab1 Adding fiilegroup name label to the input box and auto focus of newly added row (#24536)
* adds nameupdate textbox

* fixed rows table remove button

* input value update on row selection

* using display prop instead of visible css property

* select newly added cell automatically

* sets remove button to next row after deleting a row
2023-10-02 12:11:57 -05:00
Cory Rivera
b07fee5a5f Move New Login dialog's advanced options into the general section (#24538) 2023-09-29 10:46:40 -07:00
Cory Rivera
94cdaf9d57 Change Cancel button label to Back for inner dialogs. (#24537) 2023-09-28 18:02:25 -07:00
Cory Rivera
c5e8ecd24b Add additional telemetry for basic admin operations (#24526) 2023-09-27 16:32:19 -07:00
Cory Rivera
131c288ab4 Enable Rename Database for on-prem servers. Use common method for getting OE node info. (#24517) 2023-09-27 11:21:07 -07:00
Cory Rivera
64337310ae Remove redundant usage of object URNs in database commands (#24485) 2023-09-21 11:38:44 -07:00
Sai Avishkar Sreerama
9c5ec7dcbc Filegroup Memory optimized Add button should be disabled when have one filegroup #24309 (#24446) 2023-09-15 16:19:44 -05:00
Sai Avishkar Sreerama
183c743537 max file size input field has wierd enable/disable behavior #24322 (#24407) 2023-09-14 13:13:22 -05:00
Cory Rivera
08ded51e75 Use remote file dialog for database and server properties dialogs (#24390) 2023-09-13 10:49:10 -07:00
Cheena Malhotra
7e401bfa1a Azure Active Directory (Azure AD) is becoming Microsoft Entra ID (#24385) 2023-09-12 13:41:04 -07:00
Sai Avishkar Sreerama
96c4257d25 Database properties options fixes (#24361)
* fix for File size input in DB properties can be decremented into the negative #24307

* Some DB Scoped Config options are sentence cased #24196

* cannot add a file with filestream data filegroup type #24359

* DB Scoped Secondary values aren't updated when hidden #24197

* DB Scoped Config shows secondary values for non-secondary options #24192

* Query store capture policy section is enabling on non-custom capture mode #24371

* queryStore WaitStatistics options should be a dropdown #24372
2023-09-12 11:20:26 -05:00
Barbara Valdez
41e7569fde More server properties fixes (#24366)
* fix locks min value

* disable login auditing in linux

* disable some properties from advanced tab
2023-09-11 12:53:25 -07:00
Barbara Valdez
b8629592d4 Fix some of the issues found in the bug bash (#24348) 2023-09-09 01:36:56 -07:00
Barbara Valdez
4a9feedbcc Notify user to restart server (#24351) 2023-09-08 23:53:59 -07:00
Sai Avishkar Sreerama
118e726fab Revert the changes of row fileGroup table which was added accidentally (#24339) 2023-09-08 12:00:48 -05:00
Sai Avishkar Sreerama
aa006b9da7 Enabling QueryStore options to the database properties (#24255)
* Initial commit

* updated query capture policy props

* all done except, querydiskSpaceSection

* disabling capture policy options on off mode but with custom mode enabled

* adding query disk usage section with purge button

* fg table replace

* STS vbump to 4.9.0.34

* typo
2023-09-07 21:37:24 -05:00
Barbara Valdez
77ea6d7e32 do not show individual processors in managed instance (#24302) 2023-09-06 16:08:21 -07:00
Cory Rivera
32817ae52e Handle undefined nodeInfo for top-level database objects (#24298) 2023-09-06 14:12:07 -07:00
Cory Rivera
ec91de78e5 Update task labels for Attach, Detach, and Drop Database (#24289) 2023-09-05 16:21:09 -07:00
Barbara Valdez
e05ee98dae Add advanced tab (#24267) 2023-09-01 16:53:46 -07:00
Barbara Valdez
c695c5f941 Add database settings tab (#24260) 2023-08-31 14:26:08 -07:00
Cory Rivera
0703eff3f0 Pass through database names to enable connection cleanup (#24251)
* Also re-ordered Attach entry to match context menu placement of other admin commands.
2023-08-31 11:12:33 -07:00
Sai Avishkar Sreerama
41202a65bd Enabling FILEGROUPS tab experience to the database properties (#24226)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* initial commit - fullText and owner need revision

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* loading data, need stylings-increase col length, etc

* using the existed setTableData method

* Adding new file dialog

* creating addFile, but not displaying in table, issue with appendData

* Adding row to the table, options are getting from STS

* all working except InPercent value

* code review comment updates

* Input type checkbox update table additional validation

* all except path

* fixing the input type focus and reverting the enterKeyPress logic

* browse path is created, need stylings,refactor,filestream selection and add

* fixing the flickering issue with data refresh

* new file options toggle and grid display string updates

* moving code inline and using actual component

* cleanup

* Add file saving is done, except one styling issue with autogrowth section

* add,remove working, need to edit file

* add, edit, remove - all working, need css fixes and -1 fix

* addressing code review comments

* adding local changes adn fixing for edit file

* adjusting css

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* all fixed, need testing and refactor

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch

* fixing autogrowth radio buttons change updates

* all working except some css

* disabled size for filestream

* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file

* added max and min values to the inputs

* editing filename validation completed, all done exccept CSS

* all fixed except scroll bar

* edit db file header, filename enable issue fix

* PR comment supporting updates for STS

* initial commit

* min updates

* loading data into table.. adding rows

* modfying addButtonsForTable method and reusing it for edit button

* add empty row/remove done, edit name and other columns required and save with tests

* All working except new name validation

* adding validation

* code review comment updates

* Dialogbase addbuttons to table refactored

* more typo fixes

* all working except 'Remove' revist logic and delete correct row

* removing fulltext index prop

* adding defualt conditions to the columns checkboxes

* service fix

* using path.join instead of hardcoded separators

* updating files is updating filegroups tabs, removing fg to file update required

* fixed toggle remove button for tab;es

* filegroup refactor

* update filegroups and files on new fg name

* final commit changes

* code review updates

* vBump STS to 4.9.0.26
2023-08-30 19:21:46 -05:00
Cory Rivera
e4abe4d167 Add Attach Database dialog (#24225) 2023-08-30 13:38:25 -07:00
Barbara Valdez
362290f8ec Add security tab for server properties (#24209)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-29 13:28:17 -07:00
Sai Avishkar Sreerama
c4b1765745 Enabling Files tab to the database properties (#24138)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* initial commit - fullText and owner need revision

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* loading data, need stylings-increase col length, etc

* using the existed setTableData method

* Adding new file dialog

* creating addFile, but not displaying in table, issue with appendData

* Adding row to the table, options are getting from STS

* all working except InPercent value

* code review comment updates

* Input type checkbox update table additional validation

* all except path

* fixing the input type focus and reverting the enterKeyPress logic

* browse path is created, need stylings,refactor,filestream selection and add

* fixing the flickering issue with data refresh

* new file options toggle and grid display string updates

* moving code inline and using actual component

* cleanup

* Add file saving is done, except one styling issue with autogrowth section

* add,remove working, need to edit file

* add, edit, remove - all working, need css fixes and -1 fix

* addressing code review comments

* adding local changes adn fixing for edit file

* adjusting css

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* all fixed, need testing and refactor

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch

* fixing autogrowth radio buttons change updates

* all working except some css

* disabled size for filestream

* fixing filegroups and filetypes scnearios, added filename validation for newfile, todo:editingNew file

* added max and min values to the inputs

* editing filename validation completed, all done exccept CSS

* all fixed except scroll bar

* edit db file header, filename enable issue fix

* PR comment supporting updates for STS

* min updates

* modfying addButtonsForTable method and reusing it for edit button

* code review comment updates

* Dialogbase addbuttons to table refactored

* more typo fixes

* removing fulltext index prop

* service fix

* using path.join instead of hardcoded separators

* final commit changes
2023-08-29 14:42:09 -05:00
Barbara Valdez
41ad39f665 Enable script button for Server properties (#24201)
* enable script button

* remove override method
2023-08-22 15:42:11 -07:00
Barbara Valdez
60bff01240 Add processors tab (#23634)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-08-21 10:52:55 -07:00
Cory Rivera
0e7942913b Replace usage of Delete with Drop in object management code (#24159)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-17 14:26:03 -07:00
Sai Avishkar Sreerama
e5b7bff7b4 Enabling Database scoped configurations tab to DB Properties (#23890)
* initial changes for loadin dsc table with real values from smo

* Displaying diff columns for DSC for diff sql server

* checkbox maiants the selection

* elevate option fails to load correct value when set to when_supported option

* all working till maxdop, todo pause option, save

* commented MAXDOP changes, as it is causing issues

* primary,sec,checkbox working as expected, TODO:MaxDop etc options,saving,tests

* Undo MAXDOP commented code

* refactored with service data

* column header width adjustments

* Maxdop and pause resume options completed, apply button is failing now

* Removed option names from loc  and using Id instead as names may change in future like in doc

* Apply button fixed

* refactored to reduce table reload

* Ledger digest completed

* refactor done: maxdop secondary shows wrong data from pause_resume

* refactor more: all working but table focus disturbs on update table

* adds conditions for unsupported dsc to <2016 server

* maxdop secondary checkbox fix

* rows still loses focus after value change due to update table row data

* Fixed updating secondary dropdown value

* reusing the private method and removed the duplicated codes

* Enter key in input type allows the change to update the table data, reduces the live update issues

* Setting focus to the current row

* using the existed setTableData method

* code review comment updates

* Input type checkbox update table additional validation

* fixing the input type focus and reverting the enterKeyPress logic

* fixing the flickering issue with data refresh

* moving code inline and using actual component

* cleanup

* addressing code review comments

* addressing code review comment for using loc var instead of duplicated line of code to get the rowinfo

* vBump STS  and fixing required field causing the apply button not enable for other options on main branch
2023-08-16 12:00:18 -05:00
Barbara Valdez
3fbca593be Refactor create inputbox method (#24113)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-08-15 13:36:02 -07:00
Cory Rivera
04301629c1 Rename internal references to Delete Database to Drop Database (#24132) 2023-08-14 14:23:53 -07:00
Cory Rivera
22e2b0df9f Add Delete Database dialog to enable additional deletion options (#24109) 2023-08-14 11:20:08 -07:00
Cory Rivera
9727a761c9 Select default database dropdown values based on a default index value (#24013) 2023-07-28 14:37:37 -07:00
Cory Rivera
5c5b73525d Connect query editor when producing script from object management dialogs. (#24015) 2023-07-28 14:26:33 -07:00
Cory Rivera
cc778ad69f Use faster, editable dropdown for Collations in database dialogs (#23974)
* Also fixed an issue where a manually edited text field doesn't get updated when selecting the same dropdown value from before the manual edit.
---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-26 10:04:29 -07:00
Cory Rivera
fed4f2a18e Change OK button label based on whether the dialog is creating a new object or updating an existing one. (#23908) 2023-07-17 15:54:30 -07:00
Barbara Valdez
6e84766cec Add basic validation to database names (#23842)
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-14 10:11:52 -07:00
Sai Avishkar Sreerama
207b1daf9f Making IsLedger Property to Read-only (#23804)
* Making IsLedger Property to Read-only

* refactor

* Update extensions/mssql/src/objectManagement/ui/databaseDialog.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-12 16:13:38 -05:00
Sai Avishkar Sreerama
9884bb44c0 Recovery time validation (#23789) 2023-07-12 10:47:10 -05:00
Barbara Valdez
03acee1d12 Create new context menu item for Database (#23771) 2023-07-11 11:28:04 -07:00
Barbara Valdez
bfb8536aa6 Fix error when trying to update server or database properties (#23695) 2023-07-11 11:07:09 -07:00
Barbara Valdez
017fcf14b0 Fix issues found in the bug bash (#23741)
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2023-07-11 10:15:41 -07:00
Barbara Valdez
a52f86bc48 Add memory inputs validation (#23685)
* memory validation

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>

* Update extensions/mssql/src/objectManagement/localizedConstants.ts

Co-authored-by: Cory Rivera <corivera@microsoft.com>

* rename property to match sts

---------

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
2023-07-07 12:36:55 -07:00
Cory Rivera
f4688f447c Add New Object context menu entries on the objects themselves in OE (#23676) 2023-07-07 10:45:39 -07:00
Sai Avishkar Sreerama
acfa93fbb8 Enabling options tab for database properties (#23448)
* Initial commit for adding a basic general tab for the database properties

* Refactoring for dialog inputs

* removed properties nodeType and using database node and additional cleanup, diabling the functionality.

* Changes according to STS data fetch

* Reuse database Dialog

* Undo contract file change

* more refactoring

* fetched scrollbar fix into this PR

* Tabbed panel is being used for horizontal tabs

* stying fix for general tab button

* final commit for today :)

* Updates according to STS changes

* missed updates

* Refactored updates

* moved options as discussed and added collapsible sections... need to fix scroll bar

* Fixing the horizontal scroll bar of tabbedpanel

* initial updates

* need to fix the error!

* rror fixed and options are loading with sample values

* need to load real values for all felds and map values to dropdown options

* Dd loading correctly, need to add validation to recovery field and save options back

* refactor

* removing nullable property

* All changes done except recoveryTime validation

* Refactoring

* all values are saving as expected, isDirty flag is fixed. Todo: recovery validation and tests

* added general section for the options tab

* modifying pageVerify and userAccess to string array

* updates to general section of options tb

* disabling couple of general properties for MI

* Adding server edition conditions and toggling the UI options

* adding numeric validation to the recovey time

* Removing serveInfo logic and using the unsupported options approach from STS

* addressing comments and little code refactor

* changes with nullOrUndefined helper method

* replacing dropdowns with checkboxes

* adding unit test for helper method

* removed commented sample code and added comments
2023-07-06 18:22:20 -05:00
Barbara Valdez
32356cabc5 Server properties fixes (#23667)
* server properties fixes
2023-07-06 12:58:01 -07:00
Cory Rivera
e5aa752740 Add Detach Database option to database context menu (#23480) 2023-06-27 12:32:09 -07:00