* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.
* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.
* Modified preview icons
* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.
* add turndown and save markdown
* update model on UI when source changes
* Added conditional that sets element attribute contentEditable when it is in edit mode.
* Added textView component that can be used for editing.
* update source on MD view not on every keystroke
* Added markdown editor buttons that allow user to swap editor, preview views.
* Cleaning up implementation
* Setting base value of _showPreview to false.
* don't allow html edit on split view
* Update editor automagically
* Add an image picking dialog to notebook toolbar.
* Await transformText()
* revert pushEditOperations to fix cursor issue
* Implemented radio buttons for three view toggles.
* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.
* Style tweaks.
* Added new ViewAction file where the RadioButton action will reside.
* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.
* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.
* WYSIWYG 3 Modes
* Ensure one action active at a time
* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.
* Ensure we respect editMode, add showMarkdown
* hiding overflow on code-cell
* Empty text container needs 100% width. Eliminates weird selection border too.
* Initialize _previewMode
* Actions Compatibility
* Further toolbar enhancements
* Update yarn lock after merge
* Slim down changes
* Remove commented out code
* Added margins around notebook-preview container for more visual space for text
* Add turndown to workbench html
* Tweak import
* Add types/turndown
* Remove workbench.html fix
* Import cjs modules directly for turndown
* Leverage solution from github
* browser umd
* non browser umd
* welp dependency
* Modified updatePreview to insert a p tag only when text cell is empty.
* add listener for undo
* add turndown to remote and web
* Fix workbench, check in plugin
* PR comment
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
* Notebook cell toolbar additions - move up and move down added. Stubbed out related actions. Cleaned up component code.
* Added new more actions menu item: Convert cell.
* add move cell support in model
* Schema Compare cleanup (#11418)
* cleanup async and await stuff
* remove awaits
* remove more awaits
* fix (#11437)
* Add some unit tests for PyPiClient. (#11442)
* handle invalid character in kubectl version output (#11460)
* Add tests for azdata extension (#11423)
* Add tests for azdata extension
* Fail on stderr
* Skip test for not implemented logic
* Move executeCommand stub
* Add missing packages
* let semver to parse the version (#11463)
* let semver to parse the version
* check
* Stop hardcoding python3 (#11464)
* Add ConnectControllerDialog tests (#11443)
* Automatically fix up arc controller URL
* wip
* Force tests to pass
* Refactor
* comment
* adds role of button to all links that are buttons (#11465)
* Merge from vscode 0a7364f00514c46c9caceece15e1f82f82e3712f
* bump smoke extensions
* bump node version in builds
* bump smoke extensions
* Add query-history and sql-assessment to recommended extensions (#11477)
* First draft of outputProcessor tests (#11368)
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Adds support for installing azdata on Linux (#11469)
* Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)
* do a large cleanup of azurecore
* Fix tests
* Rework Device Code
* Fix tests
* Fix AE scenario
* Fix firewall rule - clenaup logging
* Shorthand syntax
* Fix firewall tests
* Start on tests for azureAuth
* Add more tests
* Address comments
* Add a few more important tests
* Don't throw error on old code
* Fill in todo
* Adding button plugin to table component (#10918)
* Added delete plugin to table component
* Arc - Remove Azure params from Postgres deployment (#11478)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* tests for KernelsDropdown class (#11476)
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* implement review feedback (#11470)
* fix sql proj sqlcmd table showing after loading profile when it shouldn't (#11479)
* Feature/outer paths for project (#11445)
* allow relative paths in project file outside of project folder
* Adding some tests
* Adding error string to loc strings
* Fixed test
* fix error message
* PR comments and some more fixes
* change userName to match what the azure account display name is (#11484)
* change userName to match what the azure account display name is
* Handle undefined value
* Merge from vscode 8c426f9f3b6b18935cc6c2ec8aa6d45ccd88021e
* recomment out integration tests
* Fix/open book error (#11379)
* add isNotebook param and showPreview option
* showPreview changes
* update OpenNotebookFolder to open a specific path
* added test for showPreviewFile
* test name typo
* remove isNotebook from openBook
* Add test coverage for dacpac wizard import flow (#11483)
* Adding importConfig onPageEnter() test
* Removing redundancy from dacpac wizard pages
* promisifying file selection so it can be awaited in the test
* removing debug prints
* PR feedback
* Remove all accounts regardless of failure in one account (#11431)
* distro (#11487)
* distro
* distro
* distro
* distro
* Adding icons to Database Projects' tree view (#11488)
* Add images
* Splitting to light and dark mode icons
* Hooks up icons to treeItems
* updating package.json with new icon and vbump
* move icon loader before tree view created
* Update Arc extension version and fix Controller connectivity status names (#11498)
* Update connectivity mode names
(cherry picked from commit f0aabcfa86d178cdf74470f9fdeded19718bcea2)
* Bump package version
(cherry picked from commit e08370539006c638d6e25c2f4f23fa2754a3377d)
* deploy to single existing device (#11494)
* deploy to single existing device
* comments
* Add versioning for accounts (#11497)
* Add versioning for accounts
* deletion value
* Changes to getAccountSecurityToken (#11502)
* Hook up convert cell
* Fix tests
* Add convert cell tests
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: v-bbrady <60623315+v-bbrady@users.noreply.github.com>
Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* 10551 - Notebook UI: Added cell toolbar component, actions scaffolding, styles and theme colors. Removed markup for legacy, hidden hover buttons. Updated instaces of icon class: mask to masked-icon.
* Uncommented lines for CellToggleMoreActions so we can see how the ellipses currently work.
* Added EditCellAction which toggles between two icons.
* Cleaned up comments and removed some unused code.
* Copied DeleteCellAction into celltoolbarActions
* Connecting model and cell model to toolbar component for necessary context.
* Pass in cell + nb model from notebook component
* Adding context for EditCellAction so we can activate a cell via icon.
* Removed my copy of AddCellAction and simply referred to the existing one.
* Fixes to propogate cell model edit mode changes
* Added onCellModeChanged event registration to code.component.
* Moved cellToggleMoreActions into cellToolbarActions. Suppressing ellipses in code and textCell components.
* Fix adding cells
* Copied and modified ToggleMoreWidgetAction for use in cellToolbarActions. Instantiating cellToggleMoreActions and adding to toolbar.
* Removed unused markup, code and styles. Moved cell toolbar template into compoent.
* Removed double-click from textCell. Changed message to indicate where content goes - without it the cell does not have dimension and cannot be found by the user.
* Removed unused code file.
* Fixing my boo boo
* Updated AddCellAction with null coalescer. Set Promise to type: void.
Co-authored-by: chlafreniere <hichise@gmail.com>
* Reworking notebook action bar functionality and appearance.
* added separator
* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.
* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.
* Adjusted styles for the cell and run all icons in notebook toolbar.
* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
* Added new icon for Underline action.
* Removed comment from needed markup.
* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.
* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
* Removed unnecessary !important from style override.
* Removed reference to unused color entry.
* Syntax cleanup.
* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.
* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
* Replaced SVG code for not-trusted icon.
* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
* Markdown editor toolbar - initial commit
* Moved icons. Refactored new toolbar component to include markup.
* Edited markdown toolbar component and referencing in textCell component markup.
* Completed UI updates for selected cell toolbar and markdown toolbar.
* Modified import path to Event class. Changed EventEmitter to Emitter.
* Cleaned up newly added toolbar components
* Works sometimes sometimes editor is null
* Removed commented out code and styles. CellToolbar and MarkdownToolbar: moved component markup into html file.
* Added icon for highlight. Removed more commented code. Re-scoped two styles to their parent components. Corrected templateUrl reference for the new toolbars.
* Adjusted paths to SVG icons from toolbar stylesheet.
* Add lists and links
* Refactor out of component, add actionbar
* Support for nothing selected, quick bug fix
* Updated split view icons. Added markdown tool backgrounds and cell border colors to color registry and parent components. Updated toolbar icons to use mask as this allows the SVG icon colors to be adjusted on theme change.
* Added colorRegistry entries for code cell. Removed colors from styles. Running registerThemingParticipant from code.component.
* Revised code component style rules and corrected syntax.
* Merged in Chris' working branch and removed unused markup.
* Corrected styles and moved another color into colorRegistry for use in new markdown toolbar.
* Corrected style error. Overrode left position of content inside textCell and codeCell. Added more entries to colorRegistry.
* Moved toolbar and editor icons to common-icons location. Updated related stylesheet. Revised color theming rules for markdown and code cells.
* Added themed border between markdown and preview. Moved all notebook themes into notebookStyles.ts
* Merged in latest from origin/master and included a small but significant style tweak to light theme code cell toolbar.
* Add Undo Support for Markdown Toolbar (#9915)
* Remove comment
* Renamed registered notebook colors and prefixed with notebook. Moved markdown component theme colors into notebookStyles.ts. Removed colors from cellToolbar styles. Revised icon class names to generic names for better re-use. Removed commented markup.
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* dashboard improvement - WIP (#8836)
* wip
* wip
* tabgroup
* tab group
* agent views
* clean up
* formats
* feedback
* fix error
* contribute top level server/db dashboard tab (#8868)
* tabbedPanel component (#8861)
* tabbed panel
* tabbed panel
* fix errors
* revert main.ts changes
* use margin
* address comments
* remove orientation property
* content tab group (#8878)
* add databases tab
* use more extensible approach
* remove unnecessary code
* add when expression
* objects tab for database dashboard (#8892)
* fix build errors
* fix build error
* Dashboard toolbar (#9118)
* remove old toolbar with only edit and refresh
* remove tasks widgets from server and databases dashboards
* adding toolbar to dashboardpage and clicking new query works
* restore and new notebook now do something
* add backup to toolbar for database dashboards
* new notebook connects to db
* only show backup and restore for non-azure
* new backup and restore svgs
* clean up
* got toolbar actions to show up from contribution
* some cleanup and add database dashboard toolbar contributions
* don't show all tasks when there should be no tasks
* fix toolbar showing multiple times when switching opening another dashboard from OE
* only show toolbar for home page
* update to new icons - same icons for light and dark theme
* don't show separator if there aren't any actions
* read toolbar actions from tasks-widget
* remove tasks widget from home dashboard page
* show extension's actions in toolbar
* clean up
* more cleaning up
* fix extension actions not always loading the first time
* add configure dashboard
* remove old edit icon css
* change tasks back to original order
* make sure tasks widget is the one being removed
* collapsible tab panel (#9221)
* collapsible vertical tab panel
* fix lint error
* comments batch 1
* pr comments
* update new query icon (#9351)
* Update toolbar actions (#9313)
* remove edit and configure dashboard and add refresh to toolbar for other dashboard pages too
* Add refresh for tabs that have container type with refresh implemented
* change refresh to only refresh the current tab
* remove map for tab to actions
* add back configure dashboard to home toolbar
* check if index is -1 before trying to remove tasks widget from widgets
* Move objects widget back to database home tab (#9432)
* move objects widget back to database home tab and reorder toolbar
* change order of actions back to previous order
* Allow extensions to add actions to home toolbar (#9269)
* add support for extensions to add actions to home toolbar
* fix spacing
* use menu contribution point
* undo previous changes that added dashboardToolbarHomeAction contribution
* remove home from name
* add context key for tab name
* allow actions to also be added to the toolbar of other tabs
* add extension contributed actions even if no tasks-widget
* fix refresh being added twice after merging
* hide the tab list when collapsed (#9529)
* update the order of css selectors (#9606)
* Update dashboard style to be closer to mockups (#9570)
* update style to be closer to mockups
* tab panel styling
* change back tab styling for tabs in a tab contributed by an extension
* change color of borders when theme changes
* set dark theme active tab background to same as OE for now
* update border colors
* move colors to theme file
* fix a few issues (#9690)
* couple fixes
* comments
* small dashboard toolbar fixes (#9695)
* fix backup icon in toolbar
* fix database page toolbar border color
* add back center center in common-icons.css (#9703)
* change padding so bottom border shows again (#9710)
* tab panel fixes (#9724)
* tab panel fixes
* fix package.nls.json
* feedbacks (#9761)
* feedbacks
* remove comments
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
This is the 1st step to supporting HDFS Tiering
Changes:
Add new mounted folder icon. Will have separate commit for file icon
Disable delete/mkdir/upload for mounted files and folders
Disable delete for root HDFS folder (this was added in error)
* added initial data explorer viewlet
* added dataexplorer contribution point
* removed test view
* remove unused imports
* added flag and tests
* CR comments
* added icon for data explorer
* Initial work of adding tab in the dashboard (#526)
* refactor dashboard to have the home tab
* formatting
* fix grid layout issue
* fix initailize issue in database dashboard
* Add action bar to the panel and add close tab to the dashboard (#562)
* add action bar to the panel and add close tab to the dashboard
* formatting
* Tab contribution (#564)
* added contrib
* disabled edit for extensions; fixed new name for insights contrib
* fix merge issue
* move file
* formatting
* fix builds
* moving imports
* Expand on tab contrib (#581)
* added contrib
* disabled edit for extensions; fixed new name for insights contrib
* fix merge issue
* move file
* formatting
* fix builds
* adding to contrib
* updated contrib
* format
* moving imports
* updated contribution to map to current design
* implemented actually using provider and edition filtering
* Refactor and fix issues in close tab and add the placeholder for pin tab (#588)
* refactor and fix issues in close tab and add the placeholder for pin tab
* formatting
* remove the redundant code
* add clear all tabs in dashboard page init
* Initial work for adding a feature tab dialog (#594)
* initial work for add new dashboard tab
* formatting
* fix add panel action issue
* fix breaking change
* fix issues and tab and panels
* formatting
* minor fix
* address comments
* Add tab status to add extension tab dialog (#610)
* add tab status to add extension tab dialog
* add tab status to add extension tab dialog
* rename add feature tab action
* address comments
* Webview widget (#618)
* getting closer
* webview widget now works
* fix problem with rerendering webview
* formatting
* ensure that webview only shows up for extensions
* formatting
* comments
* fix more compile issues
* Change dashboard page init (#640)
* changed init of serverpage
* formatting
* Webview tab (#638)
* getting closer
* webview widget now works
* fix problem with rerendering webview
* formatting
* ensure that webview only shows up for extensions
* formatting
* comments
* fix more compile issues
* refacting stuff
* added inital webview tab
* piped through messaging and tested
* Implement pin/unpin feature and always on tabs (#629)
* implement pin/unpin feature
* fix issue where insight can't be loaded after reopen
* fix tab look and feel
* implement always show tabs
* make AddFeatureTabAction to track always show and pinned tabs
* formatting
* make dashboard tabs looks like the UX design
* load always show before pinned tab
* fix regression in panel for restore and connection dialog
* fix merge conflict
* don't worry about no widgets if its a webview (#656)
* expose the dashboard server info when a webview is rendering (#644)
* Fix few issues in dashboard command center (#655)
* fix reloading insight wigets and create new tab when there is no extension
* show possible tabIDs in the setting file
* formatting
* address comment
* fix import name
* fixes problem with size of webview widget being wrong (#654)
* Refactor tab contribution to support content type (#685)
* refactor tab contribution to support content type
* formatting
* address comment
* fix rendering tab issue (#694)
* Add layout option to panel for supporting horizontal and vertical navigation bar (#700)
* Add left navigation panel for inner tab in the dashboard
* add layout option in panel
* remove panel option in dashboard Page
