Editor component didn't have a minimum height set, so fixing this by passing through a minimum height to EditorComponent. Now, if the scrollable height of the editor is less than the minimum height, we use the minimum height as the height of the component.
Also fixed an issue where the markdown code editor's height was far too high. Now we're calculating the height on the layout() call, which gets called every time we display the markdown editor.
* initial work for addig code and code cell type
* add cell model and create editor for each cell
* formatting
* fix resizing issue
* small changes
* address comment
* edit data bug fix
* rename the event and use undefined instead of null
* use thenable instead of callback
* handle the new SlickGrid OnRendered event to control the keyboard focus
* use the new event to control the focus and change the add row behavior
* Revert "Revert "Port the Azure Resource Explorer extension to core." (#2770)"
This reverts commit 210447cd37.
* WIP1
* Add custom build task for azurecore extension
* Fix azurecore output path for macOS build
* Fix linux gulp task name
* fixed right click context menu bug in jobs view
* added stepInfo and edit job WIP
* show jobs in job edit
* added schedule description on select schedule
* fetch schedules during history and show in edit job
* added alerts to job histories and show in edit
* made history calls async
* filter menus now close when esc is pressed
* fixed bug where clicking on error row wouldnt populate job details
* added functionality to delete steps in a job
* added real time adding steps in edit job
* Revert "change how query plan is handled (#2735)"
This reverts commit 0693080630.
* Revert "center the icon (#2760)"
This reverts commit 75d27837c2.
* Revert "Alanren/edit data improvement (#2748)"
This reverts commit 597f29e90a.
* Revert "Port the Azure Resource Explorer extension to core. (#2701)"
This reverts commit a77bb50b9e.
* fixed right click context menu bug in jobs view
* added stepInfo and edit job WIP
* show jobs in job edit
* added schedule description on select schedule
* fetch schedules during history and show in edit job
* added alerts to job histories and show in edit
* made history calls async
* filter menus now close when esc is pressed
* fixed bug where clicking on error row wouldnt populate job details
* Port the Azure Resource Explorer extension to core.
This will enable Azure viewlet by default in the next release.
- Moving this code from the SQL Server 2019 extension to Azure Data Studio core
- Ported tests and verified they work in the integration tests.sh file
- Fixed an issue that caused integration tests to fail if you have a SQL Server 2019 big data cluster endpoint listed, but the extension isn't installed.
* Bump Electron to 2.0.8 and SQL Ops to 0.33.3 (#2466)
* Merged PR 328: Initial "Azure Data Studio" branding changes
* Alanren/icon overwrite issue (#2484)
* fix the error icon too large issue
* formatting
* add logic to hide and add grid panel based on size (#2481)
* add grid styles (#2483)
* Add check for potential failure in handling drag (#2499)
* add check for potential failure in handling drag
* move check to avoid ui glitches
* Reorder Connection Name field in Connection Dialog (#2498)
* change cursor in message panel to default (#2494)
* add select all handler to grid (#2496)
* Fix macOS titlebar branding
* add animation when button is clicked and fix title in button (#2488)
* add animation similar to toolbar in vscode and fix title in button
* remove bur method in button
* Disable the User Setup prompt (#2501)
* fixes a rendering problem in splitview (#2512)
* add listener to change action bar on maximize change (#2505)
* fix the save and save all for untitled file (#2526)
* add check for selection model in edit data (#2517)
* add min size for row num column (#2518)
* expand messages panel on error (#2519)
* Selection in grid context (#2527)
* update action context on selection change
* correctly add ranges rather than a new range for every row
* add required functions to typings
* Fixes#2523 (#2528)
The IdGenerator was recreated each time and had a high likelihood of conflicts. Invitably after adding dozens or hundreds of icons you'll start seeing the CSS class replaced and overridden.
The solution is to do like elsewhere: have 1 const that is loaded on first import of the file and keeps a global track.
Side note is that it'd be a good idea to cache CSS rules with the same iconPath so we don't create lots of additional rules unnecessarily. If we reuse the same icon a bunch we should cache them - #2524 is tracking this.
* Fix grid gaps (#2531)
* modifying grid gaps
* reduce gaps and increase gap for action bar
* fix grid action bar not updating (#2532)
* Turn-off Git missing prompt (#2533)
* Reduce message panel min size to 0 (#2534)
* reduce message panel minimum size to 0; attempt to restore panel sizing on requery sizes; default grid panel size to 80%
* formatting
* Fix bug around debounced event not being flushed in time (#2536)
* fix bug around debounced event not being flushed in time
* add comment
* Fix build break in Git extension (#2538)
* Update SQL Ops to 0.33.4
* Fix sizing error when switching windows (#2544)
* add work around for when we need to resize while we don't have a dimension to resize off of
* formatting
* change active cell during change to fix focus shift (#2545)
* fix the account not found error when creating firewall rules (#2543)
* Support isDirty flag for model view editors and begin plumb through of save support (#2547)
* Add dirty and save support to model view
* Add issue # for a TODO
* add divcontainer in modelview (#2559)
* add divcontainer in modelview
* address comment
* Bug/extension contribution (#2560)
* revert 4ab5d84b94
* fixed extensions
* Merged PR 352: Switch settings folder back to .sqlops
Switch settings folder back to .sqlops
* fix the connection issue when opening new query after connection (#2561)
* Update SQL Ops to 0.33.5
* Disabled connection name input when connecting to a server. (#2566)
* Disabled connection name input when connecting to a server.
#2557
* Fixed reset state of connection inputs
* added context to chart buttons so they work (#2575)
* accessibility setting based select database dropdown (#2579)
* Maintain Query State (#2571)
* add results view stating
* working through the bugs
* handle various resizing bugs
* gnale resizing better
* fix tests by adding missing node module
* formatting
* refactor interfaces out to get around testing restrictions
* more refactoring of importants to avoid loading errors
* use latest slickgrid library (#2584)
* Add OE node refresh API method (#2578)
* Initial working commit for refreshing OE node via API
* Add test and fix up code
* Run tsfmt
* Fix test
* Merged PR 356: Fix getDefaultLogLocation to use 'Azure Data Studio'
Update getDefaultLogLocation to use 'Azure Data Studio' to fix Azure Account creation on macOS.
* Update SQL Ops to 0.33.6
* Fix crash when reverting in edit data with no changes (#2594)
* edit data issue with column index handling (#2595)
* fixed insights crash (#2596)
* Changed the "Configure" link to "Learn How To Configure The Dashboard". (#2599)
* Changed the "Configure" link to "Learn How To Configure the Dashboard".
This inlcudes the command as well as the tile label
#1227
* Capitalizing first character in each word
* The "New Query" context menu is now only available from the server & db (#2598)
#1890
* Merged PR 366: Revert to using 'sqlops' so settings are maintained during upgraded
Revert to using 'sqlops' so settings are maintained during upgraded
* Merged PR 371: Fix casing for AZURE DATA STUDIO in EULA
Fix casing for AZURE DATA STUDIO in EULA
* Merged PR 375: Create new appid
Create new appid
* Merged PR 376: Update settings path back to 'azuredatastudio'
Update settings path back to 'azuredatastudio'
* Fix/bump dependency versions (#2608)
* Use version 2.0.9 of electron (#2606)
* fixes scrolling in query plan (#2609)
* Dashboard: Fixed all insight bugs (#2612)
* fixed all insight bugs
* removed unused imports
* added comment
* add view area options to pick up chart background fix (#2613)
* Respect message settings (#2614)
* add results view stating
* working through the bugs
* handle various resizing bugs
* gnale resizing better
* add configuration to state
* address comments
* Fix stating for scrolls (#2615)
* nearly working
* add accounting for the downsides to slickgrid
* Update SQL Ops to 0.33.7
* Added text underline CSS for DB NULL values when editing / showing data (#2597)
* Added text underline CSS for DB NULL values when editing / showing data
#217
* Changed db nulls styling to italic
* Bug/oetimeout Fix - When timeout happens while fetching node children, the node becomes unusable (#2616)
This commit fixes issue when multiple OE nodes are expanded simultaneously. While the error was getting displayed the node was left in incorrect state which was leading to the node being unusable in future. This commit repairs this defect.
* fixed actual show plan command (#2620)
* Bump SQL Tools Service to 1.5.0-alpha.34 (#2621)
* Feat/add dom component (#2622)
* add dom component for model view
* formatting
* make css style hardcoded in dom.component
* comment out the unused CSS
* address comments
* address comment
* Hide tabs on reexecute (#2624)
* add logic to hide tabs when a query rerun is executed
* remove double entry in the map
* Bump Azure Data Studio to 1.0.0
* Bump Azure Data Studio to 0.33.8
* Scroll query editor when clicking batch links (#2644)
* Fix broken 'Clear Token Cache' command (#2643)
* fixed right click context menu bug in jobs view (#2632)
* fix css issue (#2650)
* reload the chart types when we actually need it (#2651)
* Bump Azure Data Studio to 1.0.0
* Fix chart error that caused query editor to close (#2652)
* Bump Agent, Import and Profiler extension versions
