Commit Graph

3512 Commits

Author SHA1 Message Date
Aasim Khan
7554fbcaa0 Fixing zoomed badges (#19178) 2022-04-22 11:57:18 -07:00
Alan Ren
eb1212a606 increase nps survey probability (#19175) 2022-04-21 13:52:56 -07:00
Nemanja Milovančević
1cf905a7b8 Create shared access signature RPC (#18823)
* Rebase from main branch

* Made mssql a module

* remove rpc specific stuff

* Added create sas RPC call

* Backup to url works now

* Moved createSas RPC to the BlobService

* Relocated createSas RPC from sql-dataprotocolclient to the mssql

* After rebase

* Removed duplicate symbol

* Renamed Blob to AzureBlob and relocated CreateSasResponse to mssql extension

* Removed AzureBlobProvider, removed AzureBlobService feature

* renamed blob to azureblob, converted thenable to promise

* Simplify API

* fixes

* docs update, blob to azureblob update

* bumped sts version

* Fix config

Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-04-21 10:30:46 -07:00
Charles Gagnon
e9fefd2487 Fix typings pipeline + cleanup (#19163) 2022-04-21 10:30:18 -07:00
Chris LaFreniere
6c4bf812cd Notebooks: Preventing "previousSibling of Null" Errors on Cell Selection (#19153)
* Defensive programming

* PR comments
2022-04-20 17:37:38 -07:00
Aditya Bist
909d022562 change style (#19159) 2022-04-20 13:05:53 -07:00
Aditya Bist
449d27a5ae Add confirmation dialog before closing app (#19139)
* added confirmation dialog before closing app

* only one prompt for multiple open table designers
2022-04-19 20:26:22 -07:00
Alan Ren
6395402b80 fix activitybar icon focus style (#19150)
* fix activity bar icon accessibility issue

* use state
2022-04-19 14:26:49 -07:00
Alan Ren
6578e5e4cf Fix High Contrast theme name (#19125) 2022-04-15 14:19:12 -07:00
Alan Ren
5ec567a4f7 add title for color box (#19121) 2022-04-15 12:56:07 -07:00
Lewis Sanchez
010107aea8 Telemetry for Query Execution Plans (#19039)
* Adds telemetry around how the properties window is opened

* Adds telemetry around accessing execution plan top operations

* Adds key for viewing top operations

* Adds telemetry around using the open query button and context menu item

* Adds telemetry around execution plan zoom in, out, to fit, and custom

* Adds telemetry around searching for nodes in execution plans

* Reduces telemetry additional properties to 1.

* Code review changes

* Removes unnecessary export
2022-04-14 11:41:35 -07:00
Barbara Valdez
7a8681481e fix cell nav (#19082) 2022-04-14 10:49:17 -07:00
Cory Rivera
8bd5ea5c84 Only update hover execution state if cell is not active. (#19073) 2022-04-14 10:19:58 -07:00
Aasim Khan
d7f8b0bfed Fixing parallism icon not showing up (#19085) 2022-04-14 00:19:36 -07:00
Aasim Khan
192f7cc390 Fixing broken action label logic. (#19086)
* Fixing broken action label logic.

* Cleaning up some code
2022-04-14 00:19:07 -07:00
Aasim Khan
7dfa347250 Updating the cache element and not an unlinked reference to it. (#19057) 2022-04-13 14:33:35 -07:00
Cory Rivera
d98a421035 Enable cell cancellation for Interactive notebooks (#19005)
* Also added a check to prevent multiple Interactive cells from executing simultaneously.
2022-04-12 15:12:22 -07:00
Aasim Khan
387f4cd116 Adding caching to execution plan and refactoring code and some other fixes (#18913)
* Making ep code modular for easy swithcing in and out

* Changing to innerText

* Fixing renames

* Fixing var name in one file
2022-04-12 12:52:24 -07:00
Aasim Khan
dd2d6e0b5c Adding link support to infobox. (#18876) 2022-04-11 20:39:41 -07:00
Aasim Khan
170950dca8 Adding badge icons to execution plan (#19004)
* Adding badge icons to executionplan

* Fixing doc comment

* Fixing doc comments

* Making enum value more readable

* Changing default to undefined.

* Fixing some icon names
2022-04-11 14:44:07 -07:00
Alan Ren
fe1aefdd5f fix table designer issues (#18988)
* fix table designer issues

* commit change on blur

* new sts
2022-04-10 12:09:33 -07:00
Aasim Khan
9fcfe5b23c Adding flag to hide refresh button in dashboards. (#18964) 2022-04-09 17:52:09 -07:00
Cory Rivera
c2cc32a4a0 Add option to use notebook json contents instead of file string when creating a notebook. (#18972) 2022-04-08 16:39:14 -07:00
Hai Cao
0738c148ca A few table designer improvements && bump STS to .227 (#18982)
* Add unified col for data type deit

* remove seperate type setting cols and rename unified col to 'type'

* remove advanced type from properties window

* add description to col, idx, constraints

* nit

* bump STS to .227
2022-04-08 15:00:56 -07:00
Maddy
4191ef8aa5 Fix active cell update on tabbing (#18614)
* listen on focus_in of toolbar

* update styles on focus_in

* listen for active cell change on notebook componen

* add tabbing order to textcells

* remove duplicate listener

* clean up

* undo

* remove visible check from cellToolbar

* remove duplicate detectChanges on updateActiveCell

* only update active cell if it's already not

* add aria-label for accessibility

* localize the aria label

* refactor

* add cellLabel property to CellModel

* remove updateActiveCell from code component

* regression from merge fix

* set edit mode as true when focusing on cell

* moce check to model

* merge changes correctly

* update edit mode if code cell

* fixes

Co-authored-by: barbaravaldez <bavaldez@microsoft.com>
Co-authored-by: chgagnon <chgagnon@microsoft.com>
2022-04-08 12:31:30 -07:00
Alan Ren
c04f78981c retrieve the data from display data source (#18973) 2022-04-08 11:13:29 -07:00
Aditya Bist
197d56a29b Fix new table issue (#18974)
* fix new table issue

* fix new table scenario

* simplify logic
2022-04-08 11:10:30 -07:00
Cory Rivera
03d2e83250 Treat Jupyter's Python 3 Ipykernel alias as Python 3. (#18943) 2022-04-06 11:27:15 -07:00
Cory Rivera
7c399e84eb Add markdown smoke tests for changing text size and inserting links (#18888)
* Temporarily disabled text size tests due to issues running on Unix.
2022-04-05 15:53:06 -07:00
Lewis Sanchez
a6000aef67 Resolves undefined tenant error while adding an account. (#18937)
* Selects the first tenant that appears in the drop down list of tenants

* Fixes tenant undefined while adding account error
2022-04-05 13:14:06 -07:00
Aasim Khan
4db0814b94 Adding context menu to table component (#18914)
* Adding context menu to table component

* Removing extra whitespace

* Some logic fixes

* Fixing focus logic
2022-04-04 23:47:39 -07:00
Alan Ren
a795e64bed fix language change issue (#18906) 2022-04-01 17:52:11 -07:00
Aditya Bist
bab5118996 Add graph icons to OE and TD (#18808)
* add graph icons to OE and TD

* PR comments

* change enum type

* change sub type to icon and make basic as default

* changed icontype to icon

* change default logic location

* change icon name to be more generic

* use right icons
2022-04-01 00:27:59 -07:00
Aditya Bist
e7773425ee added graph node types from edit and publish results (#18891)
* added graph node types from edit and publish results

* make generic property bag

* review comments

* add comment for function

* edit comment

* change name to telemetry info
2022-03-31 21:50:26 -07:00
Alan Ren
b6083b6447 handle special values in the table filter (#18872)
* handle special values in the table filter

* pr comments
2022-03-31 11:17:55 -07:00
Charles Gagnon
4166c622f3 Fix DiffEditorComponent types (#18883)
* Fix DiffEditorComponent types

* spacing
2022-03-30 15:24:10 -07:00
Chris LaFreniere
af3d307d40 Restart kernel initial implementation (#18835)
* Restart kernel initial implementation

* Update notebook extension TestKernel

* PR comments
2022-03-29 12:56:52 -07:00
Lewis Sanchez
85b4bf13f9 Initial sets up of new execution plan comparison result endpoint (#18813)
* Initial sets up of new execution plan comparison result endpoint

* Makes query execution plan endpoint URI's more consistent.
2022-03-25 11:47:46 -07:00
Cory Rivera
d9501ffc03 Enable loading spinner for notebook editor. (#18810) 2022-03-24 16:31:33 -07:00
Charles Gagnon
f325a2df08 Throw more detailed error when compilation fails (#18783)
* Throw more detailed error when compilation fails

* Add SQL edits
2022-03-24 13:20:18 -07:00
Nemanja Milovančević
5e68ff1dfe Make mssql extension a module (#18804)
* Rebase from main branch

* import from module

* Add mssql module ref

Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
2022-03-24 11:09:55 -07:00
Charles Gagnon
bdf3261612 Disable broken tests (#18793) 2022-03-21 18:16:04 -07:00
Charles Gagnon
08b2d9668e Fix and enable core unit test coverage (#18781)
* Fix and enable core unit test coverage

* switch

* Fix coverage mapping

* don't output marked

* Fix filter check
2022-03-21 15:15:07 -07:00
Cory Rivera
7914fcf101 Fix issues with unknown notebook file types not opening as a default notebook. (#18779) 2022-03-18 16:59:22 -07:00
Maddy
23a69f9b69 Add test for last edit mode (#18734)
* add test for persisting last edit mode

* remove empty line

* address comments

* update comment
2022-03-18 16:13:58 -07:00
Alan Ren
f2d4801634 change the trigger of inputbox commit event (#18776) 2022-03-18 13:16:43 -07:00
Alan Ren
d6abcb892d handle validation error (#18766) 2022-03-17 19:43:02 -07:00
Aasim Khan
6c51b934f9 Fixing clickable state of infobox not setting properly when initializing it. (#18763)
* Fixing clickable state of infobox not set when initializing it.

* Removing unnecessary calls to a method
2022-03-17 14:11:15 -07:00
Alan Ren
9f2940e8f8 add severity support for issues (#18761)
* add severity support for issues

* vbump STS

* pr comments
2022-03-17 14:09:02 -07:00
Aasim Khan
a0c2dc199e Adding Execution Plan Editor to ADS (#18696)
* Pushing Execution Plan Editor

* Renaming class
Handling error

* Awaiting for handlers to be registered

* Addressing some PR comments

* Fixing return type for provider

* Fixing editor id and removing unnecessary overrides

* Adding a namespace

* adding execution plan namespace

* Adding protocol comment

* Fixing if logic

* Fixing error message

* Cleaning up code

* cleanup code

* Adding help comments

* Fixing method call

* Using path.ts to get the base file name

* converting to lambda functions

* Adding comment for run action

* Fixing pr comments

* Fixing editor label

* Fixing doc comments

* Adding some more comments

* Fixign branding in comments
2022-03-16 15:07:29 -07:00