Commit Graph

6436 Commits

Author SHA1 Message Date
v-bbrady
cc78d6a8f0 accessibility fix: swaps header tags for label tags on most recent list (#11189)
* switches header tags on form to label tags

* fixes issue according to pr comments
2020-07-15 18:04:21 -07:00
Kim Santiago
0a1c2583cc Load connection from publish profile (#11263)
* initial changes for reading connection from profile

* connection string can now be read from publish.xml

* fix build errors and update test

* move publish profile tests to their own file

* cleanup

* update message

* fix string

* remove apiWrapper
2020-07-15 17:03:25 -07:00
ADS Merger
9d3f12d0b7 Merge from vscode 1b314ab317fbff7d799b21754326b7d849889ceb 2020-07-15 23:51:18 +00:00
Anthony Dresser
aae013d498 add option to open excel file externally (#11324) 2020-07-15 15:06:46 -07:00
v-bbrady
0fa23eb3b5 Bbrady/welcome page focus contrast #10616 (#11233)
* fixes focus \color contrast for welcome page

* removes dead code

* removes dead css

* merge

* merge
2020-07-15 14:16:53 -07:00
Charles Gagnon
f4a4127471 Remove ApiWrapper from sql-database-projects (#11345)
* Remove ApiWrapper

* fix compile error

* Use .resolves

* Check error messages

* Check for not called

* FIx global beforeEach/afterEach
2020-07-15 14:02:33 -07:00
Alan Ren
c7799168b0 post release vbump (#11351)
* v bump

* update vscode version
2020-07-15 09:21:35 -07:00
Alan Ren
59ad8b3e61 update change log and readme (#11352) 2020-07-15 08:46:09 -07:00
Arvind Ranasaria
f8f64340f6 New tests for NotebookServiceImpl module (#11250)
* Working tests Upto 97.5% coverage

* pr feedback

* pr feedback

* pr feedback and test bug fixes + 1 new test

* revert debug change
2020-07-14 23:08:58 -07:00
Benjin Dubishar
dc7e6f59bd Aligns how Import and New project flows work (#11184)
* Slight import refactor

* Test updates

* Adds test, sets script name for File extractType to projectName

* generating correct folder list

* Correctly setting serverId for Imports started from Object Explorer

* Adding regression test

* uncommented test check
2020-07-14 19:31:22 -07:00
Alan Ren
6147e1cba4 bump import extension version (#11346) 2020-07-14 17:47:36 -07:00
Kim Santiago
de69e73a9d Open sql projects in opened folder (#11333)
* open projects in workspace automatically

* add test

* fix for windows
2020-07-14 16:20:37 -07:00
Aasim Khan
24f6cd2e5b Removing ApiWrapper and adding sinon (#11340)
* Added sinon
removed api wrapper
removed unnecesaary utils

* merged from testfix

* merged from aasim/import/downloadTestFix

* merge from aasim/import/downloadTestFix
2020-07-14 14:53:18 -07:00
Aasim Khan
cabbbb56f2 bumping up the services version to 0.0.4 (#11341) 2020-07-14 14:52:05 -07:00
Charles Gagnon
1b616acfdb Remove ApiWrapper from mssql extension (#11336) 2020-07-14 10:59:55 -07:00
Charles Gagnon
cbf3cd7445 Remove AzureCore ApiWrapper (#11335) 2020-07-13 18:11:54 -07:00
Charles Gagnon
9e6056968b Add Sinon docs to test README (#11332) 2020-07-13 18:03:17 -07:00
Anthony Dresser
6e9e97f711 fix screenshots for smoketests (#11334) 2020-07-13 16:34:49 -07:00
Alan Ren
11aa2b73b4 update ASDE strings (#11317)
* update strings

* comments

* update license term link
2020-07-13 15:40:06 -07:00
Amir Omidi
22f85ad4ff Handle don't ask again button (#11236)
* Handle don't ask again button

* Change to ignore

* Change language

* Pass in tenant name and ID

* Fix message

* Don't allow common tenant to get interaction required prompt

* Move things around
2020-07-13 14:52:41 -07:00
Amir Omidi
3c0d819911 Fixes the declarative table issue (#11330) 2020-07-13 14:35:35 -07:00
Anthony Dresser
351ab2f40f fix default connection group by changing ordering of groups (#11303) 2020-07-13 13:25:05 -07:00
Anthony Dresser
286c021df9 Fix access to query editor configuration (#11321)
* fix access to query editor configuration

* fix configuration type

* fix setting type
2020-07-13 13:05:36 -07:00
Amir Omidi
ff979f90d1 Optional PII logging (#11322)
* Start with logger

* allow user to enable PII logging

* prefix the log
2020-07-13 13:05:00 -07:00
Kim Santiago
347c193455 Add main controller tests for a few extensions (#11307)
* add a few tests

* fix errors

* undo change

* move registering commands to extension.ts for dacpac and schema compare

* undo createController() addition

* fix whitespace
2020-07-13 09:59:12 -07:00
Charles Gagnon
1e62030581 Revert to previous behavior for tree data providers getChildren (#11308)
* Revert to previous behavior for tree data providers without resolve support

* Add another sql carbon edit
2020-07-13 09:48:28 -07:00
Arvind Ranasaria
32c3a13f7b Phase 3 of notebookEditor tests (#11188)
* Phase 3 of notebookEditor tests

* update visibility for visibility tests

* saving in progress version to switch tasks

* remove inadvertent change

* corner cases tests to drive to 100%

* remove commented code

* pr feedback
2020-07-13 03:06:19 -07:00
Sakshi Sharma
81008d3803 Mark failing schema compare test as unstable (#11310) 2020-07-12 07:57:32 -07:00
Udeesha Gautam
ab9fceec70 Dacpac extensions tests - for investigation (#11192)
* Adding some tests for dacpac extension to understand how coverage gets affected

* Added config page tests

* Fixing PR issues
2020-07-11 13:45:50 -07:00
Anthony Dresser
d2bdd2bace web smoke tests (#11280)
* distro

* renable web smoke

* add missing script

* update node version

* update node version everywhere

* ensure playwright drivers are installed

* fix screenshot capture

* try this

* rewrite connection dialog code

* fix permissions

* more wip

* replace more $ with ^

* revert changes

* refactor and revert more changes

* add screen shot functionality to playwright

* fix compile

* fix profiler compile

* don't run new files for web

* continue on error for web

* continue on error for web not normal

* revert some changes
2020-07-10 22:12:45 -07:00
Alan Ren
e2b52b97c8 fix insight details dialog issue (#11309)
* fix show details dialog

* update viewlet id
2020-07-10 18:07:39 -07:00
Aasim Khan
df8f5ae3a6 Additional tests for the import wizard (#11273)
* Setting up tests on import extension

* -Added API wrappers for all the azdata and vscode APIs to make them easily mockable
-Added some unit tests for the import extension
-Some code logic separations

* -added code report for the import extension in ci

* Did some more code refractoring

* -Added json report generation

* updated vscodetestcoverage to latest version in import extension.

* -remove duplicate codecoverageConfig.json

* -Added some modifyColumnPage tests

* pushing temp changes

* -Added some more testcases

* -Added tests using available vscode and azdata apis

* some minor comment change

* removed unnecessary test

* added accidently removed test

* Added some comments

* fixed some broken tests and added comments in fileConfigPage

* code clean up and some more comments

* fixed the prosePreviewPage test and the download test

* added getter and setters

* Increasing timeout and fixing a comment

* removed unnecessary comments and some other code cleanup

* Deleting dotnet files before redownloading them

* - made changes in the PR
- Moved extensioncode to utils.test for better reusability

* added some 'should' messages
2020-07-10 15:34:44 -07:00
Christopher Suh
30e8edd875 added name (#11302) 2020-07-10 18:16:01 -04:00
Anthony Dresser
6d6abdff7d fix configuration access for grid (#11299) 2020-07-10 14:51:10 -07:00
Vasu Bhog
e714c876c2 Onboarding Pull Request (#11298)
Co-authored-by: Vasu Bhog <vasubhog@Vasus-MacBook-Pro.local>
2020-07-10 16:17:35 -05:00
Charles Gagnon
3db33de69f Add new ViewContainerLocation for dialogs (#11289) 2020-07-10 14:09:16 -07:00
Charles Gagnon
0835d3ed0f Only throw if releaseNotesUrl doesn't exist (#11295) 2020-07-10 12:31:55 -07:00
Sakshi Sharma
3e860692a2 Add missing await (#11275)
* Add missing await

* Addressed comment
2020-07-10 11:26:18 -07:00
Vladimir Chernov
95b024ed66 Updated README file for Sql Assessment extension (#11293) 2020-07-10 20:56:46 +03:00
Charles Gagnon
16329d6749 Remove unused ViewPane implementation (#11290) 2020-07-10 10:52:02 -07:00
Charles Gagnon
1ce24fae05 Filter to just BDC for create new controller action (#11291) 2020-07-10 10:15:34 -07:00
Lucy Zhang
826a0cf9ec added name to developers.ts (#11288) 2020-07-10 10:02:46 -07:00
Charles Gagnon
399bac33f4 Add empty azdata extension (#11281) 2020-07-10 08:13:39 -07:00
Chris LaFreniere
171f091c88 Fix no books currently selected error in viewlet (#11269)
* Fix no books currently selected error

* check sections undefined vs length
2020-07-09 23:14:46 -07:00
Kim Santiago
7d5ecfe905 Add "Import New Database Project" to dashboard toolbar (#11229)
* add import database project to database and server dashboard home toolbar

* connection profile is getting passed to the extension

* use MenuItemAction instead of creating a new one

* move database picking

* add comment

* add helper function
2020-07-09 16:47:55 -07:00
Aasim Khan
1796b519e5 Fixed a Bug where csv is treated as txt file by import wizard (#11271)
* Add CodeQL Analysis workflow (#10195)

* Add CodeQL Analysis workflow

* Fix path

* Fixed the bug where CSVs were treated as TXT files

Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
2020-07-09 15:01:48 -07:00
Amir Omidi
c334a95d35 Fixes the SSMS launch issue (#11257)
* Fixes the SSMS launch issue

* Spelling
2020-07-09 14:04:53 -07:00
Alan Ren
5a275209cc fix account dropdown list issue (#11266)
* fix the empty account list issue

* remove comments
2020-07-09 13:58:07 -07:00
Maddy
9c0f415bd9 Feat/search in books (#11117)
* clean up unsavedBooks to providedBooks

* added notebooks viewley contribution

* added notebookExporerAction context

* temp shortcut key B

* remove commenred code

* changes with master merge

* fix comments

* initial tests

* fix casing and description

* merged master and resolved errors

* initial commit

* search view changes

* remove extension point & add custom view container

* merge latest from master

* remove unused files

* move book images to common

* remove notebookExplorer contrib & move to notebook

* build fix

* remove explorer specific sryles from common

* vscode convention to define container actions

* rename notebooks/title

* show collapsible search view separately

* style changes

* rename method

* code cleanup

* enable search on type

* merged master and resolved compile errors

* highlight fix

* code cleanup

* rename interface

* fix hygiene floating promises errors

* more hygiene errors

* avoid circular dependency

* new ids for notebookSearch actions

* reuse SearchSortOrder from search

* merged main and resolved compile errors

* reuse search code

* vscode merge regression on highlight

* extend searchView

* missed resoved files

* null to undefined

* make treeView readonly

* revert carbon edit

* address PR comments

* convert async
2020-07-09 13:13:36 -07:00
Anthony Dresser
a69032e317 fix issues with file menu commands (#11254) 2020-07-08 18:52:26 -07:00