* log when an editor action doesn't run because of enablement
* notebooks create/dispose editors. this means controllers must be created eagerly (😢) and that notebooks need a custom way of plugging comparision keys for session. works unless creating another session for the same cell of a duplicated editor
* Set offSide to sql lang configuration to true (#183461)
* Fixes#181764 (#183550)
* fix typo
* Always scroll down and focus the input (#183557)
* Fixes#180386 (#183561)
* cli: ensure ordering of rpc server messages (#183558)
* cli: ensure ordering of rpc server messages
Sending lots of messages to a stream would block them around the async
tokio mutex, which is "fair" so doesn't preserve ordering. Instead, use
the write_loop approach I introduced to the server_multiplexer for the
same reason some time ago.
* fix clippy
* update for May endgame
* testing: allow invalidateTestResults to take an array (#183569)
* Document `ShareProvider` API proposal (#183568)
* Document `ShareProvider` API proposal
* Remove mention of VS Code from JSDoc
* Add support for rendering svg and md in welcome message (#183580)
* Remove toggle setting more eagerly (#183584)
* rm message abt macOS
* Change text (#183589)
* Change text
* Accidentally changed the wrong file
* cli: improve output for code tunnel status (#183571)
* testing: allow invalidateTestResults to take an array
* cli: improve output for code tunnel status
Fixes#183570
* [json/css/html] update services (#183595)
* Add experimental setting to enable this dialog
* Fix exporting chat model to JSON before it is initialized (#183597)
* minimum scrolling to reveal the next cell on shift+enter (#183600)
do minimum scrolling to reveal the next cell on Execute cell and select next
* Fixing Jupyter notebook issue 13263 (#183527)
fix for the issue, still need to understand why there is strange focusing
* Tweak proposed API JSDoc (#183590)
* Tweak proposed API JSDoc
* workbench -> workspace
* fix ? operator
* Use active editor and show progress when sharing (#183603)
Use active editor and show progress
* use scroll setting variable correctly
* Schedule welcome widget to show once between typing. (#183606)
* Schedule dialog to show once between typing
* Don't re-render if already displayed once
* Add F10 keybinding for debugger step, even on Web. (#183510)
Fixes#181792.
Previously, for Web the keyboard shortcut was Alt-F10, because it was
believed that F10 could not be bound on browsers. This turned out to be
incorrect, so we make the shortcut consistent (F10) with desktop VSCode
which is also what many other debuggers use.
We keep Alt-F10 on web as a secondary keybinding to keep the experience
some web users may have gotten used to by now.
* Also pass process.env
* Restore missing chat clear commands (#183651)
* chore: update electron@22.5.4 (#183716)
* Show remote indicator in web when remoteAuthority is set (#183728)
* feat: .vuerc as json file (#153017)
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Delete --compatibility=1.63 code from the server (#183738)
* Copy vscode.dev link to tunnel generates an invalid link when an untitled workspace is open (#183739)
* Recent devcontainer display string corrupted on Get Started page (#183740)
* Improve "next codeblock" navigation (#183744)
* Improve "next codeblock" navigation
Operate on the current focused response, or the last one, and scroll to the selected item
* Normalize command title
* Git - run git status if similarityThreshold changes (#183762)
* fix aria-label issue in kb editor
fixes A11y_GradeB_VSCode_Keyboard shortcut reads words together - Blind: Arrow key navigation to row Find the binding keys and "when" cell data are read together resulting in a word " CTRL + FeditorFocus instead of CTRL + F editorFocus" #182490
* Status - fix compact padding (#183768)
* Remove angle brackets from VB brackets (#183782)
Fixes#183359
* Update language config schema with more details about brackets. (#183779)
* fix comment (#183812)
* Support for `Notebook` CodeAction Kind (#183457)
* nb kind support -- wip
* allow notebook codeactions around single cell edit check
* move notebook code action type out of editor
---------
Co-authored-by: rebornix <penn.lv@gmail.com>
* cli: fix connection default being applied (#183827)
* cli: bump to openssl 1.1.1u (#183828)
* Implement "delete" action for chat history (#183609)
* Use desired file name when generating new md pasted file paths (#183861)
Fixes#183851
* Default to filename for markdown new file if empty (#183864)
Fixes#183848
* Fix small typo (#183865)
Fixes#183819
* Noop when moving a symbol into the file it is already in (#183866)
Fixes#183793
* Adjust codeAction validation to account for notebook kind (#183859)
* Make JS/TS `go to configuration` commands work on non-`file:` file systems (#183688)
Make `go to project` commands work on non-`file:` file systems
Fixes#183685
* Can't do regex search after opening notebook (#183884)
Fixes#183858
* Default to current dir for `move to file` select (#183875)
Fixes#183870
`showOpenDialog` seems to ignore `defaultUri` if the file doesn't exist
* Use `<...>` style markdown links when needed (#183876)
Fixes#183849
* Remove check for context keys
* Update xterm package
* Enable updating a chat model without triggering incremental typing (#183894)
* Enable chat "move" commands on empty sessions (#183895)
* Enable chat "move" commands on empty sessions
and also imported sessions
* Fix command name
* Fix some chat keybindings on windows (#183896)
* "Revert File" on inactive editors are ignored (fix#177557) (#183903)
* Empty reason while switching profile (fix#183775) (#183904)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4278 (#183910)
* fix https://github.com/microsoft/vscode/issues/183770 (#183914)
* code --status displays a lot of errors before actual status output (fix#183787) (#183915)
* joh/icy manatee (#183917)
* Use idle value for widget of interactive editor controller
https://github.com/microsoft/vscode/issues/183820
* also make preview editors idle values
https://github.com/microsoft/vscode/issues/183820
* Fix#183777 (#183929)
* Fix#182309 (#183925)
* Tree checkbox item -> items (#183931)
Fixes#183826
* Fixes#183909 (#183940)
* Fix#183837 (#183943)
fix#183837
* Git - fix#183941 (#183944)
* Update xterm.css
Fixes#181242
* chore: add @ulugbekna and @aiday-mar to my-endgame notebook (#183946)
* Revert "When snippet mode is active, make `Tab` not accept suggestion but advance placeholder"
This reverts commit 50a80cdb61511343996ff1d41d0b676c3d329f48.
* revert not focusing completion list when quick suggest happens during snippet
* change `snippetsPreventQuickSuggestions` default to false
* Fix#181446 (#183956)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4298 (#183957)
* fix: remove extraneous incorrect context keys (#183959)
These were actually getting added in getTestItemContextOverlay, and the test ID was using the extended ID which extensions do not know about.
Fixes#183612
* Fixes https://github.com/microsoft/monaco-editor/issues/3920 (#183960)
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4324 (#183961)
* fix#183030
* fix#180826 (#183962)
* make message more generic for interactive editor help
* .
* fix#183968
* Keep codeblock toolbar visible when focused
* Fix when clause on "Run in terminal" command
* add important info to help menu
* fix#183970
* Set `isRefactoring` for all TS refactoring edits (#183982)
* consolidate
* Disable move to file in TS versions < 5.2 (#183992)
There are still a few key bugs with refactoring. We will ship this as a preview for TS 5.2+ instead of for 5.1
* Polish query accepting (#183995)
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280
* Allow widget to have focus (#184000)
So that selecting non-code text works.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4294
* Fix microsoft/vscode-internalbacklog#4257. Mitigate zindex for zone widgets. (#184001)
* Change welcome dialog contribution to Eventually
* Misc fixes
* Workspace folder picker entry descriptions are suboptimal for some filesystems (fix#183418) (#184018)
* cli - ignore std error unless verbose (#183787) (#184031)
* joh/inquisitive meerkat (#184034)
* only stash sessions that are none empty
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* only unstash a session once - unless new exchanges are made,
https://github.com/microsoft/vscode-internalbacklog/issues/4281
* account for all exchange types
* Improve declared components (#184039)
* make sure to read setting (#184040)
d'oh, related to https://github.com/microsoft/vscode/issues/173387#issuecomment-1571696644
* [html] update service (#184049)
[html] update service. FIxes#181176
* reset context keys on reset/hide (#184042)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4330
* use `Lazy`, not `IdleValue` for the IE widget held by the eager controller (#184048)
https://github.com/microsoft/vscode/issues/183820
* fix https://github.com/microsoft/vscode-internalbacklog/issues/4333 (#184067)
* use undo-loop instead of undo-edit when discarding chat session (#184063)
* use undo-loop instead of undo-edit when discarding chat session
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4118
* fix tests, wait for correct state
* Add logging to node download (#184070)
Add logging to node download. For #182951
* re-enable default zone widget revealing when showing (#184072)
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4332, also fixes https://github.com/microsoft/vscode-internalbacklog/issues/3784
* fix#178202
* Allow APIs in stable (#184062)
* Fixmicrosoft/vscode-internalbacklog#4206. Override List view whitespace css for monaco editor (#184087)
* Fix JSDoc grammatical error (#184090)
* Pick up TS 5.1.3 (#184091)
Fixes#182931
* Misc fixes
* update distro (#184097)
* chore: update electron@22.5.5 (#184116)
* Extension host veto is registered multiple times on restart (fix#183778) (#184127)
Extension host veto is registered multiple times on restart (#183778)
* Do not auto start the local web worker extension host (#184137)
* Allow embedders to intercept trustedTypes.createPolicy calls (#184136)
Allow embedders to intercept trustedTypes.createPolicy calls (#184100)
* fix: reading from console output for --status on windows and linux (#184138)
fix: reading from console output for --status on windows and linux (#184118)
* Misc fixes
* code --status displays a lot of errors before actual status output (fix#183787) (#184200)
fix 183787
* (cherry-pick to 1.79 from main) Handle galleryExtension failure in featuredExtensionService (#184205)
Handle galleryExtension failure in featuredExtensionService (#184198)
Handle galleryExtension failure
* Fix#184183. Multiple output height updates are skipped. (#184188)
* Post merge init fixes
* Misc build issues
* disable toggle inline diff of `alt` down
https://github.com/microsoft/vscode-internalbacklog/issues/4342
* Take into account already activated extensions when computing running locations (#184303)
Take into account already activated extensions when computing running locations (fixes#184180)
* Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (#184310)
Avoid `extensionService.getExtension` and use `ActivationKind.Immediate` to allow that URI handling works while resolving (fixes#182217)
* WIP
* rm fish auto injection
* More breaks
* Fix Port Attributes constructor (#184412)
* WIP
* WIP
* Allow extensions to get at the exports of other extensions during resolving (#184487)
Allow extensions to get at the exports of other extensions during resolving (fixes#184472)
* do not auto finish session when inline chat widgets have focus
re https://github.com/microsoft/vscode-internalbacklog/issues/4354
* fix compile errors caused by new base method
* WIP
* WIP
* WIP
* WIP
* Build errors
* unc - fix path traversal bypass
* Bump version
* cherry-pick prod changes from main
* Disable sandbox
* Build break from merge
* bump version
* Merge pull request #184739 from max06/max06/issue184659
Restore ShellIntegration for fish (#184659)
* Git - only add --find-renames if the value is not the default one (#185053)
Git - only add --find-renames if the value is not the default one (#184992)
* Cherry-pick: Revert changes to render featured extensions when available (#184747)
Revert changes to render featured extensions when available. (#184573)
* Lower timeouts for experimentation and gallery service
* Revert changes to render extensions when available
* Add audio cues
* fix: disable app sandbox when --no-sandbox is present (#184913)
* fix: disable app sandbox when --no-sandbox is present (#184897)
* fix: loading minimist in packaged builds
* Runtime errors
* UNC allow list checks cannot be disabled in extension host (fix#184989) (#185085)
* UNC allow list checks cannot be disabled in extension host (#184989)
* Update src/vs/base/node/unc.js
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: Robo <hop2deep@gmail.com>
* Add notebook extension
* Fix mangling issues
* Fix mangling issues
* npm install
* npm install
* Issues blocking bundle
* Fix build folder compile errors
* Fix windows bundle build
* Linting fixes
* Fix sqllint issues
* Update yarn.lock files
* Fix unit tests
* Fix a couple breaks from test fixes
* Bump distro
* redo the checkbox style
* Update linux build container dockerfile
* Bump build image tag
* Bump native watch dog package
* Bump node-pty
* Bump distro
* Fix documnetation error
* Update distro
* redo the button styles
* Update datasource TS
* Add missing yarn.lock files
* Windows setup fix
* Turn off extension unit tests while investigating
* color box style
* Remove appx
* Turn off test log upload
* update dropdownlist style
* fix universal app build error (#23488)
* Skip flaky bufferContext vscode test
---------
Co-authored-by: Johannes <johannes.rieken@gmail.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Julien Richard <jairbubbles@hotmail.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Megan Rogge <merogge@microsoft.com>
Co-authored-by: meganrogge <megan.rogge@microsoft.com>
Co-authored-by: Rob Lourens <roblourens@gmail.com>
Co-authored-by: Connor Peet <connor@peet.io>
Co-authored-by: Joyce Er <joyce.er@microsoft.com>
Co-authored-by: Bhavya U <bhavyau@microsoft.com>
Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Aaron Munger <aamunger@microsoft.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: rebornix <penn.lv@gmail.com>
Co-authored-by: Ole <oler@google.com>
Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com>
Co-authored-by: Ulugbek Abdullaev <ulugbekna@gmail.com>
Co-authored-by: Alex Ross <alros@microsoft.com>
Co-authored-by: Michael Lively <milively@microsoft.com>
Co-authored-by: Matt Bierner <matb@microsoft.com>
Co-authored-by: Andrea Mah <31675041+andreamah@users.noreply.github.com>
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com>
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com>
Co-authored-by: Alexandru Dima <alexdima@microsoft.com>
Co-authored-by: Joao Moreno <Joao.Moreno@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* table designer add/remove row support
* save changes and editor support
* address comments
* fix build error
* including missing change
* lower case request name
* wip
* wire up e2e
* hook up styler and add as dataprotocal feature
* designer child component rendering
* table component updates
* styler and selectbox column editor
* fix editor size and dupe component creation issue
* fix checkbox column and add more testing data
* properties pane
* only rerender when needed
* properties pane update
* update commands
* cleanup for PR
* revert unwanted changes
* Adding a few tests for Add SQL binding (#17079)
* initial changes
* add a couple more tests
* LEGO: check in for main to temporary branch. (#17089)
* LEGO: check in for main to temporary branch. (#17091)
Co-authored-by: kburtram <karlb@microsoft.com>
* Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078)
* Initial changes
* checkpoint
* Constructing project with post deployment script
* Correcting to intentionally read from cached list of projects
* Adding activation event, fixing fresh workspace bug
* Convert netcoreTool and autorestHelper to share a helper class for streamed command
* Include npm package version to force update
* test checkpoint
* Unit tests
* Added contextual quickpicks for autorest dialogs
* Adding projectController test
* Added projectController test, some refactoring for testability
* Merge branch 'main' into benjin/autorest
* Fixing 'which' import
* PR feedback
* Fixing tests
* Adding additional information for when project provider tests fail
* Hopefully fixing failing tests (unable to repro locally)
* Adding Generate Project item to workspace menu
* PR feedback
* LEGO: check in for main to temporary branch. (#17097)
* added sql database projects strings (#17100)
* Set kernelAlias in startSession when isValidConnection is truthy (#17102)
* PR follow-up comments (#17113)
* Change recompare message after changing options to modal (#17103)
* Change recompare message to modal
* change options to yes and no
* Remove commented code block in git extension (#17116)
* Remove commented code block in git extension
* Add SQL CARBON EDIT tag
* [Loc] Small change to generatingProjectFailed (#17118)
* Add Null Shortcut and added NULL text for default NULL value. (#17085)
* added test key event
* added null function to tryHandleKeyEvent
* added null formatting
* added working null insert.
* added editDataGridPanel string null support
* Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115)
Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/fb55/nth-check/releases)
- [Commits](https://github.com/fb55/nth-check/compare/v2.0.0...v2.0.1)
---
updated-dependencies:
- dependency-name: nth-check
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add excludeFlags to extenson marketplace query (#17121)
* Add excludeFlags to extenson marketplace query
* Remove dead code
* Remove extraneous blank line
* Address code review feedback
* Adding Derived Columns to ADS Flatfile Import (#16795)
* Adding derived column boilerplate
* brandan preliminary frontend changes
* empty commit
* added new param
* updating contracts, dialogue changes
* utils changes, saving timeout attempt
* pushing for aasim
* Cleaning up code and fixing the issue in theory
* changing button, did not solve independent scroll
* Fixing the scroll bar issue
* updating flat file service
* adding override keyword to overrriden method
* improving UI
* pushing changes associated with resolved comments
* localizing strings, editing comments
* all comments resolved
* Fixing a test
* updating import package
Updating azure MFA bug
* Clearing navigation validator
Fixing broken table name change
* fixed prose test
* removing unused code from tests
* Fixed PR comments
* Fixing some PR comments
* WIP
* Fixing transformation code and create derived column dialog styling
* removing unused code
* Adding comment for console log
* fixed table styling
* Adding some aria labels
* Fixed some code cleanup issues
* update import service
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
* Change keybindings for copying query with Results (#17127)
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
* sql proj - publish to docker improvements (#17124)
* Add AAD token expiration handling for query runner (#17117)
* Add AAD token refresh for notebook
* move token refresh to query management and remove previous refresh calls
* Add guids to RunAll and RunCell events (#17123)
Add guids to RunAll and RunCell events
* add error banner for failed migration cutover and cancel migration (#17106)
* [Loc] update to sql migration, database projects and import extension strings (#17130)
* Apply optional storage class settings in sql mi create command (#17129)
* Make storage classes optional
* Fix notebook to use storage class options
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
* Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093)
* be able to add new setting in local.settings.json
* cleanup
* addressing comments
* remove todo comment
* addressing comments
* update some strings to uris
* bump version of sqltoolsservice (#17133)
* mark schema compare tests as unstable (#17140)
* [Loc] Update for arc and sql-database-projects (#17148)
* ML extension vbump (#17143)
* Configure docker image and web smoke tests for ADSWeb. (#17136)
* Adjusts timeout period
* Revert "Adjusts timeout period"
This reverts commit 0f372eae2a4611554093b6c09f1ff6c451132e19.
* Adds firefox as browser option
* Corrects yaml smoke test script
* Resets args array to original values
* Corrects build path
* Resolves ignoring browser option error
* continue even after writing to stderr
* Adjusts smoke test (browser) script
* More adjustments to smoke test script
* Corrects server path
* Uses build variable directly in build path
* Specifies browser type since cannot be ignored error
* Adds browser option
* Updates web build image and corrects smoke test exe command
* Removes commented out task
* Updates dockerfile to support web smoketests
* Removes failOnStderr flag
* Use curl instead of wget in Dockerfile
* Fixed a bug with cancling publish (#17160)
* Save And Close Functionality (#17000)
* save and close
* wip
* working save and close
* cleanup
* pr changes
* pr changes
* fix capitalization
* fix build
* pr fix
* Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119)
* Dynamic enablement
* Added new package.json field for dynamic options and corresponding functions and classes.
* Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left.
* Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal.
* fix unit test
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
* LEGO: check in for main to temporary branch. (#17168)
* [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171)
* [Loc] added new arc strings and fix for sql-database-projects xlf
* removed newline
* Port of Vscode fix for colors too close (#17146)
* default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes#127597
* remove activeSelectionBackground from theme-carbon as it conflicts with vscode.
* remove dark carbon background
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
* Markdown Horizontal Scrollbar Fix (#17083)
* dynamically change horizontal scrollbar
* working horizontal scrollbar
* created new event to handle both scrollbar and mouse wheel
* only show scrollbar when needed
* LEGO: check in for main to temporary branch. (#17181)
* Bump axios to 0.21.4 (#17161)
* Kusto version bump to 0.5.6 (#17114)
* Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6
* Changed netcoreapp3.1 to net5.0 in Kusto config.json
* AzureMonitor bump ToolService version and extension version. (#17174)
* Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158)
Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0.
- [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases)
- [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits)
---
updated-dependencies:
- dependency-name: concat-with-sourcemaps
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update service downloader to 0.2.3 (#17186)
* Notebook Views grid fixes (#17170)
* update data workspace restart ADS to open workspace message (#17188)
* update message
* update string
* Add back "Remove Project" (#17178)
* remove project working with full paths
* use relative paths
* const
* addressing comments
* Bump github-auth axios to 0.21.4 (#17189)
* LEGO: check in for main to temporary branch. (#17192)
* LEGO: check in for main to temporary branch. (#17190)
Co-authored-by: kburtram <karlb@microsoft.com>
* [Loc] Add a small change to dataworkspace (#17194)
* added bump to sqltoolsservice version (#17195)
* Check if file is dirty before adding sql binding (#17175)
* check if file is dirty before adding sql binding
* Addressing comments
* Add vertical scroll bar to Preview in Split View (#17164)
* reset max height
* add editor height
* set md editor height
* Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176)
* fix floating promises
* pr comments
* reuse component definition
* comments
* fix error
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: kburtram <karlb@microsoft.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
Co-authored-by: Alex Ma <alma1@microsoft.com>
Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com>
Co-authored-by: Aasim Khan <aasimkhan30@gmail.com>
Co-authored-by: bnhoule <t-bhoule@microsoft.com>
Co-authored-by: Monica Gupta <scorpio90m@gmail.com>
Co-authored-by: Monica Gupta <mogupt@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Hai Cao <hacao@microsoft.com>
Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com>
Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com>
Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com>
Co-authored-by: Charmaine Chan <chachan@microsoft.com>
Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com>
Co-authored-by: Christopher Suh <chsuh@microsoft.com>
Co-authored-by: Candice Ye <candiceye@berkeley.edu>
Co-authored-by: Candice Ye <canye@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
Co-authored-by: Vasu Bhog <vabhog@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
* Modified modal styles, limiting height of basic modal to 480px.
* wip - added new attachCalloutDialogStyler. Moved callout-specific styler code out of modal.ts
* Moved attach styler code to workbench/common. Added custom styles to imageCalloutDialog
* Moved styler code into calloutDialog. Added callout-specific theme colors to colorRegistry. Removed color styles from modal and callout stylesheets.
* Added CalloutDialogModal that extends CalloutDialog so that the callout can be instantiated from core. Revised calloutDialog so the position cn be passed in from where it is instantiated.
* Revised refactor of modal and image/link callouts so that callout dialog invoked by core can also use the styler. Removed unused properties from dialog code.
* Added conditional to dialogModal to use correct styler for callouts.
* Cleaned up styles. Modified custom colors.
* Wrapped call to positionCalloutDialog in conditional.
* Style, colors, styler and modal updates to align callout with latest OPAC toolkit styles.
* Moved calloutDialog stylesheet
* Consolidated styler code and added a flexible custom styler to provide values for dialogModal
* Added image callout code.
* Remove image callout dialog until wired fully
* Test fixes
Co-authored-by: chlafreniere <hichise@gmail.com>
* highlight current range in the marked html
* find ranges on textContent not innerHtml
* add comment
* highlight all and mark the specific in orange
* register highlights in color themes
* fix the closure on the last style
* undo delete locproj file
* add comment
* undo format on locProj file
* Backend work for Parameterization + Tests
* address comments
* Add Parameters Tag upon state change
* Edit CSS Styling for accessibility
* more generic tag names
* wip
* wip
* weird splitview scrolling stuff
* working table
* remove spliceable table
* handling resizing columns
* get perf table integrated into grid
* make more improvments to table view
* testing
* wip
* wip
* fix async data window; add more optimization to scrolling
* work on scrolling
* fix column resizing
* start working on table widget
* inital work to get table widget working with styles and mouse controls
* fix unrendering selection; fix sizes of cells
* support high perf table option; remove unused files; add cell borders to high perf
* add accessibility tags
* handle borders and row count
* more styling changfes
* fix strict null checks
* adding inital keyboard navigation
* center row count; add padding left to rows
* inital drag selection
* remove drag implementation; it can be done better utilizing the global mouse monitor object
* range logic
* create custom grid range
* work with new range
* remove unused code
* fix how plus range works
* add drag selection; change focus to set selection; fix problem with creating a range with inverse start and end
* code cleanup
* fix strict-null-checks
* fix up perf table
* fix layering
* inital table service
* finish table service
* fix some compile errors
* fix compile
* fix compile
* fix up for use
* fix layering
* remove console use
* fix strict nulls
* Reworking notebook action bar functionality and appearance.
* added separator
* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.
* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.
* Adjusted styles for the cell and run all icons in notebook toolbar.
* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
* Added new icon for Underline action.
* Removed comment from needed markup.
* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.
* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
* Removed unnecessary !important from style override.
* Removed reference to unused color entry.
* Syntax cleanup.
* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.
* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
* Replaced SVG code for not-trusted icon.
* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
* Markdown editor toolbar - initial commit
* Moved icons. Refactored new toolbar component to include markup.
* Edited markdown toolbar component and referencing in textCell component markup.
* Completed UI updates for selected cell toolbar and markdown toolbar.
* Modified import path to Event class. Changed EventEmitter to Emitter.
* Cleaned up newly added toolbar components
* Works sometimes sometimes editor is null
* Removed commented out code and styles. CellToolbar and MarkdownToolbar: moved component markup into html file.
* Added icon for highlight. Removed more commented code. Re-scoped two styles to their parent components. Corrected templateUrl reference for the new toolbars.
* Adjusted paths to SVG icons from toolbar stylesheet.
* Add lists and links
* Refactor out of component, add actionbar
* Support for nothing selected, quick bug fix
* Updated split view icons. Added markdown tool backgrounds and cell border colors to color registry and parent components. Updated toolbar icons to use mask as this allows the SVG icon colors to be adjusted on theme change.
* Added colorRegistry entries for code cell. Removed colors from styles. Running registerThemingParticipant from code.component.
* Revised code component style rules and corrected syntax.
* Merged in Chris' working branch and removed unused markup.
* Corrected styles and moved another color into colorRegistry for use in new markdown toolbar.
* Corrected style error. Overrode left position of content inside textCell and codeCell. Added more entries to colorRegistry.
* Moved toolbar and editor icons to common-icons location. Updated related stylesheet. Revised color theming rules for markdown and code cells.
* Added themed border between markdown and preview. Moved all notebook themes into notebookStyles.ts
* Merged in latest from origin/master and included a small but significant style tweak to light theme code cell toolbar.
* Add Undo Support for Markdown Toolbar (#9915)
* Remove comment
* Renamed registered notebook colors and prefixed with notebook. Moved markdown component theme colors into notebookStyles.ts. Removed colors from cellToolbar styles. Revised icon class names to generic names for better re-use. Removed commented markup.
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
* adds icons for welcome page
* updates markup and styles for welcome page
* updates color registry with welcome page colors
* updates styles for welcome page
* updates markup for welcome page
* updates theming styles for welcome page and adds date since last opened functionality on history items
* adds all icons and images for welcome page
* updates markup for welcome page
* updates styles for welcome page
* updates color registry with welcome page styles
* updates welcome page icons with microsoft flag and dark theme home banner
* updates welcome page markup
* updates dynamically generated extension list
* updates styles for welcome page
* updates markup for welcome page
* adds dynamic lists for extension pack individual extensions
* updates icons for welcome page
* updates styles for welcome page
* updates welcome page styles
* updates theme colors
* updates markup for welcome page
* updates color registry with welcomepage colors
* updates sql.de.xlf with copy for welcome page
* reverts generated file
* updates welcome page styles
* updates extension pack copy casing
* updates color registry with welcome page styles
* updates welcome page markup
* adds welcome page icons
* updates welcome page markup
* updates welcome page icons
* updates welcome page styles
* reverts color registry in vs folder to original state
* moves color registry to sql folder
* removes dead code, localizes dates
* updates welcome page styles
* moves all colors from css to color registry
* updates styles by removing all colors
* removes stat import because of laying issue, adds color registry colors to welcomePage
* updates welcome page font sizes to ems
* updates localized strings
* removes unnecessary comment
* removes double quotes around string key for single quotes
* updates welcome page styles
* updates color registry
* updates welcome page markup
* adds dropdown button functionality
* adds centering classes for installed button text
* updates welcome page styles
* updates markup and styles for welcome page
* removes icon attempt from color registry
* removes theme specific icon svgs for theme specific icon css
* removes unused import
* removes console.log
* adds back mac new file button
* removes unused rules
* updates markup
* updates markup
* updates extension links to link to extensions in ADS
* pulls in changes from welcome-page-reskin-anthonydresser
* adds back code-icon to vs folder
* reverts welcomePage.css
* removes duplicate color registry variables
* fixes icon overlap on text for mac
* removes null import
* updates welcome page styles for mac
* updates welcome page images to use sql folder
* updates welcome page markup
* updates welcome page styles
* updates styles
* updates files paths
* delete images from sql folder
* updates icons
* updates welcome page styles
* updates preview popup
* updates markup for accessibility
* adds hover state to tiles
* updates dropdown
* fixes line-height issue
* updates class names
* updates keyboard accessibility for tooltip
* format document
* updates accessibility for preview tooltip
* removes whitespace
* updates preview modal accessibility
* adds aria labels to popup and tooltip
* removes max-width for zoom
* removes escaped strings, adds keycodes to promises, marks function as async and has the return as the signature of the function
* moves keycoes to class, removes comment
* fixes promise
* testing promise
* testing promise
* promise test
* localizes copy
* uses keycode import
* removes unnecessary arguments
* formating
* refactor constructor into async function called by constructor
* attempts to fix floating promise
* removes floating promise
* moves icons and images to sql folder, removes unused icons
* uses icons already existing in ads
* updates styles
* updates color registry
* updates keycode events
* fixes issues per charles comments
* moves icons to media folder
* updates image file paths
* updates file path
* adds href to extension pack extensions
* fixes links
* fixes issues per alan's comments
* uses exisiting colors from color registry
* updates welcome page to use existing colors from color registry
* updates dark theme
* updates color registry
* updates dark theme
* formats css
* fixes dropdown arrow icon on mac
Co-authored-by: Anthony Dresser <andresse@microsoft.com>
* working on formatting
* fixed basic lint errors; starting moving things to their appropriate location
* formatting
* update tslint to match the version of vscode we have
* remove unused code
* work in progress fixing layering
* formatting
* moved connection management service to platform
* formatting
* add missing file
* moving more servies
* formatting
* moving more services
* formatting
* wip
* moving more services
* formatting
* move css file
* add missing svgs
* moved the rest of services
* formatting
* changing around some references
* formatting
* revert tslint
* revert some changes that brake things
* formatting
* fix tests
* fix testzx
* fix tests
* fix tests
* fix compile issue
