* save connection info in notebook metadata
* update attachTo dropdown based on saved alias
* add setting for saving connection (default=false)
* dont show saved conn if seting off + added test
* show conn dialog if save conn name setting off
* address PR comments and fix unit test
* change connectionName to connection_name
* refactor grid streaming (convert to data first)
* change convertRowsToHtml method to return value
* remove griddataconversioncomplete checks
* send row data from STS to gridoutput component
* clean up code
* send data updates to cell model
* serialize cell output at the end of cell execution
* remove unused parameters
* update output contents instead of output reference
* remove unnecessary promise
* move azdata changes to proposed
* update comment
* create unique query runner for each cell
* use cellUri instead of cellId to identify runner
* disconnect each query runner connection
* remove queryrunners size check
* Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable.
* Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead.
* Modified preview icons
* Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however.
* add turndown and save markdown
* update model on UI when source changes
* Added conditional that sets element attribute contentEditable when it is in edit mode.
* Added textView component that can be used for editing.
* update source on MD view not on every keystroke
* Added markdown editor buttons that allow user to swap editor, preview views.
* Cleaning up implementation
* Setting base value of _showPreview to false.
* don't allow html edit on split view
* Update editor automagically
* Add an image picking dialog to notebook toolbar.
* Await transformText()
* revert pushEditOperations to fix cursor issue
* Implemented radio buttons for three view toggles.
* Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly.
* Style tweaks.
* Added new ViewAction file where the RadioButton action will reside.
* Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly.
* Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used.
* WYSIWYG 3 Modes
* Ensure one action active at a time
* Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow.
* Ensure we respect editMode, add showMarkdown
* hiding overflow on code-cell
* Empty text container needs 100% width. Eliminates weird selection border too.
* Initialize _previewMode
* Actions Compatibility
* Further toolbar enhancements
* Update yarn lock after merge
* Slim down changes
* Remove commented out code
* Added margins around notebook-preview container for more visual space for text
* Add turndown to workbench html
* Tweak import
* Add types/turndown
* Remove workbench.html fix
* Import cjs modules directly for turndown
* Leverage solution from github
* browser umd
* non browser umd
* welp dependency
* Modified updatePreview to insert a p tag only when text cell is empty.
* add listener for undo
* add turndown to remote and web
* Fix workbench, check in plugin
* PR comment
Co-authored-by: maddydev <makoripa@microsoft.com>
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Lucy Zhang <luczhan@microsoft.com>
* add onResultUpdate handler in gridoutput
* convert rows to mimetype and html
* wait for data conversion to finish before saving
* detach changeRef after output is created
* fix save grid action
* move data conversion check to each cell
* move conversion logic to dataprovider
* notify data converting when user saves
* add comments and remove unused methods
* fix method return type
* fix tests
* fix convertData method header
* move azdata changes to azdata proposed
* address PR comments
* display top rows message
* fix messages/table ordering and query 100 rows
* add missing escape import
* set default max rows to 5000
* add undefined check to updateResultSet
* change gridDataConversionComplete return type
* tests for getRow method
* use suiteSetup
* added more tests
* revert changes to gridOutput.component.ts
* mocked out services for DataResourceDataProvider
* add test for serializeResults
* change path to fsPath
* fix param type and use fs promises
* use async in startSerialization
* mock ContextService
* Able to get Kernel Alias using extension registery
* Get Kernel Alias through Capability Services
* Notebook Action feature to add kusto to dropdown based on extension - complete
* Fixed indexing issue when Kusto is in kernels Dropdown
* Kusto Kernel listed properly and selected when kernel changes
* Added kernel change when user Attaches To Kusto connection
* Deleted unnecessary code/refactored
* Fix Merge Issues
* Resolving Compile issues - test file error
* Capabilities Provider Changes
* Fixed Notebook Tests
* Rearchitect kernel changes to Notebook Model
* Address minor changes
* Notebook cell toolbar additions - move up and move down added. Stubbed out related actions. Cleaned up component code.
* Added new more actions menu item: Convert cell.
* add move cell support in model
* Schema Compare cleanup (#11418)
* cleanup async and await stuff
* remove awaits
* remove more awaits
* fix (#11437)
* Add some unit tests for PyPiClient. (#11442)
* handle invalid character in kubectl version output (#11460)
* Add tests for azdata extension (#11423)
* Add tests for azdata extension
* Fail on stderr
* Skip test for not implemented logic
* Move executeCommand stub
* Add missing packages
* let semver to parse the version (#11463)
* let semver to parse the version
* check
* Stop hardcoding python3 (#11464)
* Add ConnectControllerDialog tests (#11443)
* Automatically fix up arc controller URL
* wip
* Force tests to pass
* Refactor
* comment
* adds role of button to all links that are buttons (#11465)
* Merge from vscode 0a7364f00514c46c9caceece15e1f82f82e3712f
* bump smoke extensions
* bump node version in builds
* bump smoke extensions
* Add query-history and sql-assessment to recommended extensions (#11477)
* First draft of outputProcessor tests (#11368)
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Adds support for installing azdata on Linux (#11469)
* Large cleanup of AzureCore - Introduction of getAccountSecurityToken and deprecation of getSecurityToken (#11446)
* do a large cleanup of azurecore
* Fix tests
* Rework Device Code
* Fix tests
* Fix AE scenario
* Fix firewall rule - clenaup logging
* Shorthand syntax
* Fix firewall tests
* Start on tests for azureAuth
* Add more tests
* Address comments
* Add a few more important tests
* Don't throw error on old code
* Fill in todo
* Adding button plugin to table component (#10918)
* Added delete plugin to table component
* Arc - Remove Azure params from Postgres deployment (#11478)
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
* tests for KernelsDropdown class (#11476)
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* implement review feedback (#11470)
* fix sql proj sqlcmd table showing after loading profile when it shouldn't (#11479)
* Feature/outer paths for project (#11445)
* allow relative paths in project file outside of project folder
* Adding some tests
* Adding error string to loc strings
* Fixed test
* fix error message
* PR comments and some more fixes
* change userName to match what the azure account display name is (#11484)
* change userName to match what the azure account display name is
* Handle undefined value
* Merge from vscode 8c426f9f3b6b18935cc6c2ec8aa6d45ccd88021e
* recomment out integration tests
* Fix/open book error (#11379)
* add isNotebook param and showPreview option
* showPreview changes
* update OpenNotebookFolder to open a specific path
* added test for showPreviewFile
* test name typo
* remove isNotebook from openBook
* Add test coverage for dacpac wizard import flow (#11483)
* Adding importConfig onPageEnter() test
* Removing redundancy from dacpac wizard pages
* promisifying file selection so it can be awaited in the test
* removing debug prints
* PR feedback
* Remove all accounts regardless of failure in one account (#11431)
* distro (#11487)
* distro
* distro
* distro
* distro
* Adding icons to Database Projects' tree view (#11488)
* Add images
* Splitting to light and dark mode icons
* Hooks up icons to treeItems
* updating package.json with new icon and vbump
* move icon loader before tree view created
* Update Arc extension version and fix Controller connectivity status names (#11498)
* Update connectivity mode names
(cherry picked from commit f0aabcfa86d178cdf74470f9fdeded19718bcea2)
* Bump package version
(cherry picked from commit e08370539006c638d6e25c2f4f23fa2754a3377d)
* deploy to single existing device (#11494)
* deploy to single existing device
* comments
* Add versioning for accounts (#11497)
* Add versioning for accounts
* deletion value
* Changes to getAccountSecurityToken (#11502)
* Hook up convert cell
* Fix tests
* Add convert cell tests
Co-authored-by: chlafreniere <hichise@gmail.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
Co-authored-by: Maddy <12754347+MaddyDev@users.noreply.github.com>
Co-authored-by: Cory Rivera <corivera@microsoft.com>
Co-authored-by: Alan Ren <alanren@microsoft.com>
Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com>
Co-authored-by: v-bbrady <60623315+v-bbrady@users.noreply.github.com>
Co-authored-by: ADS Merger <andresse@microsoft.com>
Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com>
Co-authored-by: Amir Omidi <amomidi@microsoft.com>
Co-authored-by: Leila Lali <llali@microsoft.com>
Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com>
Co-authored-by: Brian Bergeron <brberger@microsoft.com>
Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com>
Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com>
* add return type for a function
* tests for KernelsDropdown class
* remove inadvertent change
* remove inadvertent change
* formatting changes
* pr feedback
* pr feedback
* First draft of outputProcessor tests
* add return type for a function
* pr feedback
* comments and Spellings, getRandom ==> getRandomElement
* pr feedback
* pr feedback
* Adds heading dropdown to markdown toolbar.
* Added a method specific to headings that places markdown at beginning of line selected.
* Rewrote comment for my new method.
* Revised code to support multi select for headers, similar to how unordered list is applied. Multi-line headings can be undone if the multi lines are selected.
* Modified transformText to make single-line undo operation possible with just the cursor position.
* Added utility methods to help determine if the selection is a line-only or multi-line.
* Building isReplaceOperation to determine when preceeding characters need to be replaced with a new MarkdownButtonType.
* Updated comments.
* Applied changes written by Chris.
* Reverted changes to earlier stage where heading addition works just like list item additions.
* getExtendedSelectedText now returns an actual value in range for MarkdownLineType.EVERY_LINE.
* Added conditional so that Preview element is updated only when Preview is enabled.
* Updated tests for heading toolbar: heading 1, 2 and 3.
* Removed code that could not be reached.
* Corrected tests for headings.
* wip
(cherry picked from commit 43deb9635cc0eeebaffef22d4373f1f6ad713ace)
* cleanup
* fix error
* Fix tests
* Add more testing
* delete
* re-add
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Added code to remove multiple separators from more actions menu.
* Moved check for separators after list is deduped.
* Logic cleanup
* Added unit test for cell toolbar ellipses menu.
* Fix tests
Co-authored-by: chgagnon <chgagnon@microsoft.com>
* Reworking notebook action bar functionality and appearance.
* added separator
* Revised notebookActions for collapse, clear and trusted such that they can be implemented with a boolean set to T of F and show labels or shift them into tooltip for accessibility. Updated styles for select boxes. Added toolbar icons to common icon location. Split icon definition for use as masked or background-image.
* Completed styles for action icons: collapse, clear and trusted. Added theme colors. Simplified icon behavior styles.
* Made maskedIconClass optional. Added theme colors for toolbar icons, select box border and dropdown arrow. Experimenting with adding masked icon to pseudo element so I can pull out label text from icons.
* Added icons styles to handle masked SVG elements as pseudo element beside button text. Added icons using this method to respect the color theming system.
* Adjusted styles for the cell and run all icons in notebook toolbar.
* Prepped notebook toolbar with placeholder icon for Underline action. Implemented Underline action. Added custom --wip-- ButtonMenu control, a modified copy of DropDown.
* Revised colorRegistry and corresponding notebook styles. Removed unused code from new custom control: buttonMneu. Revised icon styles to create a dropdown arrow for buttonMenu.
* Added new icon for Underline action.
* Removed comment from needed markup.
* Replaced actionItemProvider with optional undefined per DropdownMenuActionViewItem constructor.
* Cleaned up new control, removing unneeded code and referencing what the class needs. Corrected style declaration for overriding input box padding. Removed unused notebook color styles. Scoped element styles to the toolbar so others outside the toolbar are not affected.
* Removed unnecessary !important from style override.
* Removed reference to unused color entry.
* Syntax cleanup.
* Put notebook toolbar improvements behind the preview flag. This involves some conditionals and CSS classes.
* Updated icon used for Manage Packages. Created and updated styles for notebook toolbar icon spacing. Modified notebook.component contributed actions so that the label text is shifted into the title attribute. Added new icon for Not Trusted toggle.
* Replaced SVG code for not-trusted icon.
* Addressed PR feedback: changed masked classname. Revised component and CSS accordingly. Removed unnecessary instance of in-preview class. Fixed code logic that assigns label text to tooltip on incoming contributed action
